All of lore.kernel.org
 help / color / mirror / Atom feed
From: Zhou Wang <wangzhou.bry@gmail.com>
To: Jerome FORISSIER <jerome.forissier@huawei.com>
Cc: Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
	Mark Rutland <mark.rutland@arm.com>,
	Ian Campbell <ijc+devicetree@hellion.org.uk>,
	Kumar Gala <galak@codeaurora.org>,
	Russell King <linux@arm.linux.org.uk>,
	David Woodhouse <dwmw2@infradead.org>,
	Brian Norris <computersforpeace@gmail.com>,
	Grant Likely <grant.likely@linaro.org>,
	Ezequiel Garcia <ezequiel.garcia@free-electrons.com>,
	Pekon Gupta <pekon@ti.com>,
	Artem Bityutskiy <artem.bityutskiy@linux.intel.com>,
	Alexander Shiyan <shc_work@mail.ru>,
	Ivan Khoronzhuk <ivan.khoronzhuk@ti.com>,
	Jussi Kivilinna <jussi.kivilinna@iki.fi>,
	Joern Engel <joern@logfs.org>,
	Randy Dunlap <rdunlap@infradead.org>,
	linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
	linux-mtd@lists.infradead.org, linux-doc@vger.kernel.org,
	linux-kernel@vger.kernel.org, caizhiyong@huawei.com,
	wangzhou1@hisilicon.com
Subject: Re: [PATCH 1/3] mtd: hisilicon: add device tree node for nand controller
Date: Fri, 11 Jul 2014 10:40:20 +0800	[thread overview]
Message-ID: <53BF4E94.7030104@gmail.com> (raw)
In-Reply-To: <53BCEA77.2080004@huawei.com>

On 2014年07月09日 15:08, Jerome FORISSIER wrote:
> On 30-Jun-14 10:03, Zhou Wang wrote:
>> Signed-off-by: Zhou Wang <wangzhou.bry@gmail.com>
>> ---
>>   arch/arm/boot/dts/hip04.dtsi |   31 +++++++++++++++++++++++++++++++
>>   1 file changed, 31 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/hip04.dtsi b/arch/arm/boot/dts/hip04.dtsi
>> index abb42ca..e63fc61 100644
>> --- a/arch/arm/boot/dts/hip04.dtsi
>> +++ b/arch/arm/boot/dts/hip04.dtsi
>> @@ -386,5 +386,36 @@
>>   				interrupts = <0 389 4>;
>>   			};
>>   		};
>> +
>> +		nand: nand@4020000 {
>> +			compatible = "hisilicon,504-nfc";
>
> In PATCH 2/3 and 3/3 you are using "hisilicon,nfc504".
>

It was my mistake. All should be "hisilicon,504-nfc". Thanks a lot.

>> +			reg = <0x4020000 0x10000>, <0x5000000 0x1000>;
>> +			interrupts = <0 379 4>;
>> +			nand-bus-width = <8>;
>> +			nand-ecc-mode = "none";
>> +			hisi,nand-ecc-bits = <0>;
>> +			#address-cells = <1>;
>> +			#size-cells = <1>;
>> +
>> +			partition@0 {
>> +				label = "nand_text";
>> +				reg = <0x00000000 0x00400000>;
>> +			};
>> +
>> +			partition@00400000 {
>> +				label = "nand_monitor";
>> +				reg = <0x00400000 0x00400000>;
>> +			};
>> +
>> +			partition@00800000 {
>> +				label = "nand_kernel";
>> +				reg = <0x00800000 0x00800000>;
>> +			};
>> +
>> +			partition@01000000 {
>> +				label = "nand_fs";
>> +				reg = <0x01000000 0x1f000000>;
>> +			};
>> +		};
>>   	};
>>   };
>>
>


WARNING: multiple messages have this Message-ID (diff)
From: Zhou Wang <wangzhou.bry@gmail.com>
To: Jerome FORISSIER <jerome.forissier@huawei.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
	Jussi Kivilinna <jussi.kivilinna@iki.fi>,
	linux-doc@vger.kernel.org,
	Artem Bityutskiy <artem.bityutskiy@linux.intel.com>,
	linux-mtd@lists.infradead.org,
	Russell King <linux@arm.linux.org.uk>,
	Alexander Shiyan <shc_work@mail.ru>,
	Ezequiel Garcia <ezequiel.garcia@free-electrons.com>,
	Grant Likely <grant.likely@linaro.org>,
	devicetree@vger.kernel.org, Pawel Moll <pawel.moll@arm.com>,
	Ian Campbell <ijc+devicetree@hellion.org.uk>,
	Joern Engel <joern@logfs.org>, Rob Herring <robh+dt@kernel.org>,
	Pekon Gupta <pekon@ti.com>,
	linux-arm-kernel@lists.infradead.org,
	Randy Dunlap <rdunlap@infradead.org>,
	linux-kernel@vger.kernel.org, wangzhou1@hisilicon.com,
	Kumar Gala <galak@codeaurora.org>,
	caizhiyong@huawei.com, Ivan Khoronzhuk <ivan.khoronzhuk@ti.com>,
	Brian Norris <computersforpeace@gmail.com>,
	David Woodhouse <dwmw2@infradead.org>
Subject: Re: [PATCH 1/3] mtd: hisilicon: add device tree node for nand controller
Date: Fri, 11 Jul 2014 10:40:20 +0800	[thread overview]
Message-ID: <53BF4E94.7030104@gmail.com> (raw)
In-Reply-To: <53BCEA77.2080004@huawei.com>

On 2014年07月09日 15:08, Jerome FORISSIER wrote:
> On 30-Jun-14 10:03, Zhou Wang wrote:
>> Signed-off-by: Zhou Wang <wangzhou.bry@gmail.com>
>> ---
>>   arch/arm/boot/dts/hip04.dtsi |   31 +++++++++++++++++++++++++++++++
>>   1 file changed, 31 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/hip04.dtsi b/arch/arm/boot/dts/hip04.dtsi
>> index abb42ca..e63fc61 100644
>> --- a/arch/arm/boot/dts/hip04.dtsi
>> +++ b/arch/arm/boot/dts/hip04.dtsi
>> @@ -386,5 +386,36 @@
>>   				interrupts = <0 389 4>;
>>   			};
>>   		};
>> +
>> +		nand: nand@4020000 {
>> +			compatible = "hisilicon,504-nfc";
>
> In PATCH 2/3 and 3/3 you are using "hisilicon,nfc504".
>

It was my mistake. All should be "hisilicon,504-nfc". Thanks a lot.

>> +			reg = <0x4020000 0x10000>, <0x5000000 0x1000>;
>> +			interrupts = <0 379 4>;
>> +			nand-bus-width = <8>;
>> +			nand-ecc-mode = "none";
>> +			hisi,nand-ecc-bits = <0>;
>> +			#address-cells = <1>;
>> +			#size-cells = <1>;
>> +
>> +			partition@0 {
>> +				label = "nand_text";
>> +				reg = <0x00000000 0x00400000>;
>> +			};
>> +
>> +			partition@00400000 {
>> +				label = "nand_monitor";
>> +				reg = <0x00400000 0x00400000>;
>> +			};
>> +
>> +			partition@00800000 {
>> +				label = "nand_kernel";
>> +				reg = <0x00800000 0x00800000>;
>> +			};
>> +
>> +			partition@01000000 {
>> +				label = "nand_fs";
>> +				reg = <0x01000000 0x1f000000>;
>> +			};
>> +		};
>>   	};
>>   };
>>
>

WARNING: multiple messages have this Message-ID (diff)
From: wangzhou.bry@gmail.com (Zhou Wang)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/3] mtd: hisilicon: add device tree node for nand controller
Date: Fri, 11 Jul 2014 10:40:20 +0800	[thread overview]
Message-ID: <53BF4E94.7030104@gmail.com> (raw)
In-Reply-To: <53BCEA77.2080004@huawei.com>

On 2014?07?09? 15:08, Jerome FORISSIER wrote:
> On 30-Jun-14 10:03, Zhou Wang wrote:
>> Signed-off-by: Zhou Wang <wangzhou.bry@gmail.com>
>> ---
>>   arch/arm/boot/dts/hip04.dtsi |   31 +++++++++++++++++++++++++++++++
>>   1 file changed, 31 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/hip04.dtsi b/arch/arm/boot/dts/hip04.dtsi
>> index abb42ca..e63fc61 100644
>> --- a/arch/arm/boot/dts/hip04.dtsi
>> +++ b/arch/arm/boot/dts/hip04.dtsi
>> @@ -386,5 +386,36 @@
>>   				interrupts = <0 389 4>;
>>   			};
>>   		};
>> +
>> +		nand: nand at 4020000 {
>> +			compatible = "hisilicon,504-nfc";
>
> In PATCH 2/3 and 3/3 you are using "hisilicon,nfc504".
>

It was my mistake. All should be "hisilicon,504-nfc". Thanks a lot.

>> +			reg = <0x4020000 0x10000>, <0x5000000 0x1000>;
>> +			interrupts = <0 379 4>;
>> +			nand-bus-width = <8>;
>> +			nand-ecc-mode = "none";
>> +			hisi,nand-ecc-bits = <0>;
>> +			#address-cells = <1>;
>> +			#size-cells = <1>;
>> +
>> +			partition at 0 {
>> +				label = "nand_text";
>> +				reg = <0x00000000 0x00400000>;
>> +			};
>> +
>> +			partition at 00400000 {
>> +				label = "nand_monitor";
>> +				reg = <0x00400000 0x00400000>;
>> +			};
>> +
>> +			partition at 00800000 {
>> +				label = "nand_kernel";
>> +				reg = <0x00800000 0x00800000>;
>> +			};
>> +
>> +			partition at 01000000 {
>> +				label = "nand_fs";
>> +				reg = <0x01000000 0x1f000000>;
>> +			};
>> +		};
>>   	};
>>   };
>>
>

  reply	other threads:[~2014-07-11  2:40 UTC|newest]

Thread overview: 51+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-30  8:03 [PATCH 0/3] mtd: hisilicon: add a new driver for NAND controller of hisilicon hip04 Soc Zhou Wang
2014-06-30  8:03 ` Zhou Wang
2014-06-30  8:03 ` Zhou Wang
2014-06-30  8:03 ` [PATCH 1/3] mtd: hisilicon: add device tree node for nand controller Zhou Wang
2014-06-30  8:03   ` Zhou Wang
2014-06-30  8:03   ` Zhou Wang
2014-07-09  7:08   ` Jerome FORISSIER
2014-07-09  7:08     ` Jerome FORISSIER
2014-07-09  7:08     ` Jerome FORISSIER
2014-07-09  7:08     ` Jerome FORISSIER
2014-07-11  2:40     ` Zhou Wang [this message]
2014-07-11  2:40       ` Zhou Wang
2014-07-11  2:40       ` Zhou Wang
2014-06-30  8:03 ` [PATCH 2/3] mtd: hisilicon: add a new nand controller driver for hisilicon hip04 Soc Zhou Wang
2014-06-30  8:03   ` Zhou Wang
2014-06-30  8:03   ` Zhou Wang
2014-06-30  9:00   ` Arnd Bergmann
2014-06-30  9:00     ` Arnd Bergmann
2014-06-30  9:00     ` Arnd Bergmann
2014-06-30  9:59     ` Caizhiyong
2014-06-30  9:59       ` Caizhiyong
2014-06-30  9:59       ` Caizhiyong
2014-07-02  2:12       ` Zhou Wang
2014-07-02  2:12         ` Zhou Wang
2014-07-02  2:12         ` Zhou Wang
2014-07-02  2:07     ` Zhou Wang
2014-07-02  2:07       ` Zhou Wang
2014-07-02  2:07       ` Zhou Wang
2014-07-02  2:07       ` Zhou Wang
2014-06-30  9:45   ` Ivan Khoronzhuk
2014-06-30  9:45     ` Ivan Khoronzhuk
2014-06-30  9:45     ` Ivan Khoronzhuk
2014-06-30  9:45     ` Ivan Khoronzhuk
2014-07-02  2:09     ` Zhou Wang
2014-07-02  2:09       ` Zhou Wang
2014-07-02  2:09       ` Zhou Wang
2014-06-30 10:00   ` Mark Rutland
2014-06-30 10:00     ` Mark Rutland
2014-06-30 10:00     ` Mark Rutland
2014-07-02  2:15     ` Zhou Wang
2014-07-02  2:15       ` Zhou Wang
2014-07-02  2:15       ` Zhou Wang
2014-06-30  8:03 ` [PATCH 3/3] mtd: hisilicon: add device tree binding documentation Zhou Wang
2014-06-30  8:03   ` Zhou Wang
2014-06-30  8:03   ` Zhou Wang
2014-06-30  9:52   ` Mark Rutland
2014-06-30  9:52     ` Mark Rutland
2014-06-30  9:52     ` Mark Rutland
2014-07-02  2:46     ` Zhou Wang
2014-07-02  2:46       ` Zhou Wang
2014-07-02  2:46       ` Zhou Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53BF4E94.7030104@gmail.com \
    --to=wangzhou.bry@gmail.com \
    --cc=artem.bityutskiy@linux.intel.com \
    --cc=caizhiyong@huawei.com \
    --cc=computersforpeace@gmail.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dwmw2@infradead.org \
    --cc=ezequiel.garcia@free-electrons.com \
    --cc=galak@codeaurora.org \
    --cc=grant.likely@linaro.org \
    --cc=ijc+devicetree@hellion.org.uk \
    --cc=ivan.khoronzhuk@ti.com \
    --cc=jerome.forissier@huawei.com \
    --cc=joern@logfs.org \
    --cc=jussi.kivilinna@iki.fi \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=linux@arm.linux.org.uk \
    --cc=mark.rutland@arm.com \
    --cc=pawel.moll@arm.com \
    --cc=pekon@ti.com \
    --cc=rdunlap@infradead.org \
    --cc=robh+dt@kernel.org \
    --cc=shc_work@mail.ru \
    --cc=wangzhou1@hisilicon.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.