All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dave Hansen <dave.hansen@intel.com>
To: David Rientjes <rientjes@google.com>,
	Andrew Morton <akpm@linux-foundation.org>
Cc: Andrea Arcangeli <aarcange@redhat.com>,
	Mel Gorman <mgorman@suse.de>, Rik van Riel <riel@redhat.com>,
	"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
	Bob Liu <bob.liu@oracle.com>,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [patch] mm, thp: only collapse hugepages to nodes with affinity
Date: Mon, 14 Jul 2014 21:47:13 -0700	[thread overview]
Message-ID: <53C4B251.5000505@intel.com> (raw)
In-Reply-To: <alpine.DEB.2.02.1407141807030.8808@chino.kir.corp.google.com>

On 07/14/2014 06:09 PM, David Rientjes wrote:
> +		if (node == NUMA_NO_NODE) {
> +			node = page_to_nid(page);
> +		} else {
> +			int distance = node_distance(page_to_nid(page), node);
> +
> +			/*
> +			 * Do not migrate to memory that would not be reclaimed
> +			 * from.
> +			 */
> +			if (distance > RECLAIM_DISTANCE)
> +				goto out_unmap;
> +		}

Isn't the reclaim behavior based on zone_reclaim_mode and not
RECLAIM_DISTANCE directly?  And isn't that reclaim behavior disabled by
default?

I think you should at least be consulting zone_reclaim_mode.

WARNING: multiple messages have this Message-ID (diff)
From: Dave Hansen <dave.hansen@intel.com>
To: David Rientjes <rientjes@google.com>,
	Andrew Morton <akpm@linux-foundation.org>
Cc: Andrea Arcangeli <aarcange@redhat.com>,
	Mel Gorman <mgorman@suse.de>, Rik van Riel <riel@redhat.com>,
	"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
	Bob Liu <bob.liu@oracle.com>,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [patch] mm, thp: only collapse hugepages to nodes with affinity
Date: Mon, 14 Jul 2014 21:47:13 -0700	[thread overview]
Message-ID: <53C4B251.5000505@intel.com> (raw)
In-Reply-To: <alpine.DEB.2.02.1407141807030.8808@chino.kir.corp.google.com>

On 07/14/2014 06:09 PM, David Rientjes wrote:
> +		if (node == NUMA_NO_NODE) {
> +			node = page_to_nid(page);
> +		} else {
> +			int distance = node_distance(page_to_nid(page), node);
> +
> +			/*
> +			 * Do not migrate to memory that would not be reclaimed
> +			 * from.
> +			 */
> +			if (distance > RECLAIM_DISTANCE)
> +				goto out_unmap;
> +		}

Isn't the reclaim behavior based on zone_reclaim_mode and not
RECLAIM_DISTANCE directly?  And isn't that reclaim behavior disabled by
default?

I think you should at least be consulting zone_reclaim_mode.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2014-07-15  4:47 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-15  1:09 [patch] mm, thp: only collapse hugepages to nodes with affinity David Rientjes
2014-07-15  1:09 ` David Rientjes
2014-07-15  4:47 ` Dave Hansen [this message]
2014-07-15  4:47   ` Dave Hansen
2014-07-15 23:17   ` David Rientjes
2014-07-15 23:17     ` David Rientjes
2014-07-16  0:13 ` [patch v2] mm, tmp: only collapse hugepages to nodes with affinity for zone_reclaim_mode David Rientjes
2014-07-16  0:13   ` David Rientjes
2014-07-16  1:22   ` Bob Liu
2014-07-16  1:22     ` Bob Liu
2014-07-16 15:47     ` Vlastimil Babka
2014-07-16 15:47       ` Vlastimil Babka
2014-07-16 19:37       ` Hugh Dickins
2014-07-16 19:37         ` Hugh Dickins
2014-07-17  0:49       ` David Rientjes
2014-07-17  0:49         ` David Rientjes
2014-07-16 15:38   ` Vlastimil Babka
2014-07-16 15:38     ` Vlastimil Babka
2014-07-17  0:54     ` David Rientjes
2014-07-17  0:54       ` David Rientjes
2014-07-17  0:59       ` [patch v3] mm, thp: " David Rientjes
2014-07-17  0:59         ` David Rientjes
2014-07-17 16:28         ` Dave Hansen
2014-07-17 16:28           ` Dave Hansen
2014-07-17 21:48           ` [patch v4] " David Rientjes
2014-07-17 21:48             ` David Rientjes
2014-07-25 15:34             ` Mel Gorman
2014-07-25 15:34               ` Mel Gorman
2014-07-28  8:42         ` [patch v3] " Vlastimil Babka
2014-07-28  8:42           ` Vlastimil Babka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53C4B251.5000505@intel.com \
    --to=dave.hansen@intel.com \
    --cc=aarcange@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=bob.liu@oracle.com \
    --cc=kirill.shutemov@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mgorman@suse.de \
    --cc=riel@redhat.com \
    --cc=rientjes@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.