* [PATCH 1/1] si2168: Remove testing for demod presence on probe. If the demod is in sleep mode it will fail.
@ 2014-07-17 20:56 Luis Alves
2014-07-17 21:39 ` Antti Palosaari
0 siblings, 1 reply; 2+ messages in thread
From: Luis Alves @ 2014-07-17 20:56 UTC (permalink / raw)
To: linux-media; +Cc: crope, Luis Alves
Signed-off-by: Luis Alves <ljalvs@gmail.com>
---
drivers/media/dvb-frontends/si2168.c | 8 --------
1 file changed, 8 deletions(-)
diff --git a/drivers/media/dvb-frontends/si2168.c b/drivers/media/dvb-frontends/si2168.c
index 3fed522..7e45eeab 100644
--- a/drivers/media/dvb-frontends/si2168.c
+++ b/drivers/media/dvb-frontends/si2168.c
@@ -595,7 +595,6 @@ static int si2168_probe(struct i2c_client *client,
struct si2168_config *config = client->dev.platform_data;
struct si2168 *s;
int ret;
- struct si2168_cmd cmd;
dev_dbg(&client->dev, "%s:\n", __func__);
@@ -609,13 +608,6 @@ static int si2168_probe(struct i2c_client *client,
s->client = client;
mutex_init(&s->i2c_mutex);
- /* check if the demod is there */
- cmd.wlen = 0;
- cmd.rlen = 1;
- ret = si2168_cmd_execute(s, &cmd);
- if (ret)
- goto err;
-
/* create mux i2c adapter for tuner */
s->adapter = i2c_add_mux_adapter(client->adapter, &client->dev, s,
0, 0, 0, si2168_select, si2168_deselect);
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 1/1] si2168: Remove testing for demod presence on probe. If the demod is in sleep mode it will fail.
2014-07-17 20:56 [PATCH 1/1] si2168: Remove testing for demod presence on probe. If the demod is in sleep mode it will fail Luis Alves
@ 2014-07-17 21:39 ` Antti Palosaari
0 siblings, 0 replies; 2+ messages in thread
From: Antti Palosaari @ 2014-07-17 21:39 UTC (permalink / raw)
To: Luis Alves, linux-media
Looks good! I did some measurements against power meter and chip seems
to be low power state by default. After firmware is downloaded and chip
is put to sleep, it does not answer that fw status check, until it is
woken up. There should not be ~any I/O during I2C probe(), so removing
that quite useless check is OK.
regards
Antti
On 07/17/2014 11:56 PM, Luis Alves wrote:
> Signed-off-by: Luis Alves <ljalvs@gmail.com>
> ---
> drivers/media/dvb-frontends/si2168.c | 8 --------
> 1 file changed, 8 deletions(-)
>
> diff --git a/drivers/media/dvb-frontends/si2168.c b/drivers/media/dvb-frontends/si2168.c
> index 3fed522..7e45eeab 100644
> --- a/drivers/media/dvb-frontends/si2168.c
> +++ b/drivers/media/dvb-frontends/si2168.c
> @@ -595,7 +595,6 @@ static int si2168_probe(struct i2c_client *client,
> struct si2168_config *config = client->dev.platform_data;
> struct si2168 *s;
> int ret;
> - struct si2168_cmd cmd;
>
> dev_dbg(&client->dev, "%s:\n", __func__);
>
> @@ -609,13 +608,6 @@ static int si2168_probe(struct i2c_client *client,
> s->client = client;
> mutex_init(&s->i2c_mutex);
>
> - /* check if the demod is there */
> - cmd.wlen = 0;
> - cmd.rlen = 1;
> - ret = si2168_cmd_execute(s, &cmd);
> - if (ret)
> - goto err;
> -
> /* create mux i2c adapter for tuner */
> s->adapter = i2c_add_mux_adapter(client->adapter, &client->dev, s,
> 0, 0, 0, si2168_select, si2168_deselect);
>
--
http://palosaari.fi/
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-07-17 21:39 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-07-17 20:56 [PATCH 1/1] si2168: Remove testing for demod presence on probe. If the demod is in sleep mode it will fail Luis Alves
2014-07-17 21:39 ` Antti Palosaari
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.