From: Grygorii Strashko <grygorii.strashko@ti.com> To: Varka Bhadram <varkabhadram@gmail.com>, Thomas Gleixner <tglx@linutronix.de>, santosh.shilimkar@ti.com, Jason Cooper <jason@lakedaemon.net> Cc: Rob Herring <robh+dt@kernel.org>, Kumar Gala <galak@codeaurora.org>, ivan.khoronzhuk@ti.com, m-karicheri2@ti.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] irqchip: add keystone irq controller ip driver Date: Thu, 24 Jul 2014 19:20:14 +0300 [thread overview] Message-ID: <53D1323E.1010703@ti.com> (raw) In-Reply-To: <53D05A4F.5080905@gmail.com> On 07/24/2014 03:58 AM, Varka Bhadram wrote: > > On Wednesday 23 July 2014 11:31 PM, Grygorii Strashko wrote: >> Hi, >> >> On 07/23/2014 06:32 PM, Varka Bhadram wrote: >>> On Wednesday 23 July 2014 08:10 PM, Grygorii Strashko wrote: >>>> On Keystone SOCs, DSP cores can send interrupts to ARM >>>> host using the IRQ controller IP. It provides 28 IRQ >>>> signals to ARM. The IRQ handler running on HOST OS can >>>> identify DSP signal source by analyzing SRCCx bits in >>>> IPCARx registers. This is one of the component used by >>>> the IPC mechanism used on Keystone SOCs. >>> (...) [...] >>>> +static inline void >>>> +keystone_irq_writel(struct keystone_irq_device *kirq, u32 value) >>>> +{ >>>> + int ret; >>>> + >>>> + ret = regmap_write(kirq->devctrl_regs, kirq->devctrl_offset, value); >>>> + if (ret < 0) >>>> + dev_dbg(kirq->dev, "irq write failed ret(%d)\n", ret); >>> It can be like >>> >>> if (!regmap_write(kirq->devctrl_regs, kirq->devctrl_offset, value)) >>> dev_dbg(kirq->dev, "irq write failed \n"); >>> >>>> +} >>>> + >>>> + >> Pls, Pay attention that I'd like to see ret code here in case of failure. > > What we have to do with ret code... ? Print it :) > In case of failure only this debug message will be printed. Yep. And that exactly what I need. > >>> (...) >>> >>>> + >>>> +static struct irq_domain_ops keystone_irq_ops = { >>>> + .map = keystone_irq_map, >>>> + .xlate = irq_domain_xlate_onecell, >>>> +}; >>>> + >>>> +static int keystone_irq_probe(struct platform_device *pdev) >>>> +{ >>>> + struct device *dev = &pdev->dev; >>>> + struct device_node *np = dev->of_node; >>>> + struct keystone_irq_device *kirq; >>>> + int ret; >>>> + >>>> + if (np == NULL) >>>> + return -EINVAL; >>> return -ENODEV?????? >> If probe is executed - the dev is present, but it was created in a >> wrong/unsupported way >> or dev structure contains wrong data. > > Here we are trying to get the device tree node , but that is not present > we may return the > error code saying that NO DEVICE is present.... 1) Even in case of DT boot device can be creating using platform_device_register() (by mistake, multiplatform build) 2) I've checked current Kernel code and found that - if drivers are DT compatible only then they return -EINVAL -or- -ENOENT See, for example: - irq-imgpdc.c - gpio-tb10x.c > >>> (...) Regards, -grygorii
WARNING: multiple messages have this Message-ID (diff)
From: Grygorii Strashko <grygorii.strashko-l0cyMroinI0@public.gmane.org> To: Varka Bhadram <varkabhadram-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>, Thomas Gleixner <tglx-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org>, santosh.shilimkar-l0cyMroinI0@public.gmane.org, Jason Cooper <jason-NLaQJdtUoK4Be96aLqz0jA@public.gmane.org> Cc: Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>, Kumar Gala <galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>, ivan.khoronzhuk-l0cyMroinI0@public.gmane.org, m-karicheri2-l0cyMroinI0@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org Subject: Re: [PATCH v2] irqchip: add keystone irq controller ip driver Date: Thu, 24 Jul 2014 19:20:14 +0300 [thread overview] Message-ID: <53D1323E.1010703@ti.com> (raw) In-Reply-To: <53D05A4F.5080905-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> On 07/24/2014 03:58 AM, Varka Bhadram wrote: > > On Wednesday 23 July 2014 11:31 PM, Grygorii Strashko wrote: >> Hi, >> >> On 07/23/2014 06:32 PM, Varka Bhadram wrote: >>> On Wednesday 23 July 2014 08:10 PM, Grygorii Strashko wrote: >>>> On Keystone SOCs, DSP cores can send interrupts to ARM >>>> host using the IRQ controller IP. It provides 28 IRQ >>>> signals to ARM. The IRQ handler running on HOST OS can >>>> identify DSP signal source by analyzing SRCCx bits in >>>> IPCARx registers. This is one of the component used by >>>> the IPC mechanism used on Keystone SOCs. >>> (...) [...] >>>> +static inline void >>>> +keystone_irq_writel(struct keystone_irq_device *kirq, u32 value) >>>> +{ >>>> + int ret; >>>> + >>>> + ret = regmap_write(kirq->devctrl_regs, kirq->devctrl_offset, value); >>>> + if (ret < 0) >>>> + dev_dbg(kirq->dev, "irq write failed ret(%d)\n", ret); >>> It can be like >>> >>> if (!regmap_write(kirq->devctrl_regs, kirq->devctrl_offset, value)) >>> dev_dbg(kirq->dev, "irq write failed \n"); >>> >>>> +} >>>> + >>>> + >> Pls, Pay attention that I'd like to see ret code here in case of failure. > > What we have to do with ret code... ? Print it :) > In case of failure only this debug message will be printed. Yep. And that exactly what I need. > >>> (...) >>> >>>> + >>>> +static struct irq_domain_ops keystone_irq_ops = { >>>> + .map = keystone_irq_map, >>>> + .xlate = irq_domain_xlate_onecell, >>>> +}; >>>> + >>>> +static int keystone_irq_probe(struct platform_device *pdev) >>>> +{ >>>> + struct device *dev = &pdev->dev; >>>> + struct device_node *np = dev->of_node; >>>> + struct keystone_irq_device *kirq; >>>> + int ret; >>>> + >>>> + if (np == NULL) >>>> + return -EINVAL; >>> return -ENODEV?????? >> If probe is executed - the dev is present, but it was created in a >> wrong/unsupported way >> or dev structure contains wrong data. > > Here we are trying to get the device tree node , but that is not present > we may return the > error code saying that NO DEVICE is present.... 1) Even in case of DT boot device can be creating using platform_device_register() (by mistake, multiplatform build) 2) I've checked current Kernel code and found that - if drivers are DT compatible only then they return -EINVAL -or- -ENOENT See, for example: - irq-imgpdc.c - gpio-tb10x.c > >>> (...) Regards, -grygorii -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2014-07-24 15:34 UTC|newest] Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top 2014-07-23 14:40 [PATCH v2] irqchip: add keystone irq controller ip driver Grygorii Strashko 2014-07-23 14:40 ` Grygorii Strashko 2014-07-23 15:32 ` Varka Bhadram 2014-07-23 18:01 ` Grygorii Strashko 2014-07-23 18:01 ` Grygorii Strashko 2014-07-24 0:58 ` Varka Bhadram 2014-07-24 16:20 ` Grygorii Strashko [this message] 2014-07-24 16:20 ` Grygorii Strashko 2014-08-17 19:39 ` Jason Cooper 2014-08-17 19:39 ` Jason Cooper 2014-08-28 17:16 ` [PATCH] irqchip: keystone: remove warning unsigned 'kirq->irq' is never less than zero Grygorii Strashko 2014-08-28 17:26 ` Grygorii Strashko 2014-09-03 11:51 ` Jason Cooper
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=53D1323E.1010703@ti.com \ --to=grygorii.strashko@ti.com \ --cc=devicetree@vger.kernel.org \ --cc=galak@codeaurora.org \ --cc=ivan.khoronzhuk@ti.com \ --cc=jason@lakedaemon.net \ --cc=linux-kernel@vger.kernel.org \ --cc=m-karicheri2@ti.com \ --cc=robh+dt@kernel.org \ --cc=santosh.shilimkar@ti.com \ --cc=tglx@linutronix.de \ --cc=varkabhadram@gmail.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.