All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Andreas Färber" <afaerber@suse.de>
To: Sachin Kamat <spk.linux@gmail.com>,
	Vikas Sajjan <vikas.sajjan@samsung.com>
Cc: "linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	linux-samsung-soc <linux-samsung-soc@vger.kernel.org>,
	Kukjin Kim <kgene.kim@samsung.com>,
	Tomasz Figa <tomasz.figa@gmail.com>,
	sunil joshi <joshi@samsung.com>,
	sajjan.linux@gmail.com, Doug Anderson <dianders@chromium.org>
Subject: Re: [RESEND][PATCH 1/2] ARM: DTS: Add PMU DT node for exynos5260 SoC
Date: Mon, 28 Jul 2014 22:29:33 +0200	[thread overview]
Message-ID: <53D6B2AD.7070404@suse.de> (raw)
In-Reply-To: <CAK5sBcHdsDF60JTv7ugC4m=A-5Lmr2rDwizhkCLEyYGRio-2-Q@mail.gmail.com>

Hi Vikas and Sachin,

Am 28.07.2014 17:26, schrieb Sachin Kamat:
> On Mon, Jul 28, 2014 at 6:07 PM, Vikas Sajjan <vikas.sajjan@samsung.com> wrote:
>> Adds PMU DT node for exynos5260 SoC.
>>
>> Signed-off-by: Vikas Sajjan <vikas.sajjan@samsung.com>
>> ---
>>  .../devicetree/bindings/arm/samsung/pmu.txt        |    1 +
>>  arch/arm/boot/dts/exynos5260.dtsi                  |    5 +++++
>>  2 files changed, 6 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/arm/samsung/pmu.txt b/Documentation/devicetree/bindings/arm/samsung/pmu.txt
>> index 2a4ab04..c038628 100644
>> --- a/Documentation/devicetree/bindings/arm/samsung/pmu.txt
>> +++ b/Documentation/devicetree/bindings/arm/samsung/pmu.txt
>> @@ -8,6 +8,7 @@ Properties:
>>                    - "samsung,exynos4412-pmu" - for Exynos4412 SoC,
>>                    - "samsung,exynos5250-pmu" - for Exynos5250 SoC,
>>                    - "samsung,exynos5420-pmu" - for Exynos5420 SoC.
>> +                  - "samsung,exynos5260-pmu" - for Exynos5260 SoC.
> 
> nit: This line should come after 5250 entry to preserve the order.
> 
> Otherwise, looks good.

Earlier today, Kukjin indicated he would apply my corresponding 5410
series [*], but he hasn't pushed yet. It adds a 5410 entry before 5420,
which will conflict with adding 5260 in the same place.

Regards,
Andreas

[*]
http://www.mail-archive.com/linux-samsung-soc@vger.kernel.org/msg34686.html

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg

WARNING: multiple messages have this Message-ID (diff)
From: afaerber@suse.de (Andreas Färber)
To: linux-arm-kernel@lists.infradead.org
Subject: [RESEND][PATCH 1/2] ARM: DTS: Add PMU DT node for exynos5260 SoC
Date: Mon, 28 Jul 2014 22:29:33 +0200	[thread overview]
Message-ID: <53D6B2AD.7070404@suse.de> (raw)
In-Reply-To: <CAK5sBcHdsDF60JTv7ugC4m=A-5Lmr2rDwizhkCLEyYGRio-2-Q@mail.gmail.com>

Hi Vikas and Sachin,

Am 28.07.2014 17:26, schrieb Sachin Kamat:
> On Mon, Jul 28, 2014 at 6:07 PM, Vikas Sajjan <vikas.sajjan@samsung.com> wrote:
>> Adds PMU DT node for exynos5260 SoC.
>>
>> Signed-off-by: Vikas Sajjan <vikas.sajjan@samsung.com>
>> ---
>>  .../devicetree/bindings/arm/samsung/pmu.txt        |    1 +
>>  arch/arm/boot/dts/exynos5260.dtsi                  |    5 +++++
>>  2 files changed, 6 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/arm/samsung/pmu.txt b/Documentation/devicetree/bindings/arm/samsung/pmu.txt
>> index 2a4ab04..c038628 100644
>> --- a/Documentation/devicetree/bindings/arm/samsung/pmu.txt
>> +++ b/Documentation/devicetree/bindings/arm/samsung/pmu.txt
>> @@ -8,6 +8,7 @@ Properties:
>>                    - "samsung,exynos4412-pmu" - for Exynos4412 SoC,
>>                    - "samsung,exynos5250-pmu" - for Exynos5250 SoC,
>>                    - "samsung,exynos5420-pmu" - for Exynos5420 SoC.
>> +                  - "samsung,exynos5260-pmu" - for Exynos5260 SoC.
> 
> nit: This line should come after 5250 entry to preserve the order.
> 
> Otherwise, looks good.

Earlier today, Kukjin indicated he would apply my corresponding 5410
series [*], but he hasn't pushed yet. It adds a 5410 entry before 5420,
which will conflict with adding 5260 in the same place.

Regards,
Andreas

[*]
http://www.mail-archive.com/linux-samsung-soc at vger.kernel.org/msg34686.html

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N?rnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend?rffer; HRB 16746 AG N?rnberg

  reply	other threads:[~2014-07-28 20:29 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-28 12:37 [RESEND][PATCH 0/2] Add support to get PMU address via DT for exynos5260 Vikas Sajjan
2014-07-28 12:37 ` Vikas Sajjan
2014-07-28 12:37 ` [RESEND][PATCH 1/2] ARM: DTS: Add PMU DT node for exynos5260 SoC Vikas Sajjan
2014-07-28 12:37   ` Vikas Sajjan
2014-07-28 15:26   ` Sachin Kamat
2014-07-28 15:26     ` Sachin Kamat
2014-07-28 20:29     ` Andreas Färber [this message]
2014-07-28 20:29       ` Andreas Färber
2014-07-28 21:25       ` Kukjin Kim
2014-07-28 21:25         ` Kukjin Kim
2014-07-28 12:38 ` [RESEND][PATCH 2/2] ARM: EXYNOS: Add exynos5260 PMU compatible string to DT match table Vikas Sajjan
2014-07-28 12:38   ` Vikas Sajjan
2014-07-28 15:27   ` Sachin Kamat
2014-07-28 15:27     ` Sachin Kamat

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53D6B2AD.7070404@suse.de \
    --to=afaerber@suse.de \
    --cc=dianders@chromium.org \
    --cc=joshi@samsung.com \
    --cc=kgene.kim@samsung.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=sajjan.linux@gmail.com \
    --cc=spk.linux@gmail.com \
    --cc=tomasz.figa@gmail.com \
    --cc=vikas.sajjan@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.