Re: C_CAN: can frame drops

From: Oliver Hartkopp <socketcan@hartkopp.net>
To: Prabhakar Lad <prabhakar.csengg@gmail.com>
Cc: Ssagarr Patil <hugarsagar@outlook.com>,
	Marc Kleine-Budde <mkl@pengutronix.de>,
	"linux-can@vger.kernel.org" <linux-can@vger.kernel.org>
Subject: Re: C_CAN: can frame drops
Date: Wed, 30 Jul 2014 18:17:57 +0200	[thread overview]
Message-ID: <53D91AB5.5060507@hartkopp.net> (raw)
In-Reply-To: <CA+V-a8vm+WQXcSwPp7e7yKQehs0+BYkHhZg-EfEL1gWE_cBF=g@mail.gmail.com>

On 30.07.2014 13:28, Prabhakar Lad wrote:

>>>>  If you want to log all CAN
>>>> messages, you can probably make use of recvmmsg() to receive more than
>>>> one CAN frame at a time (instead of using recvmsg() or read()). When
>>>> writing to disk, don't write a single CAN frame at a time, it's better
>>>> to write large blocks, i.e. several 4k of data.
>>>>
>>> I am using the v3.16 (the master branch from git://gitorious.org/linux-can/linux-can.git)
>>>
>>> OK will try experiment with recvmmsg() & and writing to disk with large blocks.
>>>
>>
>> I implemented a proof-of-concept for recvmmsg() for candump.
>>
>> You can try:
>>
>> https://gitorious.org/linux-can/canpump
>>
> 
> Any plans of adding this into mainline can-utils ?
> 

Hm - currently not.

If it turns out to really help to increase the throughput for e.g. candump it
would be worth thinking to integrate it into candump.

But so far there was no feedback from Sagar, if it was at least helpful.

So from my current perspective the canpump source code would be a candidate
for can-tests as many other SocketCAN code examples are sitting there too.

Regards,
Oliver