All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marc Kleine-Budde <mkl@pengutronix.de>
To: Ssagarr Patil <hugarsagar@outlook.com>,
	Oliver Hartkopp <socketcan@hartkopp.net>,
	Prabhakar Lad <prabhakar.csengg@gmail.com>
Cc: "linux-can@vger.kernel.org" <linux-can@vger.kernel.org>
Subject: Re: C_CAN: can frame drops
Date: Thu, 31 Jul 2014 14:42:55 +0200	[thread overview]
Message-ID: <53DA39CF.2070303@pengutronix.de> (raw)
In-Reply-To: <BAY176-W523AF4513C195E7972FE52D3E60@phx.gbl>

[-- Attachment #1: Type: text/plain, Size: 1689 bytes --]

On 07/31/2014 02:41 PM, Ssagarr Patil wrote:
> Hi Oliver,
> 
> Sorry for the delayed response! was busy with other work load.
> 
>>
>>>>>> If you want to log all CAN
>>>>>> messages, you can probably make use of recvmmsg() to receive more than
>>>>>> one CAN frame at a time (instead of using recvmsg() or read()). When
>>>>>> writing to disk, don't write a single CAN frame at a time, it's better
>>>>>> to write large blocks, i.e. several 4k of data.
>>>>>>
>>>>> I am using the v3.16 (the master branch from git://gitorious.org/linux-can/linux-can.git)
>>>>>
>>>>> OK will try experiment with recvmmsg() & and writing to disk with large blocks.
>>>>>
>>>>
>>>> I implemented a proof-of-concept for recvmmsg() for candump.
>>>>
>>>> You can try:
>>>>
>>>> https://gitorious.org/linux-can/canpump
>>>>
>>>
>>> Any plans of adding this into mainline can-utils ?
>>>
>>
>> Hm - currently not.
>>
>> If it turns out to really help to increase the throughput for e.g. candump it
>> would be worth thinking to integrate it into candump.
>>
>> But so far there was no feedback from Sagar, if it was at least helpful.
>>
> Yes it was beneficial I used MSG_WAITALL flag for recvmmsg() so that 
> it waits for n frames and there is no memory wastage.
> 
> Also is it possible to configure qdiscs for improving the performance ?

AFAIK qdiscs are only used in the tx path.

Marc

-- 
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 242 bytes --]

  reply	other threads:[~2014-07-31 12:43 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-23 14:48 C_CAN: can frame drops Ssagarr Patil
2014-07-23 16:04 ` Oliver Hartkopp
2014-07-23 16:33   ` Ssagarr Patil
2014-07-24  7:40     ` Ssagarr Patil
2014-07-24 18:09       ` Oliver Hartkopp
2014-07-25  8:20         ` Ssagarr Patil
2014-07-25  7:17 ` Marc Kleine-Budde
2014-07-25  8:13   ` Ssagarr Patil
2014-07-25  8:16     ` Marc Kleine-Budde
2014-07-25  8:22       ` Ssagarr Patil
2014-07-25  8:27         ` Marc Kleine-Budde
2014-07-25  8:35           ` Ssagarr Patil
2014-07-25  8:48             ` Marc Kleine-Budde
2014-07-25  9:47               ` Ssagarr Patil
2014-07-25 10:10                 ` Marc Kleine-Budde
2014-07-25 11:22                   ` Ssagarr Patil
2014-07-25 10:43                 ` Oliver Hartkopp
2014-07-25 11:24                   ` Ssagarr Patil
2014-07-30 11:28                   ` Prabhakar Lad
2014-07-30 16:17                     ` Oliver Hartkopp
2014-07-31 12:41                       ` Ssagarr Patil
2014-07-31 12:42                         ` Marc Kleine-Budde [this message]
2014-07-31 14:11                           ` Oliver Hartkopp
2014-07-31 14:19                             ` Prabhakar Lad
2014-12-18  9:41                               ` [RFC] sched policies for candump Oliver Hartkopp
2014-12-18 12:33                                 ` Prabhakar Lad
2014-12-18 13:51                                   ` Oliver Hartkopp

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53DA39CF.2070303@pengutronix.de \
    --to=mkl@pengutronix.de \
    --cc=hugarsagar@outlook.com \
    --cc=linux-can@vger.kernel.org \
    --cc=prabhakar.csengg@gmail.com \
    --cc=socketcan@hartkopp.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.