All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v2] arch/score/kernel: Add 'score_ksyms.c' to export special symbols
@ 2014-07-09  0:19 Chen Gang
  2014-08-02 10:03 ` Lennox Wu
  0 siblings, 1 reply; 2+ messages in thread
From: Chen Gang @ 2014-07-09  0:19 UTC (permalink / raw)
  To: Liqin Chen, Lennox Wu; +Cc: linux-kernel

Some symbols are not implemented in C, or not in "arch/score", but
score need export them, so add 'score_ksyms.c' to export them, just
like other architectures have done.

The related error (with allmodconfig under score):

   MODPOST 1365 modules
  ERROR: "__clear_user" [drivers/md/dm-mod.ko] undefined!
  ERROR: "__copy_tofrom_user" [net/x25/x25.ko] undefined!
  ERROR: "__strncpy_from_user" [fs/xfs/xfs.ko] undefined!
  ERROR: "csum_partial" [net/unix/unix.ko] undefined!

  ERROR: "max_low_pfn" [net/wireless/lib80211_crypt_tkip.ko] undefined!
  ERROR: "min_low_pfn" [net/wireless/lib80211_crypt_tkip.ko] undefined!


Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com>
---
 arch/score/kernel/Makefile      |  2 +-
 arch/score/kernel/score_ksyms.c | 41 +++++++++++++++++++++++++++++++++++++++++
 2 files changed, 42 insertions(+), 1 deletion(-)
 create mode 100644 arch/score/kernel/score_ksyms.c

diff --git a/arch/score/kernel/Makefile b/arch/score/kernel/Makefile
index fb1802b..891133b 100644
--- a/arch/score/kernel/Makefile
+++ b/arch/score/kernel/Makefile
@@ -6,6 +6,6 @@ extra-y	:= head.o vmlinux.lds
 
 obj-y += entry.o irq.o process.o ptrace.o \
 	setup.o signal.o sys_score.o time.o traps.o \
-	sys_call_table.o
+	sys_call_table.o score_ksyms.o
 
 obj-$(CONFIG_MODULES) += module.o
diff --git a/arch/score/kernel/score_ksyms.c b/arch/score/kernel/score_ksyms.c
new file mode 100644
index 0000000..d093774
--- /dev/null
+++ b/arch/score/kernel/score_ksyms.c
@@ -0,0 +1,41 @@
+/*
+ * arch/score/kernel/score_ksyms.c
+ *
+ * Score Processor version.
+ *
+ * No Copyright (C)
+ *  Chen Gang <gang.chen.5i5j@gmail.com>
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 2 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, see the file COPYING, or write
+ * to the Free Software Foundation, Inc.,
+ * 51 Franklin St, Fifth Floor, Boston, MA  02110-1301  USA
+ */
+
+#include <linux/export.h>
+#include <linux/syscalls.h>
+#include <asm/checksum.h>
+
+/*
+ * Assembly functions that may be used (directly or indirectly) by modules
+ */
+EXPORT_SYMBOL(__clear_user);
+EXPORT_SYMBOL(__copy_tofrom_user);
+EXPORT_SYMBOL(__strncpy_from_user);
+EXPORT_SYMBOL(csum_partial);
+
+/*
+ * Define but not export in generic mm sub-systems, but score need export
+ */
+EXPORT_SYMBOL(min_low_pfn);
+EXPORT_SYMBOL(max_low_pfn);
-- 
1.9.2.459.g68773ac

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH v2] arch/score/kernel: Add 'score_ksyms.c' to export special symbols
  2014-07-09  0:19 [PATCH v2] arch/score/kernel: Add 'score_ksyms.c' to export special symbols Chen Gang
@ 2014-08-02 10:03 ` Lennox Wu
  0 siblings, 0 replies; 2+ messages in thread
From: Lennox Wu @ 2014-08-02 10:03 UTC (permalink / raw)
  To: Chen Gang, Liqin Chen; +Cc: linux-kernel

Acked-by: Lennox Wu<lennox.wu@gmail.com>

It was merged into Score's git tree, and it will show in the next PULL 
request.

Best,
Lennox

Chen Gang 於 2014/7/9 上午 08:19 寫道:
> Some symbols are not implemented in C, or not in "arch/score", but
> score need export them, so add 'score_ksyms.c' to export them, just
> like other architectures have done.
>
> The related error (with allmodconfig under score):
>
>     MODPOST 1365 modules
>    ERROR: "__clear_user" [drivers/md/dm-mod.ko] undefined!
>    ERROR: "__copy_tofrom_user" [net/x25/x25.ko] undefined!
>    ERROR: "__strncpy_from_user" [fs/xfs/xfs.ko] undefined!
>    ERROR: "csum_partial" [net/unix/unix.ko] undefined!
>
>    ERROR: "max_low_pfn" [net/wireless/lib80211_crypt_tkip.ko] undefined!
>    ERROR: "min_low_pfn" [net/wireless/lib80211_crypt_tkip.ko] undefined!
>
>
> Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com>
> ---
>   arch/score/kernel/Makefile      |  2 +-
>   arch/score/kernel/score_ksyms.c | 41 +++++++++++++++++++++++++++++++++++++++++
>   2 files changed, 42 insertions(+), 1 deletion(-)
>   create mode 100644 arch/score/kernel/score_ksyms.c
>
> diff --git a/arch/score/kernel/Makefile b/arch/score/kernel/Makefile
> index fb1802b..891133b 100644
> --- a/arch/score/kernel/Makefile
> +++ b/arch/score/kernel/Makefile
> @@ -6,6 +6,6 @@ extra-y	:= head.o vmlinux.lds
>
>   obj-y += entry.o irq.o process.o ptrace.o \
>   	setup.o signal.o sys_score.o time.o traps.o \
> -	sys_call_table.o
> +	sys_call_table.o score_ksyms.o
>
>   obj-$(CONFIG_MODULES) += module.o
> diff --git a/arch/score/kernel/score_ksyms.c b/arch/score/kernel/score_ksyms.c
> new file mode 100644
> index 0000000..d093774
> --- /dev/null
> +++ b/arch/score/kernel/score_ksyms.c
> @@ -0,0 +1,41 @@
> +/*
> + * arch/score/kernel/score_ksyms.c
> + *
> + * Score Processor version.
> + *
> + * No Copyright (C)
> + *  Chen Gang <gang.chen.5i5j@gmail.com>
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License as published by
> + * the Free Software Foundation; either version 2 of the License, or
> + * (at your option) any later version.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> + * GNU General Public License for more details.
> + *
> + * You should have received a copy of the GNU General Public License
> + * along with this program; if not, see the file COPYING, or write
> + * to the Free Software Foundation, Inc.,
> + * 51 Franklin St, Fifth Floor, Boston, MA  02110-1301  USA
> + */
> +
> +#include <linux/export.h>
> +#include <linux/syscalls.h>
> +#include <asm/checksum.h>
> +
> +/*
> + * Assembly functions that may be used (directly or indirectly) by modules
> + */
> +EXPORT_SYMBOL(__clear_user);
> +EXPORT_SYMBOL(__copy_tofrom_user);
> +EXPORT_SYMBOL(__strncpy_from_user);
> +EXPORT_SYMBOL(csum_partial);
> +
> +/*
> + * Define but not export in generic mm sub-systems, but score need export
> + */
> +EXPORT_SYMBOL(min_low_pfn);
> +EXPORT_SYMBOL(max_low_pfn);
>

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2014-08-02 10:04 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-07-09  0:19 [PATCH v2] arch/score/kernel: Add 'score_ksyms.c' to export special symbols Chen Gang
2014-08-02 10:03 ` Lennox Wu

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.