All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] arch: score: Export necessary symbols in related files
@ 2014-07-09  8:48 Chen Gang
  2014-07-17  2:22 ` Lennox Wu
  0 siblings, 1 reply; 7+ messages in thread
From: Chen Gang @ 2014-07-09  8:48 UTC (permalink / raw)
  To: Liqin Chen, Lennox Wu; +Cc: linux-kernel

'csum_partial_copy_from_user' and 'flush_dcache_page' are also needed by
outside modules, so need export them in the related files.

The related error (with allmodconfig under score):

    MODPOST 1365 modules
  ERROR: "csum_partial_copy_from_user" [net/rxrpc/af-rxrpc.ko] undefined!
  ERROR: "flush_dcache_page" [net/sunrpc/sunrpc.ko] undefined!


Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com>
---
 arch/score/lib/checksum_copy.c | 1 +
 arch/score/mm/cache.c          | 1 +
 2 files changed, 2 insertions(+)

diff --git a/arch/score/lib/checksum_copy.c b/arch/score/lib/checksum_copy.c
index 04565dd..9b770b3 100644
--- a/arch/score/lib/checksum_copy.c
+++ b/arch/score/lib/checksum_copy.c
@@ -50,3 +50,4 @@ unsigned int csum_partial_copy_from_user(const char *src, char *dst,
 
 	return csum_partial(dst, len, sum);
 }
+EXPORT_SYMBOL(csum_partial_copy_from_user);
diff --git a/arch/score/mm/cache.c b/arch/score/mm/cache.c
index f85ec1a..be91041 100644
--- a/arch/score/mm/cache.c
+++ b/arch/score/mm/cache.c
@@ -72,6 +72,7 @@ void flush_dcache_page(struct page *page)
 	addr = (unsigned long) page_address(page);
 	flush_data_cache_page(addr);
 }
+EXPORT_SYMBOL(flush_dcache_page);
 
 /* called by update_mmu_cache. */
 void __update_cache(struct vm_area_struct *vma, unsigned long address,
-- 
1.9.2.459.g68773ac

^ permalink raw reply related	[flat|nested] 7+ messages in thread

* Re: [PATCH] arch: score: Export necessary symbols in related files
  2014-07-09  8:48 [PATCH] arch: score: Export necessary symbols in related files Chen Gang
@ 2014-07-17  2:22 ` Lennox Wu
  2014-07-17  9:01   ` Chen Gang
  0 siblings, 1 reply; 7+ messages in thread
From: Lennox Wu @ 2014-07-17  2:22 UTC (permalink / raw)
  To: Chen Gang; +Cc: Liqin Chen, linux-kernel

 Acked-by: Lennox Wu<lennox.wu@gmail.com>

2014-07-09 16:48 GMT+08:00 Chen Gang <gang.chen.5i5j@gmail.com>:
> 'csum_partial_copy_from_user' and 'flush_dcache_page' are also needed by
> outside modules, so need export them in the related files.
>
> The related error (with allmodconfig under score):
>
>     MODPOST 1365 modules
>   ERROR: "csum_partial_copy_from_user" [net/rxrpc/af-rxrpc.ko] undefined!
>   ERROR: "flush_dcache_page" [net/sunrpc/sunrpc.ko] undefined!
>
>
> Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com>
> ---
>  arch/score/lib/checksum_copy.c | 1 +
>  arch/score/mm/cache.c          | 1 +
>  2 files changed, 2 insertions(+)
>
> diff --git a/arch/score/lib/checksum_copy.c b/arch/score/lib/checksum_copy.c
> index 04565dd..9b770b3 100644
> --- a/arch/score/lib/checksum_copy.c
> +++ b/arch/score/lib/checksum_copy.c
> @@ -50,3 +50,4 @@ unsigned int csum_partial_copy_from_user(const char *src, char *dst,
>
>         return csum_partial(dst, len, sum);
>  }
> +EXPORT_SYMBOL(csum_partial_copy_from_user);
> diff --git a/arch/score/mm/cache.c b/arch/score/mm/cache.c
> index f85ec1a..be91041 100644
> --- a/arch/score/mm/cache.c
> +++ b/arch/score/mm/cache.c
> @@ -72,6 +72,7 @@ void flush_dcache_page(struct page *page)
>         addr = (unsigned long) page_address(page);
>         flush_data_cache_page(addr);
>  }
> +EXPORT_SYMBOL(flush_dcache_page);
>
>  /* called by update_mmu_cache. */
>  void __update_cache(struct vm_area_struct *vma, unsigned long address,
> --
> 1.9.2.459.g68773ac

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH] arch: score: Export necessary symbols in related files
  2014-07-17  2:22 ` Lennox Wu
@ 2014-07-17  9:01   ` Chen Gang
  2014-08-02  6:20     ` Lennox Wu
  0 siblings, 1 reply; 7+ messages in thread
From: Chen Gang @ 2014-07-17  9:01 UTC (permalink / raw)
  To: Lennox Wu; +Cc: Liqin Chen, linux-kernel

On 07/17/2014 10:22 AM, Lennox Wu wrote:
>  Acked-by: Lennox Wu<lennox.wu@gmail.com>
> 

OK, thank you for your work.


> 2014-07-09 16:48 GMT+08:00 Chen Gang <gang.chen.5i5j@gmail.com>:
>> 'csum_partial_copy_from_user' and 'flush_dcache_page' are also needed by
>> outside modules, so need export them in the related files.
>>
>> The related error (with allmodconfig under score):
>>
>>     MODPOST 1365 modules
>>   ERROR: "csum_partial_copy_from_user" [net/rxrpc/af-rxrpc.ko] undefined!
>>   ERROR: "flush_dcache_page" [net/sunrpc/sunrpc.ko] undefined!
>>
>>
>> Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com>
>> ---
>>  arch/score/lib/checksum_copy.c | 1 +
>>  arch/score/mm/cache.c          | 1 +
>>  2 files changed, 2 insertions(+)
>>
>> diff --git a/arch/score/lib/checksum_copy.c b/arch/score/lib/checksum_copy.c
>> index 04565dd..9b770b3 100644
>> --- a/arch/score/lib/checksum_copy.c
>> +++ b/arch/score/lib/checksum_copy.c
>> @@ -50,3 +50,4 @@ unsigned int csum_partial_copy_from_user(const char *src, char *dst,
>>
>>         return csum_partial(dst, len, sum);
>>  }
>> +EXPORT_SYMBOL(csum_partial_copy_from_user);
>> diff --git a/arch/score/mm/cache.c b/arch/score/mm/cache.c
>> index f85ec1a..be91041 100644
>> --- a/arch/score/mm/cache.c
>> +++ b/arch/score/mm/cache.c
>> @@ -72,6 +72,7 @@ void flush_dcache_page(struct page *page)
>>         addr = (unsigned long) page_address(page);
>>         flush_data_cache_page(addr);
>>  }
>> +EXPORT_SYMBOL(flush_dcache_page);
>>
>>  /* called by update_mmu_cache. */
>>  void __update_cache(struct vm_area_struct *vma, unsigned long address,
>> --
>> 1.9.2.459.g68773ac

-- 
Chen Gang

Open, share, and attitude like air, water, and life which God blessed

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH] arch: score: Export necessary symbols in related files
  2014-07-17  9:01   ` Chen Gang
@ 2014-08-02  6:20     ` Lennox Wu
  2014-08-02  8:18       ` Chen Gang
  0 siblings, 1 reply; 7+ messages in thread
From: Lennox Wu @ 2014-08-02  6:20 UTC (permalink / raw)
  To: Chen Gang; +Cc: Liqin Chen, linux-kernel

It was merged into Score's git tree, and it will show in the next PULL 
request.

Best,
Lennox

Chen Gang 於 2014/7/17 下午 05:01 寫道:
> On 07/17/2014 10:22 AM, Lennox Wu wrote:
>>   Acked-by: Lennox Wu<lennox.wu@gmail.com>
>>
>
> OK, thank you for your work.
>
>
>> 2014-07-09 16:48 GMT+08:00 Chen Gang <gang.chen.5i5j@gmail.com>:
>>> 'csum_partial_copy_from_user' and 'flush_dcache_page' are also needed by
>>> outside modules, so need export them in the related files.
>>>
>>> The related error (with allmodconfig under score):
>>>
>>>      MODPOST 1365 modules
>>>    ERROR: "csum_partial_copy_from_user" [net/rxrpc/af-rxrpc.ko] undefined!
>>>    ERROR: "flush_dcache_page" [net/sunrpc/sunrpc.ko] undefined!
>>>
>>>
>>> Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com>
>>> ---
>>>   arch/score/lib/checksum_copy.c | 1 +
>>>   arch/score/mm/cache.c          | 1 +
>>>   2 files changed, 2 insertions(+)
>>>
>>> diff --git a/arch/score/lib/checksum_copy.c b/arch/score/lib/checksum_copy.c
>>> index 04565dd..9b770b3 100644
>>> --- a/arch/score/lib/checksum_copy.c
>>> +++ b/arch/score/lib/checksum_copy.c
>>> @@ -50,3 +50,4 @@ unsigned int csum_partial_copy_from_user(const char *src, char *dst,
>>>
>>>          return csum_partial(dst, len, sum);
>>>   }
>>> +EXPORT_SYMBOL(csum_partial_copy_from_user);
>>> diff --git a/arch/score/mm/cache.c b/arch/score/mm/cache.c
>>> index f85ec1a..be91041 100644
>>> --- a/arch/score/mm/cache.c
>>> +++ b/arch/score/mm/cache.c
>>> @@ -72,6 +72,7 @@ void flush_dcache_page(struct page *page)
>>>          addr = (unsigned long) page_address(page);
>>>          flush_data_cache_page(addr);
>>>   }
>>> +EXPORT_SYMBOL(flush_dcache_page);
>>>
>>>   /* called by update_mmu_cache. */
>>>   void __update_cache(struct vm_area_struct *vma, unsigned long address,
>>> --
>>> 1.9.2.459.g68773ac
>

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH] arch: score: Export necessary symbols in related files
  2014-08-02  6:20     ` Lennox Wu
@ 2014-08-02  8:18       ` Chen Gang
  2014-08-02  9:20         ` Lennox Wu
  0 siblings, 1 reply; 7+ messages in thread
From: Chen Gang @ 2014-08-02  8:18 UTC (permalink / raw)
  To: Lennox Wu; +Cc: Liqin Chen, linux-kernel

On 08/02/2014 02:20 PM, Lennox Wu wrote:
> It was merged into Score's git tree, and it will show in the next PULL
> request.
> 

OK, thanks. And next, will it be integrated into upstream main line? (I
guess it will be).


Thanks
-- 
Chen Gang

Open, share, and attitude like air, water, and life which God blessed

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH] arch: score: Export necessary symbols in related files
  2014-08-02  8:18       ` Chen Gang
@ 2014-08-02  9:20         ` Lennox Wu
  2014-08-02 10:17           ` Chen Gang
  0 siblings, 1 reply; 7+ messages in thread
From: Lennox Wu @ 2014-08-02  9:20 UTC (permalink / raw)
  To: Chen Gang; +Cc: Liqin Chen, linux-kernel

Yes, I will issue a PULL request to Linus.
Best,
Lennox

Chen Gang 於 2014/8/2 下午 04:18 寫道:
> On 08/02/2014 02:20 PM, Lennox Wu wrote:
>> It was merged into Score's git tree, and it will show in the next PULL
>> request.
>>
>
> OK, thanks. And next, will it be integrated into upstream main line? (I
> guess it will be).
>
>
> Thanks
>

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH] arch: score: Export necessary symbols in related files
  2014-08-02  9:20         ` Lennox Wu
@ 2014-08-02 10:17           ` Chen Gang
  0 siblings, 0 replies; 7+ messages in thread
From: Chen Gang @ 2014-08-02 10:17 UTC (permalink / raw)
  To: Lennox Wu; +Cc: Liqin Chen, linux-kernel

On 08/02/2014 05:20 PM, Lennox Wu wrote:
> Yes, I will issue a PULL request to Linus.

Thank you very much!

And I shall start allmodconfig for other architecture (microblaze), next
week.

> Best,
> Lennox
> 
> Chen Gang 於 2014/8/2 下午 04:18 寫道:
>> On 08/02/2014 02:20 PM, Lennox Wu wrote:
>>> It was merged into Score's git tree, and it will show in the next PULL
>>> request.
>>>
>>
>> OK, thanks. And next, will it be integrated into upstream main line? (I
>> guess it will be).
>>
>>
>> Thanks
>>

-- 
Chen Gang

Open, share, and attitude like air, water, and life which God blessed

^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2014-08-02 10:18 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-07-09  8:48 [PATCH] arch: score: Export necessary symbols in related files Chen Gang
2014-07-17  2:22 ` Lennox Wu
2014-07-17  9:01   ` Chen Gang
2014-08-02  6:20     ` Lennox Wu
2014-08-02  8:18       ` Chen Gang
2014-08-02  9:20         ` Lennox Wu
2014-08-02 10:17           ` Chen Gang

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.