From: Paolo Bonzini <pbonzini@redhat.com>
To: Fam Zheng <famz@redhat.com>, qemu-devel@nongnu.org
Cc: kwolf@redhat.com, armbru@redhat.com, stefanha@redhat.com
Subject: Re: [Qemu-devel] [PATCH 0/2] scsi: Change device init to realize
Date: Tue, 05 Aug 2014 13:23:16 +0200 [thread overview]
Message-ID: <53E0BEA4.40303@redhat.com> (raw)
In-Reply-To: <1407229913-16862-1-git-send-email-famz@redhat.com>
Il 05/08/2014 11:11, Fam Zheng ha scritto:
> DeviceClass->init is the old interface, let's convert scsi devices to the new
> ->realize API.
>
> A user visible change is the error message shown in qemu-iotests reference
> output, but I don't know what's the best way to retain it. So please review if
> and how this could be improved.
I think the new message is an improvement.
Kevin/Stefan, are you taking both patches or can you alternatively ack
the first?
Paolo
> Fam
>
> Fam Zheng (2):
> block: Pass errp in blkconf_geometry
> scsi-bus: Convert DeviceClass init to realize
>
> hw/block/block.c | 18 +++++-----
> hw/block/virtio-blk.c | 7 ++--
> hw/ide/qdev.c | 11 ++++--
> hw/scsi/lsi53c895a.c | 2 ++
> hw/scsi/scsi-bus.c | 64 +++++++++++++++++------------------
> hw/scsi/scsi-disk.c | 83 +++++++++++++++++++++++++---------------------
> hw/scsi/scsi-generic.c | 37 ++++++++++-----------
> include/hw/block/block.h | 6 ++--
> include/hw/scsi/scsi.h | 7 ++--
> tests/qemu-iotests/051.out | 4 +--
> 10 files changed, 125 insertions(+), 114 deletions(-)
>
prev parent reply other threads:[~2014-08-05 11:23 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-05 9:11 [Qemu-devel] [PATCH 0/2] scsi: Change device init to realize Fam Zheng
2014-08-05 9:11 ` [Qemu-devel] [PATCH 1/2] block: Pass errp in blkconf_geometry Fam Zheng
2014-08-05 9:11 ` [Qemu-devel] [PATCH 2/2] scsi-bus: Convert DeviceClass init to realize Fam Zheng
2014-08-05 11:33 ` Fam Zheng
2014-08-07 14:25 ` Kevin Wolf
2014-08-11 8:38 ` Fam Zheng
2014-08-05 11:23 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53E0BEA4.40303@redhat.com \
--to=pbonzini@redhat.com \
--cc=armbru@redhat.com \
--cc=famz@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.