* re: IB/srp: Fix deadlock between host removal and multipathd
@ 2014-08-04 23:31 Dan Carpenter
2014-08-06 8:28 ` Bart Van Assche
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2014-08-04 23:31 UTC (permalink / raw)
To: bvanassche-HInyCGIudOg; +Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA
Hello Bart Van Assche,
The patch bcc059103591: "IB/srp: Fix deadlock between host removal
and multipathd" from Jul 9, 2014, leads to the following static
checker warning:
drivers/infiniband/ulp/srp/ib_srp.c:3323 srp_init_module()
warn: 'srp_remove_wq' isn't an ERR_PTR
drivers/infiniband/ulp/srp/ib_srp.c
3321
3322 srp_remove_wq = create_workqueue("srp_remove");
Returns NULL on failure and not an ERR_PTR.
3323 if (IS_ERR(srp_remove_wq)) {
3324 ret = PTR_ERR(srp_remove_wq);
3325 goto out;
3326 }
3327
3328 ret = -ENOMEM;
3329 ib_srp_transport_template =
3330 srp_attach_transport(&ib_srp_transport_functions);
3331 if (!ib_srp_transport_template)
3332 goto destroy_wq;
regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: IB/srp: Fix deadlock between host removal and multipathd
2014-08-04 23:31 IB/srp: Fix deadlock between host removal and multipathd Dan Carpenter
@ 2014-08-06 8:28 ` Bart Van Assche
0 siblings, 0 replies; 2+ messages in thread
From: Bart Van Assche @ 2014-08-06 8:28 UTC (permalink / raw)
To: Dan Carpenter; +Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA
On 08/05/14 01:31, Dan Carpenter wrote:
> The patch bcc059103591: "IB/srp: Fix deadlock between host removal
> and multipathd" from Jul 9, 2014, leads to the following static
> checker warning:
>
> drivers/infiniband/ulp/srp/ib_srp.c:3323 srp_init_module()
> warn: 'srp_remove_wq' isn't an ERR_PTR
>
> drivers/infiniband/ulp/srp/ib_srp.c
> 3321
> 3322 srp_remove_wq = create_workqueue("srp_remove");
>
> Returns NULL on failure and not an ERR_PTR.
>
> 3323 if (IS_ERR(srp_remove_wq)) {
> 3324 ret = PTR_ERR(srp_remove_wq);
> 3325 goto out;
> 3326 }
> 3327
> 3328 ret = -ENOMEM;
> 3329 ib_srp_transport_template =
> 3330 srp_attach_transport(&ib_srp_transport_functions);
> 3331 if (!ib_srp_transport_template)
> 3332 goto destroy_wq;
Hello Dan,
Thanks for reporting this. I will post a fix later this month.
Bart.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-08-06 8:28 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-08-04 23:31 IB/srp: Fix deadlock between host removal and multipathd Dan Carpenter
2014-08-06 8:28 ` Bart Van Assche
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.