* [PATCH] btrfs: Drop stray check of fixup_workers creation
@ 2014-08-09 11:51 ` Andrey Utkin
0 siblings, 0 replies; 4+ messages in thread
From: Andrey Utkin @ 2014-08-09 11:51 UTC (permalink / raw)
To: clm, jbacik; +Cc: linux-btrfs, linux-kernel, kernel-janitors, Andrey Utkin
The issue was introduced in a79b7d4b3e8118f265dcb4bdf9a572c392f02708,
adding allocation of extent_workers, so this stray check is surely not
meant to be a check of something else.
Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=82021
Reported-by: Maks Naumov <maksqwe1@ukr.net>
Signed-off-by: Andrey Utkin <andrey.krieger.utkin@gmail.com>
---
fs/btrfs/disk-io.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/btrfs/disk-io.c b/fs/btrfs/disk-io.c
index 08e65e9..1881713 100644
--- a/fs/btrfs/disk-io.c
+++ b/fs/btrfs/disk-io.c
@@ -2601,7 +2601,7 @@ int open_ctree(struct super_block *sb,
fs_info->endio_freespace_worker && fs_info->rmw_workers &&
fs_info->caching_workers && fs_info->readahead_workers &&
fs_info->fixup_workers && fs_info->delayed_workers &&
- fs_info->fixup_workers && fs_info->extent_workers &&
+ fs_info->extent_workers &&
fs_info->qgroup_rescan_workers)) {
err = -ENOMEM;
goto fail_sb_buffer;
--
1.8.5.5
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] btrfs: Drop stray check of fixup_workers creation
@ 2014-08-09 11:51 ` Andrey Utkin
0 siblings, 0 replies; 4+ messages in thread
From: Andrey Utkin @ 2014-08-09 11:51 UTC (permalink / raw)
To: clm, jbacik; +Cc: linux-btrfs, linux-kernel, kernel-janitors, Andrey Utkin
The issue was introduced in a79b7d4b3e8118f265dcb4bdf9a572c392f02708,
adding allocation of extent_workers, so this stray check is surely not
meant to be a check of something else.
Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id‚021
Reported-by: Maks Naumov <maksqwe1@ukr.net>
Signed-off-by: Andrey Utkin <andrey.krieger.utkin@gmail.com>
---
fs/btrfs/disk-io.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/btrfs/disk-io.c b/fs/btrfs/disk-io.c
index 08e65e9..1881713 100644
--- a/fs/btrfs/disk-io.c
+++ b/fs/btrfs/disk-io.c
@@ -2601,7 +2601,7 @@ int open_ctree(struct super_block *sb,
fs_info->endio_freespace_worker && fs_info->rmw_workers &&
fs_info->caching_workers && fs_info->readahead_workers &&
fs_info->fixup_workers && fs_info->delayed_workers &&
- fs_info->fixup_workers && fs_info->extent_workers &&
+ fs_info->extent_workers &&
fs_info->qgroup_rescan_workers)) {
err = -ENOMEM;
goto fail_sb_buffer;
--
1.8.5.5
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] btrfs: Drop stray check of fixup_workers creation
2014-08-09 11:51 ` Andrey Utkin
@ 2014-08-09 13:26 ` Eric Sandeen
-1 siblings, 0 replies; 4+ messages in thread
From: Eric Sandeen @ 2014-08-09 13:26 UTC (permalink / raw)
To: Andrey Utkin, clm, jbacik; +Cc: linux-btrfs, linux-kernel, kernel-janitors
On 8/9/14, 6:51 AM, Andrey Utkin wrote:
> The issue was introduced in a79b7d4b3e8118f265dcb4bdf9a572c392f02708,
> adding allocation of extent_workers, so this stray check is surely not
> meant to be a check of something else.
>
> Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=82021
> Reported-by: Maks Naumov <maksqwe1@ukr.net>
> Signed-off-by: Andrey Utkin <andrey.krieger.utkin@gmail.com>
Yup, harmless but unneeded.
However, might as well put the extent_workers & qgroup_rescan_workers checks
on the same line now...
Could probably do a V2 or fix it on commit, but anyway:
Reviewed-by: Eric Sandeen <sandeen@redhat.com>
> ---
> fs/btrfs/disk-io.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/btrfs/disk-io.c b/fs/btrfs/disk-io.c
> index 08e65e9..1881713 100644
> --- a/fs/btrfs/disk-io.c
> +++ b/fs/btrfs/disk-io.c
> @@ -2601,7 +2601,7 @@ int open_ctree(struct super_block *sb,
> fs_info->endio_freespace_worker && fs_info->rmw_workers &&
> fs_info->caching_workers && fs_info->readahead_workers &&
> fs_info->fixup_workers && fs_info->delayed_workers &&
> - fs_info->fixup_workers && fs_info->extent_workers &&
> + fs_info->extent_workers &&
> fs_info->qgroup_rescan_workers)) {
> err = -ENOMEM;
> goto fail_sb_buffer;
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] btrfs: Drop stray check of fixup_workers creation
@ 2014-08-09 13:26 ` Eric Sandeen
0 siblings, 0 replies; 4+ messages in thread
From: Eric Sandeen @ 2014-08-09 13:26 UTC (permalink / raw)
To: Andrey Utkin, clm, jbacik; +Cc: linux-btrfs, linux-kernel, kernel-janitors
On 8/9/14, 6:51 AM, Andrey Utkin wrote:
> The issue was introduced in a79b7d4b3e8118f265dcb4bdf9a572c392f02708,
> adding allocation of extent_workers, so this stray check is surely not
> meant to be a check of something else.
>
> Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id‚021
> Reported-by: Maks Naumov <maksqwe1@ukr.net>
> Signed-off-by: Andrey Utkin <andrey.krieger.utkin@gmail.com>
Yup, harmless but unneeded.
However, might as well put the extent_workers & qgroup_rescan_workers checks
on the same line now...
Could probably do a V2 or fix it on commit, but anyway:
Reviewed-by: Eric Sandeen <sandeen@redhat.com>
> ---
> fs/btrfs/disk-io.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/btrfs/disk-io.c b/fs/btrfs/disk-io.c
> index 08e65e9..1881713 100644
> --- a/fs/btrfs/disk-io.c
> +++ b/fs/btrfs/disk-io.c
> @@ -2601,7 +2601,7 @@ int open_ctree(struct super_block *sb,
> fs_info->endio_freespace_worker && fs_info->rmw_workers &&
> fs_info->caching_workers && fs_info->readahead_workers &&
> fs_info->fixup_workers && fs_info->delayed_workers &&
> - fs_info->fixup_workers && fs_info->extent_workers &&
> + fs_info->extent_workers &&
> fs_info->qgroup_rescan_workers)) {
> err = -ENOMEM;
> goto fail_sb_buffer;
>
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-08-09 13:26 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-08-09 11:51 [PATCH] btrfs: Drop stray check of fixup_workers creation Andrey Utkin
2014-08-09 11:51 ` Andrey Utkin
2014-08-09 13:26 ` Eric Sandeen
2014-08-09 13:26 ` Eric Sandeen
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.