* [PATCH 1/1] memblock, memhotplug: Fix wrong type in memblock_find_in_range_node().
@ 2014-08-10 6:12 ` Tang Chen
0 siblings, 0 replies; 10+ messages in thread
From: Tang Chen @ 2014-08-10 6:12 UTC (permalink / raw)
To: akpm, santosh.shilimkar, grygorii.strashko, phacht, yinghai,
fabf, Emilian.Medve
Cc: linux-mm, linux-kernel, tangchen
In memblock_find_in_range_node(), we defeind ret as int. But it shoule
be phys_addr_t because it is used to store the return value from
__memblock_find_range_bottom_up().
The bug has not been triggered because when allocating low memory near
the kernel end, the "int ret" won't turn out to be minus. When we started
to allocate memory on other nodes, and the "int ret" could be minus.
Then the kernel will panic.
A simple way to reproduce this: comment out the following code in numa_init(),
memblock_set_bottom_up(false);
and the kernel won't boot.
Reported-by: Xishi Qiu <qiuxishi@huawei.com>
Signed-off-by: Tang Chen <tangchen@cn.fujitsu.com>
---
mm/memblock.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/mm/memblock.c b/mm/memblock.c
index 6d2f219..70fad0c 100644
--- a/mm/memblock.c
+++ b/mm/memblock.c
@@ -192,8 +192,7 @@ phys_addr_t __init_memblock memblock_find_in_range_node(phys_addr_t size,
phys_addr_t align, phys_addr_t start,
phys_addr_t end, int nid)
{
- int ret;
- phys_addr_t kernel_end;
+ phys_addr_t kernel_end, ret;
/* pump up @end */
if (end == MEMBLOCK_ALLOC_ACCESSIBLE)
--
1.8.3.1
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH 1/1] memblock, memhotplug: Fix wrong type in memblock_find_in_range_node().
@ 2014-08-10 6:12 ` Tang Chen
0 siblings, 0 replies; 10+ messages in thread
From: Tang Chen @ 2014-08-10 6:12 UTC (permalink / raw)
To: akpm, santosh.shilimkar, grygorii.strashko, phacht, yinghai,
fabf, Emilian.Medve
Cc: linux-mm, linux-kernel, tangchen
In memblock_find_in_range_node(), we defeind ret as int. But it shoule
be phys_addr_t because it is used to store the return value from
__memblock_find_range_bottom_up().
The bug has not been triggered because when allocating low memory near
the kernel end, the "int ret" won't turn out to be minus. When we started
to allocate memory on other nodes, and the "int ret" could be minus.
Then the kernel will panic.
A simple way to reproduce this: comment out the following code in numa_init(),
memblock_set_bottom_up(false);
and the kernel won't boot.
Reported-by: Xishi Qiu <qiuxishi@huawei.com>
Signed-off-by: Tang Chen <tangchen@cn.fujitsu.com>
---
mm/memblock.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/mm/memblock.c b/mm/memblock.c
index 6d2f219..70fad0c 100644
--- a/mm/memblock.c
+++ b/mm/memblock.c
@@ -192,8 +192,7 @@ phys_addr_t __init_memblock memblock_find_in_range_node(phys_addr_t size,
phys_addr_t align, phys_addr_t start,
phys_addr_t end, int nid)
{
- int ret;
- phys_addr_t kernel_end;
+ phys_addr_t kernel_end, ret;
/* pump up @end */
if (end == MEMBLOCK_ALLOC_ACCESSIBLE)
--
1.8.3.1
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH 1/1] memblock, memhotplug: Fix wrong type in memblock_find_in_range_node().
2014-08-10 6:12 ` Tang Chen
@ 2014-08-10 6:14 ` tangchen
-1 siblings, 0 replies; 10+ messages in thread
From: tangchen @ 2014-08-10 6:14 UTC (permalink / raw)
To: akpm, santosh.shilimkar, grygorii.strashko, phacht, yinghai,
fabf, Emilian.Medve, Xishi Qiu
Cc: linux-mm, linux-kernel, tangchen
Sorry, add Xishi Qiu <qiuxishi@huawei.com>
On 08/10/2014 02:12 PM, Tang Chen wrote:
> In memblock_find_in_range_node(), we defeind ret as int. But it shoule
> be phys_addr_t because it is used to store the return value from
> __memblock_find_range_bottom_up().
>
> The bug has not been triggered because when allocating low memory near
> the kernel end, the "int ret" won't turn out to be minus. When we started
> to allocate memory on other nodes, and the "int ret" could be minus.
> Then the kernel will panic.
>
> A simple way to reproduce this: comment out the following code in numa_init(),
>
> memblock_set_bottom_up(false);
>
> and the kernel won't boot.
>
> Reported-by: Xishi Qiu <qiuxishi@huawei.com>
> Signed-off-by: Tang Chen <tangchen@cn.fujitsu.com>
> ---
> mm/memblock.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/mm/memblock.c b/mm/memblock.c
> index 6d2f219..70fad0c 100644
> --- a/mm/memblock.c
> +++ b/mm/memblock.c
> @@ -192,8 +192,7 @@ phys_addr_t __init_memblock memblock_find_in_range_node(phys_addr_t size,
> phys_addr_t align, phys_addr_t start,
> phys_addr_t end, int nid)
> {
> - int ret;
> - phys_addr_t kernel_end;
> + phys_addr_t kernel_end, ret;
>
> /* pump up @end */
> if (end == MEMBLOCK_ALLOC_ACCESSIBLE)
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 1/1] memblock, memhotplug: Fix wrong type in memblock_find_in_range_node().
@ 2014-08-10 6:14 ` tangchen
0 siblings, 0 replies; 10+ messages in thread
From: tangchen @ 2014-08-10 6:14 UTC (permalink / raw)
To: akpm, santosh.shilimkar, grygorii.strashko, phacht, yinghai,
fabf, Emilian.Medve, Xishi Qiu
Cc: linux-mm, linux-kernel, tangchen
Sorry, add Xishi Qiu <qiuxishi@huawei.com>
On 08/10/2014 02:12 PM, Tang Chen wrote:
> In memblock_find_in_range_node(), we defeind ret as int. But it shoule
> be phys_addr_t because it is used to store the return value from
> __memblock_find_range_bottom_up().
>
> The bug has not been triggered because when allocating low memory near
> the kernel end, the "int ret" won't turn out to be minus. When we started
> to allocate memory on other nodes, and the "int ret" could be minus.
> Then the kernel will panic.
>
> A simple way to reproduce this: comment out the following code in numa_init(),
>
> memblock_set_bottom_up(false);
>
> and the kernel won't boot.
>
> Reported-by: Xishi Qiu <qiuxishi@huawei.com>
> Signed-off-by: Tang Chen <tangchen@cn.fujitsu.com>
> ---
> mm/memblock.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/mm/memblock.c b/mm/memblock.c
> index 6d2f219..70fad0c 100644
> --- a/mm/memblock.c
> +++ b/mm/memblock.c
> @@ -192,8 +192,7 @@ phys_addr_t __init_memblock memblock_find_in_range_node(phys_addr_t size,
> phys_addr_t align, phys_addr_t start,
> phys_addr_t end, int nid)
> {
> - int ret;
> - phys_addr_t kernel_end;
> + phys_addr_t kernel_end, ret;
>
> /* pump up @end */
> if (end == MEMBLOCK_ALLOC_ACCESSIBLE)
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 1/1] memblock, memhotplug: Fix wrong type in memblock_find_in_range_node().
2014-08-10 6:14 ` tangchen
@ 2014-08-11 2:03 ` Xishi Qiu
-1 siblings, 0 replies; 10+ messages in thread
From: Xishi Qiu @ 2014-08-11 2:03 UTC (permalink / raw)
To: tangchen
Cc: akpm, santosh.shilimkar, grygorii.strashko, phacht, yinghai,
fabf, Emilian.Medve, linux-mm, linux-kernel
On 2014/8/10 14:14, tangchen wrote:
> Sorry, add Xishi Qiu <qiuxishi@huawei.com>
>
> On 08/10/2014 02:12 PM, Tang Chen wrote:
>> In memblock_find_in_range_node(), we defeind ret as int. But it shoule
>> be phys_addr_t because it is used to store the return value from
>> __memblock_find_range_bottom_up().
>>
>> The bug has not been triggered because when allocating low memory near
>> the kernel end, the "int ret" won't turn out to be minus. When we started
>> to allocate memory on other nodes, and the "int ret" could be minus.
>> Then the kernel will panic.
>>
>> A simple way to reproduce this: comment out the following code in numa_init(),
>>
>> memblock_set_bottom_up(false);
>>
>> and the kernel won't boot.
>>
>> Reported-by: Xishi Qiu <qiuxishi@huawei.com>
>> Signed-off-by: Tang Chen <tangchen@cn.fujitsu.com>
>> ---
>> mm/memblock.c | 3 +--
>> 1 file changed, 1 insertion(+), 2 deletions(-)
>>
>> diff --git a/mm/memblock.c b/mm/memblock.c
>> index 6d2f219..70fad0c 100644
>> --- a/mm/memblock.c
>> +++ b/mm/memblock.c
>> @@ -192,8 +192,7 @@ phys_addr_t __init_memblock memblock_find_in_range_node(phys_addr_t size,
>> phys_addr_t align, phys_addr_t start,
>> phys_addr_t end, int nid)
>> {
>> - int ret;
>> - phys_addr_t kernel_end;
>> + phys_addr_t kernel_end, ret;
>> /* pump up @end */
>> if (end == MEMBLOCK_ALLOC_ACCESSIBLE)
>
>
Hi, Tang Chen
It is OK now.
Tested-by: Xishi Qiu <qiuxishi@huawei.com>
> .
>
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 1/1] memblock, memhotplug: Fix wrong type in memblock_find_in_range_node().
@ 2014-08-11 2:03 ` Xishi Qiu
0 siblings, 0 replies; 10+ messages in thread
From: Xishi Qiu @ 2014-08-11 2:03 UTC (permalink / raw)
To: tangchen
Cc: akpm, santosh.shilimkar, grygorii.strashko, phacht, yinghai,
fabf, Emilian.Medve, linux-mm, linux-kernel
On 2014/8/10 14:14, tangchen wrote:
> Sorry, add Xishi Qiu <qiuxishi@huawei.com>
>
> On 08/10/2014 02:12 PM, Tang Chen wrote:
>> In memblock_find_in_range_node(), we defeind ret as int. But it shoule
>> be phys_addr_t because it is used to store the return value from
>> __memblock_find_range_bottom_up().
>>
>> The bug has not been triggered because when allocating low memory near
>> the kernel end, the "int ret" won't turn out to be minus. When we started
>> to allocate memory on other nodes, and the "int ret" could be minus.
>> Then the kernel will panic.
>>
>> A simple way to reproduce this: comment out the following code in numa_init(),
>>
>> memblock_set_bottom_up(false);
>>
>> and the kernel won't boot.
>>
>> Reported-by: Xishi Qiu <qiuxishi@huawei.com>
>> Signed-off-by: Tang Chen <tangchen@cn.fujitsu.com>
>> ---
>> mm/memblock.c | 3 +--
>> 1 file changed, 1 insertion(+), 2 deletions(-)
>>
>> diff --git a/mm/memblock.c b/mm/memblock.c
>> index 6d2f219..70fad0c 100644
>> --- a/mm/memblock.c
>> +++ b/mm/memblock.c
>> @@ -192,8 +192,7 @@ phys_addr_t __init_memblock memblock_find_in_range_node(phys_addr_t size,
>> phys_addr_t align, phys_addr_t start,
>> phys_addr_t end, int nid)
>> {
>> - int ret;
>> - phys_addr_t kernel_end;
>> + phys_addr_t kernel_end, ret;
>> /* pump up @end */
>> if (end == MEMBLOCK_ALLOC_ACCESSIBLE)
>
>
Hi, Tang Chen
It is OK now.
Tested-by: Xishi Qiu <qiuxishi@huawei.com>
> .
>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 1/1] memblock, memhotplug: Fix wrong type in memblock_find_in_range_node().
2014-08-10 6:12 ` Tang Chen
@ 2014-08-12 22:03 ` Andrew Morton
-1 siblings, 0 replies; 10+ messages in thread
From: Andrew Morton @ 2014-08-12 22:03 UTC (permalink / raw)
To: Tang Chen
Cc: santosh.shilimkar, grygorii.strashko, phacht, yinghai, fabf,
Emilian.Medve, linux-mm, linux-kernel
On Sun, 10 Aug 2014 14:12:03 +0800 Tang Chen <tangchen@cn.fujitsu.com> wrote:
> In memblock_find_in_range_node(), we defeind ret as int. But it shoule
> be phys_addr_t because it is used to store the return value from
> __memblock_find_range_bottom_up().
>
> The bug has not been triggered because when allocating low memory near
> the kernel end, the "int ret" won't turn out to be minus. When we started
> to allocate memory on other nodes, and the "int ret" could be minus.
> Then the kernel will panic.
>
> A simple way to reproduce this: comment out the following code in numa_init(),
>
> memblock_set_bottom_up(false);
>
> and the kernel won't boot.
Which kernel versions need this fix?
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 1/1] memblock, memhotplug: Fix wrong type in memblock_find_in_range_node().
@ 2014-08-12 22:03 ` Andrew Morton
0 siblings, 0 replies; 10+ messages in thread
From: Andrew Morton @ 2014-08-12 22:03 UTC (permalink / raw)
To: Tang Chen
Cc: santosh.shilimkar, grygorii.strashko, phacht, yinghai, fabf,
Emilian.Medve, linux-mm, linux-kernel
On Sun, 10 Aug 2014 14:12:03 +0800 Tang Chen <tangchen@cn.fujitsu.com> wrote:
> In memblock_find_in_range_node(), we defeind ret as int. But it shoule
> be phys_addr_t because it is used to store the return value from
> __memblock_find_range_bottom_up().
>
> The bug has not been triggered because when allocating low memory near
> the kernel end, the "int ret" won't turn out to be minus. When we started
> to allocate memory on other nodes, and the "int ret" could be minus.
> Then the kernel will panic.
>
> A simple way to reproduce this: comment out the following code in numa_init(),
>
> memblock_set_bottom_up(false);
>
> and the kernel won't boot.
Which kernel versions need this fix?
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 1/1] memblock, memhotplug: Fix wrong type in memblock_find_in_range_node().
2014-08-12 22:03 ` Andrew Morton
@ 2014-08-13 4:57 ` tangchen
-1 siblings, 0 replies; 10+ messages in thread
From: tangchen @ 2014-08-13 4:57 UTC (permalink / raw)
To: Andrew Morton
Cc: santosh.shilimkar, grygorii.strashko, phacht, yinghai, fabf,
Emilian.Medve, linux-mm, linux-kernel
On 08/13/2014 06:03 AM, Andrew Morton wrote:
> On Sun, 10 Aug 2014 14:12:03 +0800 Tang Chen <tangchen@cn.fujitsu.com> wrote:
>
>> In memblock_find_in_range_node(), we defeind ret as int. But it shoule
>> be phys_addr_t because it is used to store the return value from
>> __memblock_find_range_bottom_up().
>>
>> The bug has not been triggered because when allocating low memory near
>> the kernel end, the "int ret" won't turn out to be minus. When we started
>> to allocate memory on other nodes, and the "int ret" could be minus.
>> Then the kernel will panic.
>>
>> A simple way to reproduce this: comment out the following code in numa_init(),
>>
>> memblock_set_bottom_up(false);
>>
>> and the kernel won't boot.
> Which kernel versions need this fix?
This bug has been in the kernel since v3.13-rc1.
Thanks.
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 1/1] memblock, memhotplug: Fix wrong type in memblock_find_in_range_node().
@ 2014-08-13 4:57 ` tangchen
0 siblings, 0 replies; 10+ messages in thread
From: tangchen @ 2014-08-13 4:57 UTC (permalink / raw)
To: Andrew Morton
Cc: santosh.shilimkar, grygorii.strashko, phacht, yinghai, fabf,
Emilian.Medve, linux-mm, linux-kernel
On 08/13/2014 06:03 AM, Andrew Morton wrote:
> On Sun, 10 Aug 2014 14:12:03 +0800 Tang Chen <tangchen@cn.fujitsu.com> wrote:
>
>> In memblock_find_in_range_node(), we defeind ret as int. But it shoule
>> be phys_addr_t because it is used to store the return value from
>> __memblock_find_range_bottom_up().
>>
>> The bug has not been triggered because when allocating low memory near
>> the kernel end, the "int ret" won't turn out to be minus. When we started
>> to allocate memory on other nodes, and the "int ret" could be minus.
>> Then the kernel will panic.
>>
>> A simple way to reproduce this: comment out the following code in numa_init(),
>>
>> memblock_set_bottom_up(false);
>>
>> and the kernel won't boot.
> Which kernel versions need this fix?
This bug has been in the kernel since v3.13-rc1.
Thanks.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2014-08-13 4:56 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-08-10 6:12 [PATCH 1/1] memblock, memhotplug: Fix wrong type in memblock_find_in_range_node() Tang Chen
2014-08-10 6:12 ` Tang Chen
2014-08-10 6:14 ` tangchen
2014-08-10 6:14 ` tangchen
2014-08-11 2:03 ` Xishi Qiu
2014-08-11 2:03 ` Xishi Qiu
2014-08-12 22:03 ` Andrew Morton
2014-08-12 22:03 ` Andrew Morton
2014-08-13 4:57 ` tangchen
2014-08-13 4:57 ` tangchen
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.