All of lore.kernel.org
 help / color / mirror / Atom feed
* [V2 PATCH] kernel: Prevent from installing so files into source dir
@ 2014-08-19 18:39 Yang Shi
  2014-08-19 18:42 ` Bruce Ashfield
  0 siblings, 1 reply; 5+ messages in thread
From: Yang Shi @ 2014-08-19 18:39 UTC (permalink / raw)
  To: bruce.ashfield, openembedded-core

vdso build could generate so files, avoid installing such so files into kernel
source dir, otherwise the below package QA error might be hit:

ERROR: QA Issue: File '/usr/src/kernel/arch/x86/vdso/vdso64.so' from
linux-windriver was already stripped, this will prevent future
debugging! [already-stripped]

Signed-off-by: Yang Shi <yang.shi@windriver.com>
---
 meta/classes/kernel.bbclass | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/classes/kernel.bbclass b/meta/classes/kernel.bbclass
index 819c302..435b6f0 100644
--- a/meta/classes/kernel.bbclass
+++ b/meta/classes/kernel.bbclass
@@ -253,7 +253,7 @@ kernel_do_install() {
 	# dir. This ensures the original Makefiles are used and not the
 	# redirecting Makefiles in the build directory.
 	#
-	find . -depth -not -name "*.cmd" -not -name "*.o" -not -name "*.so.dbg" -not -path "./Documentation*" -not -path "./source*" -not -path "./.*" -print0 | cpio --null -pdlu $kerneldir
+	find . -depth -not -name "*.cmd" -not -name "*.o" -not -name "*.so.dbg" -not -name "*.so" -not -path "./Documentation*" -not -path "./source*" -not -path "./.*" -print0 | cpio --null -pdlu $kerneldir
 	cp .config $kerneldir
 	if [ "${S}" != "${B}" ]; then
 		pwd="$PWD"
-- 
2.0.2



^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [V2 PATCH] kernel: Prevent from installing so files into source dir
  2014-08-19 18:39 [V2 PATCH] kernel: Prevent from installing so files into source dir Yang Shi
@ 2014-08-19 18:42 ` Bruce Ashfield
  2014-08-19 18:59   ` Yang Shi
  0 siblings, 1 reply; 5+ messages in thread
From: Bruce Ashfield @ 2014-08-19 18:42 UTC (permalink / raw)
  To: Yang Shi, openembedded-core

On 14-08-19 02:39 PM, Yang Shi wrote:
> vdso build could generate so files, avoid installing such so files into kernel
> source dir, otherwise the below package QA error might be hit:
>
> ERROR: QA Issue: File '/usr/src/kernel/arch/x86/vdso/vdso64.so' from
> linux-windriver was already stripped, this will prevent future

We wouldn't want to capture linux-windriver in the commit log .. I assume
that this is possible to see with the stock linux-yocto kernel as
well ?

Bruce

> debugging! [already-stripped]
>
> Signed-off-by: Yang Shi <yang.shi@windriver.com>
> ---
>   meta/classes/kernel.bbclass | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/classes/kernel.bbclass b/meta/classes/kernel.bbclass
> index 819c302..435b6f0 100644
> --- a/meta/classes/kernel.bbclass
> +++ b/meta/classes/kernel.bbclass
> @@ -253,7 +253,7 @@ kernel_do_install() {
>   	# dir. This ensures the original Makefiles are used and not the
>   	# redirecting Makefiles in the build directory.
>   	#
> -	find . -depth -not -name "*.cmd" -not -name "*.o" -not -name "*.so.dbg" -not -path "./Documentation*" -not -path "./source*" -not -path "./.*" -print0 | cpio --null -pdlu $kerneldir
> +	find . -depth -not -name "*.cmd" -not -name "*.o" -not -name "*.so.dbg" -not -name "*.so" -not -path "./Documentation*" -not -path "./source*" -not -path "./.*" -print0 | cpio --null -pdlu $kerneldir
>   	cp .config $kerneldir
>   	if [ "${S}" != "${B}" ]; then
>   		pwd="$PWD"
>



^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [V2 PATCH] kernel: Prevent from installing so files into source dir
  2014-08-19 18:42 ` Bruce Ashfield
@ 2014-08-19 18:59   ` Yang Shi
  2014-08-19 19:56     ` Bruce Ashfield
  0 siblings, 1 reply; 5+ messages in thread
From: Yang Shi @ 2014-08-19 18:59 UTC (permalink / raw)
  To: Bruce Ashfield, openembedded-core

On 8/19/2014 11:42 AM, Bruce Ashfield wrote:
> On 14-08-19 02:39 PM, Yang Shi wrote:
>> vdso build could generate so files, avoid installing such so files 
>> into kernel
>> source dir, otherwise the below package QA error might be hit:
>>
>> ERROR: QA Issue: File '/usr/src/kernel/arch/x86/vdso/vdso64.so' from
>> linux-windriver was already stripped, this will prevent future
>
> We wouldn't want to capture linux-windriver in the commit log .. I assume
> that this is possible to see with the stock linux-yocto kernel as
> well ?

I didn't try it with linux-yocto. But, if we use externalsrc, I think 
linux-yocto should have the same problem.

Yang

>
> Bruce
>
>> debugging! [already-stripped]
>>
>> Signed-off-by: Yang Shi <yang.shi@windriver.com>
>> ---
>>   meta/classes/kernel.bbclass | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/meta/classes/kernel.bbclass b/meta/classes/kernel.bbclass
>> index 819c302..435b6f0 100644
>> --- a/meta/classes/kernel.bbclass
>> +++ b/meta/classes/kernel.bbclass
>> @@ -253,7 +253,7 @@ kernel_do_install() {
>>       # dir. This ensures the original Makefiles are used and not the
>>       # redirecting Makefiles in the build directory.
>>       #
>> -    find . -depth -not -name "*.cmd" -not -name "*.o" -not -name 
>> "*.so.dbg" -not -path "./Documentation*" -not -path "./source*" -not 
>> -path "./.*" -print0 | cpio --null -pdlu $kerneldir
>> +    find . -depth -not -name "*.cmd" -not -name "*.o" -not -name 
>> "*.so.dbg" -not -name "*.so" -not -path "./Documentation*" -not -path 
>> "./source*" -not -path "./.*" -print0 | cpio --null -pdlu $kerneldir
>>       cp .config $kerneldir
>>       if [ "${S}" != "${B}" ]; then
>>           pwd="$PWD"
>>
>
>
>



^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [V2 PATCH] kernel: Prevent from installing so files into source dir
  2014-08-19 18:59   ` Yang Shi
@ 2014-08-19 19:56     ` Bruce Ashfield
  2014-08-19 21:21       ` Yang Shi
  0 siblings, 1 reply; 5+ messages in thread
From: Bruce Ashfield @ 2014-08-19 19:56 UTC (permalink / raw)
  To: Yang Shi, openembedded-core

On 14-08-19 02:59 PM, Yang Shi wrote:
> On 8/19/2014 11:42 AM, Bruce Ashfield wrote:
>> On 14-08-19 02:39 PM, Yang Shi wrote:
>>> vdso build could generate so files, avoid installing such so files
>>> into kernel
>>> source dir, otherwise the below package QA error might be hit:
>>>
>>> ERROR: QA Issue: File '/usr/src/kernel/arch/x86/vdso/vdso64.so' from
>>> linux-windriver was already stripped, this will prevent future
>>
>> We wouldn't want to capture linux-windriver in the commit log .. I assume
>> that this is possible to see with the stock linux-yocto kernel as
>> well ?
>
> I didn't try it with linux-yocto. But, if we use externalsrc, I think
> linux-yocto should have the same problem.

Shouldn't be too hard to confirm. We want the log to be based on
oe-core components (as the tests should be), so it is worth a
quick re-test and a v3 .. sorry for being a pain on this.

Bruce

>
> Yang
>
>>
>> Bruce
>>
>>> debugging! [already-stripped]
>>>
>>> Signed-off-by: Yang Shi <yang.shi@windriver.com>
>>> ---
>>>   meta/classes/kernel.bbclass | 2 +-
>>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/meta/classes/kernel.bbclass b/meta/classes/kernel.bbclass
>>> index 819c302..435b6f0 100644
>>> --- a/meta/classes/kernel.bbclass
>>> +++ b/meta/classes/kernel.bbclass
>>> @@ -253,7 +253,7 @@ kernel_do_install() {
>>>       # dir. This ensures the original Makefiles are used and not the
>>>       # redirecting Makefiles in the build directory.
>>>       #
>>> -    find . -depth -not -name "*.cmd" -not -name "*.o" -not -name
>>> "*.so.dbg" -not -path "./Documentation*" -not -path "./source*" -not
>>> -path "./.*" -print0 | cpio --null -pdlu $kerneldir
>>> +    find . -depth -not -name "*.cmd" -not -name "*.o" -not -name
>>> "*.so.dbg" -not -name "*.so" -not -path "./Documentation*" -not -path
>>> "./source*" -not -path "./.*" -print0 | cpio --null -pdlu $kerneldir
>>>       cp .config $kerneldir
>>>       if [ "${S}" != "${B}" ]; then
>>>           pwd="$PWD"
>>>
>>
>>
>>
>



^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [V2 PATCH] kernel: Prevent from installing so files into source dir
  2014-08-19 19:56     ` Bruce Ashfield
@ 2014-08-19 21:21       ` Yang Shi
  0 siblings, 0 replies; 5+ messages in thread
From: Yang Shi @ 2014-08-19 21:21 UTC (permalink / raw)
  To: Bruce Ashfield, openembedded-core

On 8/19/2014 12:56 PM, Bruce Ashfield wrote:
> On 14-08-19 02:59 PM, Yang Shi wrote:
>> On 8/19/2014 11:42 AM, Bruce Ashfield wrote:
>>> On 14-08-19 02:39 PM, Yang Shi wrote:
>>>> vdso build could generate so files, avoid installing such so files
>>>> into kernel
>>>> source dir, otherwise the below package QA error might be hit:
>>>>
>>>> ERROR: QA Issue: File '/usr/src/kernel/arch/x86/vdso/vdso64.so' from
>>>> linux-windriver was already stripped, this will prevent future
>>>
>>> We wouldn't want to capture linux-windriver in the commit log .. I 
>>> assume
>>> that this is possible to see with the stock linux-yocto kernel as
>>> well ?
>>
>> I didn't try it with linux-yocto. But, if we use externalsrc, I think
>> linux-yocto should have the same problem.
>
> Shouldn't be too hard to confirm. We want the log to be based on
> oe-core components (as the tests should be), so it is worth a
> quick re-test and a v3 .. sorry for being a pain on this.

Tested on oe-core, updated commit log accordingly. V3 is coming soon.

Yang

>
> Bruce
>
>>
>> Yang
>>
>>>
>>> Bruce
>>>
>>>> debugging! [already-stripped]
>>>>
>>>> Signed-off-by: Yang Shi <yang.shi@windriver.com>
>>>> ---
>>>>   meta/classes/kernel.bbclass | 2 +-
>>>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>>>
>>>> diff --git a/meta/classes/kernel.bbclass b/meta/classes/kernel.bbclass
>>>> index 819c302..435b6f0 100644
>>>> --- a/meta/classes/kernel.bbclass
>>>> +++ b/meta/classes/kernel.bbclass
>>>> @@ -253,7 +253,7 @@ kernel_do_install() {
>>>>       # dir. This ensures the original Makefiles are used and not the
>>>>       # redirecting Makefiles in the build directory.
>>>>       #
>>>> -    find . -depth -not -name "*.cmd" -not -name "*.o" -not -name
>>>> "*.so.dbg" -not -path "./Documentation*" -not -path "./source*" -not
>>>> -path "./.*" -print0 | cpio --null -pdlu $kerneldir
>>>> +    find . -depth -not -name "*.cmd" -not -name "*.o" -not -name
>>>> "*.so.dbg" -not -name "*.so" -not -path "./Documentation*" -not -path
>>>> "./source*" -not -path "./.*" -print0 | cpio --null -pdlu $kerneldir
>>>>       cp .config $kerneldir
>>>>       if [ "${S}" != "${B}" ]; then
>>>>           pwd="$PWD"
>>>>
>>>
>>>
>>>
>>
>
>
>



^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2014-08-19 21:21 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-08-19 18:39 [V2 PATCH] kernel: Prevent from installing so files into source dir Yang Shi
2014-08-19 18:42 ` Bruce Ashfield
2014-08-19 18:59   ` Yang Shi
2014-08-19 19:56     ` Bruce Ashfield
2014-08-19 21:21       ` Yang Shi

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.