From: Stephen Warren <swarren@wwwdotorg.org> To: Mikko Perttunen <mperttunen@nvidia.com>, rui.zhang@intel.com, edubezval@gmail.com, thierry.reding@gmail.com Cc: linux-pm@vger.kernel.org, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v3 4/4] thermal: Add Tegra SOCTHERM thermal management driver Date: Wed, 20 Aug 2014 13:50:48 -0600 [thread overview] Message-ID: <53F4FC18.90804@wwwdotorg.org> (raw) In-Reply-To: <1407320706-17440-5-git-send-email-mperttunen@nvidia.com> On 08/06/2014 04:25 AM, Mikko Perttunen wrote: > This adds support for the Tegra SOCTHERM thermal sensing and management > system found in the Tegra124 system-on-chip. This initial driver supports > temperature polling for four thermal zones. Since both the Tegra DT patches and this driver all rely on a new header added by patch 1/4, I guess this whole series needs to be applied in one branch. I think it makes sense to apply it to the Tegra since it's likely to have more conflicts there and fewer in the thermal maintainer's tree. It can be applied in a topic branch that can be merged into the thermal maintainer's tree if required to resolve conflicts there. Rui, Eduardo, do you agree? > diff --git a/drivers/thermal/tegra_soctherm.c b/drivers/thermal/tegra_soctherm.c > +static struct of_device_id tegra_soctherm_of_match[] = { > + { .compatible = "nvidia,tegra124-soctherm" }, > + { }, > +}; > +MODULE_DEVICE_TABLE(of, tegra_soctherm_of_match); > + > +static int thermctl_temp_offsets[] = { > + SENSOR_TEMP1, SENSOR_TEMP2, SENSOR_TEMP1, SENSOR_TEMP2 > +}; > + > +static int thermctl_temp_shifts[] = { > + 16, 16, 0, 0 > +}; Can any/all of those be const? I don't pretend to know anything about the soctherm HW, but I see no gross issues in the code structure, so, Acked-by: Stephen Warren <swarren@nvidia.com>
WARNING: multiple messages have this Message-ID (diff)
From: swarren@wwwdotorg.org (Stephen Warren) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH v3 4/4] thermal: Add Tegra SOCTHERM thermal management driver Date: Wed, 20 Aug 2014 13:50:48 -0600 [thread overview] Message-ID: <53F4FC18.90804@wwwdotorg.org> (raw) In-Reply-To: <1407320706-17440-5-git-send-email-mperttunen@nvidia.com> On 08/06/2014 04:25 AM, Mikko Perttunen wrote: > This adds support for the Tegra SOCTHERM thermal sensing and management > system found in the Tegra124 system-on-chip. This initial driver supports > temperature polling for four thermal zones. Since both the Tegra DT patches and this driver all rely on a new header added by patch 1/4, I guess this whole series needs to be applied in one branch. I think it makes sense to apply it to the Tegra since it's likely to have more conflicts there and fewer in the thermal maintainer's tree. It can be applied in a topic branch that can be merged into the thermal maintainer's tree if required to resolve conflicts there. Rui, Eduardo, do you agree? > diff --git a/drivers/thermal/tegra_soctherm.c b/drivers/thermal/tegra_soctherm.c > +static struct of_device_id tegra_soctherm_of_match[] = { > + { .compatible = "nvidia,tegra124-soctherm" }, > + { }, > +}; > +MODULE_DEVICE_TABLE(of, tegra_soctherm_of_match); > + > +static int thermctl_temp_offsets[] = { > + SENSOR_TEMP1, SENSOR_TEMP2, SENSOR_TEMP1, SENSOR_TEMP2 > +}; > + > +static int thermctl_temp_shifts[] = { > + 16, 16, 0, 0 > +}; Can any/all of those be const? I don't pretend to know anything about the soctherm HW, but I see no gross issues in the code structure, so, Acked-by: Stephen Warren <swarren@nvidia.com>
next prev parent reply other threads:[~2014-08-20 19:50 UTC|newest] Thread overview: 66+ messages / expand[flat|nested] mbox.gz Atom feed top 2014-08-06 10:25 [PATCH v3 0/4] Tegra124 soctherm driver Mikko Perttunen 2014-08-06 10:25 ` Mikko Perttunen 2014-08-06 10:25 ` Mikko Perttunen 2014-08-06 10:25 ` [PATCH v3 1/4] of: Add bindings for nvidia,tegra124-soctherm Mikko Perttunen 2014-08-06 10:25 ` Mikko Perttunen 2014-08-06 10:25 ` Mikko Perttunen [not found] ` <1407320706-17440-2-git-send-email-mperttunen-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> 2014-08-20 19:37 ` Stephen Warren 2014-08-20 19:37 ` Stephen Warren 2014-08-20 19:37 ` Stephen Warren 2014-08-06 10:25 ` [PATCH v3 2/4] ARM: tegra: Add soctherm and thermal zones to Tegra124 device tree Mikko Perttunen 2014-08-06 10:25 ` Mikko Perttunen 2014-08-06 10:25 ` Mikko Perttunen [not found] ` <1407320706-17440-3-git-send-email-mperttunen-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> 2014-08-20 19:42 ` Stephen Warren 2014-08-20 19:42 ` Stephen Warren 2014-08-20 19:42 ` Stephen Warren [not found] ` <1407320706-17440-1-git-send-email-mperttunen-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> 2014-08-06 10:25 ` [PATCH v3 3/4] ARM: tegra: Add thermal trip points for Jetson TK1 Mikko Perttunen 2014-08-06 10:25 ` Mikko Perttunen 2014-08-06 10:25 ` Mikko Perttunen 2014-08-20 19:44 ` Stephen Warren 2014-08-20 19:44 ` Stephen Warren 2014-08-21 7:37 ` Mikko Perttunen 2014-08-21 7:37 ` Mikko Perttunen 2014-08-21 7:37 ` Mikko Perttunen 2014-08-21 16:04 ` Eduardo Valentin 2014-08-21 16:04 ` Eduardo Valentin 2014-08-21 16:35 ` Stephen Warren 2014-08-21 16:35 ` Stephen Warren 2014-08-06 10:25 ` [PATCH v3 4/4] thermal: Add Tegra SOCTHERM thermal management driver Mikko Perttunen 2014-08-06 10:25 ` Mikko Perttunen 2014-08-06 10:25 ` Mikko Perttunen 2014-08-11 13:32 ` Eduardo Valentin 2014-08-11 13:32 ` Eduardo Valentin 2014-08-12 9:51 ` Mikko Perttunen 2014-08-12 9:51 ` Mikko Perttunen 2014-08-12 9:51 ` Mikko Perttunen [not found] ` <1407320706-17440-5-git-send-email-mperttunen-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> 2014-08-15 11:00 ` [PATCH v4 " Mikko Perttunen 2014-08-15 11:00 ` Mikko Perttunen 2014-08-15 11:00 ` Mikko Perttunen 2014-08-19 14:09 ` Juha-Matti Tilli 2014-08-19 14:09 ` Juha-Matti Tilli 2014-08-19 14:09 ` Juha-Matti Tilli 2014-08-19 14:31 ` Mikko Perttunen 2014-08-19 14:31 ` Mikko Perttunen 2014-08-19 14:31 ` Mikko Perttunen [not found] ` <20140819140955.GA50475-Xv4IVSKz7SWQi9Q/X01l6/UpdFzICT1y@public.gmane.org> 2014-08-19 14:33 ` edubezval-Re5JQEeQqe8AvxtiuMwx3w 2014-08-19 14:33 ` edubezval at gmail.com 2014-08-19 14:33 ` edubezval [not found] ` <CAC-25o-bLeDYpTgPy5UOvBGJ7k7HJkBM3YcCRPSZHBkyxugULA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2014-08-19 15:27 ` Mikko Perttunen 2014-08-19 15:27 ` Mikko Perttunen 2014-08-19 15:27 ` Mikko Perttunen 2014-08-19 18:25 ` Juha-Matti Tilli 2014-08-19 18:25 ` Juha-Matti Tilli 2014-08-19 18:25 ` Juha-Matti Tilli 2014-08-19 18:25 ` Juha-Matti Tilli 2014-08-19 18:25 ` Juha-Matti Tilli 2014-08-19 18:25 ` Juha-Matti Tilli 2014-08-20 12:05 ` Juha-Matti Tilli 2014-08-20 12:05 ` Juha-Matti Tilli 2014-08-20 12:05 ` Juha-Matti Tilli 2014-08-20 19:50 ` Stephen Warren [this message] 2014-08-20 19:50 ` [PATCH v3 " Stephen Warren [not found] ` <53F4FC18.90804-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org> 2014-08-21 7:39 ` Mikko Perttunen 2014-08-21 7:39 ` Mikko Perttunen 2014-08-21 7:39 ` Mikko Perttunen 2014-08-21 16:08 ` Eduardo Valentin 2014-08-21 16:08 ` Eduardo Valentin
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=53F4FC18.90804@wwwdotorg.org \ --to=swarren@wwwdotorg.org \ --cc=edubezval@gmail.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-pm@vger.kernel.org \ --cc=linux-tegra@vger.kernel.org \ --cc=mperttunen@nvidia.com \ --cc=rui.zhang@intel.com \ --cc=thierry.reding@gmail.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.