All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
To: Mikko Perttunen
	<mperttunen-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>,
	thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org
Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	wni-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org
Subject: Re: [PATCH v2 2/5] of: Add nvidia,controller-id property to Tegra I2C bindings
Date: Wed, 20 Aug 2014 14:19:35 -0600	[thread overview]
Message-ID: <53F502D7.9030403@wwwdotorg.org> (raw)
In-Reply-To: <1407933685-12404-3-git-send-email-mperttunen-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>

On 08/13/2014 06:41 AM, Mikko Perttunen wrote:
> Sometimes, hardware blocks want to issue requests to devices
> connected to I2C buses by itself. In such case, the bus the
> target device resides on must be configured into a register.
> For this purpose, each I2C controller has a defined ID known
> by the hardware. Add a property for these IDs to the device tree
> bindings, so that drivers can know what ID to write to a hardware
> register when configuring a block that sends I2C messages autonomously.

> diff --git a/Documentation/devicetree/bindings/i2c/nvidia,tegra20-i2c.txt b/Documentation/devicetree/bindings/i2c/nvidia,tegra20-i2c.txt

> +Optional properties:
> +- nvidia,controller-id: ID of controller when referred to in
> +                        hardware registers.

I'd prefer to put this information into the thermal trip node, since 
this represents what ID the PMC uses to communicate with the I2C 
controller, and there's no absolute guarantee that multiple clients that 
communicate directly with an I2C controller would use the same numbering 
scheme.

If that doesn't work, can be at least name this nvidia,pmc-controller-id 
or nvidia,id-in-pmc so that if there are different numbering schemes, 
there's a clear path to represent this in different properties without 
conflicting names?

WARNING: multiple messages have this Message-ID (diff)
From: Stephen Warren <swarren@wwwdotorg.org>
To: Mikko Perttunen <mperttunen@nvidia.com>, thierry.reding@gmail.com
Cc: linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-tegra@vger.kernel.org, wni@nvidia.com
Subject: Re: [PATCH v2 2/5] of: Add nvidia,controller-id property to Tegra I2C bindings
Date: Wed, 20 Aug 2014 14:19:35 -0600	[thread overview]
Message-ID: <53F502D7.9030403@wwwdotorg.org> (raw)
In-Reply-To: <1407933685-12404-3-git-send-email-mperttunen@nvidia.com>

On 08/13/2014 06:41 AM, Mikko Perttunen wrote:
> Sometimes, hardware blocks want to issue requests to devices
> connected to I2C buses by itself. In such case, the bus the
> target device resides on must be configured into a register.
> For this purpose, each I2C controller has a defined ID known
> by the hardware. Add a property for these IDs to the device tree
> bindings, so that drivers can know what ID to write to a hardware
> register when configuring a block that sends I2C messages autonomously.

> diff --git a/Documentation/devicetree/bindings/i2c/nvidia,tegra20-i2c.txt b/Documentation/devicetree/bindings/i2c/nvidia,tegra20-i2c.txt

> +Optional properties:
> +- nvidia,controller-id: ID of controller when referred to in
> +                        hardware registers.

I'd prefer to put this information into the thermal trip node, since 
this represents what ID the PMC uses to communicate with the I2C 
controller, and there's no absolute guarantee that multiple clients that 
communicate directly with an I2C controller would use the same numbering 
scheme.

If that doesn't work, can be at least name this nvidia,pmc-controller-id 
or nvidia,id-in-pmc so that if there are different numbering schemes, 
there's a clear path to represent this in different properties without 
conflicting names?

WARNING: multiple messages have this Message-ID (diff)
From: swarren@wwwdotorg.org (Stephen Warren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 2/5] of: Add nvidia,controller-id property to Tegra I2C bindings
Date: Wed, 20 Aug 2014 14:19:35 -0600	[thread overview]
Message-ID: <53F502D7.9030403@wwwdotorg.org> (raw)
In-Reply-To: <1407933685-12404-3-git-send-email-mperttunen@nvidia.com>

On 08/13/2014 06:41 AM, Mikko Perttunen wrote:
> Sometimes, hardware blocks want to issue requests to devices
> connected to I2C buses by itself. In such case, the bus the
> target device resides on must be configured into a register.
> For this purpose, each I2C controller has a defined ID known
> by the hardware. Add a property for these IDs to the device tree
> bindings, so that drivers can know what ID to write to a hardware
> register when configuring a block that sends I2C messages autonomously.

> diff --git a/Documentation/devicetree/bindings/i2c/nvidia,tegra20-i2c.txt b/Documentation/devicetree/bindings/i2c/nvidia,tegra20-i2c.txt

> +Optional properties:
> +- nvidia,controller-id: ID of controller when referred to in
> +                        hardware registers.

I'd prefer to put this information into the thermal trip node, since 
this represents what ID the PMC uses to communicate with the I2C 
controller, and there's no absolute guarantee that multiple clients that 
communicate directly with an I2C controller would use the same numbering 
scheme.

If that doesn't work, can be at least name this nvidia,pmc-controller-id 
or nvidia,id-in-pmc so that if there are different numbering schemes, 
there's a clear path to represent this in different properties without 
conflicting names?

  parent reply	other threads:[~2014-08-20 20:19 UTC|newest]

Thread overview: 65+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-13 12:41 [PATCH v2 0/5] Thermal reset support in PMC Mikko Perttunen
2014-08-13 12:41 ` Mikko Perttunen
2014-08-13 12:41 ` Mikko Perttunen
2014-08-13 12:41 ` [PATCH v2 1/5] of: Add descriptions of thermtrip properties to Tegra PMC bindings Mikko Perttunen
2014-08-13 12:41   ` Mikko Perttunen
2014-08-13 12:41   ` Mikko Perttunen
     [not found]   ` <1407933685-12404-2-git-send-email-mperttunen-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2014-08-20 20:16     ` Stephen Warren
2014-08-20 20:16       ` Stephen Warren
2014-08-20 20:16       ` Stephen Warren
     [not found]       ` <53F50231.5010605-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2014-08-21  6:58         ` Thierry Reding
2014-08-21  6:58           ` Thierry Reding
2014-08-21  6:58           ` Thierry Reding
2014-08-21 15:38           ` Stephen Warren
2014-08-21 15:38             ` Stephen Warren
2014-08-21 15:38             ` Stephen Warren
     [not found]             ` <53F61275.9020508-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2014-08-21 16:53               ` Thierry Reding
2014-08-21 16:53                 ` Thierry Reding
2014-08-21 16:53                 ` Thierry Reding
2014-08-21 17:54                 ` Stephen Warren
2014-08-21 17:54                   ` Stephen Warren
2014-08-21 17:54                   ` Stephen Warren
     [not found]                   ` <53F6326F.2050600-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2014-09-05  9:50                     ` Mikko Perttunen
2014-09-05  9:50                       ` Mikko Perttunen
2014-09-05  9:50                       ` Mikko Perttunen
     [not found]                       ` <5409875E.2080607-/1wQRMveznE@public.gmane.org>
2014-09-05 18:48                         ` Stephen Warren
2014-09-05 18:48                           ` Stephen Warren
2014-09-05 18:48                           ` Stephen Warren
2014-08-20 20:22     ` Stephen Warren
2014-08-20 20:22       ` Stephen Warren
2014-08-20 20:22       ` Stephen Warren
2014-08-13 12:41 ` [PATCH v2 2/5] of: Add nvidia,controller-id property to Tegra I2C bindings Mikko Perttunen
2014-08-13 12:41   ` [PATCH v2 2/5] of: Add nvidia, controller-id " Mikko Perttunen
2014-08-13 12:41   ` [PATCH v2 2/5] of: Add nvidia,controller-id " Mikko Perttunen
     [not found]   ` <1407933685-12404-3-git-send-email-mperttunen-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2014-08-20 20:19     ` Stephen Warren [this message]
2014-08-20 20:19       ` Stephen Warren
2014-08-20 20:19       ` Stephen Warren
     [not found]       ` <53F502D7.9030403-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2014-08-21  7:05         ` Thierry Reding
2014-08-21  7:05           ` Thierry Reding
2014-08-21  7:05           ` Thierry Reding
2014-08-21 15:41           ` Stephen Warren
2014-08-21 15:41             ` Stephen Warren
2014-08-13 12:41 ` [PATCH v2 3/5] ARM: tegra124: Add I2C controller ids to device tree Mikko Perttunen
2014-08-13 12:41   ` Mikko Perttunen
2014-08-13 12:41   ` Mikko Perttunen
2014-08-13 12:41 ` [PATCH v2 4/5] ARM: tegra: Add PMC thermtrip programming to Jetson TK1 " Mikko Perttunen
2014-08-13 12:41   ` Mikko Perttunen
2014-08-13 12:41   ` Mikko Perttunen
2014-08-13 12:41 ` [PATCH v2 5/5] ARM: tegra: Add thermal reset (thermtrip) support to PMC Mikko Perttunen
2014-08-13 12:41   ` Mikko Perttunen
2014-08-13 12:41   ` Mikko Perttunen
     [not found]   ` <1407933685-12404-6-git-send-email-mperttunen-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2014-08-20 20:25     ` Stephen Warren
2014-08-20 20:25       ` Stephen Warren
2014-08-20 20:25       ` Stephen Warren
     [not found]       ` <53F5042A.7020603-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2014-08-21 13:11         ` Mikko Perttunen
2014-08-21 13:11           ` Mikko Perttunen
2014-08-21 13:11           ` Mikko Perttunen
     [not found]           ` <53F5F019.10308-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2014-08-21 15:40             ` Stephen Warren
2014-08-21 15:40               ` Stephen Warren
2014-08-21 15:40               ` Stephen Warren
     [not found]               ` <53F612D2.8020803-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2014-08-22 12:55                 ` Mikko Perttunen
2014-08-22 12:55                   ` Mikko Perttunen
2014-08-22 12:55                   ` Mikko Perttunen
     [not found] ` <1407933685-12404-1-git-send-email-mperttunen-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2014-08-14 11:26   ` [PATCH v2 0/5] Thermal reset support in PMC Wei Ni
2014-08-14 11:26     ` Wei Ni
2014-08-14 11:26     ` Wei Ni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53F502D7.9030403@wwwdotorg.org \
    --to=swarren-3lzwwm7+weoh9zmkesr00q@public.gmane.org \
    --cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=mperttunen-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
    --cc=thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=wni-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.