From: Diana Craciun <diana.craciun@freescale.com> To: Jingchang Lu <jingchang.lu@freescale.com> Cc: <mturquette@linaro.org>, <linux-kernel@vger.kernel.org>, <linux-arm-kernel@lists.infradead.org> Subject: Re: [PATCH] clk: ppc-corenet: Add Freescale ARM-based platforms CLK_OF_DECLARE support Date: Thu, 21 Aug 2014 14:28:29 +0300 [thread overview] Message-ID: <53F5D7DD.4070805@freescale.com> (raw) In-Reply-To: <1407145537-15027-1-git-send-email-jingchang.lu@freescale.com> I think you should cc also linuxppc-dev as it touches common code. On 08/04/2014 12:45 PM, Jingchang Lu wrote: > Signed-off-by: Jingchang Lu <jingchang.lu@freescale.com> > --- > drivers/clk/Kconfig | 7 ++++--- > drivers/clk/clk-ppc-corenet.c | 5 +++++ > 2 files changed, 9 insertions(+), 3 deletions(-) > > diff --git a/drivers/clk/Kconfig b/drivers/clk/Kconfig > index cfd3af7..8784704 100644 > --- a/drivers/clk/Kconfig > +++ b/drivers/clk/Kconfig > @@ -82,11 +82,12 @@ config COMMON_CLK_AXI_CLKGEN > FPGAs. It is commonly used in Analog Devices' reference designs. > > config CLK_PPC_CORENET > - bool "Clock driver for PowerPC corenet platforms" > - depends on PPC_E500MC && OF > + bool "Clock driver for PowerPC corenet and compatible ARM-based platforms" > + depends on (PPC_E500MC || ARM) && OF > ---help--- > This adds the clock driver support for Freescale PowerPC corenet > - platforms using common clock framework. > + platforms and compatible Freescale ARM based platforms using common > + clock framework. > > config COMMON_CLK_XGENE > bool "Clock driver for APM XGene SoC" > diff --git a/drivers/clk/clk-ppc-corenet.c b/drivers/clk/clk-ppc-corenet.c Can't this file be renamed in order to reflect that is common between PPC and ARM? It is strange to be named ppc_xxx and to be used by ARM kernel. > index 8e58edf..7692cac 100644 > --- a/drivers/clk/clk-ppc-corenet.c > +++ b/drivers/clk/clk-ppc-corenet.c > @@ -305,3 +305,8 @@ static int __init ppc_corenet_clk_init(void) > return platform_driver_register(&ppc_corenet_clk_driver); > } > subsys_initcall(ppc_corenet_clk_init); > + > +CLK_OF_DECLARE(ppc_core_pll_v1, "fsl,qoriq-core-pll-1.0", core_pll_init); > +CLK_OF_DECLARE(ppc_core_pll_v2, "fsl,qoriq-core-pll-2.0", core_pll_init); > +CLK_OF_DECLARE(ppc_core_mux_v1, "fsl,qoriq-core-mux-1.0", core_mux_init); > +CLK_OF_DECLARE(ppc_core_mux_v2, "fsl,qoriq-core-mux-2.0", core_mux_init); Diana
WARNING: multiple messages have this Message-ID (diff)
From: diana.craciun@freescale.com (Diana Craciun) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH] clk: ppc-corenet: Add Freescale ARM-based platforms CLK_OF_DECLARE support Date: Thu, 21 Aug 2014 14:28:29 +0300 [thread overview] Message-ID: <53F5D7DD.4070805@freescale.com> (raw) In-Reply-To: <1407145537-15027-1-git-send-email-jingchang.lu@freescale.com> I think you should cc also linuxppc-dev as it touches common code. On 08/04/2014 12:45 PM, Jingchang Lu wrote: > Signed-off-by: Jingchang Lu <jingchang.lu@freescale.com> > --- > drivers/clk/Kconfig | 7 ++++--- > drivers/clk/clk-ppc-corenet.c | 5 +++++ > 2 files changed, 9 insertions(+), 3 deletions(-) > > diff --git a/drivers/clk/Kconfig b/drivers/clk/Kconfig > index cfd3af7..8784704 100644 > --- a/drivers/clk/Kconfig > +++ b/drivers/clk/Kconfig > @@ -82,11 +82,12 @@ config COMMON_CLK_AXI_CLKGEN > FPGAs. It is commonly used in Analog Devices' reference designs. > > config CLK_PPC_CORENET > - bool "Clock driver for PowerPC corenet platforms" > - depends on PPC_E500MC && OF > + bool "Clock driver for PowerPC corenet and compatible ARM-based platforms" > + depends on (PPC_E500MC || ARM) && OF > ---help--- > This adds the clock driver support for Freescale PowerPC corenet > - platforms using common clock framework. > + platforms and compatible Freescale ARM based platforms using common > + clock framework. > > config COMMON_CLK_XGENE > bool "Clock driver for APM XGene SoC" > diff --git a/drivers/clk/clk-ppc-corenet.c b/drivers/clk/clk-ppc-corenet.c Can't this file be renamed in order to reflect that is common between PPC and ARM? It is strange to be named ppc_xxx and to be used by ARM kernel. > index 8e58edf..7692cac 100644 > --- a/drivers/clk/clk-ppc-corenet.c > +++ b/drivers/clk/clk-ppc-corenet.c > @@ -305,3 +305,8 @@ static int __init ppc_corenet_clk_init(void) > return platform_driver_register(&ppc_corenet_clk_driver); > } > subsys_initcall(ppc_corenet_clk_init); > + > +CLK_OF_DECLARE(ppc_core_pll_v1, "fsl,qoriq-core-pll-1.0", core_pll_init); > +CLK_OF_DECLARE(ppc_core_pll_v2, "fsl,qoriq-core-pll-2.0", core_pll_init); > +CLK_OF_DECLARE(ppc_core_mux_v1, "fsl,qoriq-core-mux-1.0", core_mux_init); > +CLK_OF_DECLARE(ppc_core_mux_v2, "fsl,qoriq-core-mux-2.0", core_mux_init); Diana
next prev parent reply other threads:[~2014-08-21 11:28 UTC|newest] Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top 2014-08-04 9:45 [PATCH] clk: ppc-corenet: Add Freescale ARM-based platforms CLK_OF_DECLARE support Jingchang Lu 2014-08-04 9:45 ` Jingchang Lu 2014-08-21 11:28 ` Diana Craciun [this message] 2014-08-21 11:28 ` Diana Craciun 2014-08-22 10:14 ` Jingchang Lu 2014-08-22 10:14 ` Jingchang Lu
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=53F5D7DD.4070805@freescale.com \ --to=diana.craciun@freescale.com \ --cc=jingchang.lu@freescale.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=mturquette@linaro.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.