All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] phy: exynos5-usbdrd: Add MODULE_DEVICE_TABLE entry
@ 2014-08-22 13:58 ` Sjoerd Simons
  0 siblings, 0 replies; 6+ messages in thread
From: Sjoerd Simons @ 2014-08-22 13:58 UTC (permalink / raw)
  To: Kishon Vijay Abraham I, Kukjin Kim
  Cc: linux-arm-kernel, linux-samsung-soc, devicetree, Sjoerd Simons

Add a MODULE_DEVICE_TABLE call for OF match tables. This allows the
module to be autoloaded based on devicetree information.

Signed-off-by: Sjoerd Simons <sjoerd.simons@collabora.co.uk>
---
 drivers/phy/phy-exynos5-usbdrd.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/phy/phy-exynos5-usbdrd.c b/drivers/phy/phy-exynos5-usbdrd.c
index b05302b..e9a0f54 100644
--- a/drivers/phy/phy-exynos5-usbdrd.c
+++ b/drivers/phy/phy-exynos5-usbdrd.c
@@ -542,6 +542,7 @@ static const struct of_device_id exynos5_usbdrd_phy_of_match[] = {
 	},
 	{ },
 };
+MODULE_DEVICE_TABLE (of, exynos5_usbdrd_phy_of_match);
 
 static int exynos5_usbdrd_phy_probe(struct platform_device *pdev)
 {
-- 
2.1.0

^ permalink raw reply related	[flat|nested] 6+ messages in thread
* [PATCH] phy: exynos5-usbdrd: Add MODULE_DEVICE_TABLE entry
@ 2014-08-22 13:58 ` Sjoerd Simons
  0 siblings, 0 replies; 6+ messages in thread
From: Sjoerd Simons @ 2014-08-22 13:58 UTC (permalink / raw)
  To: linux-arm-kernel

Add a MODULE_DEVICE_TABLE call for OF match tables. This allows the
module to be autoloaded based on devicetree information.

Signed-off-by: Sjoerd Simons <sjoerd.simons@collabora.co.uk>
---
 drivers/phy/phy-exynos5-usbdrd.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/phy/phy-exynos5-usbdrd.c b/drivers/phy/phy-exynos5-usbdrd.c
index b05302b..e9a0f54 100644
--- a/drivers/phy/phy-exynos5-usbdrd.c
+++ b/drivers/phy/phy-exynos5-usbdrd.c
@@ -542,6 +542,7 @@ static const struct of_device_id exynos5_usbdrd_phy_of_match[] = {
 	},
 	{ },
 };
+MODULE_DEVICE_TABLE (of, exynos5_usbdrd_phy_of_match);
 
 static int exynos5_usbdrd_phy_probe(struct platform_device *pdev)
 {
-- 
2.1.0

^ permalink raw reply related	[flat|nested] 6+ messages in thread
* Re: [PATCH] phy: exynos5-usbdrd: Add MODULE_DEVICE_TABLE entry
  2014-08-22 13:58 ` Sjoerd Simons
@ 2014-08-23 16:23   ` Andreas Färber
  -1 siblings, 0 replies; 6+ messages in thread
From: Andreas Färber @ 2014-08-23 16:23 UTC (permalink / raw)
  To: Sjoerd Simons
  Cc: Kishon Vijay Abraham I, Kukjin Kim, linux-arm-kernel,
	linux-samsung-soc, devicetree

Hi,

Am 22.08.2014 15:58, schrieb Sjoerd Simons:
> Add a MODULE_DEVICE_TABLE call for OF match tables. This allows the
> module to be autoloaded based on devicetree information.
> 
> Signed-off-by: Sjoerd Simons <sjoerd.simons@collabora.co.uk>
> ---
>  drivers/phy/phy-exynos5-usbdrd.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/phy/phy-exynos5-usbdrd.c b/drivers/phy/phy-exynos5-usbdrd.c
> index b05302b..e9a0f54 100644
> --- a/drivers/phy/phy-exynos5-usbdrd.c
> +++ b/drivers/phy/phy-exynos5-usbdrd.c
> @@ -542,6 +542,7 @@ static const struct of_device_id exynos5_usbdrd_phy_of_match[] = {
>  	},
>  	{ },
>  };
> +MODULE_DEVICE_TABLE (of, exynos5_usbdrd_phy_of_match);

Nit: Probably there should be no space before '('?

>  
>  static int exynos5_usbdrd_phy_probe(struct platform_device *pdev)
>  {

Otherwise certainly sensible. I ran into another such case myself.

Regards,
Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg

^ permalink raw reply	[flat|nested] 6+ messages in thread
* [PATCH] phy: exynos5-usbdrd: Add MODULE_DEVICE_TABLE entry
@ 2014-08-23 16:23   ` Andreas Färber
  0 siblings, 0 replies; 6+ messages in thread
From: Andreas Färber @ 2014-08-23 16:23 UTC (permalink / raw)
  To: linux-arm-kernel

Hi,

Am 22.08.2014 15:58, schrieb Sjoerd Simons:
> Add a MODULE_DEVICE_TABLE call for OF match tables. This allows the
> module to be autoloaded based on devicetree information.
> 
> Signed-off-by: Sjoerd Simons <sjoerd.simons@collabora.co.uk>
> ---
>  drivers/phy/phy-exynos5-usbdrd.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/phy/phy-exynos5-usbdrd.c b/drivers/phy/phy-exynos5-usbdrd.c
> index b05302b..e9a0f54 100644
> --- a/drivers/phy/phy-exynos5-usbdrd.c
> +++ b/drivers/phy/phy-exynos5-usbdrd.c
> @@ -542,6 +542,7 @@ static const struct of_device_id exynos5_usbdrd_phy_of_match[] = {
>  	},
>  	{ },
>  };
> +MODULE_DEVICE_TABLE (of, exynos5_usbdrd_phy_of_match);

Nit: Probably there should be no space before '('?

>  
>  static int exynos5_usbdrd_phy_probe(struct platform_device *pdev)
>  {

Otherwise certainly sensible. I ran into another such case myself.

Regards,
Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N?rnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend?rffer; HRB 16746 AG N?rnberg

^ permalink raw reply	[flat|nested] 6+ messages in thread
* [PATCH v2] phy: exynos5-usbdrd: Add MODULE_DEVICE_TABLE entry
  2014-08-23 16:23   ` Andreas Färber
@ 2014-08-25  7:38     ` Sjoerd Simons
  -1 siblings, 0 replies; 6+ messages in thread
From: Sjoerd Simons @ 2014-08-25  7:38 UTC (permalink / raw)
  To: Kishon Vijay Abraham I, Kukjin Kim
  Cc: linux-arm-kernel, linux-samsung-soc, devicetree,
	Andreas Färber, Sjoerd Simons

Add a MODULE_DEVICE_TABLE call for OF match tables. This allows the
module to be autoloaded based on devicetree information.

Signed-off-by: Sjoerd Simons <sjoerd.simons@collabora.co.uk>
---
Changes since v1:
  - Fix an indentation nitpick spotted by Andreas Färber

 drivers/phy/phy-exynos5-usbdrd.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/phy/phy-exynos5-usbdrd.c b/drivers/phy/phy-exynos5-usbdrd.c
index b05302b..392101c 100644
--- a/drivers/phy/phy-exynos5-usbdrd.c
+++ b/drivers/phy/phy-exynos5-usbdrd.c
@@ -542,6 +542,7 @@ static const struct of_device_id exynos5_usbdrd_phy_of_match[] = {
 	},
 	{ },
 };
+MODULE_DEVICE_TABLE(of, exynos5_usbdrd_phy_of_match);
 
 static int exynos5_usbdrd_phy_probe(struct platform_device *pdev)
 {
-- 
2.1.0

^ permalink raw reply related	[flat|nested] 6+ messages in thread
* [PATCH v2] phy: exynos5-usbdrd: Add MODULE_DEVICE_TABLE entry
@ 2014-08-25  7:38     ` Sjoerd Simons
  0 siblings, 0 replies; 6+ messages in thread
From: Sjoerd Simons @ 2014-08-25  7:38 UTC (permalink / raw)
  To: linux-arm-kernel

Add a MODULE_DEVICE_TABLE call for OF match tables. This allows the
module to be autoloaded based on devicetree information.

Signed-off-by: Sjoerd Simons <sjoerd.simons@collabora.co.uk>
---
Changes since v1:
  - Fix an indentation nitpick spotted by Andreas F?rber

 drivers/phy/phy-exynos5-usbdrd.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/phy/phy-exynos5-usbdrd.c b/drivers/phy/phy-exynos5-usbdrd.c
index b05302b..392101c 100644
--- a/drivers/phy/phy-exynos5-usbdrd.c
+++ b/drivers/phy/phy-exynos5-usbdrd.c
@@ -542,6 +542,7 @@ static const struct of_device_id exynos5_usbdrd_phy_of_match[] = {
 	},
 	{ },
 };
+MODULE_DEVICE_TABLE(of, exynos5_usbdrd_phy_of_match);
 
 static int exynos5_usbdrd_phy_probe(struct platform_device *pdev)
 {
-- 
2.1.0

^ permalink raw reply related	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2014-08-25  7:38 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-08-22 13:58 [PATCH] phy: exynos5-usbdrd: Add MODULE_DEVICE_TABLE entry Sjoerd Simons
2014-08-22 13:58 ` Sjoerd Simons
2014-08-23 16:23 ` Andreas Färber
2014-08-23 16:23   ` Andreas Färber
2014-08-25  7:38   ` [PATCH v2] " Sjoerd Simons
2014-08-25  7:38     ` Sjoerd Simons

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.