* [PATCH] drm/radeon: move the IB test after the AGP fallback
@ 2014-08-24 12:54 Christian König
2014-08-25 2:10 ` Michel Dänzer
2014-08-25 15:41 ` Alex Deucher
0 siblings, 2 replies; 3+ messages in thread
From: Christian König @ 2014-08-24 12:54 UTC (permalink / raw)
To: dri-devel
From: Christian König <christian.koenig@amd.com>
Otherwise we won't test if the fallback to PCIe GART really worked.
Signed-off-by: Christian König <christian.koenig@amd.com>
---
drivers/gpu/drm/radeon/radeon_device.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/radeon/radeon_device.c b/drivers/gpu/drm/radeon/radeon_device.c
index c58f84f..152181d 100644
--- a/drivers/gpu/drm/radeon/radeon_device.c
+++ b/drivers/gpu/drm/radeon/radeon_device.c
@@ -1397,10 +1397,6 @@ int radeon_device_init(struct radeon_device *rdev,
if (r)
return r;
- r = radeon_ib_ring_tests(rdev);
- if (r)
- DRM_ERROR("ib ring test failed (%d).\n", r);
-
r = radeon_gem_debugfs_init(rdev);
if (r) {
DRM_ERROR("registering gem debugfs failed (%d).\n", r);
@@ -1418,6 +1414,10 @@ int radeon_device_init(struct radeon_device *rdev,
return r;
}
+ r = radeon_ib_ring_tests(rdev);
+ if (r)
+ DRM_ERROR("ib ring test failed (%d).\n", r);
+
if ((radeon_testing & 1)) {
if (rdev->accel_working)
radeon_test_moves(rdev);
--
1.8.3.2
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/radeon: move the IB test after the AGP fallback
2014-08-24 12:54 [PATCH] drm/radeon: move the IB test after the AGP fallback Christian König
@ 2014-08-25 2:10 ` Michel Dänzer
2014-08-25 15:41 ` Alex Deucher
1 sibling, 0 replies; 3+ messages in thread
From: Michel Dänzer @ 2014-08-25 2:10 UTC (permalink / raw)
To: Christian König; +Cc: dri-devel
On 24.08.2014 21:54, Christian König wrote:
> From: Christian König <christian.koenig@amd.com>
>
> Otherwise we won't test if the fallback to PCIe GART really worked.
>
> Signed-off-by: Christian König <christian.koenig@amd.com>
Reviewed-by: Michel Dänzer <michel.daenzer@amd.com>
--
Earthling Michel Dänzer | http://www.amd.com
Libre software enthusiast | Mesa and X developer
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/radeon: move the IB test after the AGP fallback
2014-08-24 12:54 [PATCH] drm/radeon: move the IB test after the AGP fallback Christian König
2014-08-25 2:10 ` Michel Dänzer
@ 2014-08-25 15:41 ` Alex Deucher
1 sibling, 0 replies; 3+ messages in thread
From: Alex Deucher @ 2014-08-25 15:41 UTC (permalink / raw)
To: Christian König; +Cc: Maling list - DRI developers
On Sun, Aug 24, 2014 at 8:54 AM, Christian König
<deathsimple@vodafone.de> wrote:
> From: Christian König <christian.koenig@amd.com>
>
> Otherwise we won't test if the fallback to PCIe GART really worked.
>
> Signed-off-by: Christian König <christian.koenig@amd.com>
Applied to my 3.18 tree.
Alex
> ---
> drivers/gpu/drm/radeon/radeon_device.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/radeon/radeon_device.c b/drivers/gpu/drm/radeon/radeon_device.c
> index c58f84f..152181d 100644
> --- a/drivers/gpu/drm/radeon/radeon_device.c
> +++ b/drivers/gpu/drm/radeon/radeon_device.c
> @@ -1397,10 +1397,6 @@ int radeon_device_init(struct radeon_device *rdev,
> if (r)
> return r;
>
> - r = radeon_ib_ring_tests(rdev);
> - if (r)
> - DRM_ERROR("ib ring test failed (%d).\n", r);
> -
> r = radeon_gem_debugfs_init(rdev);
> if (r) {
> DRM_ERROR("registering gem debugfs failed (%d).\n", r);
> @@ -1418,6 +1414,10 @@ int radeon_device_init(struct radeon_device *rdev,
> return r;
> }
>
> + r = radeon_ib_ring_tests(rdev);
> + if (r)
> + DRM_ERROR("ib ring test failed (%d).\n", r);
> +
> if ((radeon_testing & 1)) {
> if (rdev->accel_working)
> radeon_test_moves(rdev);
> --
> 1.8.3.2
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-08-25 15:41 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-08-24 12:54 [PATCH] drm/radeon: move the IB test after the AGP fallback Christian König
2014-08-25 2:10 ` Michel Dänzer
2014-08-25 15:41 ` Alex Deucher
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.