[PATCH] KVM: Only export kvm_ple_window for x86_64

[PATCH] KVM: Only export kvm_ple_window for x86_64

[Steven Rostedt]

Commit 7b46268d2954 "KVM: trace kvm_ple_window grow/shrink"
Added the tracepoint kvm_ple_window under a #ifdef CONFIG_X86_64 but
left the export for that tracepoint unprotected, which would cause it
to fail to compile when X86_32 is set.

Link: http://lkml.kernel.org/p/20140825172204.769ab4e6@gandalf.local.home

Reported-by: Jim Davis <jim.epost@gmail.com>
tested-by: Jim Davis <jim.epost@gmail.com>
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
---
 arch/x86/kvm/x86.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c
index c10408ef9ab1..3da45a3ecaa4 100644
--- a/arch/x86/kvm/x86.c
+++ b/arch/x86/kvm/x86.c
@@ -7673,4 +7673,6 @@ EXPORT_TRACEPOINT_SYMBOL_GPL(kvm_invlpga);
 EXPORT_TRACEPOINT_SYMBOL_GPL(kvm_skinit);
 EXPORT_TRACEPOINT_SYMBOL_GPL(kvm_nested_intercepts);
 EXPORT_TRACEPOINT_SYMBOL_GPL(kvm_write_tsc_offset);
+#ifdef CONFIG_X86_64
 EXPORT_TRACEPOINT_SYMBOL_GPL(kvm_ple_window);
+#endif
-- 
1.8.1.4

Re: [PATCH] KVM: Only export kvm_ple_window for x86_64

[Paolo Bonzini]

Il 26/08/2014 01:10, Steven Rostedt ha scritto:
> Commit 7b46268d2954 "KVM: trace kvm_ple_window grow/shrink"
> Added the tracepoint kvm_ple_window under a #ifdef CONFIG_X86_64 but
> left the export for that tracepoint unprotected, which would cause it
> to fail to compile when X86_32 is set.
> 
> Link: http://lkml.kernel.org/p/20140825172204.769ab4e6@gandalf.local.home
> 
> Reported-by: Jim Davis <jim.epost@gmail.com>
> tested-by: Jim Davis <jim.epost@gmail.com>
> Signed-off-by: Steven Rostedt <rostedt@goodmis.org>

The current KVM branch should have fixed this already---it leaves the
tracepoint outside CONFIG_X86_64, which was the right thing to do in the
first place.

Paolo

Re: [PATCH] KVM: Only export kvm_ple_window for x86_64

[Steven Rostedt]

On Tue, 26 Aug 2014 13:05:57 +0200
Paolo Bonzini <pbonzini@redhat.com> wrote:

> Il 26/08/2014 01:10, Steven Rostedt ha scritto:
> > Commit 7b46268d2954 "KVM: trace kvm_ple_window grow/shrink"
> > Added the tracepoint kvm_ple_window under a #ifdef CONFIG_X86_64 but
> > left the export for that tracepoint unprotected, which would cause it
> > to fail to compile when X86_32 is set.
> > 
> > Link: http://lkml.kernel.org/p/20140825172204.769ab4e6@gandalf.local.home
> > 
> > Reported-by: Jim Davis <jim.epost@gmail.com>
> > tested-by: Jim Davis <jim.epost@gmail.com>
> > Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
> 
> The current KVM branch should have fixed this already---it leaves the
> tracepoint outside CONFIG_X86_64, which was the right thing to do in the
> first place.
> 

Fair enough. I was wondering why this was unique to x86_64.

-- Steve