From: Alexander Graf <agraf@suse.de>
To: Mihai Caraman <mihai.caraman@freescale.com>, kvm-ppc@vger.kernel.org
Cc: kvm@vger.kernel.org, linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH v4 5/6] KVM: PPC: Booke: Add setter functions for IVPR, IVOR2 and IVOR8 emulation
Date: Wed, 27 Aug 2014 14:16:04 +0200 [thread overview]
Message-ID: <53FDCC04.9000605@suse.de> (raw)
In-Reply-To: <1408541787-24625-6-git-send-email-mihai.caraman@freescale.com>
On 20.08.14 15:36, Mihai Caraman wrote:
> Add setter functions for IVPR, IVOR2 and IVOR8 emulation in preparation
> for ONE_REG support.
>
> Signed-off-by: Mihai Caraman <mihai.caraman@freescale.com>
What about the other GIVORs?
Also, I would prefer to have a common helper for IVOR setting that
simply covers SPRN_GIVOR setting along the way. Something like
void kvmppc_set_ivor(struct kvm_vcpu *vcpu, int irqprio_ivor, u16 new_ivor)
{
vcpu->arch.ivor[irqprio_ivor] = new_ivor;
switch (irqprio_ivor) {
case BOOKE_IRQPRIO_DATA_STORAGE:
mtspr(SPRN_GIVOR2, new_ivor);
break;
...
}
}
which you can just call from all the IVOR setters. In fact, you can
probably combine all of the ONE_REG handlers into a single handler that
just does a quick table lookup for its irqprio.
Alex
WARNING: multiple messages have this Message-ID (diff)
From: Alexander Graf <agraf@suse.de>
To: Mihai Caraman <mihai.caraman@freescale.com>, kvm-ppc@vger.kernel.org
Cc: linuxppc-dev@lists.ozlabs.org, kvm@vger.kernel.org
Subject: Re: [PATCH v4 5/6] KVM: PPC: Booke: Add setter functions for IVPR, IVOR2 and IVOR8 emulation
Date: Wed, 27 Aug 2014 14:16:04 +0200 [thread overview]
Message-ID: <53FDCC04.9000605@suse.de> (raw)
In-Reply-To: <1408541787-24625-6-git-send-email-mihai.caraman@freescale.com>
On 20.08.14 15:36, Mihai Caraman wrote:
> Add setter functions for IVPR, IVOR2 and IVOR8 emulation in preparation
> for ONE_REG support.
>
> Signed-off-by: Mihai Caraman <mihai.caraman@freescale.com>
What about the other GIVORs?
Also, I would prefer to have a common helper for IVOR setting that
simply covers SPRN_GIVOR setting along the way. Something like
void kvmppc_set_ivor(struct kvm_vcpu *vcpu, int irqprio_ivor, u16 new_ivor)
{
vcpu->arch.ivor[irqprio_ivor] = new_ivor;
switch (irqprio_ivor) {
case BOOKE_IRQPRIO_DATA_STORAGE:
mtspr(SPRN_GIVOR2, new_ivor);
break;
...
}
}
which you can just call from all the IVOR setters. In fact, you can
probably combine all of the ONE_REG handlers into a single handler that
just does a quick table lookup for its irqprio.
Alex
WARNING: multiple messages have this Message-ID (diff)
From: Alexander Graf <agraf@suse.de>
To: Mihai Caraman <mihai.caraman@freescale.com>, kvm-ppc@vger.kernel.org
Cc: kvm@vger.kernel.org, linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH v4 5/6] KVM: PPC: Booke: Add setter functions for IVPR, IVOR2 and IVOR8 emulation
Date: Wed, 27 Aug 2014 12:16:04 +0000 [thread overview]
Message-ID: <53FDCC04.9000605@suse.de> (raw)
In-Reply-To: <1408541787-24625-6-git-send-email-mihai.caraman@freescale.com>
On 20.08.14 15:36, Mihai Caraman wrote:
> Add setter functions for IVPR, IVOR2 and IVOR8 emulation in preparation
> for ONE_REG support.
>
> Signed-off-by: Mihai Caraman <mihai.caraman@freescale.com>
What about the other GIVORs?
Also, I would prefer to have a common helper for IVOR setting that
simply covers SPRN_GIVOR setting along the way. Something like
void kvmppc_set_ivor(struct kvm_vcpu *vcpu, int irqprio_ivor, u16 new_ivor)
{
vcpu->arch.ivor[irqprio_ivor] = new_ivor;
switch (irqprio_ivor) {
case BOOKE_IRQPRIO_DATA_STORAGE:
mtspr(SPRN_GIVOR2, new_ivor);
break;
...
}
}
which you can just call from all the IVOR setters. In fact, you can
probably combine all of the ONE_REG handlers into a single handler that
just does a quick table lookup for its irqprio.
Alex
next prev parent reply other threads:[~2014-08-27 12:16 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-20 13:36 [PATCH v4 0/6] KVM: PPC: Book3e: AltiVec support Mihai Caraman
2014-08-20 13:36 ` Mihai Caraman
2014-08-20 13:36 ` Mihai Caraman
2014-08-20 13:36 ` [PATCH v4 1/6] KVM: PPC: Book3E: Increase FPU laziness Mihai Caraman
2014-08-20 13:36 ` Mihai Caraman
2014-08-20 13:36 ` Mihai Caraman
2014-08-20 13:36 ` [PATCH v4 2/6] KVM: PPC: Book3e: Add AltiVec support Mihai Caraman
2014-08-20 13:36 ` Mihai Caraman
2014-08-20 13:36 ` Mihai Caraman
2014-08-20 13:36 ` [PATCH v4 3/6] KVM: PPC: Make ONE_REG powerpc generic Mihai Caraman
2014-08-20 13:36 ` Mihai Caraman
2014-08-20 13:36 ` Mihai Caraman
2014-08-20 13:36 ` [PATCH v4 4/6] KVM: PPC: Move ONE_REG AltiVec support to powerpc Mihai Caraman
2014-08-20 13:36 ` Mihai Caraman
2014-08-20 13:36 ` Mihai Caraman
2014-08-20 13:36 ` [PATCH v4 5/6] KVM: PPC: Booke: Add setter functions for IVPR, IVOR2 and IVOR8 emulation Mihai Caraman
2014-08-20 13:36 ` Mihai Caraman
2014-08-20 13:36 ` Mihai Caraman
2014-08-27 12:16 ` Alexander Graf [this message]
2014-08-27 12:16 ` Alexander Graf
2014-08-27 12:16 ` Alexander Graf
2014-08-20 13:36 ` [PATCH v4 6/6] KVM: PPC: Booke: Add ONE_REG support for IVPR and IVORs Mihai Caraman
2014-08-20 13:36 ` Mihai Caraman
2014-08-20 13:36 ` Mihai Caraman
2014-08-27 12:16 ` [PATCH v4 0/6] KVM: PPC: Book3e: AltiVec support Alexander Graf
2014-08-27 12:16 ` Alexander Graf
2014-08-27 12:16 ` Alexander Graf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53FDCC04.9000605@suse.de \
--to=agraf@suse.de \
--cc=kvm-ppc@vger.kernel.org \
--cc=kvm@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mihai.caraman@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.