Re: [Xenomai] [Xenomai-git] Jan Kiszka : arch/x86: Fix section mismatch warning for mach_x86_c1e_disable

Re: [Xenomai] [Xenomai-git] Jan Kiszka : arch/x86: Fix section mismatch warning for mach_x86_c1e_disable

[Gilles Chanteperdrix]

Le 10/07/2014 16:23, git repository hosting a écrit :
> Module: xenomai-jki
> Branch: for-forge
> Commit: dcac4e7a3e7ccf19e4b38169e7c89eb88c821483
> URL:    http://git.xenomai.org/?p=xenomai-jki.git;a=commit;h=dcac4e7a3e7ccf19e4b38169e7c89eb88c821483
> 
> Author: Jan Kiszka <jan.kiszka@siemens.com>
> Date:   Wed Jul  9 17:50:30 2014 +0200
> 
> arch/x86: Fix section mismatch warning for mach_x86_c1e_disable
> 
> mach_x86_c1e_disable is called from non-__init function mach_x86_init,
> thus can't be tagged as __init. mach_x86_init can't be converted as it
> is referenced by the persistent xnarch_machdesc structure.

Well, it seems to me that mach_x86_init truly is an init function, is
not there any other way to fix this?

-- 
Gilles.

Re: [Xenomai] [Xenomai-git] Jan Kiszka : arch/x86: Fix section mismatch warning for mach_x86_c1e_disable

[Jan Kiszka]

On 2014-07-13 18:13, Gilles Chanteperdrix wrote:
> Le 10/07/2014 16:23, git repository hosting a écrit :
>> Module: xenomai-jki
>> Branch: for-forge
>> Commit: dcac4e7a3e7ccf19e4b38169e7c89eb88c821483
>> URL:    http://git.xenomai.org/?p=xenomai-jki.git;a=commit;h=dcac4e7a3e7ccf19e4b38169e7c89eb88c821483
>>
>> Author: Jan Kiszka <jan.kiszka@siemens.com>
>> Date:   Wed Jul  9 17:50:30 2014 +0200
>>
>> arch/x86: Fix section mismatch warning for mach_x86_c1e_disable
>>
>> mach_x86_c1e_disable is called from non-__init function mach_x86_init,
>> thus can't be tagged as __init. mach_x86_init can't be converted as it
>> is referenced by the persistent xnarch_machdesc structure.
> 
> Well, it seems to me that mach_x86_init truly is an init function, is
> not there any other way to fix this?

I do not see any due the pointed out conflict around that data structure.

Jan

-- 
Siemens AG, Corporate Technology, CT RTC ITP SES-DE
Corporate Competence Center Embedded Linux

Re: [Xenomai] [Xenomai-git] Jan Kiszka : arch/x86: Fix section mismatch warning for mach_x86_c1e_disable

[Jan Kiszka]

On 2014-07-13 18:13, Gilles Chanteperdrix wrote:
> Le 10/07/2014 16:23, git repository hosting a écrit :
>> Module: xenomai-jki
>> Branch: for-forge
>> Commit: dcac4e7a3e7ccf19e4b38169e7c89eb88c821483
>> URL:    http://git.xenomai.org/?p=xenomai-jki.git;a=commit;h=dcac4e7a3e7ccf19e4b38169e7c89eb88c821483
>>
>> Author: Jan Kiszka <jan.kiszka@siemens.com>
>> Date:   Wed Jul  9 17:50:30 2014 +0200
>>
>> arch/x86: Fix section mismatch warning for mach_x86_c1e_disable
>>
>> mach_x86_c1e_disable is called from non-__init function mach_x86_init,
>> thus can't be tagged as __init. mach_x86_init can't be converted as it
>> is referenced by the persistent xnarch_machdesc structure.
> 
> Well, it seems to me that mach_x86_init truly is an init function, is
> not there any other way to fix this?

Ping (due to lack of alternatives).

Jan

-- 
Siemens AG, Corporate Technology, CT RTC ITP SES-DE
Corporate Competence Center Embedded Linux

Re: [Xenomai] [Xenomai-git] Jan Kiszka : arch/x86: Fix section mismatch warning for mach_x86_c1e_disable

[Gilles Chanteperdrix]

On 08/28/2014 07:46 PM, Jan Kiszka wrote:
> On 2014-07-13 18:13, Gilles Chanteperdrix wrote:
>> Le 10/07/2014 16:23, git repository hosting a écrit :
>>> Module: xenomai-jki
>>> Branch: for-forge
>>> Commit: dcac4e7a3e7ccf19e4b38169e7c89eb88c821483
>>> URL:    http://git.xenomai.org/?p=xenomai-jki.git;a=commit;h=dcac4e7a3e7ccf19e4b38169e7c89eb88c821483
>>>
>>> Author: Jan Kiszka <jan.kiszka@siemens.com>
>>> Date:   Wed Jul  9 17:50:30 2014 +0200
>>>
>>> arch/x86: Fix section mismatch warning for mach_x86_c1e_disable
>>>
>>> mach_x86_c1e_disable is called from non-__init function mach_x86_init,
>>> thus can't be tagged as __init. mach_x86_init can't be converted as it
>>> is referenced by the persistent xnarch_machdesc structure.
>>
>> Well, it seems to me that mach_x86_init truly is an init function, is
>> not there any other way to fix this?
> 
> Ping (due to lack of alternatives).

It is fine by me.


-- 
                                                                Gilles.