All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] blk-mq: remove double set queue_num
@ 2017-06-22 15:06 weiping
  2017-06-22 15:19 ` Jens Axboe
  0 siblings, 1 reply; 4+ messages in thread
From: weiping @ 2017-06-22 15:06 UTC (permalink / raw)
  To: axboe; +Cc: linux-block

hwctx's queue_num has been set prior call blk_mq_init_hctx, so no need
set it again.

Signed-off-by: weiping <zhangweiping@didichuxing.com>
---
 block/blk-mq.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/block/blk-mq.c b/block/blk-mq.c
index bb66c96..adcb79c 100644
--- a/block/blk-mq.c
+++ b/block/blk-mq.c
@@ -1900,7 +1900,6 @@ static int blk_mq_init_hctx(struct request_queue *q,
 	spin_lock_init(&hctx->lock);
 	INIT_LIST_HEAD(&hctx->dispatch);
 	hctx->queue = q;
-	hctx->queue_num = hctx_idx;
 	hctx->flags = set->flags & ~BLK_MQ_F_TAG_SHARED;
 
 	cpuhp_state_add_instance_nocalls(CPUHP_BLK_MQ_DEAD, &hctx->cpuhp_dead);
-- 
1.8.3.1

^ permalink raw reply related	[flat|nested] 4+ messages in thread
* Re: [PATCH] blk-mq: remove double set queue_num
  2017-06-22 15:06 [PATCH] blk-mq: remove double set queue_num weiping
@ 2017-06-22 15:19 ` Jens Axboe
  0 siblings, 0 replies; 4+ messages in thread
From: Jens Axboe @ 2017-06-22 15:19 UTC (permalink / raw)
  To: weiping; +Cc: linux-block

On 06/22/2017 09:06 AM, weiping wrote:
> hwctx's queue_num has been set prior call blk_mq_init_hctx, so no need
> set it again.
> 
> Signed-off-by: weiping <zhangweiping@didichuxing.com>

I still prefer full names, but it's trivial enough, I've queued it up
for 4.13. Thanks.

-- 
Jens Axboe

^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [PATCH] blk-mq: remove double set queue_num
  2017-06-22  9:29 Erics Di
@ 2017-06-22 14:10 ` Jens Axboe
  0 siblings, 0 replies; 4+ messages in thread
From: Jens Axboe @ 2017-06-22 14:10 UTC (permalink / raw)
  To: Erics Di; +Cc: linux-block, Christoph Hellwig, Ming Lei

On 06/22/2017 03:29 AM, Erics Di wrote:
> hwctx's queue_num has been set prior call blk_mq_init_hctx, so no need
> 
> set it again.

You are right, that is a duplicate setting. But your patch is odd
in various ways:

1) Your signed-off-by and sender email (and name) have nothing to do
   with each other.

2) The patch is severely mangled. How are you sending it?

#2 I can manually fix up, but I can't fix up #1.

-- 
Jens Axboe

^ permalink raw reply	[flat|nested] 4+ messages in thread
* [PATCH] blk-mq: remove double set queue_num
@ 2017-06-22  9:29 Erics Di
  2017-06-22 14:10 ` Jens Axboe
  0 siblings, 1 reply; 4+ messages in thread
From: Erics Di @ 2017-06-22  9:29 UTC (permalink / raw)
  To: axboe; +Cc: linux-block, Christoph Hellwig, Ming Lei

hwctx's queue_num has been set prior call blk_mq_init_hctx, so no need

set it again.


Signed-off-by: weiping <zhangweiping@didichuxing.com>

---

 block/blk-mq.c | 1 -

 1 file changed, 1 deletion(-)


diff --git a/block/blk-mq.c b/block/blk-mq.c

index bb66c96..adcb79c 100644

--- a/block/blk-mq.c

+++ b/block/blk-mq.c

@@ -1900,7 +1900,6 @@ static int blk_mq_init_hctx(struct request_queue *q,

  spin_lock_init(&hctx->lock);

  INIT_LIST_HEAD(&hctx->dispatch);

  hctx->queue = q;

- hctx->queue_num = hctx_idx;

  hctx->flags = set->flags & ~BLK_MQ_F_TAG_SHARED;



  cpuhp_state_add_instance_nocalls(CPUHP_BLK_MQ_DEAD, &hctx->cpuhp_dead);

-- 

1.8.3.1

^ permalink raw reply	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-06-22 15:19 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-06-22 15:06 [PATCH] blk-mq: remove double set queue_num weiping
2017-06-22 15:19 ` Jens Axboe
  -- strict thread matches above, loose matches on Subject: below --
2017-06-22  9:29 Erics Di
2017-06-22 14:10 ` Jens Axboe

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.