[PATCH] config: add default MPIPE PMD config to common base

[PATCH] config: add default MPIPE PMD config to common base

[Ferruh Yigit]

Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
---
 config/common_base | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/config/common_base b/config/common_base
index 00a91b9..f44d4e4 100644
--- a/config/common_base
+++ b/config/common_base
@@ -219,6 +219,12 @@ CONFIG_RTE_LIBRTE_MLX5_DEBUG=n
 CONFIG_RTE_LIBRTE_MLX5_TX_MP_CACHE=8
 
 #
+# MPIPE PMD
+#
+CONFIG_RTE_LIBRTE_MPIPE_PMD=n
+CONFIG_RTE_LIBRTE_MPIPE_PMD_DEBUG=n
+
+#
 # Compile burst-oriented Broadcom PMD driver
 #
 CONFIG_RTE_LIBRTE_BNX2X_PMD=n
-- 
2.9.3

Re: [PATCH] config: add default MPIPE PMD config to common base

[Thomas Monjalon]

2017-01-30 10:40, Ferruh Yigit:
> --- a/config/common_base
> +++ b/config/common_base
> @@ -219,6 +219,12 @@ CONFIG_RTE_LIBRTE_MLX5_DEBUG=n
>  CONFIG_RTE_LIBRTE_MLX5_TX_MP_CACHE=8
>  
>  #
> +# MPIPE PMD
> +#
> +CONFIG_RTE_LIBRTE_MPIPE_PMD=n
> +CONFIG_RTE_LIBRTE_MPIPE_PMD_DEBUG=n

NACK

I think the whole tile arch must be removed from DPDK.
It is not maintained.

Re: [PATCH] config: add default MPIPE PMD config to common base

[Ferruh Yigit]

On 1/30/2017 10:46 AM, Thomas Monjalon wrote:
> 2017-01-30 10:40, Ferruh Yigit:
>> --- a/config/common_base
>> +++ b/config/common_base
>> @@ -219,6 +219,12 @@ CONFIG_RTE_LIBRTE_MLX5_DEBUG=n
>>  CONFIG_RTE_LIBRTE_MLX5_TX_MP_CACHE=8
>>  
>>  #
>> +# MPIPE PMD
>> +#
>> +CONFIG_RTE_LIBRTE_MPIPE_PMD=n
>> +CONFIG_RTE_LIBRTE_MPIPE_PMD_DEBUG=n
> 
> NACK
> 
> I think the whole tile arch must be removed from DPDK.
> It is not maintained.

I also have question about if newly added (and enabled by default) PMDs
should be disabled for this arch or not.

It would be nice to get an update from maintainers.

Thanks,
ferruh

Re: [PATCH] config: add default MPIPE PMD config to common base

[Thomas Monjalon]

2017-01-30 17:00, Ferruh Yigit:
> On 1/30/2017 10:46 AM, Thomas Monjalon wrote:
> > 2017-01-30 10:40, Ferruh Yigit:
> >> --- a/config/common_base
> >> +++ b/config/common_base
> >> @@ -219,6 +219,12 @@ CONFIG_RTE_LIBRTE_MLX5_DEBUG=n
> >>  CONFIG_RTE_LIBRTE_MLX5_TX_MP_CACHE=8
> >>  
> >>  #
> >> +# MPIPE PMD
> >> +#
> >> +CONFIG_RTE_LIBRTE_MPIPE_PMD=n
> >> +CONFIG_RTE_LIBRTE_MPIPE_PMD_DEBUG=n
> > 
> > NACK
> > 
> > I think the whole tile arch must be removed from DPDK.
> > It is not maintained.
> 
> I also have question about if newly added (and enabled by default) PMDs
> should be disabled for this arch or not.
> 
> It would be nice to get an update from maintainers.

No opinion?
We are going to remove the tile arch (and mpipe) from DPDK.