[thud][PATCH] lvm2: Fix RDEPEND on lvm2 to lvm2-udevrules

[thud][PATCH] lvm2: Fix RDEPEND on lvm2 to lvm2-udevrules

[Arturo Buzarra]

Commit c6e963f ("lvm2: Add RDEPEND on lvm2 to lvm2-udevrules") added
a package dependency due to lvm2-udevrules needs dmsetup, however
dmsetup was moved to libdevmapper in commit 269d009 ("lvm2:
libdevicemapper package needs udev rules and dmsetup"), so this
dependency should be only for libdevmapper instead of the full package.

With the current implementation, a package that has a dependency with
lvm2-udev rules will include also many unnecessary packages like lvm2,
lvm2-scripts, etc. and their dependencies.

Signed-off-by: Arturo Buzarra <arturo.buzarra@digi.com>
---
 meta-oe/recipes-support/lvm2/lvm2_2.02.180.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta-oe/recipes-support/lvm2/lvm2_2.02.180.bb b/meta-oe/recipes-support/lvm2/lvm2_2.02.180.bb
index 7bd7b09d8..08287e358 100644
--- a/meta-oe/recipes-support/lvm2/lvm2_2.02.180.bb
+++ b/meta-oe/recipes-support/lvm2/lvm2_2.02.180.bb
@@ -50,7 +50,7 @@ FILES_${PN}-scripts = " \
 # Specified explicitly for the udev rules, just in case that it does not get picked
 # up automatically:
 FILES_${PN}-udevrules = "${nonarch_base_libdir}/udev/rules.d"
-RDEPENDS_${PN}-udevrules = "${PN}"
+RDEPENDS_${PN}-udevrules = "libdevmapper"
 RDEPENDS_${PN}_append_class-target = " libdevmapper"
 RDEPENDS_${PN}_append_class-nativesdk = " libdevmapper"
 
-- 
2.24.0

Re: [thud][PATCH] lvm2: Fix RDEPEND on lvm2 to lvm2-udevrules

[Javier Viguera]

Hi Armin,

Could you queue this fix for Thud?

Same fix is already merged in master and Zeus.

-- 
Javier Viguera
Software Engineer

Digi International® Spain S.A.U.



On 27/11/2019 17:29, Arturo Buzarra wrote:
> Commit c6e963f ("lvm2: Add RDEPEND on lvm2 to lvm2-udevrules") added
> a package dependency due to lvm2-udevrules needs dmsetup, however
> dmsetup was moved to libdevmapper in commit 269d009 ("lvm2:
> libdevicemapper package needs udev rules and dmsetup"), so this
> dependency should be only for libdevmapper instead of the full package.
> 
> With the current implementation, a package that has a dependency with
> lvm2-udev rules will include also many unnecessary packages like lvm2,
> lvm2-scripts, etc. and their dependencies.
> 
> Signed-off-by: Arturo Buzarra <arturo.buzarra@digi.com>
> ---
>   meta-oe/recipes-support/lvm2/lvm2_2.02.180.bb | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/meta-oe/recipes-support/lvm2/lvm2_2.02.180.bb b/meta-oe/recipes-support/lvm2/lvm2_2.02.180.bb
> index 7bd7b09d8..08287e358 100644
> --- a/meta-oe/recipes-support/lvm2/lvm2_2.02.180.bb
> +++ b/meta-oe/recipes-support/lvm2/lvm2_2.02.180.bb
> @@ -50,7 +50,7 @@ FILES_${PN}-scripts = " \
>   # Specified explicitly for the udev rules, just in case that it does not get picked
>   # up automatically:
>   FILES_${PN}-udevrules = "${nonarch_base_libdir}/udev/rules.d"
> -RDEPENDS_${PN}-udevrules = "${PN}"
> +RDEPENDS_${PN}-udevrules = "libdevmapper"
>   RDEPENDS_${PN}_append_class-target = " libdevmapper"
>   RDEPENDS_${PN}_append_class-nativesdk = " libdevmapper"
>   
> 

Re: [thud][PATCH] lvm2: Fix RDEPEND on lvm2 to lvm2-udevrules

[Javier Viguera]

On 04/12/2019 10:37, Javier Viguera wrote:
> Hi Armin,
> 
> Could you queue this fix for Thud?
> 
> Same fix is already merged in master and Zeus.
> 

Ping.

The patch appears as new in patchwork:

https://patchwork.openembedded.org/patch/167467/

-- 
Javier Viguera
Software Engineer

Digi International® Spain S.A.U.