All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] usb: gadget: USB_RENESAS_USBHS_UDC should depend on HAS_DMA
@ 2014-08-29 19:31 Geert Uytterhoeven
  2014-09-03  6:02 ` Yoshihiro Shimoda
  0 siblings, 1 reply; 2+ messages in thread
From: Geert Uytterhoeven @ 2014-08-29 19:31 UTC (permalink / raw)
  To: Felipe Balbi, Kuninori Morimoto, Greg Kroah-Hartman
  Cc: linux-usb, linux-kernel, Geert Uytterhoeven

If NO_DMA=y:

drivers/built-in.o: In function `usbhsg_dma_map_ctrl':
mod_gadget.c:(.text+0x53b226): undefined reference to `usb_gadget_map_request'
mod_gadget.c:(.text+0x53b242): undefined reference to `usb_gadget_unmap_request'

Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
---
 drivers/usb/gadget/udc/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/usb/gadget/udc/Kconfig b/drivers/usb/gadget/udc/Kconfig
index 5151f947a4f5..00171d436cf8 100644
--- a/drivers/usb/gadget/udc/Kconfig
+++ b/drivers/usb/gadget/udc/Kconfig
@@ -163,7 +163,7 @@ config USB_R8A66597
 
 config USB_RENESAS_USBHS_UDC
 	tristate 'Renesas USBHS controller'
-	depends on USB_RENESAS_USBHS
+	depends on USB_RENESAS_USBHS && HAS_DMA
 	help
 	   Renesas USBHS is a discrete USB host and peripheral controller chip
 	   that supports both full and high speed USB 2.0 data transfers.
-- 
1.9.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] usb: gadget: USB_RENESAS_USBHS_UDC should depend on HAS_DMA
  2014-08-29 19:31 [PATCH] usb: gadget: USB_RENESAS_USBHS_UDC should depend on HAS_DMA Geert Uytterhoeven
@ 2014-09-03  6:02 ` Yoshihiro Shimoda
  0 siblings, 0 replies; 2+ messages in thread
From: Yoshihiro Shimoda @ 2014-09-03  6:02 UTC (permalink / raw)
  To: Geert Uytterhoeven, Felipe Balbi, kuninori morimoto, Greg Kroah-Hartman
  Cc: linux-usb, linux-kernel

Hi Geert,

(2014/08/30 4:31), Geert Uytterhoeven wrote:
> If NO_DMA=y:
> 
> drivers/built-in.o: In function `usbhsg_dma_map_ctrl':
> mod_gadget.c:(.text+0x53b226): undefined reference to `usb_gadget_map_request'
> mod_gadget.c:(.text+0x53b242): undefined reference to `usb_gadget_unmap_request'
> 
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
> ---
>  drivers/usb/gadget/udc/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/gadget/udc/Kconfig b/drivers/usb/gadget/udc/Kconfig
> index 5151f947a4f5..00171d436cf8 100644
> --- a/drivers/usb/gadget/udc/Kconfig
> +++ b/drivers/usb/gadget/udc/Kconfig
> @@ -163,7 +163,7 @@ config USB_R8A66597
>  
>  config USB_RENESAS_USBHS_UDC
>  	tristate 'Renesas USBHS controller'
> -	depends on USB_RENESAS_USBHS
> +	depends on USB_RENESAS_USBHS && HAS_DMA
>  	help
>  	   Renesas USBHS is a discrete USB host and peripheral controller chip
>  	   that supports both full and high speed USB 2.0 data transfers.
> 

Acked-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>

Best regards,
Yoshihiro Shimoda


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2014-09-03  6:02 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-08-29 19:31 [PATCH] usb: gadget: USB_RENESAS_USBHS_UDC should depend on HAS_DMA Geert Uytterhoeven
2014-09-03  6:02 ` Yoshihiro Shimoda

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.