All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Jan Beulich" <JBeulich@suse.com>
To: Dario Faggioli <dario.faggioli@citrix.com>,
	Elena Ufimtseva <ufimtseva@gmail.com>
Cc: keir@xen.org, Ian.Campbell@citrix.com,
	george.dunlap@eu.citrix.com, ian.jackson@eu.citrix.com,
	xen-devel@lists.xen.org
Subject: Re: [PATCH] numa.c: use spaces instead of tabs
Date: Wed, 03 Sep 2014 11:01:52 +0100	[thread overview]
Message-ID: <54070330020000780003029A@mail.emea.novell.com> (raw)
In-Reply-To: <1409737969.2673.35.camel@Solace.lan>

>>> On 03.09.14 at 11:52, <dario.faggioli@citrix.com> wrote:
> On mer, 2014-09-03 at 00:18 -0400, Elena Ufimtseva wrote:
>> Signed-off-by: Elena Ufimtseva <ufimtseva@gmail.com>
>> ---
>>
> I think the patch does what the subject says, i.e., converting tabs to
> spaces, and does it right (I've only one question, see below).
> 
> However, does it make sense, while at it, to turn the file into a Xen's
> code stile compliant one? Because, if yes, there are other things than
> tabs-->spaces that needs fixing, I believe.

Yes, indeed - we don't use a style like what results from this patch.

>> @@ -121,83 +121,83 @@ static int __init 
> allocate_cachealigned_memnodemap(void)
>>   * maximum possible shift.
>>   */
>>  static int __init extract_lsb_from_nodes(const struct node *nodes,
>> -					 int numnodes)
>> +                     int numnodes)
>>
> Perhaps I am the one missing something here, but shouldn't this still be
> aligned to the '(' above (through spaces, of course)?

Indeed it should.

Jan

  reply	other threads:[~2014-09-03 10:01 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-03  4:18 [PATCH] numa.c: use spaces instead of tabs Elena Ufimtseva
2014-09-03  9:52 ` Dario Faggioli
2014-09-03 10:01   ` Jan Beulich [this message]
2014-09-03 11:59     ` Elena Ufimtseva
2014-09-03 12:18       ` Ian Campbell
2014-09-03 12:29         ` Elena Ufimtseva
2014-09-03 12:29       ` Jan Beulich
2014-09-03 12:34         ` Elena Ufimtseva
2014-09-03 12:40           ` Jan Beulich
2014-09-06 17:28             ` Don Slutz
2014-09-08  6:53               ` Jan Beulich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54070330020000780003029A@mail.emea.novell.com \
    --to=jbeulich@suse.com \
    --cc=Ian.Campbell@citrix.com \
    --cc=dario.faggioli@citrix.com \
    --cc=george.dunlap@eu.citrix.com \
    --cc=ian.jackson@eu.citrix.com \
    --cc=keir@xen.org \
    --cc=ufimtseva@gmail.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.