All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Jan Beulich" <JBeulich@suse.com>
To: Don Slutz <dslutz@verizon.com>
Cc: Keir Fraser <keir@xen.org>,
	Ian Campbell <Ian.Campbell@citrix.com>,
	George Dunlap <george.dunlap@eu.citrix.com>,
	Dario Faggioli <dario.faggioli@citrix.com>,
	Ian Jackson <ian.jackson@eu.citrix.com>,
	"xen-devel@lists.xen.org" <xen-devel@lists.xen.org>,
	Elena Ufimtseva <ufimtseva@gmail.com>
Subject: Re: [PATCH] numa.c: use spaces instead of tabs
Date: Mon, 08 Sep 2014 07:53:22 +0100	[thread overview]
Message-ID: <540D6E820200007800031D17@mail.emea.novell.com> (raw)
In-Reply-To: <540B4449.1000606@terremark.com>

>>> On 06.09.14 at 19:28, <dslutz@verizon.com> wrote:
> Using this on xen/arch/x86/numa.c (and asking git to ignore white space
> changes) gives me:
> 
> dcs-xen-54:~/xen>git diff -w
> diff --git a/xen/arch/x86/numa.c b/xen/arch/x86/numa.c
> index 628a40a..35ce32c 100644
> --- a/xen/arch/x86/numa.c
> +++ b/xen/arch/x86/numa.c
> @@ -35,13 +35,15 @@ static typeof(*memnodemap) _memnodemap[64];
>   unsigned long memnodemapsize;
>   u8 *memnodemap;
> 
> -unsigned char cpu_to_node[NR_CPUS] __read_mostly = {
> +unsigned char cpu_to_node[NR_CPUS] __read_mostly =
> +{
>       [0 ... NR_CPUS - 1] = NUMA_NO_NODE
>   };
>   /*
>    * Keep BIOS's CPU2node information, should not be used for memory allocaion
>    */
> -unsigned char apicid_to_node[MAX_LOCAL_APIC] __cpuinitdata = {
> +unsigned char apicid_to_node[MAX_LOCAL_APIC] __cpuinitdata =
> +{
>       [0 ... MAX_LOCAL_APIC - 1] = NUMA_NO_NODE
>   };
>   cpumask_t node_to_cpumask[MAX_NUMNODES] __read_mostly;
> @@ -413,7 +415,8 @@ static void dump_numa(unsigned char key)
>       rcu_read_unlock(&domlist_read_lock);
>   }
> 
> -static struct keyhandler dump_numa_keyhandler = {
> +static struct keyhandler dump_numa_keyhandler =
> +{
>       .diagnostic = 1,
>       .u.fn = dump_numa,
>       .desc = "dump numa info"

Except that I think on initializers we don't strictly require the { to
be on a separate line, albeit I admit that one can conclude either
way from ./CODING_STYLE.

Jan

      reply	other threads:[~2014-09-08  6:53 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-03  4:18 [PATCH] numa.c: use spaces instead of tabs Elena Ufimtseva
2014-09-03  9:52 ` Dario Faggioli
2014-09-03 10:01   ` Jan Beulich
2014-09-03 11:59     ` Elena Ufimtseva
2014-09-03 12:18       ` Ian Campbell
2014-09-03 12:29         ` Elena Ufimtseva
2014-09-03 12:29       ` Jan Beulich
2014-09-03 12:34         ` Elena Ufimtseva
2014-09-03 12:40           ` Jan Beulich
2014-09-06 17:28             ` Don Slutz
2014-09-08  6:53               ` Jan Beulich [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=540D6E820200007800031D17@mail.emea.novell.com \
    --to=jbeulich@suse.com \
    --cc=Ian.Campbell@citrix.com \
    --cc=dario.faggioli@citrix.com \
    --cc=dslutz@verizon.com \
    --cc=george.dunlap@eu.citrix.com \
    --cc=ian.jackson@eu.citrix.com \
    --cc=keir@xen.org \
    --cc=ufimtseva@gmail.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.