From: Christian Zigotzky <chzigotzky@xenosoft.de>
To: linuxppc-dev <linuxppc-dev@lists.ozlabs.org>,
npiggin@gmail.com,
"kvm-ppc@vger.kernel.org" <kvm-ppc@vger.kernel.org>
Cc: Darren Stevens <darren@stevens-zone.net>,
"R.T.Dickinson" <rtd2@xtra.co.nz>,
Christian Zigotzky <info@xenosoft.de>
Subject: Re: PowerPC KVM-PR issue
Date: Thu, 11 Jun 2020 16:47:26 +0200 [thread overview]
Message-ID: <54082b17-31bb-f529-2e9e-b84c5a5aa9ec@xenosoft.de> (raw)
In-Reply-To: <7e859f68-9455-f98f-1fa3-071619fa1731@xenosoft.de>
On 10 June 2020 at 01:23 pm, Christian Zigotzky wrote:
> On 10 June 2020 at 11:06 am, Christian Zigotzky wrote:
>> On 10 June 2020 at 00:18 am, Christian Zigotzky wrote:
>>> Hello,
>>>
>>> KVM-PR doesn't work anymore on my Nemo board [1]. I figured out that
>>> the Git kernels and the kernel 5.7 are affected.
>>>
>>> Error message: Fienix kernel: kvmppc_exit_pr_progint: emulation at
>>> 700 failed (00000000)
>>>
>>> I can boot virtual QEMU PowerPC machines with KVM-PR with the kernel
>>> 5.6 without any problems on my Nemo board.
>>>
>>> I tested it with QEMU 2.5.0 and QEMU 5.0.0 today.
>>>
>>> Could you please check KVM-PR on your PowerPC machine?
>>>
>>> Thanks,
>>> Christian
>>>
>>> [1] https://en.wikipedia.org/wiki/AmigaOne_X1000
>>
>> I figured out that the PowerPC updates 5.7-1 [1] are responsible for
>> the KVM-PR issue. Please test KVM-PR on your PowerPC machines and
>> check the PowerPC updates 5.7-1 [1].
>>
>> Thanks
>>
>> [1]
>> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=d38c07afc356ddebaa3ed8ecb3f553340e05c969
>>
>>
> I tested the latest Git kernel with Mac-on-Linux/KVM-PR today.
> Unfortunately I can't use KVM-PR with MoL anymore because of this
> issue (see screenshots [1]). Please check the PowerPC updates 5.7-1.
>
> Thanks
>
> [1]
> -
> https://i.pinimg.com/originals/0c/b3/64/0cb364a40241fa2b7f297d4272bbb8b7.png
> -
> https://i.pinimg.com/originals/9a/61/d1/9a61d170b1c9f514f7a78a3014ffd18f.png
>
Hi All,
I bisected today because of the KVM-PR issue.
Result:
9600f261acaaabd476d7833cec2dd20f2919f1a0 is the first bad commit
commit 9600f261acaaabd476d7833cec2dd20f2919f1a0
Author: Nicholas Piggin <npiggin@gmail.com>
Date: Wed Feb 26 03:35:21 2020 +1000
powerpc/64s/exception: Move KVM test to common code
This allows more code to be moved out of unrelocated regions. The
system call KVMTEST is changed to be open-coded and remain in the
tramp area to avoid having to move it to entry_64.S. The custom nature
of the system call entry code means the hcall case can be made more
streamlined than regular interrupt handlers.
mpe: Incorporate fix from Nick:
Moving KVM test to the common entry code missed the case of HMI and
MCE, which do not do __GEN_COMMON_ENTRY (because they don't want to
switch to virt mode).
This means a MCE or HMI exception that is taken while KVM is running a
guest context will not be switched out of that context, and KVM won't
be notified. Found by running sigfuz in guest with patched host on
POWER9 DD2.3, which causes some TM related HMI interrupts (which are
expected and supposed to be handled by KVM).
This fix adds a __GEN_REALMODE_COMMON_ENTRY for those handlers to add
the KVM test. This makes them look a little more like other handlers
that all use __GEN_COMMON_ENTRY.
Signed-off-by: Nicholas Piggin <npiggin@gmail.com>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Link:
https://lore.kernel.org/r/20200225173541.1549955-13-npiggin@gmail.com
:040000 040000 ec21cec22d165f8696d69532734cb2985d532cb0
87dd49a9cd7202ec79350e8ca26cea01f1dbd93d M arch
-----
The following commit is the problem: powerpc/64s/exception: Move KVM
test to common code [1]
These changes were included in the PowerPC updates 5.7-1. [2]
Another test:
git checkout d38c07afc356ddebaa3ed8ecb3f553340e05c969 (PowerPC updates
5.7-1 [2] ) -> KVM-PR doesn't work.
After that: git revert d38c07afc356ddebaa3ed8ecb3f553340e05c969 -m 1 ->
KVM-PR works.
Could you please check the first bad commit? [1]
Thanks,
Christian
[1]
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=9600f261acaaabd476d7833cec2dd20f2919f1a0
[2]
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=d38c07afc356ddebaa3ed8ecb3f553340e05c969
WARNING: multiple messages have this Message-ID (diff)
From: Christian Zigotzky <chzigotzky@xenosoft.de>
To: linuxppc-dev <linuxppc-dev@lists.ozlabs.org>,
npiggin@gmail.com,
"kvm-ppc@vger.kernel.org" <kvm-ppc@vger.kernel.org>
Cc: Darren Stevens <darren@stevens-zone.net>,
"R.T.Dickinson" <rtd2@xtra.co.nz>,
Christian Zigotzky <info@xenosoft.de>
Subject: Re: PowerPC KVM-PR issue
Date: Thu, 11 Jun 2020 14:47:26 +0000 [thread overview]
Message-ID: <54082b17-31bb-f529-2e9e-b84c5a5aa9ec@xenosoft.de> (raw)
In-Reply-To: <7e859f68-9455-f98f-1fa3-071619fa1731@xenosoft.de>
On 10 June 2020 at 01:23 pm, Christian Zigotzky wrote:
> On 10 June 2020 at 11:06 am, Christian Zigotzky wrote:
>> On 10 June 2020 at 00:18 am, Christian Zigotzky wrote:
>>> Hello,
>>>
>>> KVM-PR doesn't work anymore on my Nemo board [1]. I figured out that
>>> the Git kernels and the kernel 5.7 are affected.
>>>
>>> Error message: Fienix kernel: kvmppc_exit_pr_progint: emulation at
>>> 700 failed (00000000)
>>>
>>> I can boot virtual QEMU PowerPC machines with KVM-PR with the kernel
>>> 5.6 without any problems on my Nemo board.
>>>
>>> I tested it with QEMU 2.5.0 and QEMU 5.0.0 today.
>>>
>>> Could you please check KVM-PR on your PowerPC machine?
>>>
>>> Thanks,
>>> Christian
>>>
>>> [1] https://en.wikipedia.org/wiki/AmigaOne_X1000
>>
>> I figured out that the PowerPC updates 5.7-1 [1] are responsible for
>> the KVM-PR issue. Please test KVM-PR on your PowerPC machines and
>> check the PowerPC updates 5.7-1 [1].
>>
>> Thanks
>>
>> [1]
>> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?idÓ8c07afc356ddebaa3ed8ecb3f553340e05c969
>>
>>
> I tested the latest Git kernel with Mac-on-Linux/KVM-PR today.
> Unfortunately I can't use KVM-PR with MoL anymore because of this
> issue (see screenshots [1]). Please check the PowerPC updates 5.7-1.
>
> Thanks
>
> [1]
> -
> https://i.pinimg.com/originals/0c/b3/64/0cb364a40241fa2b7f297d4272bbb8b7.png
> -
> https://i.pinimg.com/originals/9a/61/d1/9a61d170b1c9f514f7a78a3014ffd18f.png
>
Hi All,
I bisected today because of the KVM-PR issue.
Result:
9600f261acaaabd476d7833cec2dd20f2919f1a0 is the first bad commit
commit 9600f261acaaabd476d7833cec2dd20f2919f1a0
Author: Nicholas Piggin <npiggin@gmail.com>
Date:Â Â Wed Feb 26 03:35:21 2020 +1000
   powerpc/64s/exception: Move KVM test to common code
   This allows more code to be moved out of unrelocated regions. The
   system call KVMTEST is changed to be open-coded and remain in the
   tramp area to avoid having to move it to entry_64.S. The custom nature
   of the system call entry code means the hcall case can be made more
   streamlined than regular interrupt handlers.
   mpe: Incorporate fix from Nick:
   Moving KVM test to the common entry code missed the case of HMI and
   MCE, which do not do __GEN_COMMON_ENTRY (because they don't want to
   switch to virt mode).
   This means a MCE or HMI exception that is taken while KVM is running a
   guest context will not be switched out of that context, and KVM won't
   be notified. Found by running sigfuz in guest with patched host on
   POWER9 DD2.3, which causes some TM related HMI interrupts (which are
   expected and supposed to be handled by KVM).
   This fix adds a __GEN_REALMODE_COMMON_ENTRY for those handlers to add
   the KVM test. This makes them look a little more like other handlers
   that all use __GEN_COMMON_ENTRY.
   Signed-off-by: Nicholas Piggin <npiggin@gmail.com>
   Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
   Link:
https://lore.kernel.org/r/20200225173541.1549955-13-npiggin@gmail.com
:040000 040000 ec21cec22d165f8696d69532734cb2985d532cb0
87dd49a9cd7202ec79350e8ca26cea01f1dbd93d MÂ Â Â arch
-----
The following commit is the problem: powerpc/64s/exception: Move KVM
test to common code [1]
These changes were included in the PowerPC updates 5.7-1. [2]
Another test:
git checkout d38c07afc356ddebaa3ed8ecb3f553340e05c969 (PowerPC updates
5.7-1 [2] ) -> KVM-PR doesn't work.
After that: git revert d38c07afc356ddebaa3ed8ecb3f553340e05c969 -m 1 ->
KVM-PR works.
Could you please check the first bad commit? [1]
Thanks,
Christian
[1]
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id–00f261acaaabd476d7833cec2dd20f2919f1a0
[2]
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?idÓ8c07afc356ddebaa3ed8ecb3f553340e05c969
next prev parent reply other threads:[~2020-06-11 14:51 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-04 14:16 Boot issue with the latest Git kernel Christian Zigotzky
2020-06-04 14:26 ` Christophe Leroy
2020-06-04 14:29 ` Christophe Leroy
2020-06-04 15:46 ` Christian Zigotzky
2020-06-04 15:53 ` Christian Zigotzky
2020-06-04 17:15 ` Christophe Leroy
2020-06-05 16:23 ` Christian Zigotzky
2020-06-07 13:27 ` Christian Zigotzky
2020-06-07 14:07 ` Aneesh Kumar K.V
2020-06-09 22:18 ` PowerPC KVM-PR issue Christian Zigotzky
2020-06-10 9:06 ` Christian Zigotzky
2020-06-10 11:23 ` Christian Zigotzky
2020-06-10 11:23 ` Christian Zigotzky
2020-06-11 14:47 ` Christian Zigotzky [this message]
2020-06-11 14:47 ` Christian Zigotzky
2020-06-12 13:01 ` Christian Zigotzky
2020-06-12 13:01 ` Christian Zigotzky
2020-06-14 8:50 ` Nicholas Piggin
2020-06-14 8:50 ` Nicholas Piggin
2020-06-14 12:53 ` Nicholas Piggin
2020-06-14 12:53 ` Nicholas Piggin
2020-06-14 14:52 ` Christian Zigotzky
2020-06-14 14:52 ` Christian Zigotzky
2020-06-14 23:39 ` Christian Zigotzky
2020-06-14 23:39 ` Christian Zigotzky
2020-06-15 7:34 ` Christian Zigotzky
2020-06-15 7:34 ` Christian Zigotzky
2020-06-25 9:38 ` Christian Zigotzky
2020-06-25 9:38 ` Christian Zigotzky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54082b17-31bb-f529-2e9e-b84c5a5aa9ec@xenosoft.de \
--to=chzigotzky@xenosoft.de \
--cc=darren@stevens-zone.net \
--cc=info@xenosoft.de \
--cc=kvm-ppc@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=npiggin@gmail.com \
--cc=rtd2@xtra.co.nz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.