All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tomasz Figa <tomasz.figa@gmail.com>
To: Javier Martinez Canillas <javier.martinez@collabora.co.uk>,
	Will Deacon <will.deacon@arm.com>
Cc: Doug Anderson <dianders@chromium.org>,
	"kgene.kim@samsung.com" <kgene.kim@samsung.com>,
	"olof@lixom.net" <olof@lixom.net>,
	"rahul.sharma@samsung.com" <rahul.sharma@samsung.com>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	"linux-samsung-soc@vger.kernel.org"
	<linux-samsung-soc@vger.kernel.org>,
	Mark Brown <broonie@kernel.org>
Subject: Re: Unable to boot mainline on snow chromebook since 3.15
Date: Sun, 07 Sep 2014 17:52:59 +0200	[thread overview]
Message-ID: <540C7F5B.6070307@gmail.com> (raw)
In-Reply-To: <540C202E.2060009@collabora.co.uk>

>>> Have you seen the very long "[PATCH 4/4] simplefb: add clock handling
>>> code" thread [0]?. I wonder if the problem is that the display clocks were
>>> not known to the kernel before 3.15 but now are getting disabled and thus
>>> the simplefb driver not working?
>>>
>>> So probably is worth to try passing clk_ignore_unused as a parameter to
>>> the kernel command line.
>>>
>>> [0]: https://www.mail-archive.com/linux-sunxi@googlegroups.com/msg06623.html
>>
> 
> So my assumptions was correct and the issue is that the kernel disables the
> resources (clocks and regulators) needed to have display working and because
> the simplefb expects the display hardware to have been already initialized by
> the bootloader/firmware, it simply fails.
> 
> You didn't face this issue before 3.15 because the default bootargs set by
> nv_uboot-snow already includes the "clk_ignore_unused" parameter and the
> kernel didn't know about the regulators but the later changed with commit:
> 
> b16be76 ("ARM: dts: add tps65090 power regulator for exynos5250-snow")
> 
> This was included in 3.16, so the mentioned commit is what "broke" your
> workflow since now the kernel is aware of the tps65090 fet1 and fet6
> regulators (used as supply for the the backlight and panel respectively) and
> disables them because nothing uses them from a kernel POV.

So I believe we've got a process issue here. If you don't have normal
support for display hardware, but you want to keep the display
operational thanks to bootloader already initializing it, you should not
add anything to the kernel which breaks it, until full support comes in.

This means that respective regulators should be either always-on or not
listed at all (I'd favor the former) and respective clocks either
somehow enabled at boot-up or completely ignored, including all their
parents capable of being gated.

Now with regulators this is pretty straightforward, but with clocks I
believe it's an open issue. AFAIR we've discussed this on MLs some time
ago (at least I remember Doug commenting on that topic) and kind of
concluded that SoC clock drivers could include lists of clocks to be
enabled at boot-up (as a HACK to enable things like simplefb until
proper support for respective features are added).

I believe this would be the proper solution for $subject.

Best regards,
Tomasz

WARNING: multiple messages have this Message-ID (diff)
From: tomasz.figa@gmail.com (Tomasz Figa)
To: linux-arm-kernel@lists.infradead.org
Subject: Unable to boot mainline on snow chromebook since 3.15
Date: Sun, 07 Sep 2014 17:52:59 +0200	[thread overview]
Message-ID: <540C7F5B.6070307@gmail.com> (raw)
In-Reply-To: <540C202E.2060009@collabora.co.uk>

>>> Have you seen the very long "[PATCH 4/4] simplefb: add clock handling
>>> code" thread [0]?. I wonder if the problem is that the display clocks were
>>> not known to the kernel before 3.15 but now are getting disabled and thus
>>> the simplefb driver not working?
>>>
>>> So probably is worth to try passing clk_ignore_unused as a parameter to
>>> the kernel command line.
>>>
>>> [0]: https://www.mail-archive.com/linux-sunxi at googlegroups.com/msg06623.html
>>
> 
> So my assumptions was correct and the issue is that the kernel disables the
> resources (clocks and regulators) needed to have display working and because
> the simplefb expects the display hardware to have been already initialized by
> the bootloader/firmware, it simply fails.
> 
> You didn't face this issue before 3.15 because the default bootargs set by
> nv_uboot-snow already includes the "clk_ignore_unused" parameter and the
> kernel didn't know about the regulators but the later changed with commit:
> 
> b16be76 ("ARM: dts: add tps65090 power regulator for exynos5250-snow")
> 
> This was included in 3.16, so the mentioned commit is what "broke" your
> workflow since now the kernel is aware of the tps65090 fet1 and fet6
> regulators (used as supply for the the backlight and panel respectively) and
> disables them because nothing uses them from a kernel POV.

So I believe we've got a process issue here. If you don't have normal
support for display hardware, but you want to keep the display
operational thanks to bootloader already initializing it, you should not
add anything to the kernel which breaks it, until full support comes in.

This means that respective regulators should be either always-on or not
listed at all (I'd favor the former) and respective clocks either
somehow enabled at boot-up or completely ignored, including all their
parents capable of being gated.

Now with regulators this is pretty straightforward, but with clocks I
believe it's an open issue. AFAIR we've discussed this on MLs some time
ago (at least I remember Doug commenting on that topic) and kind of
concluded that SoC clock drivers could include lists of clocks to be
enabled at boot-up (as a HACK to enable things like simplefb until
proper support for respective features are added).

I believe this would be the proper solution for $subject.

Best regards,
Tomasz

  parent reply	other threads:[~2014-09-07 15:53 UTC|newest]

Thread overview: 106+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-05 11:57 Unable to boot mainline on snow chromebook since 3.15 Will Deacon
2014-09-05 12:22 ` Will Deacon
2014-09-05 12:22   ` Will Deacon
2014-09-05 13:46   ` Ajay kumar
2014-09-05 13:46     ` Ajay kumar
2014-09-05 13:56     ` Vivek Gautam
2014-09-05 13:56       ` Vivek Gautam
2014-09-08 11:17       ` Will Deacon
2014-09-08 11:17         ` Will Deacon
2014-09-05 14:12     ` Marc Zyngier
2014-09-05 14:12       ` Marc Zyngier
2014-09-05 20:25   ` Doug Anderson
2014-09-05 20:25     ` Doug Anderson
2014-09-07  9:06     ` Javier Martinez Canillas
2014-09-07  9:06       ` Javier Martinez Canillas
2014-09-07 15:01       ` Mark Brown
2014-09-07 15:01         ` Mark Brown
2014-09-07 15:51         ` Javier Martinez Canillas
2014-09-07 15:51           ` Javier Martinez Canillas
2014-09-07 15:52       ` Tomasz Figa [this message]
2014-09-07 15:52         ` Tomasz Figa
2014-09-07 16:12         ` Javier Martinez Canillas
2014-09-07 16:12           ` Javier Martinez Canillas
2014-09-07 16:19           ` Tomasz Figa
2014-09-07 16:19             ` Tomasz Figa
2014-09-07 16:40             ` Javier Martinez Canillas
2014-09-07 16:40               ` Javier Martinez Canillas
2014-09-08 11:21             ` Will Deacon
2014-09-08 11:21               ` Will Deacon
2014-09-08 11:55               ` Javier Martinez Canillas
2014-09-08 11:55                 ` Javier Martinez Canillas
2014-09-08 12:46                 ` Will Deacon
2014-09-08 12:46                   ` Will Deacon
2014-09-08 12:20               ` Grant Likely
2014-09-08 12:20                 ` Grant Likely
2014-09-08 13:49                 ` Mark Brown
2014-09-08 13:49                   ` Mark Brown
2014-09-08 14:05                   ` Javier Martinez Canillas
2014-09-08 14:05                     ` Javier Martinez Canillas
2014-09-10 11:17                     ` Will Deacon
2014-09-10 11:17                       ` Will Deacon
2014-09-10 16:03                       ` Doug Anderson
2014-09-10 16:03                         ` Doug Anderson
2014-09-10 16:23                         ` Will Deacon
2014-09-10 16:23                           ` Will Deacon
2014-09-08 15:58                 ` Doug Anderson
2014-09-08 15:58                   ` Doug Anderson
2014-09-08 19:40                   ` Grant Likely
2014-09-08 19:40                     ` Grant Likely
2014-09-10 13:06                     ` Olof Johansson
2014-09-10 13:06                       ` Olof Johansson
2014-09-10 14:31                       ` Mark Brown
2014-09-10 14:31                         ` Mark Brown
2014-09-10 14:56                         ` Grant Likely
2014-09-10 14:56                           ` Grant Likely
2014-09-10 15:39                           ` Mark Brown
2014-09-10 15:39                             ` Mark Brown
2014-09-10 16:29                             ` Grant Likely
2014-09-10 16:29                               ` Grant Likely
2014-09-10 16:45                               ` Doug Anderson
2014-09-10 16:45                                 ` Doug Anderson
2014-09-10 19:45                                 ` Mark Brown
2014-09-10 19:45                                   ` Mark Brown
2014-09-10 19:51                                   ` Doug Anderson
2014-09-10 19:51                                     ` Doug Anderson
2014-09-10 16:57                               ` Mark Brown
2014-09-10 16:57                                 ` Mark Brown
2014-09-11  9:22                                 ` Grant Likely
2014-09-11  9:22                                   ` Grant Likely
2014-09-11 18:03                                   ` Mark Brown
2014-09-11 18:03                                     ` Mark Brown
2014-09-11 22:54                                     ` Doug Anderson
2014-09-11 22:54                                       ` Doug Anderson
2014-09-29 12:57                           ` Thierry Reding
2014-09-29 12:57                             ` Thierry Reding
2014-09-29 13:12                             ` Grant Likely
2014-09-29 13:12                               ` Grant Likely
2014-09-29 16:37                               ` Mark Brown
2014-09-29 16:37                                 ` Mark Brown
2014-09-30  6:12                               ` Thierry Reding
2014-09-30  6:12                                 ` Thierry Reding
2014-09-29 20:46                             ` Maxime Ripard
2014-09-29 20:46                               ` Maxime Ripard
2014-09-10 16:36                         ` Olof Johansson
2014-09-10 16:36                           ` Olof Johansson
2014-09-10 18:17                           ` Mark Brown
2014-09-10 18:17                             ` Mark Brown
2014-09-11  9:06                         ` Grant Likely
2014-09-11  9:06                           ` Grant Likely
2014-09-11 16:16                           ` Mark Brown
2014-09-11 16:16                             ` Mark Brown
2014-09-08  4:36         ` Doug Anderson
2014-09-08  4:36           ` Doug Anderson
2014-09-08  6:09           ` Javier Martinez Canillas
2014-09-08  6:09             ` Javier Martinez Canillas
2014-09-08 15:55             ` Doug Anderson
2014-09-08 15:55               ` Doug Anderson
2014-09-08 16:07               ` Will Deacon
2014-09-08 16:07                 ` Will Deacon
2014-09-08 16:12                 ` Doug Anderson
2014-09-08 16:12                   ` Doug Anderson
2014-09-08 10:20           ` Mark Brown
2014-09-08 10:20             ` Mark Brown
2014-09-08  4:43         ` Doug Anderson
2014-09-08  4:43           ` Doug Anderson
2015-01-30  4:56 bruce m beach

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=540C7F5B.6070307@gmail.com \
    --to=tomasz.figa@gmail.com \
    --cc=broonie@kernel.org \
    --cc=dianders@chromium.org \
    --cc=javier.martinez@collabora.co.uk \
    --cc=kgene.kim@samsung.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=olof@lixom.net \
    --cc=rahul.sharma@samsung.com \
    --cc=will.deacon@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.