All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] Support spaces in mount_nfs (#1109933)
@ 2014-08-21 18:31 Brian C. Lane
       [not found] ` <1408645911-3268-1-git-send-email-bcl-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
  0 siblings, 1 reply; 2+ messages in thread
From: Brian C. Lane @ 2014-08-21 18:31 UTC (permalink / raw)
  To: initramfs-u79uwXL29TY76Z2rM5mHXA

nfs paths may contain spaces, make sure they are preserved when passed
to nfs_to_var and mount.

Related: rhbz#1109933
---
 modules.d/95nfs/nfs-lib.sh | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/modules.d/95nfs/nfs-lib.sh b/modules.d/95nfs/nfs-lib.sh
index d5377fe..94d05b8 100755
--- a/modules.d/95nfs/nfs-lib.sh
+++ b/modules.d/95nfs/nfs-lib.sh
@@ -125,7 +125,7 @@ munge_nfs_options() {
 mount_nfs() {
     local nfsroot="$1" mntdir="$2" netif="$3"
     local nfs="" server="" path="" options=""
-    nfs_to_var $nfsroot $netif
+    nfs_to_var "$nfsroot" $netif
     munge_nfs_options
     if [ "$nfs" = "nfs4" ]; then
         options=$options${nfslock:+,$nfslock}
@@ -136,5 +136,5 @@ mount_nfs() {
             && warn "Locks unsupported on NFSv{2,3}, using nolock" 1>&2
         options=$options,nolock
     fi
-    mount -t $nfs -o$options $server:$path $mntdir
+    mount -t $nfs -o$options "$server:$path" "$mntdir"
 }
-- 
1.9.3

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] Support spaces in mount_nfs (#1109933)
       [not found] ` <1408645911-3268-1-git-send-email-bcl-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
@ 2014-09-10  9:08   ` Harald Hoyer
  0 siblings, 0 replies; 2+ messages in thread
From: Harald Hoyer @ 2014-09-10  9:08 UTC (permalink / raw)
  To: Brian C. Lane, initramfs-u79uwXL29TY76Z2rM5mHXA

On 21.08.2014 20:31, Brian C. Lane wrote:
> nfs paths may contain spaces, make sure they are preserved when passed
> to nfs_to_var and mount.
> 
> Related: rhbz#1109933
> ---
>  modules.d/95nfs/nfs-lib.sh | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/modules.d/95nfs/nfs-lib.sh b/modules.d/95nfs/nfs-lib.sh
> index d5377fe..94d05b8 100755
> --- a/modules.d/95nfs/nfs-lib.sh
> +++ b/modules.d/95nfs/nfs-lib.sh
> @@ -125,7 +125,7 @@ munge_nfs_options() {
>  mount_nfs() {
>      local nfsroot="$1" mntdir="$2" netif="$3"
>      local nfs="" server="" path="" options=""
> -    nfs_to_var $nfsroot $netif
> +    nfs_to_var "$nfsroot" $netif
>      munge_nfs_options
>      if [ "$nfs" = "nfs4" ]; then
>          options=$options${nfslock:+,$nfslock}
> @@ -136,5 +136,5 @@ mount_nfs() {
>              && warn "Locks unsupported on NFSv{2,3}, using nolock" 1>&2
>          options=$options,nolock
>      fi
> -    mount -t $nfs -o$options $server:$path $mntdir
> +    mount -t $nfs -o$options "$server:$path" "$mntdir"
>  }
> 

Thanks! pushed

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2014-09-10  9:08 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-08-21 18:31 [PATCH] Support spaces in mount_nfs (#1109933) Brian C. Lane
     [not found] ` <1408645911-3268-1-git-send-email-bcl-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2014-09-10  9:08   ` Harald Hoyer

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.