[PATCH 0/5] arm: shmobile: Lager Add USB and SATA support

[PATCH 0/5] arm: shmobile: Lager Add USB and SATA support

[Valentine Barshak]

I've decided to bundle USB and SATA patches together, since I've done SATA on top of USB.
Most of the SATA/USBHS/PCI USB host support patches for Lager are available in the respective
susbsystem git trees (for 3.14) but are still missing from the Renesas tree.

So, in order to test these, the following patches from other subsystem trees are needed:
USB:
https://git.kernel.org/cgit/linux/kernel/git/helgaas/pci.git/commit/?h=pci/host-rcar&idû178d8b2fab3f2a9f203c13ffe80cfd6e01bdf1
https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?idÈba8115a21226fba3211085f570b128fa271e31
https://git.kernel.org/cgit/linux/kernel/git/balbi/usb.git/commit/?h=next&idÃe5d2985ef720cbbdc63546a5c545ac4450d96e
https://git.kernel.org/cgit/linux/kernel/git/gregkh/usb.git/commit/?h=usb-next&id\x103e127d1f8f985e8a662da6537ebc5e08902ee3
https://git.kernel.org/cgit/linux/kernel/git/gregkh/usb.git/commit/?h=usb-next&id\x1ae5799ef63176cc75ec10e545cb65f620a82747

SATA:
https://git.kernel.org/cgit/linux/kernel/git/tj/libata.git/commit/?h=for-3.14&idæ7adb4e669db834c1f95cbdf99bb4e9ec8455b3

The USB channel 0 (CN6) is configured as PCI USB host if USB_RENESAS_USBHS_UDC is disabled.
Otherwise it is configured as USBHS device.
Please note that the following switches have to be set correctly as well:
PCI USB Host: SW5 - pin1;    SW6 - pin1
USBHS device: SW5 - neutral; SW6 - pin3

Valentine Barshak (5):
  arm: shmobile: r8a7790: Add PCI USB host clock support
  arm: shmobile: r8a7790: Add SATA clock
  arm: shmobile: lager: Add USBHS support
  arm: shmobile: lager: Add internal PCI support
  arm: shmobile: lager: Add SATA support

 arch/arm/mach-shmobile/board-lager.c   | 203 +++++++++++++++++++++++++++++++++
 arch/arm/mach-shmobile/clock-r8a7790.c |  25 +++-
 2 files changed, 227 insertions(+), 1 deletion(-)

-- 
1.8.3.1

Re: [PATCH 0/5] arm: shmobile: Lager Add USB and SATA support

[Magnus Damm]

Hi Valentine,

Thanks for posting this patch series.

On Wed, Dec 18, 2013 at 9:44 PM, Valentine Barshak
<valentine.barshak@cogentembedded.com> wrote:
> I've decided to bundle USB and SATA patches together, since I've done SATA on top of USB.
> Most of the SATA/USBHS/PCI USB host support patches for Lager are available in the respective
> susbsystem git trees (for 3.14) but are still missing from the Renesas tree.
>
> So, in order to test these, the following patches from other subsystem trees are needed:
> USB:
> https://git.kernel.org/cgit/linux/kernel/git/helgaas/pci.git/commit/?h=pci/host-rcar&idû178d8b2fab3f2a9f203c13ffe80cfd6e01bdf1
> https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?idÈba8115a21226fba3211085f570b128fa271e31
> https://git.kernel.org/cgit/linux/kernel/git/balbi/usb.git/commit/?h=next&idÃe5d2985ef720cbbdc63546a5c545ac4450d96e
> https://git.kernel.org/cgit/linux/kernel/git/gregkh/usb.git/commit/?h=usb-next&id\x103e127d1f8f985e8a662da6537ebc5e08902ee3
> https://git.kernel.org/cgit/linux/kernel/git/gregkh/usb.git/commit/?h=usb-next&id\x1ae5799ef63176cc75ec10e545cb65f620a82747

So let me clarify about the above, this is for USB Host 2.0 support
only? Or is USB Function also included? If both are included, can you
please show me the dependencies for USB Function by itself?

> SATA:
> https://git.kernel.org/cgit/linux/kernel/git/tj/libata.git/commit/?h=for-3.14&idæ7adb4e669db834c1f95cbdf99bb4e9ec8455b3

This patch looks like a small enough dependency for us to handle
easily. I propose that we begin getting this one merged.

> The USB channel 0 (CN6) is configured as PCI USB host if USB_RENESAS_USBHS_UDC is disabled.
> Otherwise it is configured as USBHS device.
> Please note that the following switches have to be set correctly as well:
> PCI USB Host: SW5 - pin1;    SW6 - pin1
> USBHS device: SW5 - neutral; SW6 - pin3
>
> Valentine Barshak (5):
>   arm: shmobile: r8a7790: Add PCI USB host clock support
>   arm: shmobile: r8a7790: Add SATA clock
>   arm: shmobile: lager: Add USBHS support
>   arm: shmobile: lager: Add internal PCI support
>   arm: shmobile: lager: Add SATA support

May I ask you to break out the SATA bits and submit them as a separate
series. I'd like to try them on both Lager and Koelsch, so if you
happen to have patches for both boards then that would be great
(platform device style for now is acceptable to me).

Timing wise we're a bit unfortunate with the holidays and all, but I
will do my best to work with Simon to get your code merged. I will
probably ask you to add support for DT via CCF and MULTIPLATFORM in
the not too distant future, hope that's ok.

When we're done with SATA then i'd like to give USB Function a go too,
please let me know those dependencies.

Cheers,

/ magnus

Re: [PATCH 0/5] arm: shmobile: Lager Add USB and SATA support

[Valentine]

On 12/19/2013 02:09 PM, Magnus Damm wrote:
> Hi Valentine,
>
> Thanks for posting this patch series.
>
> On Wed, Dec 18, 2013 at 9:44 PM, Valentine Barshak
> <valentine.barshak@cogentembedded.com> wrote:
>> I've decided to bundle USB and SATA patches together, since I've done SATA on top of USB.
>> Most of the SATA/USBHS/PCI USB host support patches for Lager are available in the respective
>> susbsystem git trees (for 3.14) but are still missing from the Renesas tree.
>>
>> So, in order to test these, the following patches from other subsystem trees are needed:
>> USB:
>> https://git.kernel.org/cgit/linux/kernel/git/helgaas/pci.git/commit/?h=pci/host-rcar&idû178d8b2fab3f2a9f203c13ffe80cfd6e01bdf1
>> https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?idÈba8115a21226fba3211085f570b128fa271e31
>> https://git.kernel.org/cgit/linux/kernel/git/balbi/usb.git/commit/?h=next&idÃe5d2985ef720cbbdc63546a5c545ac4450d96e
>> https://git.kernel.org/cgit/linux/kernel/git/gregkh/usb.git/commit/?h=usb-next&id\x103e127d1f8f985e8a662da6537ebc5e08902ee3
>> https://git.kernel.org/cgit/linux/kernel/git/gregkh/usb.git/commit/?h=usb-next&id\x1ae5799ef63176cc75ec10e545cb65f620a82747
>
> So let me clarify about the above, this is for USB Host 2.0 support
> only? Or is USB Function also included? If both are included, can you
> please show me the dependencies for USB Function by itself?
>

Both, USBHS and USB host depend on the following commits:
https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?idÈba8115a21226fba3211085f570b128fa271e31
https://git.kernel.org/cgit/linux/kernel/git/balbi/usb.git/commit/?h=next&idÃe5d2985ef720cbbdc63546a5c545ac4450d96e

USB Host also needs these:
https://git.kernel.org/cgit/linux/kernel/git/gregkh/usb.git/commit/?h=usb-next&id\x103e127d1f8f985e8a662da6537ebc5e08902ee3
https://git.kernel.org/cgit/linux/kernel/git/gregkh/usb.git/commit/?h=usb-next&id\x1ae5799ef63176cc75ec10e545cb65f620a82747
https://git.kernel.org/cgit/linux/kernel/git/helgaas/pci.git/commit/?h=pci/host-rcar&idû178d8b2fab3f2a9f203c13ffe80cfd6e01bdf1

>> SATA:
>> https://git.kernel.org/cgit/linux/kernel/git/tj/libata.git/commit/?h=for-3.14&idæ7adb4e669db834c1f95cbdf99bb4e9ec8455b3
>
> This patch looks like a small enough dependency for us to handle
> easily. I propose that we begin getting this one merged.

Just FYI, there's also another patch in libata tree that adds documentation for the SATA DT bindings:
https://git.kernel.org/cgit/linux/kernel/git/tj/libata.git/commit/?h=for-3.14&id€361fa02e59cbc4ddfd4ceae18441092797149f
It may need some updates in the future due to recent CCF DT work. Not sure if you want to merge it as well, it's just a .txt file.

>
>> The USB channel 0 (CN6) is configured as PCI USB host if USB_RENESAS_USBHS_UDC is disabled.
>> Otherwise it is configured as USBHS device.
>> Please note that the following switches have to be set correctly as well:
>> PCI USB Host: SW5 - pin1;    SW6 - pin1
>> USBHS device: SW5 - neutral; SW6 - pin3
>>
>> Valentine Barshak (5):
>>    arm: shmobile: r8a7790: Add PCI USB host clock support
>>    arm: shmobile: r8a7790: Add SATA clock
>>    arm: shmobile: lager: Add USBHS support
>>    arm: shmobile: lager: Add internal PCI support
>>    arm: shmobile: lager: Add SATA support
>
> May I ask you to break out the SATA bits and submit them as a separate
> series. I'd like to try them on both Lager and Koelsch, so if you
> happen to have patches for both boards then that would be great
> (platform device style for now is acceptable to me).

Sure,
I'll break out the SATA.
I'll try to produce some patches for Koelsch as well.
I'll let you know hot it goes later today.

>
> Timing wise we're a bit unfortunate with the holidays and all, but I
> will do my best to work with Simon to get your code merged.

Thanks!

> I will probably ask you to add support for DT via CCF and MULTIPLATFORM in
> the not too distant future, hope that's ok.

Yes, that was next on my to-do list. I'm just not sure about the latest CCF status.
Do I wait until it's merged, or should I use clocks/ccf/rcar-gen2-clocks branch from Laurent's tree?

>
> When we're done with SATA then i'd like to give USB Function a go too,
> please let me know those dependencies.
>
> Cheers,
>
> / magnus
>

Thanks,
Val.

Re: [PATCH 0/5] arm: shmobile: Lager Add USB and SATA support

[Valentine]

On 12/19/2013 05:02 PM, Valentine wrote:
> On 12/19/2013 02:09 PM, Magnus Damm wrote:
>> Hi Valentine,
>>

Hi Magnus,

[snip]

>>>
>>> Valentine Barshak (5):
>>>    arm: shmobile: r8a7790: Add PCI USB host clock support
>>>    arm: shmobile: r8a7790: Add SATA clock
>>>    arm: shmobile: lager: Add USBHS support
>>>    arm: shmobile: lager: Add internal PCI support
>>>    arm: shmobile: lager: Add SATA support
>>
>> May I ask you to break out the SATA bits and submit them as a separate
>> series. I'd like to try them on both Lager and Koelsch, so if you
>> happen to have patches for both boards then that would be great
>> (platform device style for now is acceptable to me).
>
> Sure,
> I'll break out the SATA.
> I'll try to produce some patches for Koelsch as well.
> I'll let you know hot it goes later today.
>

Will send separate SATA patches for Lager and Koelsch in a bit.

[snip]

Thanks,
Val.

Re: [PATCH 0/5] arm: shmobile: Lager Add USB and SATA support

[Valentine]

On 12/18/2013 04:44 PM, Valentine Barshak wrote:
> I've decided to bundle USB and SATA patches together, since I've done SATA on top of USB.
> Most of the SATA/USBHS/PCI USB host support patches for Lager are available in the respective
> susbsystem git trees (for 3.14) but are still missing from the Renesas tree.
>
> So, in order to test these, the following patches from other subsystem trees are needed:
> USB:
> https://git.kernel.org/cgit/linux/kernel/git/helgaas/pci.git/commit/?h=pci/host-rcar&idû178d8b2fab3f2a9f203c13ffe80cfd6e01bdf1
> https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?idÈba8115a21226fba3211085f570b128fa271e31
> https://git.kernel.org/cgit/linux/kernel/git/balbi/usb.git/commit/?h=next&idÃe5d2985ef720cbbdc63546a5c545ac4450d96e
> https://git.kernel.org/cgit/linux/kernel/git/gregkh/usb.git/commit/?h=usb-next&id\x103e127d1f8f985e8a662da6537ebc5e08902ee3
> https://git.kernel.org/cgit/linux/kernel/git/gregkh/usb.git/commit/?h=usb-next&id\x1ae5799ef63176cc75ec10e545cb65f620a82747
>
> SATA:
> https://git.kernel.org/cgit/linux/kernel/git/tj/libata.git/commit/?h=for-3.14&idæ7adb4e669db834c1f95cbdf99bb4e9ec8455b3
>
> The USB channel 0 (CN6) is configured as PCI USB host if USB_RENESAS_USBHS_UDC is disabled.
> Otherwise it is configured as USBHS device.
> Please note that the following switches have to be set correctly as well:
> PCI USB Host: SW5 - pin1;    SW6 - pin1
> USBHS device: SW5 - neutral; SW6 - pin3
>
> Valentine Barshak (5):
>    arm: shmobile: r8a7790: Add PCI USB host clock support
>    arm: shmobile: r8a7790: Add SATA clock
>    arm: shmobile: lager: Add USBHS support
>    arm: shmobile: lager: Add internal PCI support
>    arm: shmobile: lager: Add SATA support
>
>   arch/arm/mach-shmobile/board-lager.c   | 203 +++++++++++++++++++++++++++++++++
>   arch/arm/mach-shmobile/clock-r8a7790.c |  25 +++-
>   2 files changed, 227 insertions(+), 1 deletion(-)
>

I've rebased the series on top of the latest renesas-devel-v3.13-rc4-20131219 branch
and split it into separate USB and SATA ones. The SATA support was posted yesterday.
I'll resend the USB part for both Lager/Koelsch boards in a bit.

Thanks,
Val.

Re: [PATCH 0/5] arm: shmobile: Lager Add USB and SATA support

[Ryusuke Sakato]

Hi Hiep-san,

Can you check as CONFIG_CPU_FREQ is not set?

When you perform a benchmark, you should check a /sys/devices/system/cpu/cpu0/cpufreq/scaling_governor
setup of your userland.

Thank you,
Sakato.

(2014/09/09 19:48), カオ　ミン　ヒェップ wrote:
> Hello,
> 
> We are testing Serial-ATA driver on linux uptream-v3.17-rc2 on Lager(R8a7790 SoC),
> On this version Serial-ATA's Writing speed on HDD is about 42.61MB/s.
> This writing speed|| seems good, but on Upstream-v3.16-rc5 the writing speed was up to 66MB/s,
> Please see it when you have time.
> 
> Best Regards,
> Jinso/Cao Minh Hiep.
> 
> 
> 
> 
> 
> 
> On 12/18/2013 09:44 PM, Valentine Barshak wrote:
>> I've decided to bundle USB and SATA patches together, since I've done SATA on top of USB.
>> Most of the SATA/USBHS/PCI USB host support patches for Lager are available in the respective
>> susbsystem git trees (for 3.14) but are still missing from the Renesas tree.
>>
>> So, in order to test these, the following patches from other subsystem trees are needed:
>> USB:
>> https://git.kernel.org/cgit/linux/kernel/git/helgaas/pci.git/commit/?h=pci/host-rcar&idû178d8b2fab3f2a9f203c13ffe80cfd6e01bdf1
>> https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?idÈba8115a21226fba3211085f570b128fa271e31
>> https://git.kernel.org/cgit/linux/kernel/git/balbi/usb.git/commit/?h=next&idÃe5d2985ef720cbbdc63546a5c545ac4450d96e
>> https://git.kernel.org/cgit/linux/kernel/git/gregkh/usb.git/commit/?h=usb-next&id\x103e127d1f8f985e8a662da6537ebc5e08902ee3
>> https://git.kernel.org/cgit/linux/kernel/git/gregkh/usb.git/commit/?h=usb-next&id\x1ae5799ef63176cc75ec10e545cb65f620a82747
>>
>> SATA:
>> https://git.kernel.org/cgit/linux/kernel/git/tj/libata.git/commit/?h=for-3.14&idæ7adb4e669db834c1f95cbdf99bb4e9ec8455b3
>>
>> The USB channel 0 (CN6) is configured as PCI USB host if USB_RENESAS_USBHS_UDC is disabled.
>> Otherwise it is configured as USBHS device.
>> Please note that the following switches have to be set correctly as well:
>> PCI USB Host: SW5 - pin1;    SW6 - pin1
>> USBHS device: SW5 - neutral; SW6 - pin3
>>
>> Valentine Barshak (5):
>>    arm: shmobile: r8a7790: Add PCI USB host clock support
>>    arm: shmobile: r8a7790: Add SATA clock
>>    arm: shmobile: lager: Add USBHS support
>>    arm: shmobile: lager: Add internal PCI support
>>    arm: shmobile: lager: Add SATA support
>>
>>   arch/arm/mach-shmobile/board-lager.c   | 203 +++++++++++++++++++++++++++++++++
>>   arch/arm/mach-shmobile/clock-r8a7790.c |  25 +++-
>>   2 files changed, 227 insertions(+), 1 deletion(-)
>>
> 
> 

Re: [PATCH 0/5] arm: shmobile: Lager Add USB and SATA support

[カオ ミン ヒェップ]

Hi Sakato-san

Thanks for your comment.

On 09/10/2014 10:21 AM, Ryusuke Sakato wrote:
> Hi Hiep-san,
>
> Can you check as CONFIG_CPU_FREQ is not set?
>
> When you perform a benchmark, you should check a /sys/devices/system/cpu/cpu0/cpufreq/scaling_governor
> setup of your userland.
CONFIG_CPU_FREQ=y on default config,
And I have just checked 
/sys/devices/system/cpu/cpu0/cpufreq/scaling_governor

Before writing:
# cat /sys/devices/system/cpu/cpu0/cpufreq/scaling_governor
ondemand
just after writing:
#cp /tmp/file-350mb /mnt/ ; cat 
/sys/devices/system/cpu/cpu1/cpufreq/scaling_governor
ondemand


Best regards,
Cao Minh Hiep

> Thank you,
> Sakato.
>
> (2014/09/09 19:48), カオ　ミン　ヒェップ wrote:
>> Hello,
>>
>> We are testing Serial-ATA driver on linux uptream-v3.17-rc2 on Lager(R8a7790 SoC),
>> On this version Serial-ATA's Writing speed on HDD is about 42.61MB/s.
>> This writing speed|| seems good, but on Upstream-v3.16-rc5 the writing speed was up to 66MB/s,
>> Please see it when you have time.
>>
>> Best Regards,
>> Jinso/Cao Minh Hiep.
>>
>>
>>
>>
>>
>>
>> On 12/18/2013 09:44 PM, Valentine Barshak wrote:
>>> I've decided to bundle USB and SATA patches together, since I've done SATA on top of USB.
>>> Most of the SATA/USBHS/PCI USB host support patches for Lager are available in the respective
>>> susbsystem git trees (for 3.14) but are still missing from the Renesas tree.
>>>
>>> So, in order to test these, the following patches from other subsystem trees are needed:
>>> USB:
>>> https://git.kernel.org/cgit/linux/kernel/git/helgaas/pci.git/commit/?h=pci/host-rcar&idû178d8b2fab3f2a9f203c13ffe80cfd6e01bdf1
>>> https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?idÈba8115a21226fba3211085f570b128fa271e31
>>> https://git.kernel.org/cgit/linux/kernel/git/balbi/usb.git/commit/?h=next&idÃe5d2985ef720cbbdc63546a5c545ac4450d96e
>>> https://git.kernel.org/cgit/linux/kernel/git/gregkh/usb.git/commit/?h=usb-next&id\x103e127d1f8f985e8a662da6537ebc5e08902ee3
>>> https://git.kernel.org/cgit/linux/kernel/git/gregkh/usb.git/commit/?h=usb-next&id\x1ae5799ef63176cc75ec10e545cb65f620a82747
>>>
>>> SATA:
>>> https://git.kernel.org/cgit/linux/kernel/git/tj/libata.git/commit/?h=for-3.14&idæ7adb4e669db834c1f95cbdf99bb4e9ec8455b3
>>>
>>> The USB channel 0 (CN6) is configured as PCI USB host if USB_RENESAS_USBHS_UDC is disabled.
>>> Otherwise it is configured as USBHS device.
>>> Please note that the following switches have to be set correctly as well:
>>> PCI USB Host: SW5 - pin1;    SW6 - pin1
>>> USBHS device: SW5 - neutral; SW6 - pin3
>>>
>>> Valentine Barshak (5):
>>>     arm: shmobile: r8a7790: Add PCI USB host clock support
>>>     arm: shmobile: r8a7790: Add SATA clock
>>>     arm: shmobile: lager: Add USBHS support
>>>     arm: shmobile: lager: Add internal PCI support
>>>     arm: shmobile: lager: Add SATA support
>>>
>>>    arch/arm/mach-shmobile/board-lager.c   | 203 +++++++++++++++++++++++++++++++++
>>>    arch/arm/mach-shmobile/clock-r8a7790.c |  25 +++-
>>>    2 files changed, 227 insertions(+), 1 deletion(-)
>>>
>>
>

Re: [PATCH 0/5] arm: shmobile: Lager Add USB and SATA support

[Ryusuke Sakato]

Hi Hiep-san,


I believe that I should unite the conditions of the performance test of "CONFIG_CPU_FREQ is not set" on Upstream-v3.16-rc5,
 and "CONFIG_CPU_FREQ=y" on uptream-v3.17-rc2.


> # cat /sys/devices/system/cpu/cpu0/cpufreq/scaling_governor
> ondemand

In order that you may not be subject to the influence of cpufreq, you should change
 "CONFIG_CPU_FREQ is not set", or should perform the following setup.

　echo -n performance > /sys/device/system/cpu/cpu0/cpufreq/scaling_governor
　echo -n performance > /sys/device/system/cpu/cpu1/cpufreq/scaling_governor
　echo -n performance > /sys/device/system/cpu/cpu2/cpufreq/scaling_governor
　echo -n performance > /sys/device/system/cpu/cpu3/cpufreq/scaling_governor


Thank you,
Sakato.




(2014/09/10 14:18), カオ　ミン　ヒェップ wrote:
> Hi Sakato-san
> 
> Thanks for your comment.
> 
> On 09/10/2014 10:21 AM, Ryusuke Sakato wrote:
>> Hi Hiep-san,
>>
>> Can you check as CONFIG_CPU_FREQ is not set?
>>
>> When you perform a benchmark, you should check a /sys/devices/system/cpu/cpu0/cpufreq/scaling_governor
>> setup of your userland.
> CONFIG_CPU_FREQ=y on default config,
> And I have just checked /sys/devices/system/cpu/cpu0/cpufreq/scaling_governor
> 
> Before writing:
> # cat /sys/devices/system/cpu/cpu0/cpufreq/scaling_governor
> ondemand
> just after writing:
> #cp /tmp/file-350mb /mnt/ ; cat /sys/devices/system/cpu/cpu1/cpufreq/scaling_governor
> ondemand
> 
> 
> Best regards,
> Cao Minh Hiep
> 
>> Thank you,
>> Sakato.
>>
>> (2014/09/09 19:48), カオ　ミン　ヒェップ wrote:
>>> Hello,
>>>
>>> We are testing Serial-ATA driver on linux uptream-v3.17-rc2 on Lager(R8a7790 SoC),
>>> On this version Serial-ATA's Writing speed on HDD is about 42.61MB/s.
>>> This writing speed|| seems good, but on Upstream-v3.16-rc5 the writing speed was up to 66MB/s,
>>> Please see it when you have time.
>>>
>>> Best Regards,
>>> Jinso/Cao Minh Hiep.
>>>
>>>
>>>
>>>
>>>
>>>
>>> On 12/18/2013 09:44 PM, Valentine Barshak wrote:
>>>> I've decided to bundle USB and SATA patches together, since I've done SATA on top of USB.
>>>> Most of the SATA/USBHS/PCI USB host support patches for Lager are available in the respective
>>>> susbsystem git trees (for 3.14) but are still missing from the Renesas tree.
>>>>
>>>> So, in order to test these, the following patches from other subsystem trees are needed:
>>>> USB:
>>>> https://git.kernel.org/cgit/linux/kernel/git/helgaas/pci.git/commit/?h=pci/host-rcar&idû178d8b2fab3f2a9f203c13ffe80cfd6e01bdf1
>>>>
>>>> https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?idÈba8115a21226fba3211085f570b128fa271e31
>>>> https://git.kernel.org/cgit/linux/kernel/git/balbi/usb.git/commit/?h=next&idÃe5d2985ef720cbbdc63546a5c545ac4450d96e
>>>> https://git.kernel.org/cgit/linux/kernel/git/gregkh/usb.git/commit/?h=usb-next&id\x103e127d1f8f985e8a662da6537ebc5e08902ee3
>>>> https://git.kernel.org/cgit/linux/kernel/git/gregkh/usb.git/commit/?h=usb-next&id\x1ae5799ef63176cc75ec10e545cb65f620a82747
>>>>
>>>> SATA:
>>>> https://git.kernel.org/cgit/linux/kernel/git/tj/libata.git/commit/?h=for-3.14&idæ7adb4e669db834c1f95cbdf99bb4e9ec8455b3
>>>>
>>>> The USB channel 0 (CN6) is configured as PCI USB host if USB_RENESAS_USBHS_UDC is disabled.
>>>> Otherwise it is configured as USBHS device.
>>>> Please note that the following switches have to be set correctly as well:
>>>> PCI USB Host: SW5 - pin1;    SW6 - pin1
>>>> USBHS device: SW5 - neutral; SW6 - pin3
>>>>
>>>> Valentine Barshak (5):
>>>>     arm: shmobile: r8a7790: Add PCI USB host clock support
>>>>     arm: shmobile: r8a7790: Add SATA clock
>>>>     arm: shmobile: lager: Add USBHS support
>>>>     arm: shmobile: lager: Add internal PCI support
>>>>     arm: shmobile: lager: Add SATA support
>>>>
>>>>    arch/arm/mach-shmobile/board-lager.c   | 203 +++++++++++++++++++++++++++++++++
>>>>    arch/arm/mach-shmobile/clock-r8a7790.c |  25 +++-
>>>>    2 files changed, 227 insertions(+), 1 deletion(-)
>>>>
>>>
>>
> 
> .
> 

Re: [PATCH 0/5] arm: shmobile: Lager Add USB and SATA support

[カオ ミン ヒェップ]

Hi Sakato-san

On 09/10/2014 04:15 PM, Ryusuke Sakato wrote:
> Hi Hiep-san,
>
>
> I believe that I should unite the conditions of the performance test of "CONFIG_CPU_FREQ is not set" on Upstream-v3.16-rc5,
>   and "CONFIG_CPU_FREQ=y" on uptream-v3.17-rc2.
>
>
>> # cat /sys/devices/system/cpu/cpu0/cpufreq/scaling_governor
>> ondemand
> In order that you may not be subject to the influence of cpufreq, you should change
>   "CONFIG_CPU_FREQ is not set", or should perform the following setup.
>
> 　echo -n performance > /sys/device/system/cpu/cpu0/cpufreq/scaling_governor
> 　echo -n performance > /sys/device/system/cpu/cpu1/cpufreq/scaling_governor
> 　echo -n performance > /sys/device/system/cpu/cpu2/cpufreq/scaling_governor
> 　echo -n performance > /sys/device/system/cpu/cpu3/cpufreq/scaling_governor
>
As you pointed out, I changed "CONFIG_CPU_FREQ=y" to "CONFIG_CPU_FREQ is 
not set" on uptream-v3.17-rc2 ,
I saw that the writing speed on v3.17-rc2 and is same writing speed on 
v3.16-rc5.

# mount -t tmpfs -o size@0m tmpfs /tmp
root@linaro-nano:~# dd if=/dev/urandom of=/tmp/file-350mb bs=1M count50
350+0 records in
350+0 records out
367001600 bytes (367 MB) copied, 90.2065 s, 4.1 MB/s
root@linaro-nano:~# mount /dev/sda1 /mnt/
kjournald starting.  Commit interval 5 seconds
EXT3-fs (sda1): using internal journal
EXT3-fs (sda1): recovery complete
EXT3-fs (sda1): mounted filesystem with ordered data mode
root@linaro-nano:~# time cp /tmp/file-350mb /mnt/file; time umount /mnt/

real    0m5.386s
user    0m0.010s
sys     0m5.200s

real    0m1.078s
user    0m0.020s
sys     0m0.510s

Thanks you for your help!



Cao Minh Hiep.

Re: [PATCH 0/5] arm: shmobile: Lager Add USB and SATA support

[Khiem Nguyen]

Hi Hiep-san, Sakato-san,

Sorry for interruption.

Could you also confirm performance of SATA driver
in case that CPUFreq uses performance governor ?

If SATA performance is degraded in that case,
I guess we still need countermeasure. 
(because CPUFreq will definitely be enabled in multi-platform defconfig.)

Thanks.

Best regards,
KHIEM Nguyen

On 9/10/2014 6:16 PM, カオ　ミン　ヒェップ wrote:
> Hi Sakato-san
> 
> On 09/10/2014 04:15 PM, Ryusuke Sakato wrote:
>> Hi Hiep-san,
>>
>>
>> I believe that I should unite the conditions of the performance test of "CONFIG_CPU_FREQ is not set" on Upstream-v3.16-rc5,
>>   and "CONFIG_CPU_FREQ=y" on uptream-v3.17-rc2.
>>
>>
>>> # cat /sys/devices/system/cpu/cpu0/cpufreq/scaling_governor
>>> ondemand
>> In order that you may not be subject to the influence of cpufreq, you should change
>>   "CONFIG_CPU_FREQ is not set", or should perform the following setup.
>>
>> 　echo -n performance > /sys/device/system/cpu/cpu0/cpufreq/scaling_governor
>> 　echo -n performance > /sys/device/system/cpu/cpu1/cpufreq/scaling_governor
>> 　echo -n performance > /sys/device/system/cpu/cpu2/cpufreq/scaling_governor
>> 　echo -n performance > /sys/device/system/cpu/cpu3/cpufreq/scaling_governor
>>
> As you pointed out, I changed "CONFIG_CPU_FREQ=y" to "CONFIG_CPU_FREQ is not set" on uptream-v3.17-rc2 ,
> I saw that the writing speed on v3.17-rc2 and is same writing speed on v3.16-rc5.
> 
> # mount -t tmpfs -o size@0m tmpfs /tmp
> root@linaro-nano:~# dd if=/dev/urandom of=/tmp/file-350mb bs=1M count50
> 350+0 records in
> 350+0 records out
> 367001600 bytes (367 MB) copied, 90.2065 s, 4.1 MB/s
> root@linaro-nano:~# mount /dev/sda1 /mnt/
> kjournald starting.  Commit interval 5 seconds
> EXT3-fs (sda1): using internal journal
> EXT3-fs (sda1): recovery complete
> EXT3-fs (sda1): mounted filesystem with ordered data mode
> root@linaro-nano:~# time cp /tmp/file-350mb /mnt/file; time umount /mnt/
> 
> real    0m5.386s
> user    0m0.010s
> sys     0m5.200s
> 
> real    0m1.078s
> user    0m0.020s
> sys     0m0.510s
> 
> Thanks you for your help!
> 
> 
> 
> Cao Minh Hiep.
> 
> -- 
> To unsubscribe from this list: send the line "unsubscribe linux-sh" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 0/5] arm: shmobile: Lager Add USB and SATA support

[カオ ミン ヒェップ]

Hi Khiem-san

Sorry for late replying!

On 09/10/2014 06:32 PM, Khiem Nguyen wrote:
> Hi Hiep-san, Sakato-san,
>
> Sorry for interruption.
>
> Could you also confirm performance of SATA driver
> in case that CPUFreq uses performance governor ?
>
> If SATA performance is degraded in that case,
> I guess we still need countermeasure.
> (because CPUFreq will definitely be enabled in multi-platform defconfig.)
Here is the results of SATA driver writing speed in case CPUFreq uses 
governor:
Data size: 350MB,
root@linaro-nano:~# uname -a
Linux linaro-nano 3.17.0-rc2 #3 SMP Thu Sep 11 17:15:17 JST 2014 armv7l 
armv7l armv7l GNU/Lix
root@linaro-nano:~# cat 
/sys/devices/system/cpu/cpu0/cpufreq/scaling_governor
ondemand
root@linaro-nano:~# cat 
/sys/devices/system/cpu/cpu1/cpufreq/scaling_governor
ondemand
root@linaro-nano:~# cat 
/sys/devices/system/cpu/cpu2/cpufreq/scaling_governor
ondemand
root@linaro-nano:~# cat 
/sys/devices/system/cpu/cpu3/cpufreq/scaling_governor
ondemand

# mount -t tmpfs -o size@0m tmpfs /tmp
root@linaro-nano:~# dd if=/dev/urandom of=/tmp/file-350mb bs=1M count50

350+0 records in
350+0 records out
367001600 bytes (367 MB) copied, 88.5655 s, 4.1 MB/s
root@linaro-nano:~# mount /dev/sda1 /mnt/sata/
kjournald starting.  Commit interval 5 seconds
EXT3-fs (sda1): using internal journal
EXT3-fs (sda1): mounted filesystem with ordered data mode
  oot@linaro-nano:~# time cp /tmp/file-350mb /mnt/sata/; time umount 
/mnt/sata/

real    0m6.665s
user    0m0.020s
sys     0m5.690s

real    0m1.243s
user    0m0.010s
sys     0m0.660s

Total: 7.9s
Speed: 46.45MB/s
=========================

root@linaro-nano:~# cat 
/sys/devices/system/cpu/cpu0/cpufreq/scaling_governor
performance
root@linaro-nano:~# cat 
/sys/devices/system/cpu/cpu1/cpufreq/scaling_governor
performance
root@linaro-nano:~# cat 
/sys/devices/system/cpu/cpu2/cpufreq/scaling_governor
performance
root@linaro-nano:~# cat 
/sys/devices/system/cpu/cpu3/cpufreq/scaling_governor
performance
# time cp /tmp/file-350mb /mnt/sata/; time umount /mnt/sata/

real    0m5.331s
user    0m0.010s
sys     0m5.250s

real    0m1.084s
user    0m0.030s
sys     0m0.500s

Total: 6.3s
Speed: 58.3MB/s


Thank you!
Cao Minh Hiep.

Re: [PATCH 0/5] arm: shmobile: Lager Add USB and SATA support

[Khiem Nguyen]

Hi Hiep-san,

Thanks for your test result.

On 9/11/2014 6:35 PM, カオ　ミン　ヒェップ wrote:
> Hi Khiem-san
> 
> Sorry for late replying!
> 
> On 09/10/2014 06:32 PM, Khiem Nguyen wrote:
>> Hi Hiep-san, Sakato-san,
>>
>> Sorry for interruption.
>>
>> Could you also confirm performance of SATA driver
>> in case that CPUFreq uses performance governor ?
>>
>> If SATA performance is degraded in that case,
>> I guess we still need countermeasure.
>> (because CPUFreq will definitely be enabled in multi-platform defconfig.)
> Here is the results of SATA driver writing speed in case CPUFreq uses governor:
> Data size: 350MB,
> root@linaro-nano:~# uname -a
> Linux linaro-nano 3.17.0-rc2 #3 SMP Thu Sep 11 17:15:17 JST 2014 armv7l armv7l armv7l GNU/Lix
> root@linaro-nano:~# cat /sys/devices/system/cpu/cpu0/cpufreq/scaling_governor
> ondemand
> root@linaro-nano:~# cat /sys/devices/system/cpu/cpu1/cpufreq/scaling_governor
> ondemand
> root@linaro-nano:~# cat /sys/devices/system/cpu/cpu2/cpufreq/scaling_governor
> ondemand
> root@linaro-nano:~# cat /sys/devices/system/cpu/cpu3/cpufreq/scaling_governor
> ondemand
> 
> # mount -t tmpfs -o size@0m tmpfs /tmp
> root@linaro-nano:~# dd if=/dev/urandom of=/tmp/file-350mb bs=1M count50
> 
> 350+0 records in
> 350+0 records out
> 367001600 bytes (367 MB) copied, 88.5655 s, 4.1 MB/s
> root@linaro-nano:~# mount /dev/sda1 /mnt/sata/
> kjournald starting.  Commit interval 5 seconds
> EXT3-fs (sda1): using internal journal
> EXT3-fs (sda1): mounted filesystem with ordered data mode
>  oot@linaro-nano:~# time cp /tmp/file-350mb /mnt/sata/; time umount /mnt/sata/
> 
> real    0m6.665s
> user    0m0.020s
> sys     0m5.690s
> 
> real    0m1.243s
> user    0m0.010s
> sys     0m0.660s
> 
> Total: 7.9s
> Speed: 46.45MB/s
> =========================
> 
> root@linaro-nano:~# cat /sys/devices/system/cpu/cpu0/cpufreq/scaling_governor
> performance
> root@linaro-nano:~# cat /sys/devices/system/cpu/cpu1/cpufreq/scaling_governor
> performance
> root@linaro-nano:~# cat /sys/devices/system/cpu/cpu2/cpufreq/scaling_governor
> performance
> root@linaro-nano:~# cat /sys/devices/system/cpu/cpu3/cpufreq/scaling_governor
> performance
> # time cp /tmp/file-350mb /mnt/sata/; time umount /mnt/sata/
> 
> real    0m5.331s
> user    0m0.010s
> sys     0m5.250s
> 
> real    0m1.084s
> user    0m0.030s
> sys     0m0.500s
> 
> Total: 6.3s
> Speed: 58.3MB/s

It seems SATA performance (write speed) is degraded after CPUFreq is enabled
(even performance governor is selected).

Base on your test result so far:
T1 Upstream-v3.16-rc5: 66 MB/s
T2 v3.17-rc2 (CPUFreq disabled): ~ 66 MB/s
T3 v3.17-rc2 (CPUFreq enable / on-demand governor): 42.61MB/s
T4 v3.17-rc2 (CPUFreq disabled / performance governor ): 58.3MB/s

The diff between T2 and T4 is ~8 MB/s (or 8% of 66 MB/s).
I guess we should try to find the cause of this regression.
(I wonder similar phenomenon occurs in backport version ...)

(I added Inami-san, CPUFreq developer for his info.)
> 
> 
> Thank you!
> Cao Minh Hiep.

-- 
Best regards,
KHIEM Nguyen

Re: [PATCH 0/5] arm: shmobile: Lager Add USB and SATA support

[カオ ミン ヒェップ]

Hi Khiem-san

> It seems SATA performance (write speed) is degraded after CPUFreq is enabled
> (even performance governor is selected).
>
> Base on your test result so far:
> T1 Upstream-v3.16-rc5: 66 MB/s
> T2 v3.17-rc2 (CPUFreq disabled): ~ 66 MB/s
> T3 v3.17-rc2 (CPUFreq enable / on-demand governor): 42.61MB/s
> T4 v3.17-rc2 (CPUFreq disabled / performance governor ): 58.3MB/s
>
> The diff between T2 and T4 is ~8 MB/s (or 8% of 66 MB/s).
> I guess we should try to find the cause of this regression.
> (I wonder similar phenomenon occurs in backport version ...)
>
> (I added Inami-san, CPUFreq developer for his info.)
Have some miss in my way of the report yesterday.
As yesterday results, T2 v3.17-rc2 (CPUFreq disabled) should be 
(367MB/(5.3s+1.0s)) ->58.2MB/s

Here is yesterday's report:
  > As you pointed out, I changed "CONFIG_CPU_FREQ=y" to 
"CONFIG_CPU_FREQ is not set" on uptream-v3.17-rc2 ,
(snip)
 >root@linaro-nano:~# dd if=/dev/urandom of=/tmp/file-350mb bs=1M count50
 >350+0 records in
 >350+0 records out
 >367001600 bytes (367 MB) copied, 90.2065 s, 4.1 MB/s
 >root@linaro-nano:~# time cp /tmp/file-350mb /mnt/file; time umount /mnt/
 >real    0m5.386s
 >user    0m0.010s
 >sys     0m5.200s

 >real    0m1.078s
 >user    0m0.020s
 >sys     0m0.510s

And I have just re-confirmed T1 (Upstream-v3.16-rc5),
On upstream-v3.16-rc5 SATA's writing speed should be 55.6MB/s as below.
There is no uniformity in the speed calculation of SATA in our test team.
That 66MB/s only is result of copy to SATA-HDD without umount the device 
before finish.
Sorry for the inconvenience.

Here is the test results of v3.16-rc5:
root@linaro-nano:~# uname -a
Linux linaro-nano 3.16.0-rc5 #4 SMP Thu Sep 11 20:01:58 JST 2014 armv7l 
armv7l ax
root@linaro-nano:~# mount -t tmpfs -o size@0m tmpfs /tmp
root@linaro-nano:~# dd if=/dev/urandom of=/tmp/file-350mb bs=1M count50
350+0 records in
350+0 records out
367001600 bytes (367 MB) copied, 115.374 s, 3.2 MB/s
root@linaro-nano:~# mount /dev/sda1 /mnt/sata/
kjournald starting.  Commit interval 5 seconds
EXT3-fs (sda1): using internal journal
EXT3-fs (sda1): mounted filesystem with ordered data mode
root@linaro-nano:~# rm /mnt/sata/file-350mb
root@linaro-nano:~# time cp /tmp/file-350mb /mnt/sata/; time umount 
/mnt/sata/

real    0m5.473s
user    0m0.020s
sys     0m5.430s

real    0m1.149s
user    0m0.000s
sys     0m0.510s


Speed: 55.6MB/s


>>
>> Thank you!
>> Cao Minh Hiep.

Re: [PATCH 0/5] arm: shmobile: Lager Add USB and SATA support

[Khiem Nguyen]

Hi Hiep-san,

Thanks for your update.

On 9/11/2014 8:26 PM, カオ　ミン　ヒェップ wrote:
> Hi Khiem-san
> 
>> It seems SATA performance (write speed) is degraded after CPUFreq is enabled
>> (even performance governor is selected).
>>
>> Base on your test result so far:
>> T1 Upstream-v3.16-rc5: 66 MB/s
>> T2 v3.17-rc2 (CPUFreq disabled): ~ 66 MB/s
>> T3 v3.17-rc2 (CPUFreq enable / on-demand governor): 42.61MB/s
>> T4 v3.17-rc2 (CPUFreq disabled / performance governor ): 58.3MB/s
>>
>> The diff between T2 and T4 is ~8 MB/s (or 8% of 66 MB/s).
>> I guess we should try to find the cause of this regression.
>> (I wonder similar phenomenon occurs in backport version ...)

[snip]

> Have some miss in my way of the report yesterday.
> As yesterday results, T2 v3.17-rc2 (CPUFreq disabled) should be (367MB/(5.3s+1.0s)) ->58.2MB/s

[snip]

> And I have just re-confirmed T1 (Upstream-v3.16-rc5),
> On upstream-v3.16-rc5 SATA's writing speed should be 55.6MB/s as below.
> There is no uniformity in the speed calculation of SATA in our test team.
> That 66MB/s only is result of copy to SATA-HDD without umount the device before finish.
> Sorry for the inconvenience.
[snip] 

It makes sense now.
SATA performance does not degrade after CPUFreq is enabled (select performance governor).
>> T1 Upstream-v3.16-rc5 (CPUFreq disabled by default): -> 55.6MB/s
>> T2 v3.17-rc2 (CPUFreq disabled)                    : -> 58.2MB/s
>> T3 v3.17-rc2 (CPUFreq enable / on-demand governor) : 42.61MB/s
>> T4 v3.17-rc2 (CPUFreq disabled / performance governor ): 58.3MB/s

And we should take note SATA performance
when CPUfreq/on-demand governor is selected.
(perhaps, CPUFreq parameters should be tuned)

Thanks for your testing, Hiep-san.

>>>
>>> Thank you!
>>> Cao Minh Hiep.


-- 
Best regards,
KHIEM Nguyen