[PATCH] memory-hotplug: fix below build warning

[PATCH] memory-hotplug: fix below build warning

[Zhang Zhen]

drivers/base/memory.c: In function 'show_valid_zones':
drivers/base/memory.c:384:22: warning: unused variable 'zone_prev' [-Wunused-variable]
  struct zone *zone, *zone_prev;
                      ^

Signed-off-by: Zhang Zhen <zhenzhang.zhang@huawei.com>
---
 drivers/base/memory.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/base/memory.c b/drivers/base/memory.c
index efd456c..7c5d871 100644
--- a/drivers/base/memory.c
+++ b/drivers/base/memory.c
@@ -381,7 +381,7 @@ static ssize_t show_valid_zones(struct device *dev,
 	unsigned long start_pfn, end_pfn;
 	unsigned long nr_pages = PAGES_PER_SECTION * sections_per_block;
 	struct page *first_page;
-	struct zone *zone, *zone_prev;
+	struct zone *zone;
 
 	start_pfn = section_nr_to_pfn(mem->start_section_nr);
 	end_pfn = start_pfn + nr_pages;
-- 
1.8.1.4

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

Re: [PATCH] memory-hotplug: fix below build warning

[David Rientjes]

On Tue, 9 Sep 2014, Zhang Zhen wrote:

> drivers/base/memory.c: In function 'show_valid_zones':
> drivers/base/memory.c:384:22: warning: unused variable 'zone_prev' [-Wunused-variable]
>   struct zone *zone, *zone_prev;
>                       ^
> 
> Signed-off-by: Zhang Zhen <zhenzhang.zhang@huawei.com>

This is
Reported-by: kbuild test robot <fengguang.wu@intel.com>
on August 29 to this mailing list.

> ---
>  drivers/base/memory.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/base/memory.c b/drivers/base/memory.c
> index efd456c..7c5d871 100644
> --- a/drivers/base/memory.c
> +++ b/drivers/base/memory.c
> @@ -381,7 +381,7 @@ static ssize_t show_valid_zones(struct device *dev,
>  	unsigned long start_pfn, end_pfn;
>  	unsigned long nr_pages = PAGES_PER_SECTION * sections_per_block;
>  	struct page *first_page;
> -	struct zone *zone, *zone_prev;
> +	struct zone *zone;
>  
>  	start_pfn = section_nr_to_pfn(mem->start_section_nr);
>  	end_pfn = start_pfn + nr_pages;

Looks good, but this should already be fixed by
http://ozlabs.org/~akpm/mmotm/broken-out/memory-hotplug-add-sysfs-zones_online_to-attribute-fix-3-fix.patch
right?

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

Re: [PATCH] memory-hotplug: fix below build warning

[Zhang Zhen]

On 2014/9/11 2:55, David Rientjes wrote:
> On Tue, 9 Sep 2014, Zhang Zhen wrote:
> 
>> drivers/base/memory.c: In function 'show_valid_zones':
>> drivers/base/memory.c:384:22: warning: unused variable 'zone_prev' [-Wunused-variable]
>>   struct zone *zone, *zone_prev;
>>                       ^
>>
>> Signed-off-by: Zhang Zhen <zhenzhang.zhang@huawei.com>
> 
> This is
> Reported-by: kbuild test robot <fengguang.wu@intel.com>
> on August 29 to this mailing list.
> 
>> ---
>>  drivers/base/memory.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/base/memory.c b/drivers/base/memory.c
>> index efd456c..7c5d871 100644
>> --- a/drivers/base/memory.c
>> +++ b/drivers/base/memory.c
>> @@ -381,7 +381,7 @@ static ssize_t show_valid_zones(struct device *dev,
>>  	unsigned long start_pfn, end_pfn;
>>  	unsigned long nr_pages = PAGES_PER_SECTION * sections_per_block;
>>  	struct page *first_page;
>> -	struct zone *zone, *zone_prev;
>> +	struct zone *zone;
>>  
>>  	start_pfn = section_nr_to_pfn(mem->start_section_nr);
>>  	end_pfn = start_pfn + nr_pages;
> 
> Looks good, but this should already be fixed by
> http://ozlabs.org/~akpm/mmotm/broken-out/memory-hotplug-add-sysfs-zones_online_to-attribute-fix-3-fix.patch
> right?
> 
Yeah, thanks!
> 


--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>