All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] clk: rockchip: rk3288: add VOP1 softresets and rename VOP0 softresets
@ 2014-09-12 10:33 ` Mark yao
  0 siblings, 0 replies; 6+ messages in thread
From: Mark yao @ 2014-09-12 10:33 UTC (permalink / raw)
  To: Mike Turquette, heiko, Rob Herring, Pawel Moll, Mark Rutland,
	Ian Campbell, Kumar Gala
  Cc: devicetree, linux-kernel, djkurtz, dianders, dkl, eddie.cai, xjq,
	kfx, huangtao, zyw, yxj, cym, zhengsq, caesar.wang, kever.yang,
	Mark yao

The rk3288 have two vop, and each vop has three softresets were axi_reset,
ahb_reset and dclk_reset.

Signed-off-by: Mark yao <mark.yao@rock-chips.com>
---
 include/dt-bindings/clock/rk3288-cru.h | 10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)

diff --git a/include/dt-bindings/clock/rk3288-cru.h b/include/dt-bindings/clock/rk3288-cru.h
index ebcb460..4d65959 100644
--- a/include/dt-bindings/clock/rk3288-cru.h
+++ b/include/dt-bindings/clock/rk3288-cru.h
@@ -235,9 +235,9 @@
 #define SRST_RGA_NIU		97
 #define SRST_VIO0_NIU_AXI	98
 #define SRST_VIO_NIU_AHB	99
-#define SRST_LCDC0_AXI		100
-#define SRST_LCDC0_AHB		101
-#define SRST_LCDC0_DCLK		102
+#define SRST_VOP0_AXI		100
+#define SRST_VOP0_AHB		101
+#define SRST_VOP0_DCLK		102
 #define SRST_VIO1_NIU_AXI	103
 #define SRST_VIP		104
 #define SRST_RGA_CORE		105
@@ -276,3 +276,7 @@
 #define SRST_USBHOST1_CON	140
 #define SRST_USB_ADP		141
 #define SRST_ACC_EFUSE		142
+
+#define SRST_VOP1_AXI		176
+#define SRST_VOP1_AHB		177
+#define SRST_VOP1_DCLK		178
-- 
1.9.1


^ permalink raw reply related	[flat|nested] 6+ messages in thread
* [PATCH] clk: rockchip: rk3288: add VOP1 softresets and rename VOP0 softresets
@ 2014-09-12 10:33 ` Mark yao
  0 siblings, 0 replies; 6+ messages in thread
From: Mark yao @ 2014-09-12 10:33 UTC (permalink / raw)
  To: Mike Turquette, heiko-4mtYJXux2i+zQB+pC5nmwQ, Rob Herring,
	Pawel Moll, Mark Rutland, Ian Campbell, Kumar Gala
  Cc: devicetree-u79uwXL29TY76Z2rM5mHXA,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA,
	djkurtz-F7+t8E8rja9g9hUCZPvPmw, dianders-F7+t8E8rja9g9hUCZPvPmw,
	dkl-TNX95d0MmH7DzftRWevZcw, eddie.cai-TNX95d0MmH7DzftRWevZcw,
	xjq-TNX95d0MmH7DzftRWevZcw, kfx-TNX95d0MmH7DzftRWevZcw,
	huangtao-TNX95d0MmH7DzftRWevZcw, zyw-TNX95d0MmH7DzftRWevZcw,
	yxj-TNX95d0MmH7DzftRWevZcw, cym-TNX95d0MmH7DzftRWevZcw,
	zhengsq-TNX95d0MmH7DzftRWevZcw,
	caesar.wang-TNX95d0MmH7DzftRWevZcw,
	kever.yang-TNX95d0MmH7DzftRWevZcw, Mark yao

The rk3288 have two vop, and each vop has three softresets were axi_reset,
ahb_reset and dclk_reset.

Signed-off-by: Mark yao <mark.yao-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
---
 include/dt-bindings/clock/rk3288-cru.h | 10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)

diff --git a/include/dt-bindings/clock/rk3288-cru.h b/include/dt-bindings/clock/rk3288-cru.h
index ebcb460..4d65959 100644
--- a/include/dt-bindings/clock/rk3288-cru.h
+++ b/include/dt-bindings/clock/rk3288-cru.h
@@ -235,9 +235,9 @@
 #define SRST_RGA_NIU		97
 #define SRST_VIO0_NIU_AXI	98
 #define SRST_VIO_NIU_AHB	99
-#define SRST_LCDC0_AXI		100
-#define SRST_LCDC0_AHB		101
-#define SRST_LCDC0_DCLK		102
+#define SRST_VOP0_AXI		100
+#define SRST_VOP0_AHB		101
+#define SRST_VOP0_DCLK		102
 #define SRST_VIO1_NIU_AXI	103
 #define SRST_VIP		104
 #define SRST_RGA_CORE		105
@@ -276,3 +276,7 @@
 #define SRST_USBHOST1_CON	140
 #define SRST_USB_ADP		141
 #define SRST_ACC_EFUSE		142
+
+#define SRST_VOP1_AXI		176
+#define SRST_VOP1_AHB		177
+#define SRST_VOP1_DCLK		178
-- 
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply related	[flat|nested] 6+ messages in thread
* Re: [PATCH] clk: rockchip: rk3288: add VOP1 softresets and rename VOP0 softresets
@ 2014-09-12 10:41   ` Heiko Stübner
  0 siblings, 0 replies; 6+ messages in thread
From: Heiko Stübner @ 2014-09-12 10:41 UTC (permalink / raw)
  To: Mark yao
  Cc: Mike Turquette, Rob Herring, Pawel Moll, Mark Rutland,
	Ian Campbell, Kumar Gala, devicetree, linux-kernel, djkurtz,
	dianders, dkl, eddie.cai, xjq, kfx, huangtao, zyw, yxj, cym,
	zhengsq, caesar.wang, kever.yang

Hi Mark,

Am Freitag, 12. September 2014, 18:33:23 schrieb Mark yao:
> The rk3288 have two vop, and each vop has three softresets were axi_reset,
> ahb_reset and dclk_reset.

I'm not sure about renaming the indices, since they're part of the devicetree-
binding. We know that so far no device in the wild used them, so it might be 
ok.

But in any case could you also add the rest of the indices of the "new" reset 
registers please, so that we don't end up adding each small index in a 
separate patch.

patch1: add reset indices for SOFTRST9 - SOFTRST11
patch2: rename LCDC0 -> VOP0


Heiko

> 
> Signed-off-by: Mark yao <mark.yao@rock-chips.com>
> ---
>  include/dt-bindings/clock/rk3288-cru.h | 10 +++++++---
>  1 file changed, 7 insertions(+), 3 deletions(-)
> 
> diff --git a/include/dt-bindings/clock/rk3288-cru.h
> b/include/dt-bindings/clock/rk3288-cru.h index ebcb460..4d65959 100644
> --- a/include/dt-bindings/clock/rk3288-cru.h
> +++ b/include/dt-bindings/clock/rk3288-cru.h
> @@ -235,9 +235,9 @@
>  #define SRST_RGA_NIU		97
>  #define SRST_VIO0_NIU_AXI	98
>  #define SRST_VIO_NIU_AHB	99
> -#define SRST_LCDC0_AXI		100
> -#define SRST_LCDC0_AHB		101
> -#define SRST_LCDC0_DCLK		102
> +#define SRST_VOP0_AXI		100
> +#define SRST_VOP0_AHB		101
> +#define SRST_VOP0_DCLK		102
>  #define SRST_VIO1_NIU_AXI	103
>  #define SRST_VIP		104
>  #define SRST_RGA_CORE		105
> @@ -276,3 +276,7 @@
>  #define SRST_USBHOST1_CON	140
>  #define SRST_USB_ADP		141
>  #define SRST_ACC_EFUSE		142
> +
> +#define SRST_VOP1_AXI		176
> +#define SRST_VOP1_AHB		177
> +#define SRST_VOP1_DCLK		178


^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] clk: rockchip: rk3288: add VOP1 softresets and rename VOP0 softresets
@ 2014-09-12 10:41   ` Heiko Stübner
  0 siblings, 0 replies; 6+ messages in thread
From: Heiko Stübner @ 2014-09-12 10:41 UTC (permalink / raw)
  To: Mark yao
  Cc: Mike Turquette, Rob Herring, Pawel Moll, Mark Rutland,
	Ian Campbell, Kumar Gala, devicetree-u79uwXL29TY76Z2rM5mHXA,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA,
	djkurtz-F7+t8E8rja9g9hUCZPvPmw, dianders-F7+t8E8rja9g9hUCZPvPmw,
	dkl-TNX95d0MmH7DzftRWevZcw, eddie.cai-TNX95d0MmH7DzftRWevZcw,
	xjq-TNX95d0MmH7DzftRWevZcw, kfx-TNX95d0MmH7DzftRWevZcw,
	huangtao-TNX95d0MmH7DzftRWevZcw, zyw-TNX95d0MmH7DzftRWevZcw,
	yxj-TNX95d0MmH7DzftRWevZcw, cym-TNX95d0MmH7DzftRWevZcw,
	zhengsq-TNX95d0MmH7DzftRWevZcw,
	caesar.wang-TNX95d0MmH7DzftRWevZcw,
	kever.yang-TNX95d0MmH7DzftRWevZcw

Hi Mark,

Am Freitag, 12. September 2014, 18:33:23 schrieb Mark yao:
> The rk3288 have two vop, and each vop has three softresets were axi_reset,
> ahb_reset and dclk_reset.

I'm not sure about renaming the indices, since they're part of the devicetree-
binding. We know that so far no device in the wild used them, so it might be 
ok.

But in any case could you also add the rest of the indices of the "new" reset 
registers please, so that we don't end up adding each small index in a 
separate patch.

patch1: add reset indices for SOFTRST9 - SOFTRST11
patch2: rename LCDC0 -> VOP0


Heiko

> 
> Signed-off-by: Mark yao <mark.yao-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
> ---
>  include/dt-bindings/clock/rk3288-cru.h | 10 +++++++---
>  1 file changed, 7 insertions(+), 3 deletions(-)
> 
> diff --git a/include/dt-bindings/clock/rk3288-cru.h
> b/include/dt-bindings/clock/rk3288-cru.h index ebcb460..4d65959 100644
> --- a/include/dt-bindings/clock/rk3288-cru.h
> +++ b/include/dt-bindings/clock/rk3288-cru.h
> @@ -235,9 +235,9 @@
>  #define SRST_RGA_NIU		97
>  #define SRST_VIO0_NIU_AXI	98
>  #define SRST_VIO_NIU_AHB	99
> -#define SRST_LCDC0_AXI		100
> -#define SRST_LCDC0_AHB		101
> -#define SRST_LCDC0_DCLK		102
> +#define SRST_VOP0_AXI		100
> +#define SRST_VOP0_AHB		101
> +#define SRST_VOP0_DCLK		102
>  #define SRST_VIO1_NIU_AXI	103
>  #define SRST_VIP		104
>  #define SRST_RGA_CORE		105
> @@ -276,3 +276,7 @@
>  #define SRST_USBHOST1_CON	140
>  #define SRST_USB_ADP		141
>  #define SRST_ACC_EFUSE		142
> +
> +#define SRST_VOP1_AXI		176
> +#define SRST_VOP1_AHB		177
> +#define SRST_VOP1_DCLK		178

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] clk: rockchip: rk3288: add VOP1 softresets and rename VOP0 softresets
  2014-09-12 10:41   ` Heiko Stübner
@ 2014-09-12 11:01     ` mark
  -1 siblings, 0 replies; 6+ messages in thread
From: mark @ 2014-09-12 11:01 UTC (permalink / raw)
  To: Heiko Stübner, Mark yao
  Cc: Mike Turquette, Rob Herring, Pawel Moll, Mark Rutland,
	Ian Campbell, Kumar Gala, devicetree, linux-kernel, djkurtz,
	dianders, dkl, eddie.cai, xjq, kfx, huangtao, zyw, yxj, cym,
	zhengsq, caesar.wang, kever.yang


On 2014年09月12日 18:41, Heiko Stübner wrote:
> Hi Mark,
>
> Am Freitag, 12. September 2014, 18:33:23 schrieb Mark yao:
>> The rk3288 have two vop, and each vop has three softresets were axi_reset,
>> ahb_reset and dclk_reset.
> I'm not sure about renaming the indices, since they're part of the devicetree-
> binding. We know that so far no device in the wild used them, so it might be
> ok.
now vop driver need these reset, so we need add it.
> But in any case could you also add the rest of the indices of the "new" reset
> registers please, so that we don't end up adding each small index in a
> separate patch.
>
> patch1: add reset indices for SOFTRST9 - SOFTRST11
> patch2: rename LCDC0 -> VOP0
OK, I will do it
>
> Heiko
>
>> Signed-off-by: Mark yao <mark.yao@rock-chips.com>
>> ---
>>   include/dt-bindings/clock/rk3288-cru.h | 10 +++++++---
>>   1 file changed, 7 insertions(+), 3 deletions(-)
>>
>> diff --git a/include/dt-bindings/clock/rk3288-cru.h
>> b/include/dt-bindings/clock/rk3288-cru.h index ebcb460..4d65959 100644
>> --- a/include/dt-bindings/clock/rk3288-cru.h
>> +++ b/include/dt-bindings/clock/rk3288-cru.h
>> @@ -235,9 +235,9 @@
>>   #define SRST_RGA_NIU		97
>>   #define SRST_VIO0_NIU_AXI	98
>>   #define SRST_VIO_NIU_AHB	99
>> -#define SRST_LCDC0_AXI		100
>> -#define SRST_LCDC0_AHB		101
>> -#define SRST_LCDC0_DCLK		102
>> +#define SRST_VOP0_AXI		100
>> +#define SRST_VOP0_AHB		101
>> +#define SRST_VOP0_DCLK		102
>>   #define SRST_VIO1_NIU_AXI	103
>>   #define SRST_VIP		104
>>   #define SRST_RGA_CORE		105
>> @@ -276,3 +276,7 @@
>>   #define SRST_USBHOST1_CON	140
>>   #define SRST_USB_ADP		141
>>   #define SRST_ACC_EFUSE		142
>> +
>> +#define SRST_VOP1_AXI		176
>> +#define SRST_VOP1_AHB		177
>> +#define SRST_VOP1_DCLK		178
>
>
>


^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] clk: rockchip: rk3288: add VOP1 softresets and rename VOP0 softresets
@ 2014-09-12 11:01     ` mark
  0 siblings, 0 replies; 6+ messages in thread
From: mark @ 2014-09-12 11:01 UTC (permalink / raw)
  To: Heiko Stübner, Mark yao
  Cc: Mike Turquette, Rob Herring, Pawel Moll, Mark Rutland,
	Ian Campbell, Kumar Gala, devicetree-u79uwXL29TY76Z2rM5mHXA,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA,
	djkurtz-F7+t8E8rja9g9hUCZPvPmw, dianders-F7+t8E8rja9g9hUCZPvPmw,
	dkl-TNX95d0MmH7DzftRWevZcw, eddie.cai-TNX95d0MmH7DzftRWevZcw,
	xjq-TNX95d0MmH7DzftRWevZcw, kfx-TNX95d0MmH7DzftRWevZcw,
	huangtao-TNX95d0MmH7DzftRWevZcw, zyw-TNX95d0MmH7DzftRWevZcw,
	yxj-TNX95d0MmH7DzftRWevZcw, cym-TNX95d0MmH7DzftRWevZcw,
	zhengsq-TNX95d0MmH7DzftRWevZcw,
	caesar.wang-TNX95d0MmH7DzftRWevZcw,
	kever.yang-TNX95d0MmH7DzftRWevZcw


On 2014年09月12日 18:41, Heiko Stübner wrote:
> Hi Mark,
>
> Am Freitag, 12. September 2014, 18:33:23 schrieb Mark yao:
>> The rk3288 have two vop, and each vop has three softresets were axi_reset,
>> ahb_reset and dclk_reset.
> I'm not sure about renaming the indices, since they're part of the devicetree-
> binding. We know that so far no device in the wild used them, so it might be
> ok.
now vop driver need these reset, so we need add it.
> But in any case could you also add the rest of the indices of the "new" reset
> registers please, so that we don't end up adding each small index in a
> separate patch.
>
> patch1: add reset indices for SOFTRST9 - SOFTRST11
> patch2: rename LCDC0 -> VOP0
OK, I will do it
>
> Heiko
>
>> Signed-off-by: Mark yao <mark.yao-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
>> ---
>>   include/dt-bindings/clock/rk3288-cru.h | 10 +++++++---
>>   1 file changed, 7 insertions(+), 3 deletions(-)
>>
>> diff --git a/include/dt-bindings/clock/rk3288-cru.h
>> b/include/dt-bindings/clock/rk3288-cru.h index ebcb460..4d65959 100644
>> --- a/include/dt-bindings/clock/rk3288-cru.h
>> +++ b/include/dt-bindings/clock/rk3288-cru.h
>> @@ -235,9 +235,9 @@
>>   #define SRST_RGA_NIU		97
>>   #define SRST_VIO0_NIU_AXI	98
>>   #define SRST_VIO_NIU_AHB	99
>> -#define SRST_LCDC0_AXI		100
>> -#define SRST_LCDC0_AHB		101
>> -#define SRST_LCDC0_DCLK		102
>> +#define SRST_VOP0_AXI		100
>> +#define SRST_VOP0_AHB		101
>> +#define SRST_VOP0_DCLK		102
>>   #define SRST_VIO1_NIU_AXI	103
>>   #define SRST_VIP		104
>>   #define SRST_RGA_CORE		105
>> @@ -276,3 +276,7 @@
>>   #define SRST_USBHOST1_CON	140
>>   #define SRST_USB_ADP		141
>>   #define SRST_ACC_EFUSE		142
>> +
>> +#define SRST_VOP1_AXI		176
>> +#define SRST_VOP1_AHB		177
>> +#define SRST_VOP1_DCLK		178
>
>
>

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2014-09-12 11:02 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-09-12 10:33 [PATCH] clk: rockchip: rk3288: add VOP1 softresets and rename VOP0 softresets Mark yao
2014-09-12 10:33 ` Mark yao
2014-09-12 10:41 ` Heiko Stübner
2014-09-12 10:41   ` Heiko Stübner
2014-09-12 11:01   ` mark
2014-09-12 11:01     ` mark

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.