All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] ath9k_htc: fix random decryption failure
@ 2014-09-12 20:36 ` Johannes Stezenbach
  0 siblings, 0 replies; 4+ messages in thread
From: Johannes Stezenbach @ 2014-09-12 20:36 UTC (permalink / raw)
  To: John W. Linville; +Cc: Oleksij Rempel, ath9k-devel, linux-wireless

In v3.15 the driver stopped to accept network packets after successful
authentification, which could be worked around by passing the
nohwcrypt=1 module parameter.  This was not reproducible by
everyone, and showed random behaviour in some tests.
It was caused by an uninitialized variable introduced
in 4ed1a8d4a257 ("ath9k_htc: use ath9k_cmn_rx_accept") and
used in 341b29b9cd2f ("ath9k_htc: use ath9k_cmn_rx_skb_postprocess").

Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=78581
Fixes: 341b29b9cd2f ("ath9k_htc: use ath9k_cmn_rx_skb_postprocess")
Signed-off-by: Johannes Stezenbach <js@sig21.net>

diff --git a/drivers/net/wireless/ath/ath9k/htc_drv_txrx.c b/drivers/net/wireless/ath/ath9k/htc_drv_txrx.c
index bb86eb2..f0484b1 100644
--- a/drivers/net/wireless/ath/ath9k/htc_drv_txrx.c
+++ b/drivers/net/wireless/ath/ath9k/htc_drv_txrx.c
@@ -978,7 +978,7 @@ static bool ath9k_rx_prepare(struct ath9k_htc_priv *priv,
 	struct ath_hw *ah = common->ah;
 	struct ath_htc_rx_status *rxstatus;
 	struct ath_rx_status rx_stats;
-	bool decrypt_error;
+	bool decrypt_error = false;
 
 	if (skb->len < HTC_RX_FRAME_HEADER_SIZE) {
 		ath_err(common, "Corrupted RX frame, dropping (len: %d)\n",

^ permalink raw reply related	[flat|nested] 4+ messages in thread
* [ath9k-devel] [PATCH] ath9k_htc: fix random decryption failure
@ 2014-09-12 20:36 ` Johannes Stezenbach
  0 siblings, 0 replies; 4+ messages in thread
From: Johannes Stezenbach @ 2014-09-12 20:36 UTC (permalink / raw)
  To: ath9k-devel

In v3.15 the driver stopped to accept network packets after successful
authentification, which could be worked around by passing the
nohwcrypt=1 module parameter.  This was not reproducible by
everyone, and showed random behaviour in some tests.
It was caused by an uninitialized variable introduced
in 4ed1a8d4a257 ("ath9k_htc: use ath9k_cmn_rx_accept") and
used in 341b29b9cd2f ("ath9k_htc: use ath9k_cmn_rx_skb_postprocess").

Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=78581
Fixes: 341b29b9cd2f ("ath9k_htc: use ath9k_cmn_rx_skb_postprocess")
Signed-off-by: Johannes Stezenbach <js@sig21.net>

diff --git a/drivers/net/wireless/ath/ath9k/htc_drv_txrx.c b/drivers/net/wireless/ath/ath9k/htc_drv_txrx.c
index bb86eb2..f0484b1 100644
--- a/drivers/net/wireless/ath/ath9k/htc_drv_txrx.c
+++ b/drivers/net/wireless/ath/ath9k/htc_drv_txrx.c
@@ -978,7 +978,7 @@ static bool ath9k_rx_prepare(struct ath9k_htc_priv *priv,
 	struct ath_hw *ah = common->ah;
 	struct ath_htc_rx_status *rxstatus;
 	struct ath_rx_status rx_stats;
-	bool decrypt_error;
+	bool decrypt_error = false;
 
 	if (skb->len < HTC_RX_FRAME_HEADER_SIZE) {
 		ath_err(common, "Corrupted RX frame, dropping (len: %d)\n",

^ permalink raw reply related	[flat|nested] 4+ messages in thread
* Re: [PATCH] ath9k_common: fix random decryption failure
  2014-09-12 20:36 ` [ath9k-devel] " Johannes Stezenbach
@ 2014-09-13  6:04   ` Oleksij Rempel
  -1 siblings, 0 replies; 4+ messages in thread
From: Oleksij Rempel @ 2014-09-13  6:04 UTC (permalink / raw)
  To: Johannes Stezenbach, John W. Linville; +Cc: ath9k-devel, linux-wireless

[-- Attachment #1: Type: text/plain, Size: 1363 bytes --]

Am 12.09.2014 um 22:36 schrieb Johannes Stezenbach:
> In v3.15 the driver stopped to accept network packets after successful
> authentification, which could be worked around by passing the
> nohwcrypt=1 module parameter.  This was not reproducible by
> everyone, and showed random behaviour in some tests.
> It was caused by an uninitialized variable introduced
> in 4ed1a8d4a257 ("ath9k_htc: use ath9k_cmn_rx_accept") and
> used in 341b29b9cd2f ("ath9k_htc: use ath9k_cmn_rx_skb_postprocess").
> 
> Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=78581
> Fixes: 341b29b9cd2f ("ath9k_htc: use ath9k_cmn_rx_skb_postprocess")
> Signed-off-by: Johannes Stezenbach <js@sig21.net>
> 
> diff --git a/drivers/net/wireless/ath/ath9k/htc_drv_txrx.c b/drivers/net/wireless/ath/ath9k/htc_drv_txrx.c
> index bb86eb2..f0484b1 100644
> --- a/drivers/net/wireless/ath/ath9k/htc_drv_txrx.c
> +++ b/drivers/net/wireless/ath/ath9k/htc_drv_txrx.c
> @@ -978,7 +978,7 @@ static bool ath9k_rx_prepare(struct ath9k_htc_priv *priv,
>  	struct ath_hw *ah = common->ah;
>  	struct ath_htc_rx_status *rxstatus;
>  	struct ath_rx_status rx_stats;
> -	bool decrypt_error;
> +	bool decrypt_error = false;
>  
>  	if (skb->len < HTC_RX_FRAME_HEADER_SIZE) {
>  		ath_err(common, "Corrupted RX frame, dropping (len: %d)\n",
> 

ACK.

-- 
Regards,
Oleksij


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 213 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread
* [ath9k-devel] [PATCH] ath9k_common: fix random decryption failure
@ 2014-09-13  6:04   ` Oleksij Rempel
  0 siblings, 0 replies; 4+ messages in thread
From: Oleksij Rempel @ 2014-09-13  6:04 UTC (permalink / raw)
  To: ath9k-devel

Am 12.09.2014 um 22:36 schrieb Johannes Stezenbach:
> In v3.15 the driver stopped to accept network packets after successful
> authentification, which could be worked around by passing the
> nohwcrypt=1 module parameter.  This was not reproducible by
> everyone, and showed random behaviour in some tests.
> It was caused by an uninitialized variable introduced
> in 4ed1a8d4a257 ("ath9k_htc: use ath9k_cmn_rx_accept") and
> used in 341b29b9cd2f ("ath9k_htc: use ath9k_cmn_rx_skb_postprocess").
> 
> Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=78581
> Fixes: 341b29b9cd2f ("ath9k_htc: use ath9k_cmn_rx_skb_postprocess")
> Signed-off-by: Johannes Stezenbach <js@sig21.net>
> 
> diff --git a/drivers/net/wireless/ath/ath9k/htc_drv_txrx.c b/drivers/net/wireless/ath/ath9k/htc_drv_txrx.c
> index bb86eb2..f0484b1 100644
> --- a/drivers/net/wireless/ath/ath9k/htc_drv_txrx.c
> +++ b/drivers/net/wireless/ath/ath9k/htc_drv_txrx.c
> @@ -978,7 +978,7 @@ static bool ath9k_rx_prepare(struct ath9k_htc_priv *priv,
>  	struct ath_hw *ah = common->ah;
>  	struct ath_htc_rx_status *rxstatus;
>  	struct ath_rx_status rx_stats;
> -	bool decrypt_error;
> +	bool decrypt_error = false;
>  
>  	if (skb->len < HTC_RX_FRAME_HEADER_SIZE) {
>  		ath_err(common, "Corrupted RX frame, dropping (len: %d)\n",
> 

ACK.

-- 
Regards,
Oleksij

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 213 bytes
Desc: OpenPGP digital signature
Url : http://lists.ath9k.org/pipermail/ath9k-devel/attachments/20140913/d7b1b3f4/attachment.pgp 

^ permalink raw reply	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-09-13  6:04 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-09-12 20:36 [PATCH] ath9k_htc: fix random decryption failure Johannes Stezenbach
2014-09-12 20:36 ` [ath9k-devel] " Johannes Stezenbach
2014-09-13  6:04 ` [PATCH] ath9k_common: " Oleksij Rempel
2014-09-13  6:04   ` [ath9k-devel] " Oleksij Rempel

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.