* [PATCH] xfs_metadump: don't warn about unobfuscated log with -o
@ 2016-08-04 15:51 Eric Sandeen
2016-08-04 16:13 ` Bill O'Donnell
0 siblings, 1 reply; 2+ messages in thread
From: Eric Sandeen @ 2016-08-04 15:51 UTC (permalink / raw)
To: xfs-oss
It makes no sense to warn about un-obfuscated logs
when we asked xfs_metadump to not obfuscate metadata:
# xfs_metadump -o /dev/loop2 bad.metadump
xfs_metadump: Filesystem log is dirty; image will contain unobfuscated metadata in log.
Signed-off-by: Eric Sandeen <sandeen@redhat.com>
---
diff --git a/db/metadump.c b/db/metadump.c
index d7ff6e5..01a51c4 100644
--- a/db/metadump.c
+++ b/db/metadump.c
@@ -2575,12 +2575,14 @@ copy_log(void)
break;
case 1:
/* keep the dirty log */
- print_warning(
+ if (obfuscate)
+ print_warning(
_("Filesystem log is dirty; image will contain unobfuscated metadata in log."));
break;
case -1:
/* log detection error */
- print_warning(
+ if (obfuscate)
+ print_warning(
_("Could not discern log; image will contain unobfuscated metadata in log."));
break;
}
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] xfs_metadump: don't warn about unobfuscated log with -o
2016-08-04 15:51 [PATCH] xfs_metadump: don't warn about unobfuscated log with -o Eric Sandeen
@ 2016-08-04 16:13 ` Bill O'Donnell
0 siblings, 0 replies; 2+ messages in thread
From: Bill O'Donnell @ 2016-08-04 16:13 UTC (permalink / raw)
To: Eric Sandeen; +Cc: xfs-oss
On Thu, Aug 04, 2016 at 10:51:12AM -0500, Eric Sandeen wrote:
> It makes no sense to warn about un-obfuscated logs
> when we asked xfs_metadump to not obfuscate metadata:
>
> # xfs_metadump -o /dev/loop2 bad.metadump
> xfs_metadump: Filesystem log is dirty; image will contain unobfuscated metadata in log.
>
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
Reviewed-by: Bill O'Donnell <billodo@redhat.com>
> ---
>
> diff --git a/db/metadump.c b/db/metadump.c
> index d7ff6e5..01a51c4 100644
> --- a/db/metadump.c
> +++ b/db/metadump.c
> @@ -2575,12 +2575,14 @@ copy_log(void)
> break;
> case 1:
> /* keep the dirty log */
> - print_warning(
> + if (obfuscate)
> + print_warning(
> _("Filesystem log is dirty; image will contain unobfuscated metadata in log."));
> break;
> case -1:
> /* log detection error */
> - print_warning(
> + if (obfuscate)
> + print_warning(
> _("Could not discern log; image will contain unobfuscated metadata in log."));
> break;
> }
>
> _______________________________________________
> xfs mailing list
> xfs@oss.sgi.com
> http://oss.sgi.com/mailman/listinfo/xfs
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-08-04 16:13 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-08-04 15:51 [PATCH] xfs_metadump: don't warn about unobfuscated log with -o Eric Sandeen
2016-08-04 16:13 ` Bill O'Donnell
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.