All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] ACPI / video: disable native backlight for ThinkPad X201s
@ 2014-09-19  2:01 Aaron Lu
  2014-09-22 14:02 ` Rafael J. Wysocki
  0 siblings, 1 reply; 2+ messages in thread
From: Aaron Lu @ 2014-09-19  2:01 UTC (permalink / raw)
  To: Rafael J. Wysocki, Yves-Alexis Perez
  Cc: Hans de Goede, ACPI Devel Mailing List

The ThinkPad X201s has a working ACPI video backlight interface and is
shipped before Win8; then there is BIOS update that starts to query
_OSI("Windows 2012") and that would make our video module stop creating
backlight interface and caused problem for the user. Add it to the DMI
table to disable native backlight to fix this problem.

LINK: https://bugzilla.kernel.org/show_bug.cgi?id=81691
LINK: https://bugzilla.kernel.org/show_bug.cgi?id=51231
Cc: 3.16+ <stable@vger.kernel.org> # 3.16+
Reported-and-tested-by: Yves-Alexis Perez <corsac@debian.org>
Signed-off-by: Aaron Lu <aaron.lu@intel.com>
---
 drivers/acpi/video.c | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/drivers/acpi/video.c b/drivers/acpi/video.c
index fcbda105616e..8e7e18567ae6 100644
--- a/drivers/acpi/video.c
+++ b/drivers/acpi/video.c
@@ -750,6 +750,14 @@ static struct dmi_system_id video_dmi_table[] __initdata = {
 		DMI_MATCH(DMI_PRODUCT_VERSION, "ThinkPad T520"),
 		},
 	},
+	{
+	 .callback = video_disable_native_backlight,
+	 .ident = "ThinkPad X201s",
+	 .matches = {
+		DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
+		DMI_MATCH(DMI_PRODUCT_VERSION, "ThinkPad X201s"),
+		},
+	},
 
 	/* The native backlight controls do not work on some older machines */
 	{
-- 
1.9.3


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] ACPI / video: disable native backlight for ThinkPad X201s
  2014-09-19  2:01 [PATCH] ACPI / video: disable native backlight for ThinkPad X201s Aaron Lu
@ 2014-09-22 14:02 ` Rafael J. Wysocki
  0 siblings, 0 replies; 2+ messages in thread
From: Rafael J. Wysocki @ 2014-09-22 14:02 UTC (permalink / raw)
  To: Aaron Lu; +Cc: Yves-Alexis Perez, Hans de Goede, ACPI Devel Mailing List

On Friday, September 19, 2014 10:01:18 AM Aaron Lu wrote:
> The ThinkPad X201s has a working ACPI video backlight interface and is
> shipped before Win8; then there is BIOS update that starts to query
> _OSI("Windows 2012") and that would make our video module stop creating
> backlight interface and caused problem for the user. Add it to the DMI
> table to disable native backlight to fix this problem.
> 
> LINK: https://bugzilla.kernel.org/show_bug.cgi?id=81691
> LINK: https://bugzilla.kernel.org/show_bug.cgi?id=51231
> Cc: 3.16+ <stable@vger.kernel.org> # 3.16+
> Reported-and-tested-by: Yves-Alexis Perez <corsac@debian.org>
> Signed-off-by: Aaron Lu <aaron.lu@intel.com>

Queued up for 3.17-rc7, thanks!

> ---
>  drivers/acpi/video.c | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/drivers/acpi/video.c b/drivers/acpi/video.c
> index fcbda105616e..8e7e18567ae6 100644
> --- a/drivers/acpi/video.c
> +++ b/drivers/acpi/video.c
> @@ -750,6 +750,14 @@ static struct dmi_system_id video_dmi_table[] __initdata = {
>  		DMI_MATCH(DMI_PRODUCT_VERSION, "ThinkPad T520"),
>  		},
>  	},
> +	{
> +	 .callback = video_disable_native_backlight,
> +	 .ident = "ThinkPad X201s",
> +	 .matches = {
> +		DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
> +		DMI_MATCH(DMI_PRODUCT_VERSION, "ThinkPad X201s"),
> +		},
> +	},
>  
>  	/* The native backlight controls do not work on some older machines */
>  	{
> 

-- 
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2014-09-22 13:42 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-09-19  2:01 [PATCH] ACPI / video: disable native backlight for ThinkPad X201s Aaron Lu
2014-09-22 14:02 ` Rafael J. Wysocki

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.