KVM: remove Kconfig symbol KVM_VFIO?

KVM: remove Kconfig symbol KVM_VFIO?

[Paul Bolle]

Will,

Your commit 80ce1639727e ("KVM: VFIO: register kvm_device_ops
dynamically") is included in linux-next since next-20140918. It removes
the last usage of CONFIG_KVM_VFIO. After that commit setting KVM_VFIO is
pointless.

Is the patch to remove the Kconfig symbol KVM_VFIO from the tree queued
somewhere? If not, should I submit a trivial patch that does that?


Paul Bolle

Re: KVM: remove Kconfig symbol KVM_VFIO?

[Paolo Bonzini]

Il 23/09/2014 21:09, Paul Bolle ha scritto:
> Will,
> 
> Your commit 80ce1639727e ("KVM: VFIO: register kvm_device_ops
> dynamically") is included in linux-next since next-20140918. It removes
> the last usage of CONFIG_KVM_VFIO. After that commit setting KVM_VFIO is
> pointless.
> 
> Is the patch to remove the Kconfig symbol KVM_VFIO from the tree queued
> somewhere? If not, should I submit a trivial patch that does that?

No, if you send that yourself it will be appreciated.  Thanks!

Paolo

[PATCH] [next-20140923] KVM: Remove KVM_VFIO

[Paul Bolle]

There are no checks for CONFIG_KVM_VFIO and nothing depends on KVM_VFIO.
Setting KVM_VFIO has no effect. Remove that Kconfig symbol.

Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
---
I choose not to mention commit 80ce1639727e ("KVM: VFIO: register
kvm_device_ops dynamically") as references to linux-next commits might
go stale and only confuse future readers.

Done on top of next-21040923. Tested with "git grep" only.

 arch/x86/kvm/Kconfig | 1 -
 virt/kvm/Kconfig     | 3 ---
 2 files changed, 4 deletions(-)

diff --git a/arch/x86/kvm/Kconfig b/arch/x86/kvm/Kconfig
index f9d16ff56c6b..178d872734b1 100644
--- a/arch/x86/kvm/Kconfig
+++ b/arch/x86/kvm/Kconfig
@@ -39,7 +39,6 @@ config KVM
 	select PERF_EVENTS
 	select HAVE_KVM_MSI
 	select HAVE_KVM_CPU_RELAX_INTERCEPT
-	select KVM_VFIO
 	---help---
 	  Support hosting fully virtualized guest machines using hardware
 	  virtualization extensions.  You will need a fairly recent
diff --git a/virt/kvm/Kconfig b/virt/kvm/Kconfig
index fc0c5e603eb4..1f5ebc4693c3 100644
--- a/virt/kvm/Kconfig
+++ b/virt/kvm/Kconfig
@@ -34,6 +34,3 @@ config HAVE_KVM_MSI
 
 config HAVE_KVM_CPU_RELAX_INTERCEPT
        bool
-
-config KVM_VFIO
-       bool
-- 
1.9.3

Re: [PATCH] [next-20140923] KVM: Remove KVM_VFIO

[Paolo Bonzini]

Il 24/09/2014 10:22, Paul Bolle ha scritto:
> There are no checks for CONFIG_KVM_VFIO and nothing depends on KVM_VFIO.
> Setting KVM_VFIO has no effect. Remove that Kconfig symbol.
> 
> Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
> ---
> I choose not to mention commit 80ce1639727e ("KVM: VFIO: register
> kvm_device_ops dynamically") as references to linux-next commits might
> go stale and only confuse future readers.

In the case of KVM, linux-commit hashes are substantially stable.  I'll
add back the reference.

Thanks for the patch, I'll apply it.

Paolo