All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Wanpeng Li <kernellwp@gmail.com>,
	Wanpeng Li <wanpeng.li@linux.intel.com>,
	Andres Lagar-Cavilla <andreslc@google.com>
Cc: Gleb Natapov <gleb@kernel.org>, Radim Krcmar <rkrcmar@redhat.com>,
	Rik van Riel <riel@redhat.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Andrea Arcangeli <aarcange@redhat.com>,
	Peter Feiner <pfeiner@google.com>,
	kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-mm@kvack.org
Subject: Re: [PATCH v4] kvm: Fix page ageing bugs
Date: Wed, 24 Sep 2014 10:27:55 +0200	[thread overview]
Message-ID: <5422808B.5070002@redhat.com> (raw)
In-Reply-To: <542270BA.4090708@gmail.com>

Il 24/09/2014 09:20, Wanpeng Li ha scritto:
> 
> This trace point still dup duplicated message for the same gfn in the
> for loop.

Yes, but the gfn argument lets you take it out again.

Note that having the duplicated trace would make sense if you included
the accessed bit for each spte, instead of just the "young" variable.

Paolo

WARNING: multiple messages have this Message-ID (diff)
From: Paolo Bonzini <pbonzini@redhat.com>
To: Wanpeng Li <kernellwp@gmail.com>,
	Wanpeng Li <wanpeng.li@linux.intel.com>,
	Andres Lagar-Cavilla <andreslc@google.com>
Cc: Gleb Natapov <gleb@kernel.org>, Radim Krcmar <rkrcmar@redhat.com>,
	Rik van Riel <riel@redhat.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Andrea Arcangeli <aarcange@redhat.com>,
	Peter Feiner <pfeiner@google.com>,
	kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-mm@kvack.org
Subject: Re: [PATCH v4] kvm: Fix page ageing bugs
Date: Wed, 24 Sep 2014 10:27:55 +0200	[thread overview]
Message-ID: <5422808B.5070002@redhat.com> (raw)
In-Reply-To: <542270BA.4090708@gmail.com>

Il 24/09/2014 09:20, Wanpeng Li ha scritto:
> 
> This trace point still dup duplicated message for the same gfn in the
> for loop.

Yes, but the gfn argument lets you take it out again.

Note that having the duplicated trace would make sense if you included
the accessed bit for each spte, instead of just the "young" variable.

Paolo

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2014-09-24  8:28 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-22 18:34 [PATCH] kvm: Fix page ageing bugs Andres Lagar-Cavilla
2014-09-22 18:34 ` Andres Lagar-Cavilla
2014-09-22 20:00 ` [PATCH v2] " Andres Lagar-Cavilla
2014-09-22 20:00   ` Andres Lagar-Cavilla
2014-09-22 20:26 ` [PATCH v3] " Andres Lagar-Cavilla
2014-09-22 20:26   ` Andres Lagar-Cavilla
2014-09-22 21:48   ` Paolo Bonzini
2014-09-22 21:48     ` Paolo Bonzini
2014-09-22 21:54     ` Andres Lagar-Cavilla
2014-09-22 21:54       ` Andres Lagar-Cavilla
2014-09-22 21:54 ` [PATCH v4] " Andres Lagar-Cavilla
2014-09-22 21:54   ` Andres Lagar-Cavilla
2014-09-23  7:49   ` Paolo Bonzini
2014-09-23  7:49     ` Paolo Bonzini
2014-09-23 17:04     ` Andres Lagar-Cavilla
2014-09-23 17:04       ` Andres Lagar-Cavilla
2014-09-23 17:05       ` Paolo Bonzini
2014-09-23 17:05         ` Paolo Bonzini
2014-09-24  2:27   ` Wanpeng Li
2014-09-24  2:27     ` Wanpeng Li
2014-09-24  7:04     ` Paolo Bonzini
2014-09-24  7:04       ` Paolo Bonzini
2014-09-24  7:20       ` Wanpeng Li
2014-09-24  7:20         ` Wanpeng Li
2014-09-24  7:20         ` Wanpeng Li
2014-09-24  8:27         ` Paolo Bonzini [this message]
2014-09-24  8:27           ` Paolo Bonzini
2014-09-24 17:17           ` Andres Lagar-Cavilla
2014-09-24 17:17             ` Andres Lagar-Cavilla

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5422808B.5070002@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=aarcange@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=andreslc@google.com \
    --cc=gleb@kernel.org \
    --cc=kernellwp@gmail.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=pfeiner@google.com \
    --cc=riel@redhat.com \
    --cc=rkrcmar@redhat.com \
    --cc=wanpeng.li@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.