All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chris Metcalf <cmetcalf@tilera.com>
To: Sasha Levin <sasha.levin@oracle.com>, <akpm@linux-foundation.org>
Cc: <kirill.shutemov@linux.intel.com>, <khlebnikov@openvz.org>,
	<riel@redhat.com>, <mgorman@suse.de>, <n-horiguchi@ah.jp.nec.com>,
	<mhocko@suse.cz>, <hughd@google.com>, <vbabka@suse.cz>,
	<walken@google.com>, <minchan@kernel.org>,
	<linux-kernel@vger.kernel.org>, <linux-mm@kvack.org>
Subject: Re: [PATCH 2/3] mm: introduce VM_BUG_ON_MM
Date: Wed, 24 Sep 2014 13:04:35 -0400	[thread overview]
Message-ID: <5422F9A3.2010303@tilera.com> (raw)
In-Reply-To: <1410032326-4380-2-git-send-email-sasha.levin@oracle.com>

On 9/6/2014 3:40 PM, Sasha Levin wrote:
> Very similar to VM_BUG_ON_PAGE and VM_BUG_ON_VMA, dump struct_mm
> when the bug is hit.
>
> Signed-off-by: Sasha Levin <sasha.levin@oracle.com>
> ---
>   include/linux/mmdebug.h |   10 +++++++
>   mm/debug.c              |   69 +++++++++++++++++++++++++++++++++++++++++++++++
>   2 files changed, 79 insertions(+)
>
> [...]
> diff --git a/mm/debug.c b/mm/debug.c
> index c19af12..8418893 100644
> --- a/mm/debug.c
> +++ b/mm/debug.c
> +#if defined(CONFIG_NUMA_BALANCING) || defined(CONFIG_COMPACTION)
> +		"tlb_flush_pending %d\n",
> +#endif

Putting the comma that separates the format string from the arguments
inside an ifdef means that if you don't build with NUMA_BALANCING or
COMPACTION you get a compile error.  Perhaps this instead:

+#if defined(CONFIG_NUMA_BALANCING) || defined(CONFIG_COMPACTION)
+		"tlb_flush_pending %d\n"
+#endif
-		mm, mm->mmap, mm->vmacache_seqnum, mm->task_size,
+		, mm, mm->mmap, mm->vmacache_seqnum, mm->task_size,

-- 
Chris Metcalf, Tilera Corp.
http://www.tilera.com

WARNING: multiple messages have this Message-ID (diff)
From: Chris Metcalf <cmetcalf@tilera.com>
To: Sasha Levin <sasha.levin@oracle.com>, akpm@linux-foundation.org
Cc: kirill.shutemov@linux.intel.com, khlebnikov@openvz.org,
	riel@redhat.com, mgorman@suse.de, n-horiguchi@ah.jp.nec.com,
	mhocko@suse.cz, hughd@google.com, vbabka@suse.cz,
	walken@google.com, minchan@kernel.org,
	linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH 2/3] mm: introduce VM_BUG_ON_MM
Date: Wed, 24 Sep 2014 13:04:35 -0400	[thread overview]
Message-ID: <5422F9A3.2010303@tilera.com> (raw)
In-Reply-To: <1410032326-4380-2-git-send-email-sasha.levin@oracle.com>

On 9/6/2014 3:40 PM, Sasha Levin wrote:
> Very similar to VM_BUG_ON_PAGE and VM_BUG_ON_VMA, dump struct_mm
> when the bug is hit.
>
> Signed-off-by: Sasha Levin <sasha.levin@oracle.com>
> ---
>   include/linux/mmdebug.h |   10 +++++++
>   mm/debug.c              |   69 +++++++++++++++++++++++++++++++++++++++++++++++
>   2 files changed, 79 insertions(+)
>
> [...]
> diff --git a/mm/debug.c b/mm/debug.c
> index c19af12..8418893 100644
> --- a/mm/debug.c
> +++ b/mm/debug.c
> +#if defined(CONFIG_NUMA_BALANCING) || defined(CONFIG_COMPACTION)
> +		"tlb_flush_pending %d\n",
> +#endif

Putting the comma that separates the format string from the arguments
inside an ifdef means that if you don't build with NUMA_BALANCING or
COMPACTION you get a compile error.  Perhaps this instead:

+#if defined(CONFIG_NUMA_BALANCING) || defined(CONFIG_COMPACTION)
+		"tlb_flush_pending %d\n"
+#endif
-		mm, mm->mmap, mm->vmacache_seqnum, mm->task_size,
+		, mm, mm->mmap, mm->vmacache_seqnum, mm->task_size,

-- 
Chris Metcalf, Tilera Corp.
http://www.tilera.com

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  parent reply	other threads:[~2014-09-24 17:04 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-06 19:38 [PATCH 1/3] mm: move debug code out of page_alloc.c Sasha Levin
2014-09-06 19:38 ` Sasha Levin
2014-09-06 19:38 ` [PATCH 2/3] mm: introduce VM_BUG_ON_MM Sasha Levin
2014-09-06 19:38   ` Sasha Levin
2014-09-11 21:16   ` Andrew Morton
2014-09-11 21:16     ` Andrew Morton
2014-09-11 22:36     ` Sasha Levin
2014-09-11 22:36       ` Sasha Levin
2014-09-24 17:04   ` Chris Metcalf [this message]
2014-09-24 17:04     ` Chris Metcalf
2014-09-06 19:38 ` [PATCH 3/3] mm: use VM_BUG_ON_MM where possible Sasha Levin
2014-09-06 19:38   ` Sasha Levin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5422F9A3.2010303@tilera.com \
    --to=cmetcalf@tilera.com \
    --cc=akpm@linux-foundation.org \
    --cc=hughd@google.com \
    --cc=khlebnikov@openvz.org \
    --cc=kirill.shutemov@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mgorman@suse.de \
    --cc=mhocko@suse.cz \
    --cc=minchan@kernel.org \
    --cc=n-horiguchi@ah.jp.nec.com \
    --cc=riel@redhat.com \
    --cc=sasha.levin@oracle.com \
    --cc=vbabka@suse.cz \
    --cc=walken@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.