From: Shannon Zhao <zhaoshenglong@huawei.com>
To: Christoffer Dall <christoffer.dall@linaro.org>,
<kvmarm@lists.cs.columbia.edu>,
<linux-arm-kernel@lists.infradead.org>
Cc: <kvm@vger.kernel.org>
Subject: Re: [PATCH] arm/arm64: KVM: Fix set_clear_sgi_pend_reg offset
Date: Fri, 26 Sep 2014 17:30:16 +0800 [thread overview]
Message-ID: <54253228.4060602@huawei.com> (raw)
In-Reply-To: <1411667347-2989-1-git-send-email-christoffer.dall@linaro.org>
On 2014/9/26 1:49, Christoffer Dall wrote:
> The sgi values calculated in read_set_clear_sgi_pend_reg() and
> write_set_clear_sgi_pend_reg() were horribly incorrectly multiplied by 4
> with catastrophic results in that subfunctions ended up overwriting
> memory not allocated for the expected purpose.
>
> This showed up as bugs in kfree() and the kernel complaining a lot of
> you turn on memory debugging.
>
> This addresses: http://marc.info/?l=kvm&m=141164910007868&w=2
>
> Reported-by: Shannon Zhao <zhaoshenglong@huawei.com>
> Signed-off-by: Christoffer Dall <christoffer.dall@linaro.org>
> ---
> virt/kvm/arm/vgic.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/virt/kvm/arm/vgic.c b/virt/kvm/arm/vgic.c
> index b6fab0f..8629678 100644
> --- a/virt/kvm/arm/vgic.c
> +++ b/virt/kvm/arm/vgic.c
> @@ -816,7 +816,7 @@ static bool read_set_clear_sgi_pend_reg(struct kvm_vcpu *vcpu,
> {
> struct vgic_dist *dist = &vcpu->kvm->arch.vgic;
> int sgi;
> - int min_sgi = (offset & ~0x3) * 4;
> + int min_sgi = (offset & ~0x3);
> int max_sgi = min_sgi + 3;
> int vcpu_id = vcpu->vcpu_id;
> u32 reg = 0;
> @@ -837,7 +837,7 @@ static bool write_set_clear_sgi_pend_reg(struct kvm_vcpu *vcpu,
> {
> struct vgic_dist *dist = &vcpu->kvm->arch.vgic;
> int sgi;
> - int min_sgi = (offset & ~0x3) * 4;
> + int min_sgi = (offset & ~0x3);
> int max_sgi = min_sgi + 3;
> int vcpu_id = vcpu->vcpu_id;
> u32 reg;
>
Tested-by: Shannon Zhao <zhaoshenglong@huawei.com>
--
Shannon
WARNING: multiple messages have this Message-ID (diff)
From: zhaoshenglong@huawei.com (Shannon Zhao)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm/arm64: KVM: Fix set_clear_sgi_pend_reg offset
Date: Fri, 26 Sep 2014 17:30:16 +0800 [thread overview]
Message-ID: <54253228.4060602@huawei.com> (raw)
In-Reply-To: <1411667347-2989-1-git-send-email-christoffer.dall@linaro.org>
On 2014/9/26 1:49, Christoffer Dall wrote:
> The sgi values calculated in read_set_clear_sgi_pend_reg() and
> write_set_clear_sgi_pend_reg() were horribly incorrectly multiplied by 4
> with catastrophic results in that subfunctions ended up overwriting
> memory not allocated for the expected purpose.
>
> This showed up as bugs in kfree() and the kernel complaining a lot of
> you turn on memory debugging.
>
> This addresses: http://marc.info/?l=kvm&m=141164910007868&w=2
>
> Reported-by: Shannon Zhao <zhaoshenglong@huawei.com>
> Signed-off-by: Christoffer Dall <christoffer.dall@linaro.org>
> ---
> virt/kvm/arm/vgic.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/virt/kvm/arm/vgic.c b/virt/kvm/arm/vgic.c
> index b6fab0f..8629678 100644
> --- a/virt/kvm/arm/vgic.c
> +++ b/virt/kvm/arm/vgic.c
> @@ -816,7 +816,7 @@ static bool read_set_clear_sgi_pend_reg(struct kvm_vcpu *vcpu,
> {
> struct vgic_dist *dist = &vcpu->kvm->arch.vgic;
> int sgi;
> - int min_sgi = (offset & ~0x3) * 4;
> + int min_sgi = (offset & ~0x3);
> int max_sgi = min_sgi + 3;
> int vcpu_id = vcpu->vcpu_id;
> u32 reg = 0;
> @@ -837,7 +837,7 @@ static bool write_set_clear_sgi_pend_reg(struct kvm_vcpu *vcpu,
> {
> struct vgic_dist *dist = &vcpu->kvm->arch.vgic;
> int sgi;
> - int min_sgi = (offset & ~0x3) * 4;
> + int min_sgi = (offset & ~0x3);
> int max_sgi = min_sgi + 3;
> int vcpu_id = vcpu->vcpu_id;
> u32 reg;
>
Tested-by: Shannon Zhao <zhaoshenglong@huawei.com>
--
Shannon
next prev parent reply other threads:[~2014-09-26 9:30 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-25 17:49 [PATCH] arm/arm64: KVM: Fix set_clear_sgi_pend_reg offset Christoffer Dall
2014-09-25 17:49 ` Christoffer Dall
2014-09-26 5:57 ` Shannon Zhao
2014-09-26 5:57 ` Shannon Zhao
2014-09-26 8:44 ` Christoffer Dall
2014-09-26 8:44 ` Christoffer Dall
2014-09-26 9:26 ` Shannon Zhao
2014-09-26 9:26 ` Shannon Zhao
2014-09-26 10:16 ` Christoffer Dall
2014-09-26 10:16 ` Christoffer Dall
2014-09-26 13:44 ` Christoffer Dall
2014-09-26 13:44 ` Christoffer Dall
2014-09-30 1:48 ` Shannon Zhao
2014-09-30 1:48 ` Shannon Zhao
2014-09-30 11:41 ` Christoffer Dall
2014-09-30 11:41 ` Christoffer Dall
2014-09-26 9:30 ` Shannon Zhao [this message]
2014-09-26 9:30 ` Shannon Zhao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54253228.4060602@huawei.com \
--to=zhaoshenglong@huawei.com \
--cc=christoffer.dall@linaro.org \
--cc=kvm@vger.kernel.org \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.