All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] rc: fix hix5hd2 build issue in 0-DAY kernel build
@ 2014-09-24 15:10 ` Zhangfei Gao
  0 siblings, 0 replies; 10+ messages in thread
From: Zhangfei Gao @ 2014-09-24 15:10 UTC (permalink / raw)
  To: Mauro Carvalho Chehab, Fengguang Wu
  Cc: linux-arm-kernel, linux-media, Zhangfei Gao

Add dependence of ARCH_HIX5HD2 to solve build error in arch like ia64
error: implicit declaration of function 'readl_relaxed' & 'writel_relaxed'

Change CONFIG_PM to CONFIG_PM_SLEEP to solve
warning: 'hix5hd2_ir_suspend' & 'hix5hd2_ir_resume' defined but not used

Reported-by: Fengguang Wu <fengguang.wu@intel.com>
Signed-off-by: Zhangfei Gao <zhangfei.gao@linaro.org>
---
 drivers/media/rc/Kconfig      |    2 +-
 drivers/media/rc/ir-hix5hd2.c |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/media/rc/Kconfig b/drivers/media/rc/Kconfig
index 01e5f7a..ff5a625 100644
--- a/drivers/media/rc/Kconfig
+++ b/drivers/media/rc/Kconfig
@@ -166,7 +166,7 @@ config IR_ENE
 
 config IR_HIX5HD2
 	tristate "Hisilicon hix5hd2 IR remote control"
-	depends on RC_CORE
+	depends on RC_CORE && ARCH_HIX5HD2
 	help
 	 Say Y here if you want to use hisilicon hix5hd2 remote control.
 	 To compile this driver as a module, choose M here: the module will be
diff --git a/drivers/media/rc/ir-hix5hd2.c b/drivers/media/rc/ir-hix5hd2.c
index 64f8257..c1d8527 100644
--- a/drivers/media/rc/ir-hix5hd2.c
+++ b/drivers/media/rc/ir-hix5hd2.c
@@ -289,7 +289,7 @@ static int hix5hd2_ir_remove(struct platform_device *pdev)
 	return 0;
 }
 
-#ifdef CONFIG_PM
+#ifdef CONFIG_PM_SLEEP
 static int hix5hd2_ir_suspend(struct device *dev)
 {
 	struct hix5hd2_ir_priv *priv = dev_get_drvdata(dev);
-- 
1.7.9.5


^ permalink raw reply related	[flat|nested] 10+ messages in thread
* [PATCH] rc: fix hix5hd2 build issue in 0-DAY kernel build
@ 2014-09-24 15:10 ` Zhangfei Gao
  0 siblings, 0 replies; 10+ messages in thread
From: Zhangfei Gao @ 2014-09-24 15:10 UTC (permalink / raw)
  To: linux-arm-kernel

Add dependence of ARCH_HIX5HD2 to solve build error in arch like ia64
error: implicit declaration of function 'readl_relaxed' & 'writel_relaxed'

Change CONFIG_PM to CONFIG_PM_SLEEP to solve
warning: 'hix5hd2_ir_suspend' & 'hix5hd2_ir_resume' defined but not used

Reported-by: Fengguang Wu <fengguang.wu@intel.com>
Signed-off-by: Zhangfei Gao <zhangfei.gao@linaro.org>
---
 drivers/media/rc/Kconfig      |    2 +-
 drivers/media/rc/ir-hix5hd2.c |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/media/rc/Kconfig b/drivers/media/rc/Kconfig
index 01e5f7a..ff5a625 100644
--- a/drivers/media/rc/Kconfig
+++ b/drivers/media/rc/Kconfig
@@ -166,7 +166,7 @@ config IR_ENE
 
 config IR_HIX5HD2
 	tristate "Hisilicon hix5hd2 IR remote control"
-	depends on RC_CORE
+	depends on RC_CORE && ARCH_HIX5HD2
 	help
 	 Say Y here if you want to use hisilicon hix5hd2 remote control.
 	 To compile this driver as a module, choose M here: the module will be
diff --git a/drivers/media/rc/ir-hix5hd2.c b/drivers/media/rc/ir-hix5hd2.c
index 64f8257..c1d8527 100644
--- a/drivers/media/rc/ir-hix5hd2.c
+++ b/drivers/media/rc/ir-hix5hd2.c
@@ -289,7 +289,7 @@ static int hix5hd2_ir_remove(struct platform_device *pdev)
 	return 0;
 }
 
-#ifdef CONFIG_PM
+#ifdef CONFIG_PM_SLEEP
 static int hix5hd2_ir_suspend(struct device *dev)
 {
 	struct hix5hd2_ir_priv *priv = dev_get_drvdata(dev);
-- 
1.7.9.5

^ permalink raw reply related	[flat|nested] 10+ messages in thread
* [PATCH] [media] rc: fix hix5hd2 compile-test issue
  2014-09-24 15:10 ` Zhangfei Gao
@ 2014-09-26 12:57   ` Zhangfei Gao
  -1 siblings, 0 replies; 10+ messages in thread
From: Zhangfei Gao @ 2014-09-26 12:57 UTC (permalink / raw)
  To: m.chehab; +Cc: linux-arm-kernel, linux-media, Zhangfei Gao

Add dependence to solve build error in arch like ia64
error: implicit declaration of function 'readl_relaxed' & 'writel_relaxed'

Change CONFIG_PM to CONFIG_PM_SLEEP to solve
warning: 'hix5hd2_ir_suspend' & 'hix5hd2_ir_resume' defined but not used

Reported-by: Fengguang Wu <fengguang.wu@intel.com>
Signed-off-by: Zhangfei Gao <zhangfei.gao@linaro.org>
---
 drivers/media/rc/Kconfig      |    2 +-
 drivers/media/rc/ir-hix5hd2.c |    7 +------
 2 files changed, 2 insertions(+), 7 deletions(-)

diff --git a/drivers/media/rc/Kconfig b/drivers/media/rc/Kconfig
index 8ce08107a69d..28fb2cb34e8d 100644
--- a/drivers/media/rc/Kconfig
+++ b/drivers/media/rc/Kconfig
@@ -166,7 +166,7 @@ config IR_ENE
 
 config IR_HIX5HD2
 	tristate "Hisilicon hix5hd2 IR remote control"
-	depends on RC_CORE
+	depends on RC_CORE && ARM
 	help
 	 Say Y here if you want to use hisilicon hix5hd2 remote control.
 	 To compile this driver as a module, choose M here: the module will be
diff --git a/drivers/media/rc/ir-hix5hd2.c b/drivers/media/rc/ir-hix5hd2.c
index 94967d0e0478..c1d8527ace92 100644
--- a/drivers/media/rc/ir-hix5hd2.c
+++ b/drivers/media/rc/ir-hix5hd2.c
@@ -16,11 +16,6 @@
 #include <linux/regmap.h>
 #include <media/rc-core.h>
 
-/* Allow the driver to compile on all architectures */
-#ifndef writel_relaxed
-# define writel_relaxed writel
-#endif
-
 #define IR_ENABLE		0x00
 #define IR_CONFIG		0x04
 #define CNT_LEADS		0x08
@@ -294,7 +289,7 @@ static int hix5hd2_ir_remove(struct platform_device *pdev)
 	return 0;
 }
 
-#ifdef CONFIG_PM
+#ifdef CONFIG_PM_SLEEP
 static int hix5hd2_ir_suspend(struct device *dev)
 {
 	struct hix5hd2_ir_priv *priv = dev_get_drvdata(dev);
-- 
1.7.9.5


^ permalink raw reply related	[flat|nested] 10+ messages in thread
* [PATCH] [media] rc: fix hix5hd2 compile-test issue
@ 2014-09-26 12:57   ` Zhangfei Gao
  0 siblings, 0 replies; 10+ messages in thread
From: Zhangfei Gao @ 2014-09-26 12:57 UTC (permalink / raw)
  To: linux-arm-kernel

Add dependence to solve build error in arch like ia64
error: implicit declaration of function 'readl_relaxed' & 'writel_relaxed'

Change CONFIG_PM to CONFIG_PM_SLEEP to solve
warning: 'hix5hd2_ir_suspend' & 'hix5hd2_ir_resume' defined but not used

Reported-by: Fengguang Wu <fengguang.wu@intel.com>
Signed-off-by: Zhangfei Gao <zhangfei.gao@linaro.org>
---
 drivers/media/rc/Kconfig      |    2 +-
 drivers/media/rc/ir-hix5hd2.c |    7 +------
 2 files changed, 2 insertions(+), 7 deletions(-)

diff --git a/drivers/media/rc/Kconfig b/drivers/media/rc/Kconfig
index 8ce08107a69d..28fb2cb34e8d 100644
--- a/drivers/media/rc/Kconfig
+++ b/drivers/media/rc/Kconfig
@@ -166,7 +166,7 @@ config IR_ENE
 
 config IR_HIX5HD2
 	tristate "Hisilicon hix5hd2 IR remote control"
-	depends on RC_CORE
+	depends on RC_CORE && ARM
 	help
 	 Say Y here if you want to use hisilicon hix5hd2 remote control.
 	 To compile this driver as a module, choose M here: the module will be
diff --git a/drivers/media/rc/ir-hix5hd2.c b/drivers/media/rc/ir-hix5hd2.c
index 94967d0e0478..c1d8527ace92 100644
--- a/drivers/media/rc/ir-hix5hd2.c
+++ b/drivers/media/rc/ir-hix5hd2.c
@@ -16,11 +16,6 @@
 #include <linux/regmap.h>
 #include <media/rc-core.h>
 
-/* Allow the driver to compile on all architectures */
-#ifndef writel_relaxed
-# define writel_relaxed writel
-#endif
-
 #define IR_ENABLE		0x00
 #define IR_CONFIG		0x04
 #define CNT_LEADS		0x08
@@ -294,7 +289,7 @@ static int hix5hd2_ir_remove(struct platform_device *pdev)
 	return 0;
 }
 
-#ifdef CONFIG_PM
+#ifdef CONFIG_PM_SLEEP
 static int hix5hd2_ir_suspend(struct device *dev)
 {
 	struct hix5hd2_ir_priv *priv = dev_get_drvdata(dev);
-- 
1.7.9.5

^ permalink raw reply related	[flat|nested] 10+ messages in thread
* Re: [PATCH] [media] rc: fix hix5hd2 compile-test issue
  2014-09-26 12:57   ` Zhangfei Gao
@ 2014-09-26 13:12     ` Russell King - ARM Linux
  -1 siblings, 0 replies; 10+ messages in thread
From: Russell King - ARM Linux @ 2014-09-26 13:12 UTC (permalink / raw)
  To: Zhangfei Gao; +Cc: m.chehab, linux-arm-kernel, linux-media

On Fri, Sep 26, 2014 at 08:57:30PM +0800, Zhangfei Gao wrote:
> Add dependence to solve build error in arch like ia64
> error: implicit declaration of function 'readl_relaxed' & 'writel_relaxed'
> 
> Change CONFIG_PM to CONFIG_PM_SLEEP to solve
> warning: 'hix5hd2_ir_suspend' & 'hix5hd2_ir_resume' defined but not used

There is work currently in progress (in linux-next) to provide
asm-generic accessors for the above.

-- 
FTTC broadband for 0.8mile line: currently at 9.5Mbps down 400kbps up
according to speedtest.net.

^ permalink raw reply	[flat|nested] 10+ messages in thread
* [PATCH] [media] rc: fix hix5hd2 compile-test issue
@ 2014-09-26 13:12     ` Russell King - ARM Linux
  0 siblings, 0 replies; 10+ messages in thread
From: Russell King - ARM Linux @ 2014-09-26 13:12 UTC (permalink / raw)
  To: linux-arm-kernel

On Fri, Sep 26, 2014 at 08:57:30PM +0800, Zhangfei Gao wrote:
> Add dependence to solve build error in arch like ia64
> error: implicit declaration of function 'readl_relaxed' & 'writel_relaxed'
> 
> Change CONFIG_PM to CONFIG_PM_SLEEP to solve
> warning: 'hix5hd2_ir_suspend' & 'hix5hd2_ir_resume' defined but not used

There is work currently in progress (in linux-next) to provide
asm-generic accessors for the above.

-- 
FTTC broadband for 0.8mile line: currently at 9.5Mbps down 400kbps up
according to speedtest.net.

^ permalink raw reply	[flat|nested] 10+ messages in thread
* Re: [PATCH] [media] rc: fix hix5hd2 compile-test issue
  2014-09-26 13:12     ` Russell King - ARM Linux
@ 2014-09-26 14:06       ` zhangfei
  -1 siblings, 0 replies; 10+ messages in thread
From: zhangfei @ 2014-09-26 14:06 UTC (permalink / raw)
  To: Russell King - ARM Linux; +Cc: m.chehab, linux-arm-kernel, linux-media



On 09/26/2014 09:12 PM, Russell King - ARM Linux wrote:
> On Fri, Sep 26, 2014 at 08:57:30PM +0800, Zhangfei Gao wrote:
>> Add dependence to solve build error in arch like ia64
>> error: implicit declaration of function 'readl_relaxed' & 'writel_relaxed'
>>
>> Change CONFIG_PM to CONFIG_PM_SLEEP to solve
>> warning: 'hix5hd2_ir_suspend' & 'hix5hd2_ir_resume' defined but not used
>
> There is work currently in progress (in linux-next) to provide
> asm-generic accessors for the above.

Thanks Russell for the info.

Have found the patch set about "asm-generic: io: implement relaxed 
accessor macros as conditional wrappers".

That's great.

Thanks


^ permalink raw reply	[flat|nested] 10+ messages in thread
* [PATCH] [media] rc: fix hix5hd2 compile-test issue
@ 2014-09-26 14:06       ` zhangfei
  0 siblings, 0 replies; 10+ messages in thread
From: zhangfei @ 2014-09-26 14:06 UTC (permalink / raw)
  To: linux-arm-kernel



On 09/26/2014 09:12 PM, Russell King - ARM Linux wrote:
> On Fri, Sep 26, 2014 at 08:57:30PM +0800, Zhangfei Gao wrote:
>> Add dependence to solve build error in arch like ia64
>> error: implicit declaration of function 'readl_relaxed' & 'writel_relaxed'
>>
>> Change CONFIG_PM to CONFIG_PM_SLEEP to solve
>> warning: 'hix5hd2_ir_suspend' & 'hix5hd2_ir_resume' defined but not used
>
> There is work currently in progress (in linux-next) to provide
> asm-generic accessors for the above.

Thanks Russell for the info.

Have found the patch set about "asm-generic: io: implement relaxed 
accessor macros as conditional wrappers".

That's great.

Thanks

^ permalink raw reply	[flat|nested] 10+ messages in thread
* [PATCH] [media] rc: fix hix5hd2 compile-test issue
  2014-09-26 12:57   ` Zhangfei Gao
@ 2014-09-29  6:00     ` Zhangfei Gao
  -1 siblings, 0 replies; 10+ messages in thread
From: Zhangfei Gao @ 2014-09-29  6:00 UTC (permalink / raw)
  To: Mauro Carvalho Chehab; +Cc: linux-arm-kernel, linux-media, Zhangfei Gao

Commit 4c255791ffd6410f ("asm-generic: io: implement relaxed accessor
macros as conditional wrappers") adds wrappers to asm-generic of
{read,write}{b,w,l,q}_relaxed.

Change CONFIG_PM to CONFIG_PM_SLEEP to solve
warning: 'hix5hd2_ir_suspend' & 'hix5hd2_ir_resume' defined but not used

Reported-by: Fengguang Wu <fengguang.wu@intel.com>
Signed-off-by: Zhangfei Gao <zhangfei.gao@linaro.org>
---
 drivers/media/rc/ir-hix5hd2.c |    7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)

diff --git a/drivers/media/rc/ir-hix5hd2.c b/drivers/media/rc/ir-hix5hd2.c
index c555ca2aed0e..58ec5986274e 100644
--- a/drivers/media/rc/ir-hix5hd2.c
+++ b/drivers/media/rc/ir-hix5hd2.c
@@ -16,11 +16,6 @@
 #include <linux/regmap.h>
 #include <media/rc-core.h>
 
-/* Allow the driver to compile on all architectures */
-#ifndef writel_relaxed
-# define writel_relaxed writel
-#endif
-
 #define IR_ENABLE		0x00
 #define IR_CONFIG		0x04
 #define CNT_LEADS		0x08
@@ -294,7 +289,7 @@ static int hix5hd2_ir_remove(struct platform_device *pdev)
 	return 0;
 }
 
-#ifdef CONFIG_PM
+#ifdef CONFIG_PM_SLEEP
 static int hix5hd2_ir_suspend(struct device *dev)
 {
 	struct hix5hd2_ir_priv *priv = dev_get_drvdata(dev);
-- 
1.7.9.5


^ permalink raw reply related	[flat|nested] 10+ messages in thread
* [PATCH] [media] rc: fix hix5hd2 compile-test issue
@ 2014-09-29  6:00     ` Zhangfei Gao
  0 siblings, 0 replies; 10+ messages in thread
From: Zhangfei Gao @ 2014-09-29  6:00 UTC (permalink / raw)
  To: linux-arm-kernel

Commit 4c255791ffd6410f ("asm-generic: io: implement relaxed accessor
macros as conditional wrappers") adds wrappers to asm-generic of
{read,write}{b,w,l,q}_relaxed.

Change CONFIG_PM to CONFIG_PM_SLEEP to solve
warning: 'hix5hd2_ir_suspend' & 'hix5hd2_ir_resume' defined but not used

Reported-by: Fengguang Wu <fengguang.wu@intel.com>
Signed-off-by: Zhangfei Gao <zhangfei.gao@linaro.org>
---
 drivers/media/rc/ir-hix5hd2.c |    7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)

diff --git a/drivers/media/rc/ir-hix5hd2.c b/drivers/media/rc/ir-hix5hd2.c
index c555ca2aed0e..58ec5986274e 100644
--- a/drivers/media/rc/ir-hix5hd2.c
+++ b/drivers/media/rc/ir-hix5hd2.c
@@ -16,11 +16,6 @@
 #include <linux/regmap.h>
 #include <media/rc-core.h>
 
-/* Allow the driver to compile on all architectures */
-#ifndef writel_relaxed
-# define writel_relaxed writel
-#endif
-
 #define IR_ENABLE		0x00
 #define IR_CONFIG		0x04
 #define CNT_LEADS		0x08
@@ -294,7 +289,7 @@ static int hix5hd2_ir_remove(struct platform_device *pdev)
 	return 0;
 }
 
-#ifdef CONFIG_PM
+#ifdef CONFIG_PM_SLEEP
 static int hix5hd2_ir_suspend(struct device *dev)
 {
 	struct hix5hd2_ir_priv *priv = dev_get_drvdata(dev);
-- 
1.7.9.5

^ permalink raw reply related	[flat|nested] 10+ messages in thread
end of thread, other threads:[~2014-09-29  6:01 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-09-24 15:10 [PATCH] rc: fix hix5hd2 build issue in 0-DAY kernel build Zhangfei Gao
2014-09-24 15:10 ` Zhangfei Gao
2014-09-26 12:57 ` [PATCH] [media] rc: fix hix5hd2 compile-test issue Zhangfei Gao
2014-09-26 12:57   ` Zhangfei Gao
2014-09-26 13:12   ` Russell King - ARM Linux
2014-09-26 13:12     ` Russell King - ARM Linux
2014-09-26 14:06     ` zhangfei
2014-09-26 14:06       ` zhangfei
2014-09-29  6:00   ` Zhangfei Gao
2014-09-29  6:00     ` Zhangfei Gao

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.