All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v3] ARM: DT: apq8064: add CM-QS600 board
@ 2014-09-26 16:32 ` Mike Rapoport
  0 siblings, 0 replies; 6+ messages in thread
From: Mike Rapoport @ 2014-09-26 16:32 UTC (permalink / raw)
  To: Kumar Gala
  Cc: Srinivas Kandagatla, Bjorn Andersson, linux-arm-msm,
	linux-arm-kernel, Mike Rapoport

CM-QS600 is a APQ8064 based computer on module.
The details are available at
http://compulab.co.il/products/computer-on-modules/cm-qs600/

Signed-off-by: Mike Rapoport <mike.rapoport@gmail.com>
---
v2 changes: duplicate the settings for the cm-qs600 board in its .dts file as Kumar suggested
v3 changes: add board details and keep dts Makefile sorted alphabetically

 arch/arm/boot/dts/Makefile                  |  1 +
 arch/arm/boot/dts/qcom-apq8064-cm-qs600.dts | 59 +++++++++++++++++++++++++++++
 2 files changed, 60 insertions(+)
 create mode 100644 arch/arm/boot/dts/qcom-apq8064-cm-qs600.dts

diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
index aaa1a68..3243722 100644
--- a/arch/arm/boot/dts/Makefile
+++ b/arch/arm/boot/dts/Makefile
@@ -339,6 +339,7 @@ dtb-$(CONFIG_ARCH_ORION5X) += orion5x-lacie-d2-network.dtb \
 	orion5x-rd88f5182-nas.dtb
 dtb-$(CONFIG_ARCH_PRIMA2) += prima2-evb.dtb
 dtb-$(CONFIG_ARCH_QCOM) += \
+	qcom-apq8064-cm-qs600.dtb \
 	qcom-apq8064-ifc6410.dtb \
 	qcom-apq8074-dragonboard.dtb \
 	qcom-apq8084-ifc6540.dtb \aaaaaa
diff --git a/arch/arm/boot/dts/qcom-apq8064-cm-qs600.dts b/arch/arm/boot/dts/qcom-apq8064-cm-qs600.dts
new file mode 100644
index 0000000..db7cf03
--- /dev/null
+++ b/arch/arm/boot/dts/qcom-apq8064-cm-qs600.dts
@@ -0,0 +1,59 @@
+#include "qcom-apq8064-v2.0.dtsi"
+
+/ {
+	model = "CompuLab CM-QS600";
+	compatible = "qcom,apq8064-cm-qs600", "qcom,apq8064";
+
+	soc {
+		pinctrl@800000 {
+			i2c1_pins: i2c1 {
+				mux {
+					pins = "gpio20", "gpio21";
+					function = "gsbi1";
+				};
+			};
+		};
+
+		gsbi@12440000 {
+			status = "okay";
+			qcom,mode = <GSBI_PROT_I2C>;
+
+			i2c@12460000 {
+				status = "okay";
+				clock-frequency = <200000>;
+				pinctrl-0 = <&i2c1_pins>;
+				pinctrl-names = "default";
+
+				eeprom: eeprom@52 {
+					compatible = "atmel,24c128";
+					reg = <0x52>;
+					pagesize = <32>;
+				};
+			};
+		};
+
+		gsbi@16600000 {
+			status = "ok";
+			qcom,mode = <GSBI_PROT_I2C_UART>;
+			serial@16640000 {
+				status = "ok";
+			};
+		};
+
+		amba {
+			/* eMMC */
+			sdcc1: sdcc@12400000 {
+				status = "okay";
+			};
+
+			/* External micro SD card */
+			sdcc3: sdcc@12180000 {
+				status = "okay";
+			};
+			/* WLAN */
+			sdcc4: sdcc@121c0000 {
+				status = "okay";
+			};
+		};
+	};
+};
-- 
1.9.1

^ permalink raw reply related	[flat|nested] 6+ messages in thread
* [PATCH v3] ARM: DT: apq8064: add CM-QS600 board
@ 2014-09-26 16:32 ` Mike Rapoport
  0 siblings, 0 replies; 6+ messages in thread
From: Mike Rapoport @ 2014-09-26 16:32 UTC (permalink / raw)
  To: linux-arm-kernel

CM-QS600 is a APQ8064 based computer on module.
The details are available at
http://compulab.co.il/products/computer-on-modules/cm-qs600/

Signed-off-by: Mike Rapoport <mike.rapoport@gmail.com>
---
v2 changes: duplicate the settings for the cm-qs600 board in its .dts file as Kumar suggested
v3 changes: add board details and keep dts Makefile sorted alphabetically

 arch/arm/boot/dts/Makefile                  |  1 +
 arch/arm/boot/dts/qcom-apq8064-cm-qs600.dts | 59 +++++++++++++++++++++++++++++
 2 files changed, 60 insertions(+)
 create mode 100644 arch/arm/boot/dts/qcom-apq8064-cm-qs600.dts

diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
index aaa1a68..3243722 100644
--- a/arch/arm/boot/dts/Makefile
+++ b/arch/arm/boot/dts/Makefile
@@ -339,6 +339,7 @@ dtb-$(CONFIG_ARCH_ORION5X) += orion5x-lacie-d2-network.dtb \
 	orion5x-rd88f5182-nas.dtb
 dtb-$(CONFIG_ARCH_PRIMA2) += prima2-evb.dtb
 dtb-$(CONFIG_ARCH_QCOM) += \
+	qcom-apq8064-cm-qs600.dtb \
 	qcom-apq8064-ifc6410.dtb \
 	qcom-apq8074-dragonboard.dtb \
 	qcom-apq8084-ifc6540.dtb \aaaaaa
diff --git a/arch/arm/boot/dts/qcom-apq8064-cm-qs600.dts b/arch/arm/boot/dts/qcom-apq8064-cm-qs600.dts
new file mode 100644
index 0000000..db7cf03
--- /dev/null
+++ b/arch/arm/boot/dts/qcom-apq8064-cm-qs600.dts
@@ -0,0 +1,59 @@
+#include "qcom-apq8064-v2.0.dtsi"
+
+/ {
+	model = "CompuLab CM-QS600";
+	compatible = "qcom,apq8064-cm-qs600", "qcom,apq8064";
+
+	soc {
+		pinctrl at 800000 {
+			i2c1_pins: i2c1 {
+				mux {
+					pins = "gpio20", "gpio21";
+					function = "gsbi1";
+				};
+			};
+		};
+
+		gsbi at 12440000 {
+			status = "okay";
+			qcom,mode = <GSBI_PROT_I2C>;
+
+			i2c at 12460000 {
+				status = "okay";
+				clock-frequency = <200000>;
+				pinctrl-0 = <&i2c1_pins>;
+				pinctrl-names = "default";
+
+				eeprom: eeprom at 52 {
+					compatible = "atmel,24c128";
+					reg = <0x52>;
+					pagesize = <32>;
+				};
+			};
+		};
+
+		gsbi at 16600000 {
+			status = "ok";
+			qcom,mode = <GSBI_PROT_I2C_UART>;
+			serial at 16640000 {
+				status = "ok";
+			};
+		};
+
+		amba {
+			/* eMMC */
+			sdcc1: sdcc at 12400000 {
+				status = "okay";
+			};
+
+			/* External micro SD card */
+			sdcc3: sdcc at 12180000 {
+				status = "okay";
+			};
+			/* WLAN */
+			sdcc4: sdcc at 121c0000 {
+				status = "okay";
+			};
+		};
+	};
+};
-- 
1.9.1

^ permalink raw reply related	[flat|nested] 6+ messages in thread
* Re: [PATCH v3] ARM: DT: apq8064: add CM-QS600 board
  2014-09-26 16:32 ` Mike Rapoport
@ 2014-09-29  9:35   ` Igor Grinberg
  -1 siblings, 0 replies; 6+ messages in thread
From: Igor Grinberg @ 2014-09-29  9:35 UTC (permalink / raw)
  To: Mike Rapoport, Kumar Gala
  Cc: linux-arm-msm, Srinivas Kandagatla, Bjorn Andersson, linux-arm-kernel

Hi Mike,

On 09/26/14 19:32, Mike Rapoport wrote:
> CM-QS600 is a APQ8064 based computer on module.
> The details are available at
> http://compulab.co.il/products/computer-on-modules/cm-qs600/
> 
> Signed-off-by: Mike Rapoport <mike.rapoport@gmail.com>

Thanks for working on this!
Some minor notes...

Can we have the subject aligned with other submissions, e.g.
ARM: dts: qcom: ...
?

> ---
> v2 changes: duplicate the settings for the cm-qs600 board in its .dts file as Kumar suggested
> v3 changes: add board details and keep dts Makefile sorted alphabetically

[...]

> new file mode 100644
> index 0000000..db7cf03
> --- /dev/null
> +++ b/arch/arm/boot/dts/qcom-apq8064-cm-qs600.dts
> @@ -0,0 +1,59 @@

[...]

> +				eeprom: eeprom@52 {
> +					compatible = "atmel,24c128";

I believe the above should be 24c02.
And the address is 0x50.

> +					reg = <0x52>;
> +					pagesize = <32>;

pagesize is 16.

[...]

Apart from the eeprom stuff above:

Acked-by: Igor Grinberg <grinberg@compulab.co.il>

-- 
Regards,
Igor.

^ permalink raw reply	[flat|nested] 6+ messages in thread
* [PATCH v3] ARM: DT: apq8064: add CM-QS600 board
@ 2014-09-29  9:35   ` Igor Grinberg
  0 siblings, 0 replies; 6+ messages in thread
From: Igor Grinberg @ 2014-09-29  9:35 UTC (permalink / raw)
  To: linux-arm-kernel

Hi Mike,

On 09/26/14 19:32, Mike Rapoport wrote:
> CM-QS600 is a APQ8064 based computer on module.
> The details are available at
> http://compulab.co.il/products/computer-on-modules/cm-qs600/
> 
> Signed-off-by: Mike Rapoport <mike.rapoport@gmail.com>

Thanks for working on this!
Some minor notes...

Can we have the subject aligned with other submissions, e.g.
ARM: dts: qcom: ...
?

> ---
> v2 changes: duplicate the settings for the cm-qs600 board in its .dts file as Kumar suggested
> v3 changes: add board details and keep dts Makefile sorted alphabetically

[...]

> new file mode 100644
> index 0000000..db7cf03
> --- /dev/null
> +++ b/arch/arm/boot/dts/qcom-apq8064-cm-qs600.dts
> @@ -0,0 +1,59 @@

[...]

> +				eeprom: eeprom at 52 {
> +					compatible = "atmel,24c128";

I believe the above should be 24c02.
And the address is 0x50.

> +					reg = <0x52>;
> +					pagesize = <32>;

pagesize is 16.

[...]

Apart from the eeprom stuff above:

Acked-by: Igor Grinberg <grinberg@compulab.co.il>

-- 
Regards,
Igor.

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH v3] ARM: DT: apq8064: add CM-QS600 board
  2014-09-29  9:35   ` Igor Grinberg
@ 2014-09-29 10:21     ` Igor Grinberg
  -1 siblings, 0 replies; 6+ messages in thread
From: Igor Grinberg @ 2014-09-29 10:21 UTC (permalink / raw)
  To: Mike Rapoport, Kumar Gala
  Cc: linux-arm-msm, Srinivas Kandagatla, Bjorn Andersson, linux-arm-kernel

On 09/29/14 12:35, Igor Grinberg wrote:
> Hi Mike,
> 
> On 09/26/14 19:32, Mike Rapoport wrote:
>> CM-QS600 is a APQ8064 based computer on module.
>> The details are available at
>> http://compulab.co.il/products/computer-on-modules/cm-qs600/
>>
>> Signed-off-by: Mike Rapoport <mike.rapoport@gmail.com>
> 
> Thanks for working on this!
> Some minor notes...
> 
> Can we have the subject aligned with other submissions, e.g.
> ARM: dts: qcom: ...
> ?
> 
>> ---
>> v2 changes: duplicate the settings for the cm-qs600 board in its .dts file as Kumar suggested
>> v3 changes: add board details and keep dts Makefile sorted alphabetically
> 
> [...]
> 
>> new file mode 100644
>> index 0000000..db7cf03
>> --- /dev/null
>> +++ b/arch/arm/boot/dts/qcom-apq8064-cm-qs600.dts
>> @@ -0,0 +1,59 @@
> 
> [...]
> 
>> +				eeprom: eeprom@52 {
>> +					compatible = "atmel,24c128";
> 
> I believe the above should be 24c02.
> And the address is 0x50.

Also, atmel is not the only vendor for the eeprom chips we use,
so I think at24 instead of atmel will do better here.

> 
>> +					reg = <0x52>;
>> +					pagesize = <32>;
> 
> pagesize is 16.
> 
> [...]
> 
> Apart from the eeprom stuff above:
> 
> Acked-by: Igor Grinberg <grinberg@compulab.co.il>
> 

-- 
Regards,
Igor.

^ permalink raw reply	[flat|nested] 6+ messages in thread
* [PATCH v3] ARM: DT: apq8064: add CM-QS600 board
@ 2014-09-29 10:21     ` Igor Grinberg
  0 siblings, 0 replies; 6+ messages in thread
From: Igor Grinberg @ 2014-09-29 10:21 UTC (permalink / raw)
  To: linux-arm-kernel

On 09/29/14 12:35, Igor Grinberg wrote:
> Hi Mike,
> 
> On 09/26/14 19:32, Mike Rapoport wrote:
>> CM-QS600 is a APQ8064 based computer on module.
>> The details are available at
>> http://compulab.co.il/products/computer-on-modules/cm-qs600/
>>
>> Signed-off-by: Mike Rapoport <mike.rapoport@gmail.com>
> 
> Thanks for working on this!
> Some minor notes...
> 
> Can we have the subject aligned with other submissions, e.g.
> ARM: dts: qcom: ...
> ?
> 
>> ---
>> v2 changes: duplicate the settings for the cm-qs600 board in its .dts file as Kumar suggested
>> v3 changes: add board details and keep dts Makefile sorted alphabetically
> 
> [...]
> 
>> new file mode 100644
>> index 0000000..db7cf03
>> --- /dev/null
>> +++ b/arch/arm/boot/dts/qcom-apq8064-cm-qs600.dts
>> @@ -0,0 +1,59 @@
> 
> [...]
> 
>> +				eeprom: eeprom at 52 {
>> +					compatible = "atmel,24c128";
> 
> I believe the above should be 24c02.
> And the address is 0x50.

Also, atmel is not the only vendor for the eeprom chips we use,
so I think at24 instead of atmel will do better here.

> 
>> +					reg = <0x52>;
>> +					pagesize = <32>;
> 
> pagesize is 16.
> 
> [...]
> 
> Apart from the eeprom stuff above:
> 
> Acked-by: Igor Grinberg <grinberg@compulab.co.il>
> 

-- 
Regards,
Igor.

^ permalink raw reply	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2014-09-29 10:21 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-09-26 16:32 [PATCH v3] ARM: DT: apq8064: add CM-QS600 board Mike Rapoport
2014-09-26 16:32 ` Mike Rapoport
2014-09-29  9:35 ` Igor Grinberg
2014-09-29  9:35   ` Igor Grinberg
2014-09-29 10:21   ` Igor Grinberg
2014-09-29 10:21     ` Igor Grinberg

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.