From: Don Slutz <dslutz@verizon.com> To: Paolo Bonzini <pbonzini@redhat.com>, Alexander Graf <agraf@suse.de>, Don Slutz <dslutz@verizon.com>, qemu-devel@nongnu.org Cc: xen-devel@lists.xensource.com, "Marcel Apfelbaum" <marcel.a@redhat.com>, "Michael S. Tsirkin" <mst@redhat.com>, "Markus Armbruster" <armbru@redhat.com>, "Anthony Liguori" <aliguori@amazon.com>, "Andreas Färber" <afaerber@suse.de>, "Stefano Stabellini" <stefano.stabellini@eu.citrix.com> Subject: Re: [Qemu-devel] [PATCH 1/1] xen-hvm.c: Add support for Xen access to vmport Date: Mon, 29 Sep 2014 21:05:07 -0400 [thread overview] Message-ID: <542A01C3.70908@terremark.com> (raw) In-Reply-To: <54295B38.6020105@redhat.com> On 09/29/14 09:14, Paolo Bonzini wrote: > Il 29/09/2014 14:57, Alexander Graf ha scritto: >>>> Yeah, that would be possible. You do not even need synchronize_state, >>>> it seems to me that it introduces more complication for little gain. >> Well, it makes all accels behave the same and keep information always at >> a single entity (the env struct). I don't think the vmport code should >> have knowledge of a xen env struct. > Yes, we agree on that. In fact the right CPU is already stored in > send_vcpu of XenIOState. I did reply up the thread because the info is missing here. Basically current_cpu is NULL here, and I think that no CPU objects have been created for Xen. So there is no VCPU object to select. -Don Slutz > Paolo
WARNING: multiple messages have this Message-ID (diff)
From: Don Slutz <dslutz@verizon.com> To: Paolo Bonzini <pbonzini@redhat.com>, Alexander Graf <agraf@suse.de>, Don Slutz <dslutz@verizon.com>, qemu-devel@nongnu.org Cc: xen-devel@lists.xensource.com, "Marcel Apfelbaum" <marcel.a@redhat.com>, "Michael S. Tsirkin" <mst@redhat.com>, "Markus Armbruster" <armbru@redhat.com>, "Anthony Liguori" <aliguori@amazon.com>, "Andreas Färber" <afaerber@suse.de>, "Stefano Stabellini" <stefano.stabellini@eu.citrix.com> Subject: Re: [PATCH 1/1] xen-hvm.c: Add support for Xen access to vmport Date: Mon, 29 Sep 2014 21:05:07 -0400 [thread overview] Message-ID: <542A01C3.70908@terremark.com> (raw) In-Reply-To: <54295B38.6020105@redhat.com> On 09/29/14 09:14, Paolo Bonzini wrote: > Il 29/09/2014 14:57, Alexander Graf ha scritto: >>>> Yeah, that would be possible. You do not even need synchronize_state, >>>> it seems to me that it introduces more complication for little gain. >> Well, it makes all accels behave the same and keep information always at >> a single entity (the env struct). I don't think the vmport code should >> have knowledge of a xen env struct. > Yes, we agree on that. In fact the right CPU is already stored in > send_vcpu of XenIOState. I did reply up the thread because the info is missing here. Basically current_cpu is NULL here, and I think that no CPU objects have been created for Xen. So there is no VCPU object to select. -Don Slutz > Paolo
next prev parent reply other threads:[~2014-09-30 1:06 UTC|newest] Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top 2014-09-26 18:47 [Qemu-devel] [PATCH 0/1] Add support for Xen access to vmport Don Slutz 2014-09-26 18:47 ` Don Slutz 2014-09-26 18:47 ` [Qemu-devel] [PATCH 1/1] xen-hvm.c: " Don Slutz 2014-09-26 18:47 ` Don Slutz 2014-09-29 8:12 ` [Qemu-devel] " Alexander Graf 2014-09-29 8:12 ` Alexander Graf 2014-09-29 11:10 ` [Qemu-devel] " Paolo Bonzini 2014-09-29 11:10 ` Paolo Bonzini 2014-09-29 11:53 ` [Qemu-devel] " Alexander Graf 2014-09-29 11:53 ` Alexander Graf 2014-09-29 12:21 ` [Qemu-devel] " Paolo Bonzini 2014-09-29 12:21 ` Paolo Bonzini 2014-09-29 12:57 ` [Qemu-devel] " Alexander Graf 2014-09-29 12:57 ` Alexander Graf 2014-09-29 13:14 ` [Qemu-devel] " Paolo Bonzini 2014-09-29 13:14 ` Paolo Bonzini 2014-09-30 1:05 ` Don Slutz [this message] 2014-09-30 1:05 ` Don Slutz 2014-09-30 8:14 ` [Qemu-devel] " Paolo Bonzini 2014-09-30 8:14 ` Paolo Bonzini 2014-09-30 1:00 ` [Qemu-devel] " Don Slutz 2014-09-30 1:00 ` Don Slutz 2014-09-29 10:15 ` [Qemu-devel] " Stefano Stabellini 2014-09-29 10:15 ` Stefano Stabellini 2014-09-29 10:25 ` [Qemu-devel] " Stefano Stabellini 2014-09-29 10:25 ` Stefano Stabellini 2014-09-30 0:32 ` [Qemu-devel] " Don Slutz 2014-09-30 0:32 ` Don Slutz 2014-09-30 10:35 ` [Qemu-devel] " Stefano Stabellini 2014-09-30 10:35 ` Stefano Stabellini 2014-10-01 5:21 ` [Qemu-devel] " Slutz, Donald Christopher 2014-10-01 5:21 ` Slutz, Donald Christopher 2014-10-01 9:20 ` [Qemu-devel] " Stefano Stabellini 2014-10-01 9:20 ` Stefano Stabellini 2014-10-01 12:33 ` [Qemu-devel] " Don Slutz 2014-10-01 12:33 ` Don Slutz 2014-10-01 14:44 ` [Qemu-devel] [Xen-devel] " Ian Campbell 2014-10-01 14:44 ` Ian Campbell 2014-10-01 16:01 ` [Qemu-devel] " Anthony Liguori 2014-10-01 16:01 ` Anthony Liguori 2014-10-01 15:08 ` [Qemu-devel] " Paul Durrant 2014-10-01 15:08 ` Paul Durrant
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=542A01C3.70908@terremark.com \ --to=dslutz@verizon.com \ --cc=afaerber@suse.de \ --cc=agraf@suse.de \ --cc=aliguori@amazon.com \ --cc=armbru@redhat.com \ --cc=marcel.a@redhat.com \ --cc=mst@redhat.com \ --cc=pbonzini@redhat.com \ --cc=qemu-devel@nongnu.org \ --cc=stefano.stabellini@eu.citrix.com \ --cc=xen-devel@lists.xensource.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.