From: Suravee Suthikulpanit <Suravee.Suthikulpanit@amd.com>
To: Julien Grall <julien.grall@linaro.org>,
stefano.stabellini@eu.citrix.com, ian.campbell@citrix.com
Cc: xen-devel@lists.xen.org
Subject: Re: [PATCH 2/2] xen/arm: Use PSCI-0.2 for machine_halt/restart by default
Date: Thu, 2 Oct 2014 14:51:05 -0500 [thread overview]
Message-ID: <542DACA9.5010000@amd.com> (raw)
In-Reply-To: <542D2EF7.6040708@linaro.org>
On 10/02/2014 05:54 AM, Julien Grall wrote:
> Hi Suravee,
>
> On 10/01/2014 09:02 PM, suravee.suthikulpanit@amd.com wrote:
>> void machine_halt(void)
>> {
>> + int timeout = 10;
>> +
>> watchdog_disable();
>> console_start_sync();
>> local_irq_enable();
>> smp_call_function(halt_this_cpu, NULL, 0);
>> + local_irq_disable();
>> +
>> + /* Wait at most another 10ms for all other CPUs to go offline. */
>> + while ( (num_online_cpus() > 1) && (timeout-- > 0) )
>> + mdelay(1);
>> +
>
> This doesn't look like PSCI specific. Can you explain in the commit
> message why you need to add this new block of code?
>
> Regards,
>
It's not PSCI specific. I was just trying to handle the graceful
shutdown similar to the code flow in machine_restart. If you think it's
not necessary, I can take this out.
Suravee
next prev parent reply other threads:[~2014-10-02 19:51 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-01 20:02 [PATCH 0/2] Introduce PSCI-0.2 supports suravee.suthikulpanit
2014-10-01 20:02 ` [PATCH 1/2] xen/arm: Initial support for PSCI-0.2 suravee.suthikulpanit
2014-10-02 9:07 ` Stefano Stabellini
2014-10-02 10:51 ` Julien Grall
2014-10-02 14:19 ` Ian Campbell
2014-10-02 20:17 ` Suravee Suthikulpanit
2014-10-02 14:21 ` Ian Campbell
2014-10-02 19:43 ` Suravee Suthikulpanit
2014-10-01 20:02 ` [PATCH 2/2] xen/arm: Use PSCI-0.2 for machine_halt/restart by default suravee.suthikulpanit
2014-10-02 9:04 ` Stefano Stabellini
2014-10-02 10:54 ` Julien Grall
2014-10-02 19:51 ` Suravee Suthikulpanit [this message]
2014-10-02 21:50 ` Julien Grall
2014-10-03 0:00 ` Suravee Suthikulpanit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=542DACA9.5010000@amd.com \
--to=suravee.suthikulpanit@amd.com \
--cc=ian.campbell@citrix.com \
--cc=julien.grall@linaro.org \
--cc=stefano.stabellini@eu.citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.