Re: [PATCH 1/2] xen/arm: Initial support for PSCI-0.2

From: Suravee Suthikulpanit <Suravee.Suthikulpanit@amd.com>
To: Ian Campbell <Ian.Campbell@citrix.com>,
	Julien Grall <julien.grall@linaro.org>
Cc: xen-devel@lists.xen.org, stefano.stabellini@eu.citrix.com
Subject: Re: [PATCH 1/2] xen/arm: Initial support for PSCI-0.2
Date: Thu, 2 Oct 2014 15:17:59 -0500	[thread overview]
Message-ID: <542DB2F7.8020005@amd.com> (raw)
In-Reply-To: <1412259583.17146.20.camel@citrix.com>

On 10/02/2014 09:19 AM, Ian Campbell wrote:
>>> +int __init psci_init(void)
>>> > >+{
>>> > >+    const struct dt_device_node *psci;
>>> > >+
>>> > >+    psci = dt_find_compatible_node(NULL, NULL, "arm,psci");
>>> > >+    if ( psci )
>>> > >+        return psci_init_0_1(psci);
>>> > >+
>>> > >+    psci = dt_find_compatible_node(NULL, NULL, "arm,psci-0.2");
>>> > >+    if ( psci )
>>> > >+        return psci_init_0_2(psci);
>>> > >+
>> >
>> >I think we need to prefer PSCI 0.2 if the platform supports the both
>> >version of PSCI.
> Yes, please.
>
> This may require also falling back to 0.1 if psci_init_0_2 fails?
>

Good point. I just realized that DT could have:

    compatible = "arm,psci-0.2", "arm,psci"

Suravee