* [PATCH] serial: of-serial: add PM suspend/resume support
@ 2014-09-23 8:34 ` Jingchang Lu
0 siblings, 0 replies; 11+ messages in thread
From: Jingchang Lu @ 2014-09-23 8:34 UTC (permalink / raw)
To: gregkh
Cc: arnd, linux-serial, linux-kernel, linux-arm-kernel, devicetree,
Jingchang Lu
This adds PM suspend/resume support for the of-serial driver
to provide power management support on devices attatched to it.
Signed-off-by: Jingchang Lu <jingchang.lu@freescale.com>
---
drivers/tty/serial/of_serial.c | 27 +++++++++++++++++++++++++++
1 file changed, 27 insertions(+)
diff --git a/drivers/tty/serial/of_serial.c b/drivers/tty/serial/of_serial.c
index 27981e2..8bc2563 100644
--- a/drivers/tty/serial/of_serial.c
+++ b/drivers/tty/serial/of_serial.c
@@ -240,6 +240,32 @@ static int of_platform_serial_remove(struct platform_device *ofdev)
return 0;
}
+#ifdef CONFIG_PM_SLEEP
+static int of_serial_suspend(struct device *dev)
+{
+ struct of_serial_info *info = dev_get_drvdata(dev);
+
+ serial8250_suspend_port(info->line);
+ if (info->clk)
+ clk_disable_unprepare(info->clk);
+
+ return 0;
+}
+
+static int of_serial_resume(struct device *dev)
+{
+ struct of_serial_info *info = dev_get_drvdata(dev);
+
+ if (info->clk)
+ clk_prepare_enable(info->clk);
+
+ serial8250_resume_port(info->line);
+
+ return 0;
+}
+#endif
+static SIMPLE_DEV_PM_OPS(of_serial_pm_ops, of_serial_suspend, of_serial_resume);
+
/*
* A few common types, add more as needed.
*/
@@ -271,6 +297,7 @@ static struct platform_driver of_platform_serial_driver = {
.name = "of_serial",
.owner = THIS_MODULE,
.of_match_table = of_platform_serial_table,
+ .pm = &of_serial_pm_ops,
},
.probe = of_platform_serial_probe,
.remove = of_platform_serial_remove,
--
1.8.0
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [PATCH] serial: of-serial: add PM suspend/resume support
@ 2014-09-23 8:34 ` Jingchang Lu
0 siblings, 0 replies; 11+ messages in thread
From: Jingchang Lu @ 2014-09-23 8:34 UTC (permalink / raw)
To: gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r
Cc: arnd-r2nGTMty4D4, linux-serial-u79uwXL29TY76Z2rM5mHXA,
linux-kernel-u79uwXL29TY76Z2rM5mHXA,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
devicetree-u79uwXL29TY76Z2rM5mHXA, Jingchang Lu
This adds PM suspend/resume support for the of-serial driver
to provide power management support on devices attatched to it.
Signed-off-by: Jingchang Lu <jingchang.lu-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
---
drivers/tty/serial/of_serial.c | 27 +++++++++++++++++++++++++++
1 file changed, 27 insertions(+)
diff --git a/drivers/tty/serial/of_serial.c b/drivers/tty/serial/of_serial.c
index 27981e2..8bc2563 100644
--- a/drivers/tty/serial/of_serial.c
+++ b/drivers/tty/serial/of_serial.c
@@ -240,6 +240,32 @@ static int of_platform_serial_remove(struct platform_device *ofdev)
return 0;
}
+#ifdef CONFIG_PM_SLEEP
+static int of_serial_suspend(struct device *dev)
+{
+ struct of_serial_info *info = dev_get_drvdata(dev);
+
+ serial8250_suspend_port(info->line);
+ if (info->clk)
+ clk_disable_unprepare(info->clk);
+
+ return 0;
+}
+
+static int of_serial_resume(struct device *dev)
+{
+ struct of_serial_info *info = dev_get_drvdata(dev);
+
+ if (info->clk)
+ clk_prepare_enable(info->clk);
+
+ serial8250_resume_port(info->line);
+
+ return 0;
+}
+#endif
+static SIMPLE_DEV_PM_OPS(of_serial_pm_ops, of_serial_suspend, of_serial_resume);
+
/*
* A few common types, add more as needed.
*/
@@ -271,6 +297,7 @@ static struct platform_driver of_platform_serial_driver = {
.name = "of_serial",
.owner = THIS_MODULE,
.of_match_table = of_platform_serial_table,
+ .pm = &of_serial_pm_ops,
},
.probe = of_platform_serial_probe,
.remove = of_platform_serial_remove,
--
1.8.0
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [PATCH] serial: of-serial: add PM suspend/resume support
@ 2014-09-23 8:34 ` Jingchang Lu
0 siblings, 0 replies; 11+ messages in thread
From: Jingchang Lu @ 2014-09-23 8:34 UTC (permalink / raw)
To: linux-arm-kernel
This adds PM suspend/resume support for the of-serial driver
to provide power management support on devices attatched to it.
Signed-off-by: Jingchang Lu <jingchang.lu@freescale.com>
---
drivers/tty/serial/of_serial.c | 27 +++++++++++++++++++++++++++
1 file changed, 27 insertions(+)
diff --git a/drivers/tty/serial/of_serial.c b/drivers/tty/serial/of_serial.c
index 27981e2..8bc2563 100644
--- a/drivers/tty/serial/of_serial.c
+++ b/drivers/tty/serial/of_serial.c
@@ -240,6 +240,32 @@ static int of_platform_serial_remove(struct platform_device *ofdev)
return 0;
}
+#ifdef CONFIG_PM_SLEEP
+static int of_serial_suspend(struct device *dev)
+{
+ struct of_serial_info *info = dev_get_drvdata(dev);
+
+ serial8250_suspend_port(info->line);
+ if (info->clk)
+ clk_disable_unprepare(info->clk);
+
+ return 0;
+}
+
+static int of_serial_resume(struct device *dev)
+{
+ struct of_serial_info *info = dev_get_drvdata(dev);
+
+ if (info->clk)
+ clk_prepare_enable(info->clk);
+
+ serial8250_resume_port(info->line);
+
+ return 0;
+}
+#endif
+static SIMPLE_DEV_PM_OPS(of_serial_pm_ops, of_serial_suspend, of_serial_resume);
+
/*
* A few common types, add more as needed.
*/
@@ -271,6 +297,7 @@ static struct platform_driver of_platform_serial_driver = {
.name = "of_serial",
.owner = THIS_MODULE,
.of_match_table = of_platform_serial_table,
+ .pm = &of_serial_pm_ops,
},
.probe = of_platform_serial_probe,
.remove = of_platform_serial_remove,
--
1.8.0
^ permalink raw reply related [flat|nested] 11+ messages in thread
* Re: [PATCH] serial: of-serial: add PM suspend/resume support
2014-09-23 8:34 ` Jingchang Lu
@ 2014-09-23 14:49 ` Arnd Bergmann
-1 siblings, 0 replies; 11+ messages in thread
From: Arnd Bergmann @ 2014-09-23 14:49 UTC (permalink / raw)
To: Jingchang Lu
Cc: gregkh, linux-serial, linux-kernel, linux-arm-kernel, devicetree
On Tuesday 23 September 2014 16:34:12 Jingchang Lu wrote:
> This adds PM suspend/resume support for the of-serial driver
> to provide power management support on devices attatched to it.
>
> Signed-off-by: Jingchang Lu <jingchang.lu@freescale.com>
>
Looks good to me,
Acked-by: Arnd Bergmann <arnd@arndb.de>
^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH] serial: of-serial: add PM suspend/resume support
@ 2014-09-23 14:49 ` Arnd Bergmann
0 siblings, 0 replies; 11+ messages in thread
From: Arnd Bergmann @ 2014-09-23 14:49 UTC (permalink / raw)
To: linux-arm-kernel
On Tuesday 23 September 2014 16:34:12 Jingchang Lu wrote:
> This adds PM suspend/resume support for the of-serial driver
> to provide power management support on devices attatched to it.
>
> Signed-off-by: Jingchang Lu <jingchang.lu@freescale.com>
>
Looks good to me,
Acked-by: Arnd Bergmann <arnd@arndb.de>
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] serial: of-serial: add PM suspend/resume support
@ 2014-10-03 7:45 ` Joseph Lo
0 siblings, 0 replies; 11+ messages in thread
From: Joseph Lo @ 2014-10-03 7:45 UTC (permalink / raw)
To: Jingchang Lu, gregkh
Cc: devicetree, arnd, linux-kernel, linux-serial, linux-arm-kernel
Hi,
This patch might have a potential issue that cause system hard hung
immediately when it accesses to registers with no clock. This could
happen on many chips that mainline kernel supporting with the setting
"no_console_suspend=1" during suspend time.
On 09/23/2014 04:34 PM, Jingchang Lu wrote:
> This adds PM suspend/resume support for the of-serial driver
> to provide power management support on devices attatched to it.
>
> Signed-off-by: Jingchang Lu <jingchang.lu@freescale.com>
> ---
> drivers/tty/serial/of_serial.c | 27 +++++++++++++++++++++++++++
> 1 file changed, 27 insertions(+)
>
> diff --git a/drivers/tty/serial/of_serial.c b/drivers/tty/serial/of_serial.c
> index 27981e2..8bc2563 100644
> --- a/drivers/tty/serial/of_serial.c
> +++ b/drivers/tty/serial/of_serial.c
> @@ -240,6 +240,32 @@ static int of_platform_serial_remove(struct platform_device *ofdev)
> return 0;
> }
>
> +#ifdef CONFIG_PM_SLEEP
> +static int of_serial_suspend(struct device *dev)
> +{
> + struct of_serial_info *info = dev_get_drvdata(dev);
> +
> + serial8250_suspend_port(info->line);
> + if (info->clk)
The fix would be something like this.
if (info->clk && console_suspend_enabled)
> + clk_disable_unprepare(info->clk);
> +
> + return 0;
> +}
> +
> +static int of_serial_resume(struct device *dev)
> +{
> + struct of_serial_info *info = dev_get_drvdata(dev);
> +
> + if (info->clk)
Ditto.
Thanks,
-Joseph
> + clk_prepare_enable(info->clk);
> +
> + serial8250_resume_port(info->line);
> +
> + return 0;
> +}
> +#endif
> +static SIMPLE_DEV_PM_OPS(of_serial_pm_ops, of_serial_suspend, of_serial_resume);
> +
> /*
> * A few common types, add more as needed.
> */
> @@ -271,6 +297,7 @@ static struct platform_driver of_platform_serial_driver = {
> .name = "of_serial",
> .owner = THIS_MODULE,
> .of_match_table = of_platform_serial_table,
> + .pm = &of_serial_pm_ops,
> },
> .probe = of_platform_serial_probe,
> .remove = of_platform_serial_remove,
>
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] serial: of-serial: add PM suspend/resume support
@ 2014-10-03 7:45 ` Joseph Lo
0 siblings, 0 replies; 11+ messages in thread
From: Joseph Lo @ 2014-10-03 7:45 UTC (permalink / raw)
To: Jingchang Lu, gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r
Cc: devicetree-u79uwXL29TY76Z2rM5mHXA, arnd-r2nGTMty4D4,
linux-kernel-u79uwXL29TY76Z2rM5mHXA,
linux-serial-u79uwXL29TY76Z2rM5mHXA,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r
Hi,
This patch might have a potential issue that cause system hard hung
immediately when it accesses to registers with no clock. This could
happen on many chips that mainline kernel supporting with the setting
"no_console_suspend=1" during suspend time.
On 09/23/2014 04:34 PM, Jingchang Lu wrote:
> This adds PM suspend/resume support for the of-serial driver
> to provide power management support on devices attatched to it.
>
> Signed-off-by: Jingchang Lu <jingchang.lu-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
> ---
> drivers/tty/serial/of_serial.c | 27 +++++++++++++++++++++++++++
> 1 file changed, 27 insertions(+)
>
> diff --git a/drivers/tty/serial/of_serial.c b/drivers/tty/serial/of_serial.c
> index 27981e2..8bc2563 100644
> --- a/drivers/tty/serial/of_serial.c
> +++ b/drivers/tty/serial/of_serial.c
> @@ -240,6 +240,32 @@ static int of_platform_serial_remove(struct platform_device *ofdev)
> return 0;
> }
>
> +#ifdef CONFIG_PM_SLEEP
> +static int of_serial_suspend(struct device *dev)
> +{
> + struct of_serial_info *info = dev_get_drvdata(dev);
> +
> + serial8250_suspend_port(info->line);
> + if (info->clk)
The fix would be something like this.
if (info->clk && console_suspend_enabled)
> + clk_disable_unprepare(info->clk);
> +
> + return 0;
> +}
> +
> +static int of_serial_resume(struct device *dev)
> +{
> + struct of_serial_info *info = dev_get_drvdata(dev);
> +
> + if (info->clk)
Ditto.
Thanks,
-Joseph
> + clk_prepare_enable(info->clk);
> +
> + serial8250_resume_port(info->line);
> +
> + return 0;
> +}
> +#endif
> +static SIMPLE_DEV_PM_OPS(of_serial_pm_ops, of_serial_suspend, of_serial_resume);
> +
> /*
> * A few common types, add more as needed.
> */
> @@ -271,6 +297,7 @@ static struct platform_driver of_platform_serial_driver = {
> .name = "of_serial",
> .owner = THIS_MODULE,
> .of_match_table = of_platform_serial_table,
> + .pm = &of_serial_pm_ops,
> },
> .probe = of_platform_serial_probe,
> .remove = of_platform_serial_remove,
>
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH] serial: of-serial: add PM suspend/resume support
@ 2014-10-03 7:45 ` Joseph Lo
0 siblings, 0 replies; 11+ messages in thread
From: Joseph Lo @ 2014-10-03 7:45 UTC (permalink / raw)
To: linux-arm-kernel
Hi,
This patch might have a potential issue that cause system hard hung
immediately when it accesses to registers with no clock. This could
happen on many chips that mainline kernel supporting with the setting
"no_console_suspend=1" during suspend time.
On 09/23/2014 04:34 PM, Jingchang Lu wrote:
> This adds PM suspend/resume support for the of-serial driver
> to provide power management support on devices attatched to it.
>
> Signed-off-by: Jingchang Lu <jingchang.lu@freescale.com>
> ---
> drivers/tty/serial/of_serial.c | 27 +++++++++++++++++++++++++++
> 1 file changed, 27 insertions(+)
>
> diff --git a/drivers/tty/serial/of_serial.c b/drivers/tty/serial/of_serial.c
> index 27981e2..8bc2563 100644
> --- a/drivers/tty/serial/of_serial.c
> +++ b/drivers/tty/serial/of_serial.c
> @@ -240,6 +240,32 @@ static int of_platform_serial_remove(struct platform_device *ofdev)
> return 0;
> }
>
> +#ifdef CONFIG_PM_SLEEP
> +static int of_serial_suspend(struct device *dev)
> +{
> + struct of_serial_info *info = dev_get_drvdata(dev);
> +
> + serial8250_suspend_port(info->line);
> + if (info->clk)
The fix would be something like this.
if (info->clk && console_suspend_enabled)
> + clk_disable_unprepare(info->clk);
> +
> + return 0;
> +}
> +
> +static int of_serial_resume(struct device *dev)
> +{
> + struct of_serial_info *info = dev_get_drvdata(dev);
> +
> + if (info->clk)
Ditto.
Thanks,
-Joseph
> + clk_prepare_enable(info->clk);
> +
> + serial8250_resume_port(info->line);
> +
> + return 0;
> +}
> +#endif
> +static SIMPLE_DEV_PM_OPS(of_serial_pm_ops, of_serial_suspend, of_serial_resume);
> +
> /*
> * A few common types, add more as needed.
> */
> @@ -271,6 +297,7 @@ static struct platform_driver of_platform_serial_driver = {
> .name = "of_serial",
> .owner = THIS_MODULE,
> .of_match_table = of_platform_serial_table,
> + .pm = &of_serial_pm_ops,
> },
> .probe = of_platform_serial_probe,
> .remove = of_platform_serial_remove,
>
^ permalink raw reply [flat|nested] 11+ messages in thread
* RE: [PATCH] serial: of-serial: add PM suspend/resume support
2014-10-03 7:45 ` Joseph Lo
(?)
@ 2014-10-09 7:53 ` Jingchang Lu
-1 siblings, 0 replies; 11+ messages in thread
From: Jingchang Lu @ 2014-10-09 7:53 UTC (permalink / raw)
To: Joseph Lo, gregkh
Cc: devicetree, arnd, linux-kernel, linux-serial, linux-arm-kernel
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="utf-8", Size: 1850 bytes --]
>-----Original Message-----
>From: Joseph Lo [mailto:josephl@nvidia.com]
>Sent: Friday, October 03, 2014 3:46 PM
>To: Lu Jingchang-B35083; gregkh@linuxfoundation.org
>Cc: devicetree@vger.kernel.org; arnd@arndb.de; linux-
>kernel@vger.kernel.org; linux-serial@vger.kernel.org; linux-arm-
>kernel@lists.infradead.org
>Subject: Re: [PATCH] serial: of-serial: add PM suspend/resume support
>
>Hi,
>
>This patch might have a potential issue that cause system hard hung
>immediately when it accesses to registers with no clock. This could happen
>on many chips that mainline kernel supporting with the setting
>"no_console_suspend=1" during suspend time.
>
>On 09/23/2014 04:34 PM, Jingchang Lu wrote:
>> This adds PM suspend/resume support for the of-serial driver to
>> provide power management support on devices attatched to it.
>>
>> Signed-off-by: Jingchang Lu <jingchang.lu@freescale.com>
>> ---
>> drivers/tty/serial/of_serial.c | 27 +++++++++++++++++++++++++++
>> 1 file changed, 27 insertions(+)
>>
>> diff --git a/drivers/tty/serial/of_serial.c
>> b/drivers/tty/serial/of_serial.c index 27981e2..8bc2563 100644
>> --- a/drivers/tty/serial/of_serial.c
>> +++ b/drivers/tty/serial/of_serial.c
>> @@ -240,6 +240,32 @@ static int of_platform_serial_remove(struct
>platform_device *ofdev)
>> return 0;
>> }
>>
>> +#ifdef CONFIG_PM_SLEEP
>> +static int of_serial_suspend(struct device *dev) {
>> + struct of_serial_info *info = dev_get_drvdata(dev);
>> +
>> + serial8250_suspend_port(info->line);
>> + if (info->clk)
>The fix would be something like this.
> if (info->clk && console_suspend_enabled)
>
Yes, there will be, I will send a fix on this, thanks!
Best Regards,
Jingchang
ÿôèº{.nÇ+·®+%Ëÿ±éݶ\x17¥wÿº{.nÇ+·¥{±þG«éÿ{ayº\x1dÊÚë,j\a¢f£¢·hïêÿêçz_è®\x03(éÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?¨èÚ&£ø§~á¶iOæ¬z·vØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?I¥
^ permalink raw reply [flat|nested] 11+ messages in thread
* RE: [PATCH] serial: of-serial: add PM suspend/resume support
@ 2014-10-09 7:53 ` Jingchang Lu
0 siblings, 0 replies; 11+ messages in thread
From: Jingchang Lu @ 2014-10-09 7:53 UTC (permalink / raw)
To: Joseph Lo, gregkh
Cc: devicetree, arnd, linux-kernel, linux-serial, linux-arm-kernel
>-----Original Message-----
>From: Joseph Lo [mailto:josephl@nvidia.com]
>Sent: Friday, October 03, 2014 3:46 PM
>To: Lu Jingchang-B35083; gregkh@linuxfoundation.org
>Cc: devicetree@vger.kernel.org; arnd@arndb.de; linux-
>kernel@vger.kernel.org; linux-serial@vger.kernel.org; linux-arm-
>kernel@lists.infradead.org
>Subject: Re: [PATCH] serial: of-serial: add PM suspend/resume support
>
>Hi,
>
>This patch might have a potential issue that cause system hard hung
>immediately when it accesses to registers with no clock. This could happen
>on many chips that mainline kernel supporting with the setting
>"no_console_suspend=1" during suspend time.
>
>On 09/23/2014 04:34 PM, Jingchang Lu wrote:
>> This adds PM suspend/resume support for the of-serial driver to
>> provide power management support on devices attatched to it.
>>
>> Signed-off-by: Jingchang Lu <jingchang.lu@freescale.com>
>> ---
>> drivers/tty/serial/of_serial.c | 27 +++++++++++++++++++++++++++
>> 1 file changed, 27 insertions(+)
>>
>> diff --git a/drivers/tty/serial/of_serial.c
>> b/drivers/tty/serial/of_serial.c index 27981e2..8bc2563 100644
>> --- a/drivers/tty/serial/of_serial.c
>> +++ b/drivers/tty/serial/of_serial.c
>> @@ -240,6 +240,32 @@ static int of_platform_serial_remove(struct
>platform_device *ofdev)
>> return 0;
>> }
>>
>> +#ifdef CONFIG_PM_SLEEP
>> +static int of_serial_suspend(struct device *dev) {
>> + struct of_serial_info *info = dev_get_drvdata(dev);
>> +
>> + serial8250_suspend_port(info->line);
>> + if (info->clk)
>The fix would be something like this.
> if (info->clk && console_suspend_enabled)
>
Yes, there will be, I will send a fix on this, thanks!
Best Regards,
Jingchang
^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH] serial: of-serial: add PM suspend/resume support
@ 2014-10-09 7:53 ` Jingchang Lu
0 siblings, 0 replies; 11+ messages in thread
From: Jingchang Lu @ 2014-10-09 7:53 UTC (permalink / raw)
To: linux-arm-kernel
>-----Original Message-----
>From: Joseph Lo [mailto:josephl at nvidia.com]
>Sent: Friday, October 03, 2014 3:46 PM
>To: Lu Jingchang-B35083; gregkh at linuxfoundation.org
>Cc: devicetree at vger.kernel.org; arnd at arndb.de; linux-
>kernel at vger.kernel.org; linux-serial at vger.kernel.org; linux-arm-
>kernel at lists.infradead.org
>Subject: Re: [PATCH] serial: of-serial: add PM suspend/resume support
>
>Hi,
>
>This patch might have a potential issue that cause system hard hung
>immediately when it accesses to registers with no clock. This could happen
>on many chips that mainline kernel supporting with the setting
>"no_console_suspend=1" during suspend time.
>
>On 09/23/2014 04:34 PM, Jingchang Lu wrote:
>> This adds PM suspend/resume support for the of-serial driver to
>> provide power management support on devices attatched to it.
>>
>> Signed-off-by: Jingchang Lu <jingchang.lu@freescale.com>
>> ---
>> drivers/tty/serial/of_serial.c | 27 +++++++++++++++++++++++++++
>> 1 file changed, 27 insertions(+)
>>
>> diff --git a/drivers/tty/serial/of_serial.c
>> b/drivers/tty/serial/of_serial.c index 27981e2..8bc2563 100644
>> --- a/drivers/tty/serial/of_serial.c
>> +++ b/drivers/tty/serial/of_serial.c
>> @@ -240,6 +240,32 @@ static int of_platform_serial_remove(struct
>platform_device *ofdev)
>> return 0;
>> }
>>
>> +#ifdef CONFIG_PM_SLEEP
>> +static int of_serial_suspend(struct device *dev) {
>> + struct of_serial_info *info = dev_get_drvdata(dev);
>> +
>> + serial8250_suspend_port(info->line);
>> + if (info->clk)
>The fix would be something like this.
> if (info->clk && console_suspend_enabled)
>
Yes, there will be, I will send a fix on this, thanks!
Best Regards,
Jingchang
^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2014-10-09 7:53 UTC | newest]
Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-09-23 8:34 [PATCH] serial: of-serial: add PM suspend/resume support Jingchang Lu
2014-09-23 8:34 ` Jingchang Lu
2014-09-23 8:34 ` Jingchang Lu
2014-09-23 14:49 ` Arnd Bergmann
2014-09-23 14:49 ` Arnd Bergmann
2014-10-03 7:45 ` Joseph Lo
2014-10-03 7:45 ` Joseph Lo
2014-10-03 7:45 ` Joseph Lo
2014-10-09 7:53 ` Jingchang Lu
2014-10-09 7:53 ` Jingchang Lu
2014-10-09 7:53 ` Jingchang Lu
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.