All of lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH 1/3] xtables-addons: new package
@ 2014-10-21 21:10 Gustavo Zacarias
  2014-10-21 21:10 ` [Buildroot] [PATCH 2/3] iptables: enable basic kernel options Gustavo Zacarias
                   ` (3 more replies)
  0 siblings, 4 replies; 12+ messages in thread
From: Gustavo Zacarias @ 2014-10-21 21:10 UTC (permalink / raw)
  To: buildroot

The geoip "helpers" are basically scripts that download and reformat
the geoip database in a form usable by xt_geoip.
The netfilter (kernel & userland) sides of it are built and installed.
Since there are many considerations to geoip databases (free, commercial
and variants for each) it's left to the user to deal with that if they
plan to use the extension which is only one among many.

Signed-off-by: Gustavo Zacarias <gustavo@zacarias.com.ar>
---
 package/Config.in                          |  1 +
 package/xtables-addons/Config.in           | 22 +++++++++++++++++++++
 package/xtables-addons/xtables-addons.hash |  3 +++
 package/xtables-addons/xtables-addons.mk   | 31 ++++++++++++++++++++++++++++++
 4 files changed, 57 insertions(+)
 create mode 100644 package/xtables-addons/Config.in
 create mode 100644 package/xtables-addons/xtables-addons.hash
 create mode 100644 package/xtables-addons/xtables-addons.mk

diff --git a/package/Config.in b/package/Config.in
index 989790e..97985b3 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -1128,6 +1128,7 @@ endif
 	source "package/wvdial/Config.in"
 	source "package/xinetd/Config.in"
 	source "package/xl2tp/Config.in"
+	source "package/xtables-addons/Config.in"
 	source "package/znc/Config.in"
 
 endmenu
diff --git a/package/xtables-addons/Config.in b/package/xtables-addons/Config.in
new file mode 100644
index 0000000..6e3b88c
--- /dev/null
+++ b/package/xtables-addons/Config.in
@@ -0,0 +1,22 @@
+comment "xtables-addons needs a Linux kernel to be built"
+	depends on !BR2_LINUX_KERNEL
+
+comment "xtables-addons needs a toolchain w/ dynamic library, largefile, threads"
+	depends on BR2_LINUX_KERNEL
+	depends on BR2_PREFER_STATIC_LIB || !BR2_LARGEFILE || \
+		!BR2_TOOLCHAIN_HAS_THREADS
+
+
+config BR2_PACKAGE_XTABLES_ADDONS
+	bool "xtables-addons"
+	depends on BR2_LINUX_KERNEL
+	depends on BR2_LARGEFILE
+	depends on BR2_TOOLCHAIN_HAS_THREADS
+	depends on !BR2_PREFER_STATIC_LIB # extensions are .so
+	select BR2_PACKAGE_IPTABLES
+	help
+	  Xtables-addons is the successor to patch-o-matic(-ng).
+	  Likewise, it contains extensions that were not, or are not yet,
+	  accepted in the main kernel/iptables packages.
+
+	  http://xtables-addons.sourceforge.net/
diff --git a/package/xtables-addons/xtables-addons.hash b/package/xtables-addons/xtables-addons.hash
new file mode 100644
index 0000000..d742aed
--- /dev/null
+++ b/package/xtables-addons/xtables-addons.hash
@@ -0,0 +1,3 @@
+# From http://sourceforge.net/projects/xtables-addons/files/Xtables-addons/2.6/
+md5	087835ba7e564481b6fd398692268340	xtables-addons-2.6.tar.xz
+sha1	10586961a70fd4fe4f972cb3f31962c6766b359c	xtables-addons-2.6.tar.xz
diff --git a/package/xtables-addons/xtables-addons.mk b/package/xtables-addons/xtables-addons.mk
new file mode 100644
index 0000000..2992ac6
--- /dev/null
+++ b/package/xtables-addons/xtables-addons.mk
@@ -0,0 +1,31 @@
+################################################################################
+#
+# xtables-addons
+#
+################################################################################
+
+XTABLES_ADDONS_VERSION = 2.6
+XTABLES_ADDONS_SOURCE = xtables-addons-$(XTABLES_ADDONS_VERSION).tar.xz
+XTABLES_ADDONS_SITE = http://downloads.sourceforge.net/project/xtables-addons/Xtables-addons/$(XTABLES_ADDONS_VERSION)
+XTABLES_ADDONS_CONF_OPTS = --with-kbuild="$(LINUX_DIR)" \
+	--with-xtables="$(STAGING_DIR)/usr" \
+	--with-xtlibdir="/usr/lib/xtables"
+XTABLES_ADDONS_DEPENDENCIES = iptables linux host-pkgconf
+XTABLES_ADDONS_LICENSE = GPLv2+
+XTABLES_ADDONS_LICENSE_FILES = LICENSE
+
+# geoip helpers need perl with modules and unzip so disable
+define XTABLES_DISABLE_GEOIP_HELPERS
+	$(SED) 's/ geoip//' $(@D)/Makefile.in
+endef
+XTABLES_ADDONS_POST_PATCH_HOOKS += XTABLES_DISABLE_GEOIP_HELPERS
+
+define XTABLES_ADDONS_BUILD_CMDS
+	$(MAKE) -C $(@D) $(LINUX_MAKE_FLAGS)
+endef
+
+define XTABLES_ADDONS_INSTALL_TARGET_CMDS
+	$(MAKE) -C $(@D) $(LINUX_MAKE_FLAGS) DESTDIR="$(TARGET_DIR)" install
+endef
+
+$(eval $(autotools-package))
-- 
2.0.4

^ permalink raw reply related	[flat|nested] 12+ messages in thread
* [Buildroot] [PATCH 2/3] iptables: enable basic kernel options
  2014-10-21 21:10 [Buildroot] [PATCH 1/3] xtables-addons: new package Gustavo Zacarias
@ 2014-10-21 21:10 ` Gustavo Zacarias
  2014-10-28 18:02   ` Thomas Petazzoni
  2014-10-21 21:10 ` [Buildroot] [PATCH 3/3] xtables-addons: enable necessary " Gustavo Zacarias
                   ` (2 subsequent siblings)
  3 siblings, 1 reply; 12+ messages in thread
From: Gustavo Zacarias @ 2014-10-21 21:10 UTC (permalink / raw)
  To: buildroot

Enable the basic kernel options for iptables to be useful at least to
filter incoming connections.

Signed-off-by: Gustavo Zacarias <gustavo@zacarias.com.ar>
---
 linux/linux.mk | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/linux/linux.mk b/linux/linux.mk
index 2b862ec..b9d3c8e 100644
--- a/linux/linux.mk
+++ b/linux/linux.mk
@@ -210,6 +210,11 @@ define LINUX_CONFIGURE_CMDS
 		$(call KCONFIG_ENABLE_OPT,CONFIG_SECURITY,$(@D)/.config)
 		$(call KCONFIG_ENABLE_OPT,CONFIG_SECURITY_SMACK,$(@D)/.config)
 		$(call KCONFIG_ENABLE_OPT,CONFIG_SECURITY_NETWORK,$(@D)/.config))
+	$(if $(BR2_PACKAGE_IPTABLES),
+		$(call KCONFIG_ENABLE_OPT,CONFIG_IP_NF_IPTABLES,$(@D)/.config)
+		$(call KCONFIG_ENABLE_OPT,CONFIG_IP_NF_FILTER,$(@D)/.config)
+		$(call KCONFIG_ENABLE_OPT,CONFIG_NETFILTER,$(@D)/.config)
+		$(call KCONFIG_ENABLE_OPT,CONFIG_NETFILTER_XTABLES,$(@D)/.config))
 	$(if $(BR2_LINUX_KERNEL_APPENDED_DTB),
 		$(call KCONFIG_ENABLE_OPT,CONFIG_ARM_APPENDED_DTB,$(@D)/.config))
 	yes '' | $(TARGET_MAKE_ENV) $(MAKE1) $(LINUX_MAKE_FLAGS) -C $(@D) oldconfig
-- 
2.0.4

^ permalink raw reply related	[flat|nested] 12+ messages in thread
* [Buildroot] [PATCH 3/3] xtables-addons: enable necessary kernel options
  2014-10-21 21:10 [Buildroot] [PATCH 1/3] xtables-addons: new package Gustavo Zacarias
  2014-10-21 21:10 ` [Buildroot] [PATCH 2/3] iptables: enable basic kernel options Gustavo Zacarias
@ 2014-10-21 21:10 ` Gustavo Zacarias
  2014-10-22 17:18 ` [Buildroot] [PATCH 1/3] xtables-addons: new package Arnout Vandecappelle
  2015-01-10 17:55 ` Thomas Petazzoni
  3 siblings, 0 replies; 12+ messages in thread
From: Gustavo Zacarias @ 2014-10-21 21:10 UTC (permalink / raw)
  To: buildroot

Enable the required conntrack/netfilter options, otherwise
xtables-addons will fail to build.
The basic iptables options are already covered by the iptables package
which is a required dependency anyway.

Signed-off-by: Gustavo Zacarias <gustavo@zacarias.com.ar>
---
 linux/linux.mk | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/linux/linux.mk b/linux/linux.mk
index b9d3c8e..ee8c6a0 100644
--- a/linux/linux.mk
+++ b/linux/linux.mk
@@ -215,6 +215,9 @@ define LINUX_CONFIGURE_CMDS
 		$(call KCONFIG_ENABLE_OPT,CONFIG_IP_NF_FILTER,$(@D)/.config)
 		$(call KCONFIG_ENABLE_OPT,CONFIG_NETFILTER,$(@D)/.config)
 		$(call KCONFIG_ENABLE_OPT,CONFIG_NETFILTER_XTABLES,$(@D)/.config))
+	$(if $(BR2_PACKAGE_XTABLES_ADDONS),
+		$(call KCONFIG_ENABLE_OPT,CONFIG_NF_CONNTRACK,$(@D)/.config)
+		$(call KCONFIG_ENABLE_OPT,CONFIG_NF_CONNTRACK_MARK,$(@D)/.config))
 	$(if $(BR2_LINUX_KERNEL_APPENDED_DTB),
 		$(call KCONFIG_ENABLE_OPT,CONFIG_ARM_APPENDED_DTB,$(@D)/.config))
 	yes '' | $(TARGET_MAKE_ENV) $(MAKE1) $(LINUX_MAKE_FLAGS) -C $(@D) oldconfig
-- 
2.0.4

^ permalink raw reply related	[flat|nested] 12+ messages in thread
* [Buildroot] [PATCH 1/3] xtables-addons: new package
  2014-10-21 21:10 [Buildroot] [PATCH 1/3] xtables-addons: new package Gustavo Zacarias
  2014-10-21 21:10 ` [Buildroot] [PATCH 2/3] iptables: enable basic kernel options Gustavo Zacarias
  2014-10-21 21:10 ` [Buildroot] [PATCH 3/3] xtables-addons: enable necessary " Gustavo Zacarias
@ 2014-10-22 17:18 ` Arnout Vandecappelle
  2014-10-22 22:38   ` Gustavo Zacarias
  2014-10-23 11:07   ` Gustavo Zacarias
  2015-01-10 17:55 ` Thomas Petazzoni
  3 siblings, 2 replies; 12+ messages in thread
From: Arnout Vandecappelle @ 2014-10-22 17:18 UTC (permalink / raw)
  To: buildroot

On 21/10/14 23:10, Gustavo Zacarias wrote:
> The geoip "helpers" are basically scripts that download and reformat
> the geoip database in a form usable by xt_geoip.
> The netfilter (kernel & userland) sides of it are built and installed.
> Since there are many considerations to geoip databases (free, commercial
> and variants for each) it's left to the user to deal with that if they
> plan to use the extension which is only one among many.
> 
> Signed-off-by: Gustavo Zacarias <gustavo@zacarias.com.ar>
> ---
>  package/Config.in                          |  1 +
>  package/xtables-addons/Config.in           | 22 +++++++++++++++++++++
>  package/xtables-addons/xtables-addons.hash |  3 +++
>  package/xtables-addons/xtables-addons.mk   | 31 ++++++++++++++++++++++++++++++
>  4 files changed, 57 insertions(+)
>  create mode 100644 package/xtables-addons/Config.in
>  create mode 100644 package/xtables-addons/xtables-addons.hash
>  create mode 100644 package/xtables-addons/xtables-addons.mk
> 
> diff --git a/package/Config.in b/package/Config.in
> index 989790e..97985b3 100644
> --- a/package/Config.in
> +++ b/package/Config.in
> @@ -1128,6 +1128,7 @@ endif
>  	source "package/wvdial/Config.in"
>  	source "package/xinetd/Config.in"
>  	source "package/xl2tp/Config.in"
> +	source "package/xtables-addons/Config.in"
>  	source "package/znc/Config.in"
>  
>  endmenu
> diff --git a/package/xtables-addons/Config.in b/package/xtables-addons/Config.in
> new file mode 100644
> index 0000000..6e3b88c
> --- /dev/null
> +++ b/package/xtables-addons/Config.in
> @@ -0,0 +1,22 @@
> +comment "xtables-addons needs a Linux kernel to be built"
> +	depends on !BR2_LINUX_KERNEL
> +
> +comment "xtables-addons needs a toolchain w/ dynamic library, largefile, threads"
> +	depends on BR2_LINUX_KERNEL

 Do we usually do this? I mean, if a user discovers the 'needs a Linux kernel'
comment and builds a kernel, then he comes back only to discover that he still
has to enable all this other stuff...


> +	depends on BR2_PREFER_STATIC_LIB || !BR2_LARGEFILE || \
> +		!BR2_TOOLCHAIN_HAS_THREADS
> +
> +
> +config BR2_PACKAGE_XTABLES_ADDONS
> +	bool "xtables-addons"
> +	depends on BR2_LINUX_KERNEL
> +	depends on BR2_LARGEFILE
> +	depends on BR2_TOOLCHAIN_HAS_THREADS
> +	depends on !BR2_PREFER_STATIC_LIB # extensions are .so
> +	select BR2_PACKAGE_IPTABLES
> +	help
> +	  Xtables-addons is the successor to patch-o-matic(-ng).
> +	  Likewise, it contains extensions that were not, or are not yet,
> +	  accepted in the main kernel/iptables packages.
> +
> +	  http://xtables-addons.sourceforge.net/
> diff --git a/package/xtables-addons/xtables-addons.hash b/package/xtables-addons/xtables-addons.hash
> new file mode 100644
> index 0000000..d742aed
> --- /dev/null
> +++ b/package/xtables-addons/xtables-addons.hash
> @@ -0,0 +1,3 @@
> +# From http://sourceforge.net/projects/xtables-addons/files/Xtables-addons/2.6/
> +md5	087835ba7e564481b6fd398692268340	xtables-addons-2.6.tar.xz
> +sha1	10586961a70fd4fe4f972cb3f31962c6766b359c	xtables-addons-2.6.tar.xz
> diff --git a/package/xtables-addons/xtables-addons.mk b/package/xtables-addons/xtables-addons.mk
> new file mode 100644
> index 0000000..2992ac6
> --- /dev/null
> +++ b/package/xtables-addons/xtables-addons.mk
> @@ -0,0 +1,31 @@
> +################################################################################
> +#
> +# xtables-addons
> +#
> +################################################################################
> +
> +XTABLES_ADDONS_VERSION = 2.6
> +XTABLES_ADDONS_SOURCE = xtables-addons-$(XTABLES_ADDONS_VERSION).tar.xz
> +XTABLES_ADDONS_SITE = http://downloads.sourceforge.net/project/xtables-addons/Xtables-addons/$(XTABLES_ADDONS_VERSION)
> +XTABLES_ADDONS_CONF_OPTS = --with-kbuild="$(LINUX_DIR)" \
> +	--with-xtables="$(STAGING_DIR)/usr" \
> +	--with-xtlibdir="/usr/lib/xtables"
> +XTABLES_ADDONS_DEPENDENCIES = iptables linux host-pkgconf
> +XTABLES_ADDONS_LICENSE = GPLv2+
> +XTABLES_ADDONS_LICENSE_FILES = LICENSE
> +
> +# geoip helpers need perl with modules and unzip so disable
> +define XTABLES_DISABLE_GEOIP_HELPERS
> +	$(SED) 's/ geoip//' $(@D)/Makefile.in
> +endef
> +XTABLES_ADDONS_POST_PATCH_HOOKS += XTABLES_DISABLE_GEOIP_HELPERS
> +
> +define XTABLES_ADDONS_BUILD_CMDS
> +	$(MAKE) -C $(@D) $(LINUX_MAKE_FLAGS)

 Is there a reason why

XTABLE_ADDONS_MAKE_OPTS = $(LINUX_MAKE_FLAGS)

doesn't work instead of overriding the build commands?

 Regards,
 Arnout

> +endef
> +
> +define XTABLES_ADDONS_INSTALL_TARGET_CMDS
> +	$(MAKE) -C $(@D) $(LINUX_MAKE_FLAGS) DESTDIR="$(TARGET_DIR)" install
> +endef
> +
> +$(eval $(autotools-package))
> 


-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F

^ permalink raw reply	[flat|nested] 12+ messages in thread
* [Buildroot] [PATCH 1/3] xtables-addons: new package
  2014-10-22 17:18 ` [Buildroot] [PATCH 1/3] xtables-addons: new package Arnout Vandecappelle
@ 2014-10-22 22:38   ` Gustavo Zacarias
  2014-10-28 22:18     ` Arnout Vandecappelle
  2014-10-23 11:07   ` Gustavo Zacarias
  1 sibling, 1 reply; 12+ messages in thread
From: Gustavo Zacarias @ 2014-10-22 22:38 UTC (permalink / raw)
  To: buildroot

On 10/22/2014 02:18 PM, Arnout Vandecappelle wrote:

>> +comment "xtables-addons needs a Linux kernel to be built"
>> +	depends on !BR2_LINUX_KERNEL
>> +
>> +comment "xtables-addons needs a toolchain w/ dynamic library, largefile, threads"
>> +	depends on BR2_LINUX_KERNEL
> 
>  Do we usually do this? I mean, if a user discovers the 'needs a Linux kernel'
> comment and builds a kernel, then he comes back only to discover that he still
> has to enable all this other stuff...

I can move it to linux extensions instead of it being a package, i don't
know if it's worth bloating too much there.
For the comment i didn't want to make it too wide with both, i wouldn't
mind making it a single one since i use terminals wider than 80 normally.

>> +define XTABLES_ADDONS_BUILD_CMDS
>> +	$(MAKE) -C $(@D) $(LINUX_MAKE_FLAGS)
> 
>  Is there a reason why
> 
> XTABLE_ADDONS_MAKE_OPTS = $(LINUX_MAKE_FLAGS)
> 
> doesn't work instead of overriding the build commands?

The build is somewhat fragile since it calls kbuild in the process, i'll
give it another try but i think it had some issues when building for
PowerPC SPE ABI otherwise (configure gets it's stuff from the autotools
vanilla cmds and uses that for userland, however builds vars are use for
kbuild exclusively and something sneaked in in a bad way IIRC).
Regards.

^ permalink raw reply	[flat|nested] 12+ messages in thread
* [Buildroot] [PATCH 1/3] xtables-addons: new package
  2014-10-22 17:18 ` [Buildroot] [PATCH 1/3] xtables-addons: new package Arnout Vandecappelle
  2014-10-22 22:38   ` Gustavo Zacarias
@ 2014-10-23 11:07   ` Gustavo Zacarias
  1 sibling, 0 replies; 12+ messages in thread
From: Gustavo Zacarias @ 2014-10-23 11:07 UTC (permalink / raw)
  To: buildroot

On 10/22/2014 02:18 PM, Arnout Vandecappelle wrote:
>> +define XTABLES_ADDONS_BUILD_CMDS
>> +	$(MAKE) -C $(@D) $(LINUX_MAKE_FLAGS)
> 
>  Is there a reason why
> 
> XTABLE_ADDONS_MAKE_OPTS = $(LINUX_MAKE_FLAGS)
> 
> doesn't work instead of overriding the build commands?
> 
>  Regards,
>  Arnout
> 
>> +endef
>> +
>> +define XTABLES_ADDONS_INSTALL_TARGET_CMDS
>> +	$(MAKE) -C $(@D) $(LINUX_MAKE_FLAGS) DESTDIR="$(TARGET_DIR)" install
>> +endef

It works for build but not for install, i can send a v2 just dropping
the build cmds and adding the opts.
Regarding the comment, there are packages that do so, for example fmc
and fmlib.
There are other packages that depend on linux as well but don't
have/need separate comment entries - being dependant on a kernel being
built i suspect some may need extra toolchain options but they aren't
audited by autobuilds hence they're not taken care of.
Regards.

^ permalink raw reply	[flat|nested] 12+ messages in thread
* [Buildroot] [PATCH 2/3] iptables: enable basic kernel options
  2014-10-21 21:10 ` [Buildroot] [PATCH 2/3] iptables: enable basic kernel options Gustavo Zacarias
@ 2014-10-28 18:02   ` Thomas Petazzoni
  2014-10-28 18:04     ` Gustavo Zacarias
  0 siblings, 1 reply; 12+ messages in thread
From: Thomas Petazzoni @ 2014-10-28 18:02 UTC (permalink / raw)
  To: buildroot

Gustavo, Peter,

On Tue, 21 Oct 2014 18:10:51 -0300, Gustavo Zacarias wrote:
> Enable the basic kernel options for iptables to be useful at least to
> filter incoming connections.
> 
> Signed-off-by: Gustavo Zacarias <gustavo@zacarias.com.ar>
> ---
>  linux/linux.mk | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/linux/linux.mk b/linux/linux.mk
> index 2b862ec..b9d3c8e 100644
> --- a/linux/linux.mk
> +++ b/linux/linux.mk
> @@ -210,6 +210,11 @@ define LINUX_CONFIGURE_CMDS
>  		$(call KCONFIG_ENABLE_OPT,CONFIG_SECURITY,$(@D)/.config)
>  		$(call KCONFIG_ENABLE_OPT,CONFIG_SECURITY_SMACK,$(@D)/.config)
>  		$(call KCONFIG_ENABLE_OPT,CONFIG_SECURITY_NETWORK,$(@D)/.config))
> +	$(if $(BR2_PACKAGE_IPTABLES),
> +		$(call KCONFIG_ENABLE_OPT,CONFIG_IP_NF_IPTABLES,$(@D)/.config)
> +		$(call KCONFIG_ENABLE_OPT,CONFIG_IP_NF_FILTER,$(@D)/.config)
> +		$(call KCONFIG_ENABLE_OPT,CONFIG_NETFILTER,$(@D)/.config)
> +		$(call KCONFIG_ENABLE_OPT,CONFIG_NETFILTER_XTABLES,$(@D)/.config))
>  	$(if $(BR2_LINUX_KERNEL_APPENDED_DTB),
>  		$(call KCONFIG_ENABLE_OPT,CONFIG_ARM_APPENDED_DTB,$(@D)/.config))
>  	yes '' | $(TARGET_MAKE_ENV) $(MAKE1) $(LINUX_MAKE_FLAGS) -C $(@D) oldconfig

For this one, I don't know. Back some time ago, Peter said that his
preference was to not enforce too much stuff in terms of kernel
configuration options in linux/linux.mk. I think the idea is that it's
something that can quickly become very complicated if you want to
handle all the kernel config options that all packages might need. It's
also being forced without the user being capable of doing anything
against that: those KCONFIG_ENABLE_OPT calls are done even if the user
passes a custom configuration file.

But back at the time, we only had the CONFIG_AEABI option being
handled. Now it's true we already have ktap, systemd, smack being
handled, and many other things related to appended DTB, initramfs, and
more. So it seems like the iptables/xtables-addons proposal from
Gustavo are not really creating a precedent.

Peter, what is your position on this?

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

^ permalink raw reply	[flat|nested] 12+ messages in thread
* [Buildroot] [PATCH 2/3] iptables: enable basic kernel options
  2014-10-28 18:02   ` Thomas Petazzoni
@ 2014-10-28 18:04     ` Gustavo Zacarias
  2014-10-28 18:10       ` Thomas Petazzoni
  0 siblings, 1 reply; 12+ messages in thread
From: Gustavo Zacarias @ 2014-10-28 18:04 UTC (permalink / raw)
  To: buildroot

On 10/28/2014 03:02 PM, Thomas Petazzoni wrote:

> For this one, I don't know. Back some time ago, Peter said that his
> preference was to not enforce too much stuff in terms of kernel
> configuration options in linux/linux.mk. I think the idea is that it's
> something that can quickly become very complicated if you want to
> handle all the kernel config options that all packages might need. It's
> also being forced without the user being capable of doing anything
> against that: those KCONFIG_ENABLE_OPT calls are done even if the user
> passes a custom configuration file.
> 
> But back at the time, we only had the CONFIG_AEABI option being
> handled. Now it's true we already have ktap, systemd, smack being
> handled, and many other things related to appended DTB, initramfs, and
> more. So it seems like the iptables/xtables-addons proposal from
> Gustavo are not really creating a precedent.
> 
> Peter, what is your position on this?

Unfortunately it's not optional for xtables-addons, it needs the
iptables bits for the xtables bits in the other patch.
We could just get them together or ditch the package since it will
result in a build failure.
Regards.

^ permalink raw reply	[flat|nested] 12+ messages in thread
* [Buildroot] [PATCH 2/3] iptables: enable basic kernel options
  2014-10-28 18:04     ` Gustavo Zacarias
@ 2014-10-28 18:10       ` Thomas Petazzoni
  2014-10-28 22:11         ` Arnout Vandecappelle
  0 siblings, 1 reply; 12+ messages in thread
From: Thomas Petazzoni @ 2014-10-28 18:10 UTC (permalink / raw)
  To: buildroot

Dear Gustavo Zacarias,

On Tue, 28 Oct 2014 15:04:59 -0300, Gustavo Zacarias wrote:
> On 10/28/2014 03:02 PM, Thomas Petazzoni wrote:
> 
> > For this one, I don't know. Back some time ago, Peter said that his
> > preference was to not enforce too much stuff in terms of kernel
> > configuration options in linux/linux.mk. I think the idea is that it's
> > something that can quickly become very complicated if you want to
> > handle all the kernel config options that all packages might need. It's
> > also being forced without the user being capable of doing anything
> > against that: those KCONFIG_ENABLE_OPT calls are done even if the user
> > passes a custom configuration file.
> > 
> > But back at the time, we only had the CONFIG_AEABI option being
> > handled. Now it's true we already have ktap, systemd, smack being
> > handled, and many other things related to appended DTB, initramfs, and
> > more. So it seems like the iptables/xtables-addons proposal from
> > Gustavo are not really creating a precedent.
> > 
> > Peter, what is your position on this?
> 
> Unfortunately it's not optional for xtables-addons, it needs the
> iptables bits for the xtables bits in the other patch.
> We could just get them together or ditch the package since it will
> result in a build failure.

As said on IRC, if those options are needed at build time for
xtables-addons, it makes a very good case for having them.

Peter, OK ?

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

^ permalink raw reply	[flat|nested] 12+ messages in thread
* [Buildroot] [PATCH 2/3] iptables: enable basic kernel options
  2014-10-28 18:10       ` Thomas Petazzoni
@ 2014-10-28 22:11         ` Arnout Vandecappelle
  0 siblings, 0 replies; 12+ messages in thread
From: Arnout Vandecappelle @ 2014-10-28 22:11 UTC (permalink / raw)
  To: buildroot

On 28/10/14 19:10, Thomas Petazzoni wrote:
> Dear Gustavo Zacarias,
> 
> On Tue, 28 Oct 2014 15:04:59 -0300, Gustavo Zacarias wrote:
>> On 10/28/2014 03:02 PM, Thomas Petazzoni wrote:
>>
>>> For this one, I don't know. Back some time ago, Peter said that his
>>> preference was to not enforce too much stuff in terms of kernel
>>> configuration options in linux/linux.mk. I think the idea is that it's
>>> something that can quickly become very complicated if you want to
>>> handle all the kernel config options that all packages might need. It's
>>> also being forced without the user being capable of doing anything
>>> against that: those KCONFIG_ENABLE_OPT calls are done even if the user
>>> passes a custom configuration file.
>>>
>>> But back at the time, we only had the CONFIG_AEABI option being
>>> handled. Now it's true we already have ktap, systemd, smack being
>>> handled, and many other things related to appended DTB, initramfs, and
>>> more. So it seems like the iptables/xtables-addons proposal from
>>> Gustavo are not really creating a precedent.
>>>
>>> Peter, what is your position on this?
>>
>> Unfortunately it's not optional for xtables-addons, it needs the
>> iptables bits for the xtables bits in the other patch.
>> We could just get them together or ditch the package since it will
>> result in a build failure.
> 
> As said on IRC, if those options are needed at build time for
> xtables-addons, it makes a very good case for having them.

 I completely agree with that reasoning.

 Actually, I think it's just the ktap and smack modifications that are really
controversial. The others are either required for building, or they are system
configuration options and for those it's logical to propagate to the kernel config.


 Regards,
 Arnout

> 
> Peter, OK ?
> 
> Thomas
> 


-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F

^ permalink raw reply	[flat|nested] 12+ messages in thread
* [Buildroot] [PATCH 1/3] xtables-addons: new package
  2014-10-22 22:38   ` Gustavo Zacarias
@ 2014-10-28 22:18     ` Arnout Vandecappelle
  0 siblings, 0 replies; 12+ messages in thread
From: Arnout Vandecappelle @ 2014-10-28 22:18 UTC (permalink / raw)
  To: buildroot

On 23/10/14 00:38, Gustavo Zacarias wrote:
> On 10/22/2014 02:18 PM, Arnout Vandecappelle wrote:
>
> >> +comment "xtables-addons needs a Linux kernel to be built"
> >> +    depends on !BR2_LINUX_KERNEL
> >> +
> >> +comment "xtables-addons needs a toolchain w/ dynamic library, largefile,
> threads"
> >> +    depends on BR2_LINUX_KERNEL
> >
> >  Do we usually do this? I mean, if a user discovers the 'needs a Linux kernel'
> > comment and builds a kernel, then he comes back only to discover that he still
> > has to enable all this other stuff...
>
> I can move it to linux extensions instead of it being a package, i don't
> know if it's worth bloating too much there.

 No, that's not what I meant: linux extensions are for things that modify
the kernel source, so it's really exceptional.

 What I meant is that the second comment should not depend on
BR2_LINUX_KERNEL, so both comments appear if you don't have the kernel nor
largefile selected.


 Regards,
 Arnout


[snip]

-- 
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286500
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F

^ permalink raw reply	[flat|nested] 12+ messages in thread
* [Buildroot] [PATCH 1/3] xtables-addons: new package
  2014-10-21 21:10 [Buildroot] [PATCH 1/3] xtables-addons: new package Gustavo Zacarias
                   ` (2 preceding siblings ...)
  2014-10-22 17:18 ` [Buildroot] [PATCH 1/3] xtables-addons: new package Arnout Vandecappelle
@ 2015-01-10 17:55 ` Thomas Petazzoni
  3 siblings, 0 replies; 12+ messages in thread
From: Thomas Petazzoni @ 2015-01-10 17:55 UTC (permalink / raw)
  To: buildroot

Dear Gustavo Zacarias,

On Tue, 21 Oct 2014 18:10:50 -0300, Gustavo Zacarias wrote:
> The geoip "helpers" are basically scripts that download and reformat
> the geoip database in a form usable by xt_geoip.
> The netfilter (kernel & userland) sides of it are built and installed.
> Since there are many considerations to geoip databases (free, commercial
> and variants for each) it's left to the user to deal with that if they
> plan to use the extension which is only one among many.
> 
> Signed-off-by: Gustavo Zacarias <gustavo@zacarias.com.ar>

Thanks, I've applied the three patches of this series, only after doing
a minor set of changes on the first patch:

    [Thomas:
     - Take into account the rename of BR2_PREFER_STATIC_LIB to
       BR2_STATIC_LIBS
     - Remove "depends on BR2_LINUX_KERNEL" as suggested by Arnout.
     - Move XTABLES_ADDONS_CONF_OPTS a bit further down, with newlines
       around it, and adjust the indentation of the first line. Just to
       make it slightly more readable.]

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

^ permalink raw reply	[flat|nested] 12+ messages in thread
end of thread, other threads:[~2015-01-10 17:55 UTC | newest]

Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-10-21 21:10 [Buildroot] [PATCH 1/3] xtables-addons: new package Gustavo Zacarias
2014-10-21 21:10 ` [Buildroot] [PATCH 2/3] iptables: enable basic kernel options Gustavo Zacarias
2014-10-28 18:02   ` Thomas Petazzoni
2014-10-28 18:04     ` Gustavo Zacarias
2014-10-28 18:10       ` Thomas Petazzoni
2014-10-28 22:11         ` Arnout Vandecappelle
2014-10-21 21:10 ` [Buildroot] [PATCH 3/3] xtables-addons: enable necessary " Gustavo Zacarias
2014-10-22 17:18 ` [Buildroot] [PATCH 1/3] xtables-addons: new package Arnout Vandecappelle
2014-10-22 22:38   ` Gustavo Zacarias
2014-10-28 22:18     ` Arnout Vandecappelle
2014-10-23 11:07   ` Gustavo Zacarias
2015-01-10 17:55 ` Thomas Petazzoni

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.