From: Li Liu <john.liuli@huawei.com> To: "Michael S. Tsirkin" <mst@redhat.com> Cc: <linux-kernel@vger.kernel.org>, <qemu-devel@nongnu.org>, <peter.huangpeng@huawei.com>, <rusty@rustcorp.com.au>, <virtualization@lists.linux-foundation.org>, <n.nikolaev@virtualopensystems.com>, <yingshiuan.pan@gmail.com>, <remy.gauguey@cea.fr>, <joel.schopp@amd.com> Subject: Re: [RFC PATCH 0/2] virtio-mmio: add irqfd support for vhost-net based on virtio-mmio Date: Mon, 27 Oct 2014 17:19:23 +0800 [thread overview] Message-ID: <544E0E1B.1060104@huawei.com> (raw) In-Reply-To: <20141026115210.GA5497@redhat.com> On 2014/10/26 19:52, Michael S. Tsirkin wrote: > On Sat, Oct 25, 2014 at 04:24:52PM +0800, john.liuli wrote: >> From: Li Liu <john.liuli@huawei.com> >> >> This set of patches try to implemet irqfd support of vhost-net >> based on virtio-mmio. >> >> I had posted a mail to talking about the status of vhost-net >> on kvm-arm refer to http://www.spinics.net/lists/kvm-arm/msg10804.html. >> Some dependent patches are listed in the mail too. Basically the >> vhost-net brings great performance improvements, almost 50%+. >> >> It's easy to implement irqfd support with PCI MSI-X. But till >> now arm32 do not provide equivalent mechanism to let a device >> allocate multiple interrupts. And even the aarch64 provid LPI >> but also not available in a short time. >> >> As Gauguey Remy said "Vhost does not emulate a complete virtio >> adapter but only manage virtqueue operations". Vhost module >> don't update the ISR register, so if with only one irq then it's >> no way to get the interrupt reason even we can inject the >> irq correctly. > > Well guests don't read ISR in MSI-X mode so why does it help > to set the ISR bit? Yeah, vhost don't need to set ISR under MSI-X mode. But for ARM without MSI-X kind mechanism guest can't get the interrupt reason through the only one irq hanlder (with one gsi resource). So I build a shared memory region to provide the interrupt reason instead of ISR regiser by qemu without bothering vhost. Then even there's only one irq with only one irq hanlder, it still can distinguish why irq occur. Li. > >> To get the interrupt reason to support such VIRTIO_NET_F_STATUS >> features I add a new register offset VIRTIO_MMIO_ISRMEM which >> will help to establish a shared memory region between qemu and >> virtio-mmio device. Then the interrupt reason can be accessed by >> guest driver through this region. At the same time, the virtio-mmio >> dirver check this region to see irqfd is supported or not during >> the irq handler registration, and different handler will be assigned. >> >> I want to know it's the right direction? Does it comply with the >> virtio-mmio spec.? Or anyone have more good ideas to emulate mis-x >> based on virtio-mmio? I hope to get feedback and guidance. >> Thx for any help. >> >> Li Liu (2): >> Add a new register offset let interrupt reason available >> Assign a new irq handler while irqfd enabled >> >> drivers/virtio/virtio_mmio.c | 55 +++++++++++++++++++++++++++++++++++++++--- >> include/linux/virtio_mmio.h | 3 +++ >> 2 files changed, 55 insertions(+), 3 deletions(-) >> >> -- >> 1.7.9.5 >> > > . >
WARNING: multiple messages have this Message-ID (diff)
From: Li Liu <john.liuli@huawei.com> To: "Michael S. Tsirkin" <mst@redhat.com> Cc: joel.schopp@amd.com, yingshiuan.pan@gmail.com, qemu-devel@nongnu.org, linux-kernel@vger.kernel.org, remy.gauguey@cea.fr, rusty@rustcorp.com.au, peter.huangpeng@huawei.com, n.nikolaev@virtualopensystems.com, virtualization@lists.linux-foundation.org Subject: Re: [Qemu-devel] [RFC PATCH 0/2] virtio-mmio: add irqfd support for vhost-net based on virtio-mmio Date: Mon, 27 Oct 2014 17:19:23 +0800 [thread overview] Message-ID: <544E0E1B.1060104@huawei.com> (raw) In-Reply-To: <20141026115210.GA5497@redhat.com> On 2014/10/26 19:52, Michael S. Tsirkin wrote: > On Sat, Oct 25, 2014 at 04:24:52PM +0800, john.liuli wrote: >> From: Li Liu <john.liuli@huawei.com> >> >> This set of patches try to implemet irqfd support of vhost-net >> based on virtio-mmio. >> >> I had posted a mail to talking about the status of vhost-net >> on kvm-arm refer to http://www.spinics.net/lists/kvm-arm/msg10804.html. >> Some dependent patches are listed in the mail too. Basically the >> vhost-net brings great performance improvements, almost 50%+. >> >> It's easy to implement irqfd support with PCI MSI-X. But till >> now arm32 do not provide equivalent mechanism to let a device >> allocate multiple interrupts. And even the aarch64 provid LPI >> but also not available in a short time. >> >> As Gauguey Remy said "Vhost does not emulate a complete virtio >> adapter but only manage virtqueue operations". Vhost module >> don't update the ISR register, so if with only one irq then it's >> no way to get the interrupt reason even we can inject the >> irq correctly. > > Well guests don't read ISR in MSI-X mode so why does it help > to set the ISR bit? Yeah, vhost don't need to set ISR under MSI-X mode. But for ARM without MSI-X kind mechanism guest can't get the interrupt reason through the only one irq hanlder (with one gsi resource). So I build a shared memory region to provide the interrupt reason instead of ISR regiser by qemu without bothering vhost. Then even there's only one irq with only one irq hanlder, it still can distinguish why irq occur. Li. > >> To get the interrupt reason to support such VIRTIO_NET_F_STATUS >> features I add a new register offset VIRTIO_MMIO_ISRMEM which >> will help to establish a shared memory region between qemu and >> virtio-mmio device. Then the interrupt reason can be accessed by >> guest driver through this region. At the same time, the virtio-mmio >> dirver check this region to see irqfd is supported or not during >> the irq handler registration, and different handler will be assigned. >> >> I want to know it's the right direction? Does it comply with the >> virtio-mmio spec.? Or anyone have more good ideas to emulate mis-x >> based on virtio-mmio? I hope to get feedback and guidance. >> Thx for any help. >> >> Li Liu (2): >> Add a new register offset let interrupt reason available >> Assign a new irq handler while irqfd enabled >> >> drivers/virtio/virtio_mmio.c | 55 +++++++++++++++++++++++++++++++++++++++--- >> include/linux/virtio_mmio.h | 3 +++ >> 2 files changed, 55 insertions(+), 3 deletions(-) >> >> -- >> 1.7.9.5 >> > > . >
next prev parent reply other threads:[~2014-10-27 9:26 UTC|newest] Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top 2014-10-25 8:24 [RFC PATCH 0/2] virtio-mmio: add irqfd support for vhost-net based on virtio-mmio john.liuli 2014-10-25 8:24 ` [Qemu-devel] " john.liuli 2014-10-25 8:24 ` [RFC PATCH 1/2] Add a new register offset let interrupt reason available john.liuli 2014-10-25 8:24 ` [Qemu-devel] " john.liuli 2014-10-26 12:01 ` Michael S. Tsirkin 2014-10-26 12:01 ` Michael S. Tsirkin 2014-10-26 12:01 ` [Qemu-devel] " Michael S. Tsirkin 2014-10-25 8:24 ` john.liuli 2014-10-25 8:24 ` [RFC PATCH 2/2] Assign a new irq handler while irqfd enabled john.liuli 2014-10-25 8:24 ` [Qemu-devel] " john.liuli 2014-10-26 11:56 ` Michael S. Tsirkin 2014-10-26 11:56 ` Michael S. Tsirkin 2014-10-26 11:56 ` [Qemu-devel] " Michael S. Tsirkin 2014-10-27 11:04 ` Li Liu 2014-10-27 11:04 ` Li Liu 2014-10-27 11:04 ` [Qemu-devel] " Li Liu 2014-10-27 12:03 ` Michael S. Tsirkin 2014-10-27 12:03 ` Michael S. Tsirkin 2014-10-27 12:03 ` [Qemu-devel] " Michael S. Tsirkin 2014-10-25 8:24 ` john.liuli 2014-10-26 11:52 ` [RFC PATCH 0/2] virtio-mmio: add irqfd support for vhost-net based on virtio-mmio Michael S. Tsirkin 2014-10-26 11:52 ` Michael S. Tsirkin 2014-10-26 11:52 ` [Qemu-devel] " Michael S. Tsirkin 2014-10-27 9:19 ` Li Liu [this message] 2014-10-27 9:19 ` Li Liu 2014-10-27 10:48 ` Michael S. Tsirkin 2014-10-27 10:48 ` Michael S. Tsirkin 2014-10-27 10:48 ` [Qemu-devel] " Michael S. Tsirkin 2014-10-27 9:19 ` Li Liu 2014-10-27 9:37 ` [Qemu-devel] " Peter Maydell 2014-10-27 9:37 ` Peter Maydell 2014-10-27 9:37 ` Peter Maydell 2014-10-27 11:23 ` Li Liu 2014-10-27 11:23 ` Li Liu 2014-10-27 11:23 ` Li Liu 2014-10-27 11:58 ` Peter Maydell 2014-10-27 11:58 ` Peter Maydell 2014-10-27 11:58 ` Peter Maydell 2014-11-05 9:30 ` Christoffer Dall 2014-11-05 9:30 ` Christoffer Dall 2014-11-05 9:30 ` Christoffer Dall 2014-11-05 8:43 ` Eric Auger 2014-11-05 8:43 ` Eric Auger 2014-11-06 1:59 ` Shannon Zhao 2014-11-06 1:59 ` Shannon Zhao 2014-11-06 9:24 ` Li Liu 2014-11-06 9:24 ` Li Liu 2014-11-06 9:24 ` Li Liu 2014-11-06 1:59 ` Shannon Zhao 2014-11-05 8:43 ` Eric Auger -- strict thread matches above, loose matches on Subject: below -- 2014-10-25 8:24 john.liuli
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=544E0E1B.1060104@huawei.com \ --to=john.liuli@huawei.com \ --cc=joel.schopp@amd.com \ --cc=linux-kernel@vger.kernel.org \ --cc=mst@redhat.com \ --cc=n.nikolaev@virtualopensystems.com \ --cc=peter.huangpeng@huawei.com \ --cc=qemu-devel@nongnu.org \ --cc=remy.gauguey@cea.fr \ --cc=rusty@rustcorp.com.au \ --cc=virtualization@lists.linux-foundation.org \ --cc=yingshiuan.pan@gmail.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.