All of lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH] trinity: Disable for Microblaze architecture
@ 2014-10-27 16:11 Vicente Olivert Riera
  2014-10-27 16:43 ` Thomas Petazzoni
  0 siblings, 1 reply; 5+ messages in thread
From: Vicente Olivert Riera @ 2014-10-27 16:11 UTC (permalink / raw)
  To: buildroot

This package doesn't support the Microblaze architecture. The full list
of supported architectures is in the trinity website, and Microblaze is
not among them.

Fixes:
	http://autobuild.buildroot.net/results/ea7/ea788f1f0ed5ee4e9b1bf0c8a0d1304e7467dc77/

Signed-off-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
---
 package/trinity/Config.in |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/package/trinity/Config.in b/package/trinity/Config.in
index de9c467..9882573 100644
--- a/package/trinity/Config.in
+++ b/package/trinity/Config.in
@@ -1,5 +1,6 @@
 config BR2_PACKAGE_TRINITY
 	bool "trinity"
+	depends on !BR2_microblazeel && !BR2_microblazeeb
 	help
 	  A Linux System call fuzz tester
 
-- 
1.7.1

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [Buildroot] [PATCH] trinity: Disable for Microblaze architecture
  2014-10-27 16:11 [Buildroot] [PATCH] trinity: Disable for Microblaze architecture Vicente Olivert Riera
@ 2014-10-27 16:43 ` Thomas Petazzoni
  2014-10-27 17:19   ` Vicente Olivert Riera
  0 siblings, 1 reply; 5+ messages in thread
From: Thomas Petazzoni @ 2014-10-27 16:43 UTC (permalink / raw)
  To: buildroot

Dear Vicente Olivert Riera,

On Mon, 27 Oct 2014 16:11:10 +0000, Vicente Olivert Riera wrote:
> This package doesn't support the Microblaze architecture. The full list
> of supported architectures is in the trinity website, and Microblaze is
> not among them.

Then what we want is not something like the patch you propose, but
instead a patch using positive logic to enable Trinity only on the
architecture that are known to work.

The website says: "Trinity supports Alpha, Aarch64, ARM, i386, IA-64,
MIPS, PowerPC-64, S390, S390x, SPARC-64, x86-64.". So it means that not
only Microblaze is going to cause issue, but also Blackfin, ARC,
Xtensa, SPARC 32 bits, and probably some others I forgot.

Can you respin the patch with something like:

	depends BR2_... || BR2_... || BR2_...

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [Buildroot] [PATCH] trinity: Disable for Microblaze architecture
  2014-10-27 16:43 ` Thomas Petazzoni
@ 2014-10-27 17:19   ` Vicente Olivert Riera
  2014-10-27 18:30     ` Thomas Petazzoni
  0 siblings, 1 reply; 5+ messages in thread
From: Vicente Olivert Riera @ 2014-10-27 17:19 UTC (permalink / raw)
  To: buildroot

Dear Thomas Petazzoni,

On 10/27/2014 04:43 PM, Thomas Petazzoni wrote:
> Dear Vicente Olivert Riera,
>
> On Mon, 27 Oct 2014 16:11:10 +0000, Vicente Olivert Riera wrote:
>> This package doesn't support the Microblaze architecture. The full list
>> of supported architectures is in the trinity website, and Microblaze is
>> not among them.
>
> Then what we want is not something like the patch you propose, but
> instead a patch using positive logic to enable Trinity only on the
> architecture that are known to work.
>
> The website says: "Trinity supports Alpha, Aarch64, ARM, i386, IA-64,
> MIPS, PowerPC-64, S390, S390x, SPARC-64, x86-64.". So it means that not
> only Microblaze is going to cause issue, but also Blackfin, ARC,
> Xtensa, SPARC 32 bits, and probably some others I forgot.
>
> Can you respin the patch with something like:
>
> 	depends BR2_... || BR2_... || BR2_...
>
> Thanks!
>
> Thomas

Done: http://patchwork.ozlabs.org/patch/403703/

I have marked the former patch as superseded.

Best regards,
-- 
Vicente Olivert Riera
Graduate Software Engineer, MIPS Processor IP
Imagination Technologies Limited
t: +44 (0)113 2429814
www.imgtec.com

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [Buildroot] [PATCH] trinity: Disable for Microblaze architecture
  2014-10-27 17:19   ` Vicente Olivert Riera
@ 2014-10-27 18:30     ` Thomas Petazzoni
  2014-10-28  9:31       ` Vicente Olivert Riera
  0 siblings, 1 reply; 5+ messages in thread
From: Thomas Petazzoni @ 2014-10-27 18:30 UTC (permalink / raw)
  To: buildroot

Dear Vicente Olivert Riera,

On Mon, 27 Oct 2014 17:19:36 +0000, Vicente Olivert Riera wrote:

> Done: http://patchwork.ozlabs.org/patch/403703/

This is exactly the same patch as before. What happened ? :-)

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [Buildroot] [PATCH] trinity: Disable for Microblaze architecture
  2014-10-27 18:30     ` Thomas Petazzoni
@ 2014-10-28  9:31       ` Vicente Olivert Riera
  0 siblings, 0 replies; 5+ messages in thread
From: Vicente Olivert Riera @ 2014-10-28  9:31 UTC (permalink / raw)
  To: buildroot

Dear Thomas Petazzoni,

On 10/27/2014 06:30 PM, Thomas Petazzoni wrote:
> Dear Vicente Olivert Riera,
>
> On Mon, 27 Oct 2014 17:19:36 +0000, Vicente Olivert Riera wrote:
>
>> Done: http://patchwork.ozlabs.org/patch/403703/
>
> This is exactly the same patch as before. What happened ? :-)

git add... :-(

I have sent the right patch now.

Thanks!
-- 
Vicente Olivert Riera
Graduate Software Engineer, MIPS Processor IP
Imagination Technologies Limited
t: +44 (0)113 2429814
www.imgtec.com

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2014-10-28  9:31 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-10-27 16:11 [Buildroot] [PATCH] trinity: Disable for Microblaze architecture Vicente Olivert Riera
2014-10-27 16:43 ` Thomas Petazzoni
2014-10-27 17:19   ` Vicente Olivert Riera
2014-10-27 18:30     ` Thomas Petazzoni
2014-10-28  9:31       ` Vicente Olivert Riera

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.